Monday, May 13, 2024
apps@conference.yunohost.org
May
Mon Tue Wed Thu Fri Sat Sun
    1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
   
             

[03:06:53] <Yunohost Git/Infra notifications> App scovie goes down from level 8 to 3 in job [#26400](https://ci-apps.yunohost.org/ci/job/26400)
[04:25:17] <Émy - OniriCorpe> Hum, the autoupdater didn’t work this night
[05:50:13] <Yunohost Git/Infra notifications> [apps] ericgaspar created new branch Logo-on-dark-theme
[05:50:14] <Yunohost Git/Infra notifications> [apps] ericgaspar pushed 1 commit to Logo-on-dark-theme: Update vaultwarden.png ([939bfbda](https://github.com/YunoHost/apps/commit/939bfbdab5818fcf207d269ba870b210d4524935))
[06:00:35] <Yunohost Git/Infra notifications> [apps] ericgaspar pushed 1 commit to Logo-on-dark-theme: Fix logo background when displayed on dark theme ([11ced702](https://github.com/YunoHost/apps/commit/11ced702dcbfb69c3623a2dc4858bbecdc766dd3))
[06:01:08] <Yunohost Git/Infra notifications> [apps] ericgaspar opened [pull request #2332](https://github.com/YunoHost/apps/pull/2332): Logo on dark theme
[06:17:05] <Yunohost Git/Infra notifications> [apps] OniriCorpe approved [pull request #2332](https://github.com/YunoHost/apps/pull/2332#pullrequestreview-2051779802) Logo on dark theme
[06:17:24] <Yunohost Git/Infra notifications> [apps] OniriCorpe deleted branch Logo-on-dark-theme
[06:17:26] <Yunohost Git/Infra notifications> [apps] OniriCorpe merged [pull request #2332](https://github.com/YunoHost/apps/pull/2332): Logo on dark theme
[06:17:27] <Yunohost Git/Infra notifications> [apps] OniriCorpe pushed 2 commits to master ([1a4896014000...227ef60d5d2a](https://github.com/YunoHost/apps/compare/1a4896014000...227ef60d5d2a))
[06:18:17] <Émy - OniriCorpe> > <@yunohostinfra:matrix.org> [apps] ericgaspar opened [pull request #2332](https://github.com/YunoHost/apps/pull/2332): Logo on dark theme

Thanks ❤️
[07:00:49] <tituspijean> > <@oniricorpe:im.emelyne.eu> the AGH update is looking for testers: https://forum.yunohost.org/t/adguard-adguard-home-package-for-yunohost/9075/11?u=oniricorpe

testing it tonight! <3
[07:00:50] <Yunohost Git/Infra notifications> App searxng goes down from level 8 to 6 in job [#26408](https://ci-apps.yunohost.org/ci/job/26408)
[07:25:40] <Yunohost Git/Infra notifications> App ztncui rises from level 6 to 8 in job [#26409](https://ci-apps.yunohost.org/ci/job/26409) !
[07:59:53] <Yunohost Git/Infra notifications> App bazarr rises from level 6 to 8 in job [#26410](https://ci-apps.yunohost.org/ci/job/26410) !
[08:09:49] <Yunohost Git/Infra notifications> App archivist rises from level 6 to 7 in job [#26411](https://ci-apps.yunohost.org/ci/job/26411) !
[08:16:37] <Yunohost Git/Infra notifications> Job [#26399](https://ci-apps.yunohost.org/ci/job/26399) for libremdb failed miserably :(
[09:39:14] <Yunohost Git/Infra notifications> App immich rises from level 6 to 7 in job [#26412](https://ci-apps.yunohost.org/ci/job/26412) !
[10:31:06] <Guillaume Bouzige> > <@oniricorpe:im.emelyne.eu> the AGH update is looking for testers: https://forum.yunohost.org/t/adguard-adguard-home-package-for-yunohost/9075/11?u=oniricorpe

can I downgrade afterward like that `sudo yunohost app upgrade adguardhome --force` ?
[10:35:25] <Aleks (he/him/il/lui)> nope
[10:47:41] <orhtej2> > can I downgrade afterward like that `sudo yunohost app upgrade adguardhome --force` ?

yes if you create FULL backup prior to upgrade, uninstall and restore backup
[10:52:23] <Guillaume Bouzige> > yes if you create FULL backup prior to upgrade, uninstall and restore backup

yeah no I wont restore the whole server for one app testing upgrade
[10:52:26] <orhtej2> Interestingly, MongoDB is NOT considered a dependency for Wekan, meaning you can `apt remove mongodb-org` and it does not wink regarding Wekan using it
[10:53:17] <orhtej2> > yeah no I wont restore the whole server for one app testing upgrade

restore single app, full upgrade as in not pre-upgrade backup which ignores `$data_dir` but manually created backup of single app
[10:54:58] <orhtej2> > Interestingly, MongoDB is NOT considered a dependency for Wekan, meaning you can `apt remove mongodb-org` and it does not wink regarding Wekan using it

perhaps https://yunohost.org/en/packaging_apps_helpers#ynh-install-extra-app-dep does not re-create the phony `deb` given it can be (shouldn't be but can be) called multiple times 🤔
[12:12:57] <orhtej2> Regarding `movim` there's a nice catch 22 that you cannot source `env` to `bash` function calls AND you cannot `ynh_exec_as $app` a function call apparently which is, I'd say, suboptimal, hence `ynh_composer_exec` helper is effectively useless as it runs `composer` as root which now `composer` explicitly forbids
[12:18:04] <Mateusz Szymański> > Regarding `movim` there's a nice catch 22 that you cannot source `env` to `bash` function calls AND you cannot `ynh_exec_as $app` a function call apparently which is, I'd say, suboptimal, hence `ynh_composer_exec` helper is effectively useless as it runs `composer` as root which now `composer` explicitly forbids

ah it's even ticketed https://github.com/YunoHost/issues/issues/2367
[13:29:57] <eric_G> orhtej2: I don't know how hard is it to give the app rights to the app for `ynh_composer_exec` helper
[13:31:21] <orhtej2> > <@ericg:matrix.org> orhtej2: I don't know how hard is it to give the app rights to the app for `ynh_composer_exec` helper

https://paste.yunohost.org/raw/zadikeyewo 🤷 from latest attempt https://ci-apps-dev.yunohost.org/ci/job/15796
[13:32:22] <orhtej2> would be best to add `--user` parameter to this helper and run with `sudo` in such context, preferably with phony `PATH` that includes `php` linking to `php$phpversion`
[13:33:07] <eric_G> nice, some progress
[13:34:22] <orhtej2> is it really progress though? ultimately result is the same as initially 🤷
[13:52:09] <eric_G> aaaah https://ci-apps-dev.yunohost.org/ci/job/15809
[13:53:12] <eric_G> php ❤️‍🔥
[13:53:12] <tituspijean> ah yes, `8.2 < 8.1.0`, php doing some meth
[13:54:00] <orhtej2> > <@ericg:matrix.org> aaaah https://ci-apps-dev.yunohost.org/ci/job/15809

`php` is 7.4, you need ~this dumb trick to get around that (add `php` as alias to the right version in front of `PATH`): https://github.com/orhtej2/movim_ynh/blob/46ca5fd46fb224d4fe08afcb37711ebdb0b08435/scripts/install#L58C1-L63C20
[13:54:19] <tituspijean> could it be that `vendor/bin/phinx migrate --ansi` directly invokes php?
[13:54:50] <Mateusz Szymański> > <@titus:pijean.ovh> could it be that `vendor/bin/phinx migrate --ansi` directly invokes php?

most likely, this or smth inside assumes `php` is the right exec to use
[13:56:06] <eric_G> > `php` is 7.4, you need ~this dumb trick to get around that (add `php` as alias to the right version in front of `PATH`): https://github.com/orhtej2/movim_ynh/blob/46ca5fd46fb224d4fe08afcb37711ebdb0b08435/scripts/install#L58C1-L63C20

I forked your branch along with the little trick 🤔
[13:56:21] <tituspijean> > `php` is 7.4, you need ~this dumb trick to get around that (add `php` as alias to the right version in front of `PATH`): https://github.com/orhtej2/movim_ynh/blob/46ca5fd46fb224d4fe08afcb37711ebdb0b08435/scripts/install#L58C1-L63C20

I outbid you with https://github.com/YunoHost/yunohost/blob/5b585009654d6decb9b4e39d8d9193275629bb6a/helpers/apps#L182-L183
[13:57:49] <orhtej2> > <@ericg:matrix.org> I forked your branch along with the little trick 🤔

ahhh so it did not pick up the `PATH` change
[13:59:10] <tituspijean> I think you need to `export` it when you generate subshells with the composer or exec_as helpers
[14:01:53] <orhtej2> https://github.com/cakephp/phinx/blob/6e89ab90e5dae6751fcce50cc047d5954b8dfcb7/bin/phinx#L1 here's your problem I guess?
[14:04:23] <orhtej2> ```
~$ php() { php${phpversion} ${phpflags} $@; }
~$ php --version
PHP 8.1.28 (cli) (built: Apr 24 2024 19:21:45) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.28, Copyright (c) Zend Technologies
with Zend OPcache v8.1.28, Copyright (c), by Zend Technologies
~$ /usr/bin/env php --version
PHP 7.4.33 (cli) (built: Apr 22 2024 09:38:53) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
with Zend OPcache v7.4.33, Copyright (c), by Zend Technologies
```

GG RIP
[14:04:55] <orhtej2> (export was there, forgot to include it in snippet)
[14:11:02] <orhtej2> I don't get it

```
~$ ln -s $(which php8.2) php
~$ PATH=.:$PATH /usr/bin/env php --version
PHP 8.2.18 (cli) (built: Apr 22 2024 10:09:40) (NTS)
```

Why?!?
[14:11:25] <orhtej2> is local override of `PATH` not propagated to helper?
[14:12:03] <orhtej2> hmmm now that I think about it it is not
[14:15:00] <Salamandar> > <@titus:pijean.ovh> could it be that `vendor/bin/phinx migrate --ansi` directly invokes php?

Yeah, probably, composer does that as well
[14:27:22] <tituspijean> > I don't get it
>
> ```
> ~$ ln -s $(which php8.2) php
> ~$ PATH=.:$PATH /usr/bin/env php --version
> PHP 8.2.18 (cli) (built: Apr 22 2024 10:09:40) (NTS)
> ```
>
> Why?!?

looks like it's expected (cf comment https://stackoverflow.com/questions/8737898/is-usr-bin-env-required-to-run-php-from-command-line#comment10884279_8738005): env loads all environment variables, so you need to update the PATH first (and either export it, or include it like you did)
[15:36:16] <Yunohost Git/Infra notifications> [apps] alexAubin pushed 1 commit to fix-maintenance: maintenance.sh: auto_update_app_source script should run inside a venv ? ([19b5ab16](https://github.com/YunoHost/apps/commit/19b5ab160f22513233a59dd0bed6a2555932988b))
[15:36:16] <Yunohost Git/Infra notifications> [apps] alexAubin opened [pull request #2333](https://github.com/YunoHost/apps/pull/2333): maintenance.sh: auto_update_app_source script should run inside a venv ?
[15:36:24] <Yunohost Git/Infra notifications> [apps] alexAubin deleted branch fix-maintenance
[15:36:25] <Yunohost Git/Infra notifications> [apps] alexAubin merged [pull request #2333](https://github.com/YunoHost/apps/pull/2333): maintenance.sh: auto_update_app_source script should run inside a venv ?
[15:36:25] <Yunohost Git/Infra notifications> [apps] alexAubin pushed 1 commit to master: maintenance.sh: auto_update_app_source script should run inside a venv ? (#2333) ([fd7163a9](https://github.com/YunoHost/apps/commit/fd7163a94050b6c8b9a84399d7a7ca05e12c048c))
[15:54:42] <Yunohost Git/Infra notifications> Autoupdater just ran, here are the results:

- 20 pending update PRs
- 25 new apps PRs
- 6 failed apps updates: bazarr, elasticsearch8, focalboard, gancio, tvheadend, vikunja

See the full log here: http://paste.yunohost.org/raw/gokolebaji
[16:00:37] <Aleks (he/him/il/lui)> > <@oniricorpe:im.emelyne.eu> Hum, the autoupdater didn’t work this night

(fixed the script and triggered it manually, not sure why now it has to run inside a venv when the previous cron job didnt x_x)
[16:00:57] <Salamandar> > <@Alekswag:matrix.org> (fixed the script and triggered it manually, not sure why now it has to run inside a venv when the previous cron job didnt x_x)

didnt touch it recently
[16:01:18] <Aleks (he/him/il/lui)> btw we still have 5-6 ish apps who will keep failing over and over and i still don't know what's supposed to be the plan for them ...
[16:04:53] <Aleks (he/him/il/lui)> can't we just remove the damn autoupdater info in their manifest and be done with it ...
[16:14:07] <Salamandar> hmmm
[16:14:07] <Salamandar> idk i like to *know* things fail instead of hiding them
[16:15:57] <Aleks (he/him/il/lui)> ... but how useful is it to know that something fails if it will never succeed anyway ...
[16:16:05] <Aleks (he/him/il/lui)> i mean we can run `assert True == False` and see it fail everyday but what's the point -_-
[16:16:37] <Aleks (he/him/il/lui)> or let's add a non-working autoupdater to every app and see it fail everyday
[16:16:49] <Aleks (he/him/il/lui)> right now there are actual, fixable issues which are "hidden" in the rest of the mess
[16:16:55] <Aleks (he/him/il/lui)> eg `gancio` seems fixable
[16:18:05] <Aleks (he/him/il/lui)> but who is going to read everyday 15 stacktrace and guess which is a "normal fail which will never succeed" and which is "an actual fixable issue" ...
[16:18:21] <tituspijean> (I don't understand bazarr :/)
[16:20:17] <Salamandar> le bazar d'un hasard bizarre
[16:23:27] <Aleks (he/him/il/lui)> :| ...
[17:27:27] <selfhoster1312> > is local override of `PATH` not propagated to helper?
you mean like `export PATH` ?
[18:39:50] <Émy - OniriCorpe> > <@yunohostinfra:matrix.org> Autoupdater just ran, here are the results:
>
> - 37 pending update PRs
> - 1 new apps PRs
> - 2 failed apps updates: focalboard, tvheadend
>
> See the full log here: http://paste.yunohost.org/raw/ugihozumog

do we completely remove tvheadend from the autooupdater? it's just not relevant
[18:52:25] <Aleks (he/him/il/lui)> > <@oniricorpe:im.emelyne.eu> do we completely remove tvheadend from the autooupdater? it's just not relevant

yes that's what i did, i just forgot the other half, this is fixed
[19:02:23] <Yunohost Git/Infra notifications> [gitlab_ynh] yunohost-bot [commented](https://github.com/YunoHost-Apps/gitlab_ynh/pull/249#issuecomment-2108594229) on [issue #249](https://github.com/YunoHost-Apps/gitlab_ynh/pull/249) #245 fix user creation: Fingers crossed
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-dev.yunohost.org/ci/api/job/15842/ba...
[19:02:23] <Yunohost Git/Infra notifications> [gitlab_ynh] yunohost-bot [commented](https://github.com/YunoHost-Apps/gitlab_ynh/pull/249#issuecomment-2108594250) on [issue #249](https://github.com/YunoHost-Apps/gitlab_ynh/pull/249) #245 fix user creation: :book:
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-bookworm-dev.yunohost.org/ci/api/job/937/badge...
[19:02:23] <Yunohost Git/Infra notifications> [gitlab_ynh] kay0u [commented](https://github.com/YunoHost-Apps/gitlab_ynh/pull/249#issuecomment-2108594109) on [issue #249](https://github.com/YunoHost-Apps/gitlab_ynh/pull/249) #245 fix user creation: testme
[19:10:03] <selfhoster1312> updated to jellyfin 10.9.1 and sent to testing branch instead of master (like said in the README)
[19:15:15] <selfhoster1312> please test, friends :)
https://github.com/YunoHost-Apps/jellyfin_ynh/pull/154
[20:21:29] <orhtej2> > <@oniricorpe:im.emelyne.eu> do we completely remove tvheadend from the autooupdater? it's just not relevant

tbh tvheadend could just install `deb` from predefined feed even if I hate that solution
[20:21:30] <Salamandar> > <selfhoster1312> please test, friends :)
> https://github.com/YunoHost-Apps/jellyfin_ynh/pull/154

let iz go
[20:25:19] <Salamandar> https://aria.im/_matrix/media/v1/download/matrix.org/cvRhFNHbflNTfzZkswZaVadb
[20:25:25] <Salamandar> twice is better than none
[20:29:42] <Salamandar> huh what is that ?
[20:29:49] <Salamandar> https://aria.im/_matrix/media/v1/download/matrix.org/bzoKmVqqHcaepsctsvYaEEJS
[20:38:16] <Salamandar> @_bifrost_selfhoster1312=2fapps=40conference.yunohost.org:aria-net.org wtf did you do in the manifest ?
[20:43:52] <Salamandar> (fixing it and pushing it :) )
[20:49:52] <Salamandar> @_bifrost_selfhoster1312=2fapps=40conference.yunohost.org:aria-net.org if you need explanations on my last commit on your branch, feel free :)
[20:58:02] <Salamandar> yeah that's what i'm doing now :D
[20:58:02] <orhtej2> > <@Salamandar:matrix.org> sent an image.

`upgrade -b` :P
[21:08:52] <selfhoster1312> ouch nice catch i didn't test this last batch yet i'm waiting for friends to stop using jellyfin so tomorrow morning :)
[21:09:17] <selfhoster1312> reading your last commit now
[21:10:56] <Salamandar> What a hell hole i'm trying to restore my pre upgrade backup and it takes AGES to decompress
[21:11:28] <Salamandar> it's 2.5G but most importantly its hundreds of thousands of files…
[21:17:23] <selfhoster1312> oh shit sry i just saw screenshot i'll fix manifest update script :)
[21:29:40] <Salamandar> > <selfhoster1312> oh shit sry i just saw screenshot i'll fix manifest update script :)

I pushed the fix dont worry :)
[21:32:04] <selfhoster1312> yeah but that means my update to update_script.py is broken :P
[21:32:21] <selfhoster1312> which it is of course because i just tried to improve it haha
[21:46:49] <selfhoster1312> (i tried to version each checksum so it doesn't redownload all files every time)
[21:51:21] <selfhoster1312> ah yes of course
[21:51:31] <selfhoster1312> python will let me overwrite a variable's value without warning me
[21:51:35] <selfhoster1312> that's why
[22:05:06] <selfhoster1312> Salamandar, what should i do about all your "fixes" on my "fixes"? should i push another commit based on yours?
[22:23:22] <selfhoster1312> Salamandar, i think i pushed a new commit fixing the update script: https://github.com/YunoHost-Apps/jellyfin_ynh/pull/154/commits/c656160ee1684a72c19e26e67ba3a733aa919a2c
[22:33:09] <Salamandar> > <selfhoster1312> Salamandar, i think i pushed a new commit fixing the update script: https://github.com/YunoHost-Apps/jellyfin_ynh/pull/154/commits/c656160ee1684a72c19e26e67ba3a733aa919a2c

your automated script should use `tomlkit` to keep the style (order of dict, indent etc)
[23:12:06] <Émy - OniriCorpe> lapineige: https://github.com/YunoHost-Apps/adguardhome_ynh/pull/154#issuecomment-2108940842
[23:29:36] <Yunohost Git/Infra notifications> [apps] oleole39 closed [pull request #2233](https://github.com/YunoHost/apps/pull/2233): Regenerate existing READMEs even if translation status has dropped from a lower value than 100%
[23:49:43] <Yunohost Git/Infra notifications> [apps] oleole39 opened [pull request #2337](https://github.com/YunoHost/apps/pull/2337): Regenerate existing READMEs even if translation status has dropped from a lower value than 100%