Sunday, May 19, 2024
apps@conference.yunohost.org
May
Mon Tue Wed Thu Fri Sat Sun
    1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
   
             

[01:52:25] <Yunohost Git/Infra notifications> Autoupdater just ran, here are the results:

- 22 pending update PRs
- 8 new apps PRs
- 3 failed apps updates: elasticsearch7, focalboard, minetest

See the full log here: http://paste.yunohost.org/raw/poxekomovi
[04:45:27] <Yunohost Git/Infra notifications> App diacamma goes down from level 7 to 6 in job [#26661](https://ci-apps.yunohost.org/ci/job/26661)
[07:25:06] <Yunohost Git/Infra notifications> [apps] yunohost-bot pushed 1 commit to add-to-wishlist-saltcorn: Add Saltcorn to wishlist ([b3b406df](https://github.com/YunoHost/apps/commit/b3b406dfb4d7871182bb93bd8ad45b42a209da27))
[07:25:07] <Yunohost Git/Infra notifications> [apps] yunohost-bot created new branch add-to-wishlist-saltcorn
[07:25:07] <Yunohost Git/Infra notifications> [apps] yunohost-bot opened [pull request #2352](https://github.com/YunoHost/apps/pull/2352): Add Saltcorn to wishlist
[07:25:08] <Yunohost Git/Infra notifications> [apps] yunohost-bot labeled Wishlist on [pull request #2352](https://github.com/YunoHost/apps/pull/2352): Add Saltcorn to wishlist
[08:58:43] <Yunohost Git/Infra notifications> Job [#26659](https://ci-apps.yunohost.org/ci/job/26659) for firefish failed miserably :(
[11:23:30] <ChriChri> Before I start diving into the topic: what advantage does **`ynh_local_curl`** over just calling `curl`?
[11:28:12] <ChriChri> > <@chrichri:librem.one> Before I start diving into the topic: what advantage does **`ynh_local_curl`** over just calling `curl`?

Uh, [this](https://github.com/YunoHost/yunohost/blob/7d0d82ae016ae3e7cdb06423b67678d7f7a5d9ca/helpers/utils#L427) looks like trouble (depending on which supercomputer it runs)...
[11:28:49] <Aleks (he/him/il/lui)> "For multiple calls, cookies are persisted between each call for the same app"
[11:29:05] <Aleks (he/him/il/lui)> also it temporarily enable visitor access otherwise if the app is private you can't curl it
[11:35:32] <ChriChri> Yep, and it seems really helpful to not have to write all the domain/path stuff every time. And it takes care of bypassing permissions if needed.

**But** it doesn't seem to offer an option to check for the result. The server might return http/200 containing something like "heya, that went quite wrong".

I'm not the bash type of guy, but the last commands exit code is returned, right? Which should better be the curl exit code preserved and then returned.

Is it possible to capture the output of the curl call from the subroutine to check for its content like `if ynh_local_curl <some_parameters> | grep 'error:none' > /dev/null; then …; fi` ? Probably same here: output from the permission command could interfere...
[11:36:44] <Aleks (he/him/il/lui)> i guess the helper could be improved, yes
[11:39:29] <ChriChri> I guess I'll
* copy the sub over to my _common.sh
* try it and improve it as needed
* PR it back to core if I could achieve some improvement
[11:42:58] <ChriChri> https://codeberg.org/flohmarkt/flohmarkt_ynh/issues/51
[11:52:30] <ChriChri> https://github.com/YunoHost/issues/issues/2396
[11:58:13] <ChriChri> Is there a reason why the sub uses `localhost` instead of `127.0.0.1` ?
[12:00:26] <Aleks (he/him/il/lui)> ¯\_(ツ)_/¯
[12:00:48] <Aleks (he/him/il/lui)> maybe because the machine could be ipv6-only idk
[12:05:46] <ChriChri> Huahahah, yes, true. I guess my strong believe is we'll never reach that point *eg*....
[12:07:07] <Yunohost Git/Infra notifications> [package_check] alexAubin pushed 1 commit to master: Fix stupid edge case where people add comment after [install.foobar] when parsing the manifest arg list ([aaca7137](https://github.com/YunoHost/package_check/commit/aaca7137908169f04b6357bd18a89e2f6add6c41))
[14:10:22] <tituspijean> > bookworm-dev CI is dead?

Fixed!
[16:41:57] <Yunohost Git/Infra notifications> [package_linter] tituspijean pushed 1 commit to OniriCorpe-patch-1: makes level 8 disqualification explicit ([ce522217](https://github.com/YunoHost/package_linter/commit/ce5222177fd13d0156be0f316101e7b0e17a0121))
[16:42:01] <Yunohost Git/Infra notifications> [package_linter] tituspijean approved [pull request #147](https://github.com/YunoHost/package_linter/pull/147#pullrequestreview-2065112453) makes level 8 disqualification explicit
[16:42:20] <Yunohost Git/Infra notifications> [package_linter] tituspijean deleted branch OniriCorpe-patch-1
[16:42:20] <Yunohost Git/Infra notifications> [package_linter] tituspijean merged [pull request #147](https://github.com/YunoHost/package_linter/pull/147): makes level 8 disqualification explicit
[16:42:25] <Yunohost Git/Infra notifications> [package_linter] tituspijean pushed 1 commit to master: makes level 8 disqualification explicit (#147) ([9eb04be6](https://github.com/YunoHost/package_linter/commit/9eb04be676adfe7fc7f858bf31c5a47ebbbeae1a))
[16:42:38] <Yunohost Git/Infra notifications> [package_linter] github-actions[bot] pushed 1 commit to actions/black: :art: Format Python code with Black ([ecbc8749](https://github.com/YunoHost/package_linter/commit/ecbc8749f1cddf9c5156da6f7988340e9d3ab381))
[17:02:28] <Yunohost Git/Infra notifications> Job [#26659](https://ci-apps.yunohost.org/ci/job/26659) for firefish failed miserably :(
[17:04:19] <Yunohost Git/Infra notifications> Job [#26666](https://ci-apps.yunohost.org/ci/job/26666) for onlyoffice failed miserably :(
[17:06:06] <Yunohost Git/Infra notifications> Job [#26667](https://ci-apps.yunohost.org/ci/job/26667) for outline failed miserably :(
[17:08:32] <Yunohost Git/Infra notifications> Job [#26668](https://ci-apps.yunohost.org/ci/job/26668) for elasticsearch7 failed miserably :(
[17:11:00] <Yunohost Git/Infra notifications> Job [#26669](https://ci-apps.yunohost.org/ci/job/26669) for joomla failed miserably :(
[17:13:25] <Yunohost Git/Infra notifications> Job [#26670](https://ci-apps.yunohost.org/ci/job/26670) for shaarli failed miserably :(
[17:15:50] <Yunohost Git/Infra notifications> Job [#26671](https://ci-apps.yunohost.org/ci/job/26671) for nocodb failed miserably :(
[17:19:31] <Yunohost Git/Infra notifications> Job [#26420](https://ci-apps.yunohost.org/ci/job/26420) for glitchsoc failed miserably :(
[17:30:25] <Yunohost Git/Infra notifications> [package_linter] OniriCorpe approved [pull request #148](https://github.com/YunoHost/package_linter/pull/148#pullrequestreview-2065118550) Format Python code with Black
[17:30:28] <Yunohost Git/Infra notifications> [package_linter] OniriCorpe merged [pull request #148](https://github.com/YunoHost/package_linter/pull/148): Format Python code with Black
[17:30:38] <Yunohost Git/Infra notifications> [package_linter] OniriCorpe pushed 2 commits to master ([9eb04be676ad...365eb27e1566](https://github.com/YunoHost/package_linter/compare/9eb04be676ad...365eb27e1566))
[17:30:39] <Yunohost Git/Infra notifications> [package_linter] OniriCorpe deleted branch actions/black
[17:48:24] <orhtej2> restarted but CI seems dead
[17:50:12] <Yunohost Git/Infra notifications> Job [#26667](https://ci-apps.yunohost.org/ci/job/26667) for outline failed miserably :(
[17:52:43] <Yunohost Git/Infra notifications> Job [#26668](https://ci-apps.yunohost.org/ci/job/26668) for elasticsearch7 failed miserably :(
[17:55:06] <Yunohost Git/Infra notifications> Job [#26669](https://ci-apps.yunohost.org/ci/job/26669) for joomla failed miserably :(
[17:57:31] <Yunohost Git/Infra notifications> Job [#26670](https://ci-apps.yunohost.org/ci/job/26670) for shaarli failed miserably :(
[17:59:55] <Yunohost Git/Infra notifications> Job [#26671](https://ci-apps.yunohost.org/ci/job/26671) for nocodb failed miserably :(
[18:31:00] <tituspijean> > restarted but CI seems dead

I think I just fixed it, but it's bound to happen again at some point
[18:31:33] <tituspijean> To people having access to the server, I simply deleted the container with `lxc delete ynh-appci-bullseye-amd64-stable-test-2 --force` and made sure its directory was gone too ` rm -rf /var/lib/lxd/containers/ynh-appci-bullseye-amd64-stable-test-2`
[19:00:12] <Yunohost Git/Infra notifications> App onlyoffice rises from level 6 to 8 in job [#26666](https://ci-apps.yunohost.org/ci/job/26666) !
[21:49:31] <Yunohost Git/Infra notifications> [apps] yunohost-bot opened [pull request #2353](https://github.com/YunoHost/apps/pull/2353): Translations update from Weblate for appstore
[22:24:41] <Yunohost Git/Infra notifications> [apps] alexAubin merged [pull request #2353](https://github.com/YunoHost/apps/pull/2353): Translations update from Weblate for appstore
[22:24:50] <Yunohost Git/Infra notifications> [apps] alexAubin pushed 1 commit to master: Update translation files (#2353) Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: Yu... ([ec65d970](https://github.com/YunoHost/apps/commit/ec65d9701099f212465b8852aa2030e9e5e4c631))