Tuesday, July 30, 2024
apps@conference.yunohost.org
July
Mon Tue Wed Thu Fri Sat Sun
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
       
             

[01:48:44] <Yunohost Git/Infra notifications> Autoupdater just ran, here are the results:

- 28 pending update PRs
- 5 new apps PRs
- 6 failed apps updates: domoticz, focalboard, plainpad, roundcube, snserver, webtrees

See the full log here: http://paste.yunohost.org/raw/deviliqike
[06:11:07] <Yunohost Git/Infra notifications> [nextcloud_ynh] MrTastyBiscuits [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/709#issuecomment-2257544402) on [issue #709](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/709) After 29.0.2 upgrade "Doctrine\DBAL\Exception: Failed to connect to the database" and "Internal Server Error": The thing is that in the webadmin, under Tools/Services, all PHP-FPM versions (7.4/8.1/8.2/8.3) seem to be running fine ...
[07:26:48] <Yunohost Git/Infra notifications> [nextcloud_ynh] kay0u [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/709#issuecomment-2257658984) on [issue #709](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/709) After 29.0.2 upgrade "Doctrine\DBAL\Exception: Failed to connect to the database" and "Internal Server Error": You cant run php occ upgrade like that, but: sudo -u nextcloud php8.2 --define apc.enable_cli=1 occ upgrade (or php...
[07:49:45] <Yunohost Git/Infra notifications> [nextcloud_ynh] MrTastyBiscuits [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/709#issuecomment-2257699053) on [issue #709](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/709) After 29.0.2 upgrade "Doctrine\DBAL\Exception: Failed to connect to the database" and "Internal Server Error": Fair enough, I should have added in my first message that I had used the instructions in the admin docs of Nexcloud_ynh ...
[08:00:23] <Yunohost Git/Infra notifications> [nextcloud_ynh] kay0u [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/709#issuecomment-2257718104) on [issue #709](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/709) After 29.0.2 upgrade "Doctrine\DBAL\Exception: Failed to connect to the database" and "Internal Server Error": Can you try the same with php8.3 please?
[08:12:24] <Yunohost Git/Infra notifications> [nextcloud_ynh] MrTastyBiscuits [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/709#issuecomment-2257742807) on [issue #709](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/709) After 29.0.2 upgrade "Doctrine\DBAL\Exception: Failed to connect to the database" and "Internal Server Error": Here you are: <details open> <summary>Result with php8.3</summary> root@y:~# sudo -u nextcloud php8.3 --defin...
[08:23:30] <Yunohost Git/Infra notifications> [nextcloud_ynh] kay0u [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/709#issuecomment-2257764404) on [issue #709](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/709) After 29.0.2 upgrade "Doctrine\DBAL\Exception: Failed to connect to the database" and "Internal Server Error": Yep, thats the current issue in the stable version You can get more information in this issue https://github.com/YunoH...
[08:26:18] <grenagit> Hello everyone!

I saw that translate.yunohost.org now integrates translations for apps with automatic update of the GitHub repository, it’s cool!

How to integrate an existing application?
[08:36:34] <kayou> I have no clue :)
[08:38:53] <kayou> From what I understood, all readme are translated here: https://translate.yunohost.org/projects/yunohost/readme-generator/
[08:39:07] <kayou> but if you are talking about https://translate.yunohost.org/projects/yunohost-apps/
[08:39:08] <kayou> Idk
[08:42:41] <Yunohost Git/Infra notifications> [nextcloud_ynh] MrTastyBiscuits closed [issue #709](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/709): After 29.0.2 upgrade "Doctrine\DBAL\Exception: Failed to connect to the database" and "Internal Server Error"
[08:42:42] <Yunohost Git/Infra notifications> [nextcloud_ynh] MrTastyBiscuits [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/709#issuecomment-2257803133) on [issue #709](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/709) After 29.0.2 upgrade "Doctrine\DBAL\Exception: Failed to connect to the database" and "Internal Server Error": Oh my bad, I missed this one... Yes, that is basically the exact same issue. I will rollback and wait for the next sta...
[08:46:49] <Yunohost Git/Infra notifications> [nextcloud_ynh] kay0u [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/709#issuecomment-2257811193) on [issue #709](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/709) After 29.0.2 upgrade "Doctrine\DBAL\Exception: Failed to connect to the database" and "Internal Server Error": Youre welcome, the current testing is not that far from being stable anyway, Im just waiting for the bookworm CI
[09:14:33] <kayou> ZZZZZzzzz the bookworm ci is stuck
[10:07:46] <Yunohost Git/Infra notifications> [nextcloud_ynh] kay0u created new branch trying-to-fix-the-upgrade-on-bookworm
[10:08:08] <grenagit> Yes my question is about https://translate.yunohost.org/projects/yunohost-apps/ which allows to translate the app-specific strings (config panel mainly).
[10:09:08] <Yunohost Git/Infra notifications> [nextcloud_ynh] kay0u pushed 1 commit to trying-to-fix-the-upgrade-on-bookworm: add redis-server as deps ([4b9224fd](https://github.com/YunoHost-Apps/nextcloud_ynh/commit/4b9224fd9b35ad44b316a69538f8cecb8fd7a14f))
[10:09:20] <Yunohost Git/Infra notifications> [nextcloud_ynh] kay0u opened [pull request #710](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/710): add redis-server as deps
[10:09:28] <Yunohost Git/Infra notifications> [nextcloud_ynh] kay0u [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/710#issuecomment-2257981929) on [issue #710](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/710) add redis-server as deps: testme
[10:09:31] <Yunohost Git/Infra notifications> [nextcloud_ynh] yunohost-bot [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/710#issuecomment-2257982051) on [issue #710](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/710) add redis-server as deps: :books:
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-bookworm-dev.yunohost.org/ci/api/job/2056/bad...
[10:09:33] <Yunohost Git/Infra notifications> [nextcloud_ynh] yunohost-bot [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/710#issuecomment-2257982053) on [issue #710](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/710) add redis-server as deps: :rocket:
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-dev.yunohost.org/ci/api/job/18010/badge)](ht...
[10:12:09] <kayou> > <@grenagit:matrix.org> Yes my question is about https://translate.yunohost.org/projects/yunohost-apps/ which allows to translate the app-specific strings (config panel mainly).

maybe Émy - OniriCorpe ? as I can see there is gotosocial.

Did you add it manually?
[12:16:01] <Yunohost Git/Infra notifications> App prestashop goes down from level 8 to 6 in job [#29166](https://ci-apps.yunohost.org/ci/job/29166)
[12:57:33] <Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/710#issuecomment-2258287874) on [issue #710](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/710) add redis-server as deps: ah. redis-server is not installed as default on Bookworm?
[13:02:12] <Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar pushed 1 commit to v2_PostgreSQL: Update manifest.toml ([cbc89714](https://github.com/YunoHost-Apps/nextcloud_ynh/commit/cbc897140148c785460ac99ad7f1575bff76948a))
[13:03:08] <Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar pushed 1 commit to v2_PostgreSQL: Update manifest.toml ([de7afc99](https://github.com/YunoHost-Apps/nextcloud_ynh/commit/de7afc994ceff84d112bdb7228209a91a31439e3))
[13:11:05] <Yunohost Git/Infra notifications> [nextcloud_ynh] kay0u [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/710#issuecomment-2258317005) on [issue #710](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/710) add redis-server as deps: I wasnt sure, but according to this commit, not anymore https://github.com/YunoHost/yunohost/commit/daa4c39899fb3228acf...
[13:15:07] <Yunohost Git/Infra notifications> [nextcloud_ynh] kay0u [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/710#issuecomment-2258317005) on [issue #710](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/710) add redis-server as deps: I wasnt sure, but according to this commit, not anymore https://github.com/YunoHost/yunohost/commit/daa4c39899fb3228acf...
[13:20:41] <Yunohost Git/Infra notifications> [nextcloud_ynh] kay0u [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/710#issuecomment-2258317005) on [issue #710](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/710) add redis-server as deps: I wasnt sure, but according to this commit, not anymore https://github.com/YunoHost/yunohost/commit/daa4c39899fb3228acf...
[13:33:57] <Yunohost Git/Infra notifications> [nextcloud_ynh] kay0u deleted branch trying-to-fix-the-upgrade-on-bookworm
[13:34:01] <Yunohost Git/Infra notifications> [nextcloud_ynh] kay0u pushed 2 commits to testing ([ae916549cac4...bc59bba3c194](https://github.com/YunoHost-Apps/nextcloud_ynh/compare/ae916549cac4...bc59bba3c194))
[13:34:05] <Yunohost Git/Infra notifications> [nextcloud_ynh] kay0u merged [pull request #710](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/710): add redis-server as deps
[13:34:23] <Yunohost Git/Infra notifications> [nextcloud_ynh] kay0u edited [pull request #693](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/693): Testing
[13:36:11] <Yunohost Git/Infra notifications> [nextcloud_ynh] kay0u approved [pull request #693](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/693#pullrequestreview-2207715868) Testing: Ready to merge
[13:39:56] <Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar pushed 1 commit to master: Testing (#693) * Update manifest.toml * Auto-update READMEs * add pre upgrade warning for NC 29 * update to PHP8.3 ... ([79bbe7d1](https://github.com/YunoHost-Apps/nextcloud_ynh/commit/79bbe7d11e53dd0dc6d6b63c20eb88ef619abfe9))
[13:39:57] <Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar merged [pull request #693](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/693): Testing
[13:40:21] <Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar pushed 2 commits to testing ([bc59bba3c194...12024a67e08b](https://github.com/YunoHost-Apps/nextcloud_ynh/compare/bc59bba3c194...12024a67e08b))
[13:40:48] <Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar pushed 8 commits to v2_PostgreSQL ([de7afc994cef...a52df89f9061](https://github.com/YunoHost-Apps/nextcloud_ynh/compare/de7afc994cef...a52df89f9061))
[13:41:04] <Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/597#issuecomment-2258381550) on [issue #597](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/597) V2 postgresql: testme
[13:41:05] <Yunohost Git/Infra notifications> [nextcloud_ynh] yunohost-bot [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/597#issuecomment-2258381664) on [issue #597](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/597) V2 postgresql: :bug:
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-bookworm-dev.yunohost.org/ci/api/job/2058/badge...
[13:41:06] <Yunohost Git/Infra notifications> [nextcloud_ynh] yunohost-bot [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/597#issuecomment-2258381666) on [issue #597](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/597) V2 postgresql: :sunflower:
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-dev.yunohost.org/ci/api/job/18012/badge)]...
[13:50:18] <kayou> chown -R the world during the nextcloud upgrade is so fucking absolutely boring
[14:24:19] <kayou> `find /var/www/nextcloud -not -user nextcloud` then pipe into a chown should be faster
[14:25:53] <Yunohost Git/Infra notifications> [nextcloud_ynh] kay0u created new branch speedup-chown
[14:26:53] <Aleks (he/him/il/lui)> https://unix.stackexchange.com/a/245275
[14:27:11] <kayou> yup
[14:27:34] <kayou> we can do the same for chmod i think
[14:32:18] <Yunohost Git/Infra notifications> App firefish failed all tests in job [#29171](https://ci-apps.yunohost.org/ci/job/29171) :(
[14:35:01] <Salamandar> > <@kayou:matrix.org> `find /var/www/nextcloud -not -user nextcloud` then pipe into a chown should be faster

oh god is it really faster ??
[14:35:09] <kayou> I'm not sure
[14:35:42] <Salamandar> according to the internet : https://unix.stackexchange.com/questions/245274/chown-only-where-needed-speedup-chown
[14:35:44] <kayou> but I'm ready to test it... i'm too tired
[14:38:32] <kayou> > <@Salamandar:matrix.org> according to the internet : https://unix.stackexchange.com/questions/245274/chown-only-where-needed-speedup-chown

so, it's kind of faster?
[14:39:10] <Salamandar> tested on a 10k files directory already owned by the correct user, and not
[14:43:26] <Salamandar> ```
~/tmp ❯❯❯ hyperfine 'chown fpiedallu . -R'
Benchmark 1: chown fpiedallu . -R
Time (mean ± σ): 11.7 ms ± 1.6 ms [User: 1.3 ms, System: 9.9 ms]
Range (min … max): 9.4 ms … 18.6 ms 241 runs

~/tmp ❯❯❯ hyperfine 'bash -c "find . -not -user fpiedallu -print0 | xargs -r0 chown fpiedallu"'
Benchmark 1: bash -c "find . -not -user fpiedallu -print0 | xargs -r0 chown fpiedallu"
Time (mean ± σ): 11.9 ms ± 1.2 ms [User: 2.8 ms, System: 10.9 ms]
Range (min … max): 9.9 ms … 16.7 ms 225 runs

~/tmp ❯❯❯ hyperfine 'bash -c "find . -not -user fpiedallu -exec chown fpiedallu {} \;"'
Benchmark 1: bash -c "find . -not -user fpiedallu -exec chown fpiedallu {} \;"
Time (mean ± σ): 11.0 ms ± 0.9 ms [User: 2.4 ms, System: 8.6 ms]
Range (min … max): 9.3 ms … 14.4 ms 225 runs

```
[14:43:27] <Aleks (he/him/il/lui)> does it makes sense to have to chown the files in the first place tho ?
[14:43:39] <Salamandar> -exec might be slightly faster
[14:43:49] <Salamandar> > <@Alekswag:matrix.org> does it makes sense to have to chown the files in the first place tho ?

that's the better question
[14:45:05] <kayou> > <@Alekswag:matrix.org> does it makes sense to have to chown the files in the first place tho ?

i'm really not sure about that
[14:45:23] <kayou> but at this point, I'm too afraid to remove it
[14:45:55] <Salamandar> Actually on a bigger directory it is really faster
[14:46:00] <Salamandar> here a 50k files directory
[14:46:14] <kayou> > <@Salamandar:matrix.org> -exec might be slightly faster

can you try with -execdir pls?
[14:46:14] <Salamandar> ```
~/.vscode ❯❯❯ hyperfine 'chown fpiedallu . -R'
Benchmark 1: chown fpiedallu . -R
Time (mean ± σ): 351.7 ms ± 5.4 ms [User: 32.8 ms, System: 318.3 ms]
Range (min … max): 341.6 ms … 360.5 ms 10 runs

~/.vscode ❯❯❯ hyperfine 'find . -not -user fpiedallu -exec chown fpiedallu {} \;'
Benchmark 1: find . -not -user fpiedallu -exec chown fpiedallu {} \;
Time (mean ± σ): 282.6 ms ± 9.2 ms [User: 50.9 ms, System: 231.5 ms]
Range (min … max): 273.6 ms … 300.6 ms 10 runs

~/.vscode ❯❯❯ hyperfine 'bash -c "find . -not -user fpiedallu -print0 | xargs -r0 chown fpiedallu"'
Benchmark 1: bash -c "find . -not -user fpiedallu -print0 | xargs -r0 chown fpiedallu"
Time (mean ± σ): 288.8 ms ± 10.3 ms [User: 49.4 ms, System: 241.2 ms]
Range (min … max): 279.6 ms … 310.9 ms 10 runs
```
[14:47:15] <Salamandar> > <@kayou:matrix.org> can you try with -execdir pls?

hmmm but it would require -R right ?
[14:47:44] <Salamandar> weirdly enough no difference
[14:47:48] <Salamandar> ```
~/.vscode ❯❯❯ hyperfine 'find . -not -user fpiedallu -execdir chown fpiedallu {} \;'
Benchmark 1: find . -not -user fpiedallu -execdir chown fpiedallu {} \;
Time (mean ± σ): 289.4 ms ± 22.6 ms [User: 47.6 ms, System: 241.8 ms]
Range (min … max): 264.8 ms … 347.9 ms 10 runs

~/.vscode ❯❯❯ hyperfine 'find . -not -user fpiedallu -exec chown fpiedallu {} \;'
Benchmark 1: find . -not -user fpiedallu -exec chown fpiedallu {} \;
Time (mean ± σ): 280.0 ms ± 14.6 ms [User: 51.1 ms, System: 228.5 ms]
Range (min … max): 268.1 ms … 313.7 ms 10 runs
```
[14:48:06] <kayou> we can try `xargs -P $(nproc)` too, but I'm not sure the multiprocess would make the difference here
[14:49:07] <Salamandar> > <@kayou:matrix.org> we can try `xargs -P $(nproc)` too, but I'm not sure the multiprocess would make the difference here

FYI i'm running benches in cases there are no files to chown
[14:52:43] <Salamandar> i'm astouned
[14:52:46] <Salamandar> ```
root@fr02dev4:/home/fpiedallu/tmp/lots_of_files# hyperfine --prepare 'bash -c "chown root:root .; sync"' 'bash -c "find . -not -user fpiedallu -print0 | xargs -r0 chown fpiedallu"'
Benchmark 1: bash -c "find . -not -user fpiedallu -print0 | xargs -r0 chown fpiedallu"
Time (mean ± σ): 293.0 ms ± 9.2 ms [User: 49.4 ms, System: 245.5 ms]
Range (min … max): 281.2 ms … 307.2 ms 10 runs

root@fr02dev4:/home/fpiedallu/tmp/lots_of_files# hyperfine --prepare 'bash -c "chown root:root .; sync"' 'chown fpiedallu . -R'
Benchmark 1: chown fpiedallu . -R
Time (mean ± σ): 367.0 ms ± 49.5 ms [User: 35.9 ms, System: 329.9 ms]
Range (min … max): 339.4 ms … 499.7 ms 10 runs

Warning: Statistical outliers were detected. Consider re-running this benchmark on a quiet system without any interferences from other programs. It might help to use the '--warmup' or '--prepare' options.

root@fr02dev4:/home/fpiedallu/tmp/lots_of_files# hyperfine --prepare 'bash -c "sync"' 'chown fpiedallu . -R'
Benchmark 1: chown fpiedallu . -R
Time (mean ± σ): 355.2 ms ± 12.4 ms [User: 37.5 ms, System: 317.5 ms]
Range (min … max): 341.5 ms … 378.9 ms 10 runs

root@fr02dev4:/home/fpiedallu/tmp/lots_of_files# hyperfine --prepare 'bash -c "chown root:root .; sync"' 'bash -c "find . -not -user fpiedallu -print0 | xargs -P20 -r0 chown fpiedallu"'
Benchmark 1: bash -c "find . -not -user fpiedallu -print0 | xargs -P20 -r0 chown fpiedallu"
Time (mean ± σ): 289.2 ms ± 11.7 ms [User: 50.9 ms, System: 240.1 ms]
Range (min … max): 280.2 ms … 314.0 ms 10 runs
```
[14:52:48] <Yunohost Git/Infra notifications> [nextcloud_ynh] kay0u pushed 1 commit to speedup-chown: find files before chown them ([e215d9c5](https://github.com/YunoHost-Apps/nextcloud_ynh/commit/e215d9c5c9889d8c69a056c67ad8997a5dd69646))
[14:53:17] <Aleks (he/him/il/lui)> not sure how to read that
[14:53:59] <Aleks (he/him/il/lui)> find+xargs is better ?
[14:54:35] <Salamandar> yea
[14:54:41] <Salamandar> and -P20 doesn't change a think
[14:55:13] <Salamandar> but -l (number of args passed by xargs) does
[14:55:19] <Salamandar> -l1 is slow, -l100 is good
[14:55:21] <kayou> > <@Salamandar:matrix.org> and -P20 doesn't change a think

yes, as expected, because we're waiting the IO, not the CPU
[14:55:28] <Salamandar> but that's micro optim on my machine
[14:55:54] <Yunohost Git/Infra notifications> [nextcloud_ynh] kay0u opened [pull request #711](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/711): find files before chown them
[14:56:00] <Salamandar> > <@kayou:matrix.org> yes, as expected, because we're waiting the IO, not the CPU

yeah but we might have had luck with cache
[14:56:29] <kayou> zblerg
[14:58:47] <kayou> OOOOOOR we could also remove this chown mess, and add an "action" in the config panel to run it if needed (in case of upgrade failure)
[14:59:21] <kayou> i don't know why we chown the data_dir to be honest
[14:59:27] <Salamandar> > <@kayou:matrix.org> OOOOOOR we could also remove this chown mess, and add an "action" in the config panel to run it if needed (in case of upgrade failure)

hmmm meh
[14:59:51] <kayou> we can still chown the install dir, just in case
[14:59:56] <kayou> but the data_dir.. :/
[15:00:17] <Salamandar> are you talking about the upgrade script ?
[15:00:18] <Salamandar> (the restore chown is relevant IMHO)
[15:01:07] <kayou> https://github.com/YunoHost-Apps/nextcloud_ynh/pull/711/files
[15:01:30] <kayou> the main issue is the upgrade script indeed
[15:02:00] <Salamandar> then i agree it doesn't make much sense
[15:02:14] <Salamandar> the only case we "might need" that is if the user manually did things
[15:02:28] <kayou> moreover, we chown the world two times in the install/upgrade script
[15:02:28] <Salamandar> and why would we overwrite that ?
[15:02:29] <kayou> @.@
[15:03:00] <Salamandar> was that present in packagingv1 ?
[15:03:09] <Salamandar> this might be a bad copy pasta from the v2 migration
[15:03:39] <Aleks (he/him/il/lui)> https://aria.im/_matrix/media/v1/download/matrix.org/mfPdJIEpATiwuEWUnwAwYell
[15:04:24] <kayou> > <@Salamandar:matrix.org> (the restore chown is relevant IMHO)

yes, probably, because the tar contains files with permission of the current nextcloud id user, which may changed if we install another app/create a new user before restoring it
[15:05:32] <kayou> > 2024-07-30 15:48:31,837 INFO yunohost.hook.<lambda> - [#+++................] > Upgrading nextcloud...
2024-07-30 15:48:31,838 DEBUG yunohost.hook.<lambda> - + chown -R nextcloud: /var/www/nextcloud /home/yunohost.app/nextcloud


[15:05:40] <kayou> still chowning
[15:06:32] <Salamandar> in these times I would love to find a way to kill a process but make it return zero
[15:07:10] <Salamandar> oooooh
[15:07:12] <Salamandar> with gdb
[15:07:14] <Salamandar> :D
[15:07:49] <Yunohost Git/Infra notifications> [nextcloud_ynh] kay0u [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/711#discussion_r1697135319) on pull request #711 find files before chown them: suggestion
[15:07:50] <Yunohost Git/Infra notifications> [nextcloud_ynh] kay0u [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/711#discussion_r1697135094) on pull request #711 find files before chown them: suggestion Do not chown data_dir
[15:07:54] <Yunohost Git/Infra notifications> [nextcloud_ynh] kay0u commented [pull request #711](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/711#pullrequestreview-2207972296) find files before chown them: We can also try like that, Im not sure why we should chown the data_dir
[15:07:57] <Yunohost Git/Infra notifications> [nextcloud_ynh] kay0u [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/711#discussion_r1697135600) on pull request #711 find files before chown them: suggestion
[15:08:06] <Yunohost Git/Infra notifications> [nextcloud_ynh] kay0u edited review [pull request #711](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/711#pullrequestreview-2207972296): find files before chown them
[15:09:31] <Yunohost Git/Infra notifications> [nextcloud_ynh] kay0u [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/711#issuecomment-2258587671) on [issue #711](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/711) find files before chown them: testme
[15:09:40] <Yunohost Git/Infra notifications> [nextcloud_ynh] yunohost-bot [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/711#issuecomment-2258587781) on [issue #711](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/711) find files before chown them: :carousel_horse:
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-dev.yunohost.org/ci/api/job/18016/ba...
[15:09:48] <Yunohost Git/Infra notifications> [nextcloud_ynh] yunohost-bot [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/711#issuecomment-2258587804) on [issue #711](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/711) find files before chown them: :worm:
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-bookworm-dev.yunohost.org/ci/api/job/2062/badg...
[15:30:39] <kayou> oupsie
[15:52:24] <kayou> > <@kayou:matrix.org> > 2024-07-30 15:48:31,837 INFO yunohost.hook.<lambda> - [#+++................] > Upgrading nextcloud...
> 2024-07-30 15:48:31,838 DEBUG yunohost.hook.<lambda> - + chown -R nextcloud: /var/www/nextcloud /home/yunohost.app/nextcloud

still running
[15:58:25] <Salamandar> loool
[15:58:31] <Salamandar> how many files ?
[15:59:40] <kayou> i don't know
[15:59:48] <kayou> 2h10 minutes
[15:59:58] <kayou> --'
[16:00:18] <Salamandar> alias chown=true
[16:00:19] <Salamandar> :D
[16:00:24] <Salamandar> or replace the binary
[16:00:27] <Salamandar> :D
[16:04:12] <kayou> now let's chown again
[16:06:47] <kayou> then, after there are the

> find $install\_dir/ -type f -print0 | xargs -r0 chmod 0644
> find $install\_dir/ -type d -print0 | xargs -r0 chmod 0755
> find $data\_dir/data/ -type f -print0 | xargs -r0 chmod 0640
> find $data\_dir/data/ -type d -print0 | xargs -r0 chmod 0750

stuff
[16:07:41] <kayou> next time, i'll mount bind a tmp dir on data\_dir location :P
[16:10:26] <Salamandar> ah ah yeah that might work
[16:30:29] <Yunohost Git/Infra notifications> [nextcloud_ynh] kay0u pushed 1 commit to speedup-chown: chown the root folder too ([5dc5e8ba](https://github.com/YunoHost-Apps/nextcloud_ynh/commit/5dc5e8ba10f5eab37f8ae085ae4a56f3b9a44d2d))
[16:30:48] <Yunohost Git/Infra notifications> [nextcloud_ynh] kay0u [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/711#issuecomment-2258751220) on [issue #711](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/711) find files before chown them: testme
[16:30:51] <Yunohost Git/Infra notifications> [nextcloud_ynh] yunohost-bot [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/711#issuecomment-2258751355) on [issue #711](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/711) find files before chown them: :sunflower:
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-dev.yunohost.org/ci/api/job/18017/badge)]...
[16:30:54] <Yunohost Git/Infra notifications> [nextcloud_ynh] yunohost-bot [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/711#issuecomment-2258751400) on [issue #711](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/711) find files before chown them: :worm:
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-bookworm-dev.yunohost.org/ci/api/job/2063/badg...
[18:38:51] <Yunohost Git/Infra notifications> [nextcloud_ynh] Thovi98 [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/711#discussion_r1697411326) on pull request #711 find files before chown them: I’ve taken the habit to remove the several chown/chmod datadir before making the upgrade, it was always successful and ...
[19:09:58] <Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/597#issuecomment-2253331980) on [issue #597](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/597) V2 postgresql: :bug:
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-bookworm-dev.yunohost.org/ci/api/job/2008/badge...
[19:10:10] <Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/597#issuecomment-2253331968) on [issue #597](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/597) V2 postgresql: Meow :cat2:
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-dev.yunohost.org/ci/api/job/17922/badge)]...
[19:10:17] <Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/597#issuecomment-2253331734) on [issue #597](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/597) V2 postgresql: testme
[19:10:28] <Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/597#issuecomment-2252529429) on [issue #597](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/597) V2 postgresql: :books: :worm:
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-bookworm-dev.yunohost.org/ci/api/job/2...
[19:10:30] <Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/597#issuecomment-2252529425) on [issue #597](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/597) V2 postgresql: :v:
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-dev.yunohost.org/ci/api/job/17914/badge)](https:/...
[19:10:40] <Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/597#issuecomment-2252529333) on [issue #597](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/597) V2 postgresql: testme
[19:10:50] <Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/597#issuecomment-2238649660) on [issue #597](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/597) V2 postgresql: :worm:
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-bookworm-dev.yunohost.org/ci/api/job/1916/badg...
[19:10:56] <Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/597#issuecomment-2238649616) on [issue #597](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/597) V2 postgresql: :v:
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-dev.yunohost.org/ci/api/job/17760/badge)](https:/...
[19:11:10] <Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/597#issuecomment-2238649541) on [issue #597](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/597) V2 postgresql: testme
[19:11:22] <Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/597#issuecomment-2189019831) on [issue #597](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/597) V2 postgresql: :books: :bug:
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-bookworm-dev.yunohost.org/ci/api/job/16...
[19:11:23] <Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/597#issuecomment-2189019823) on [issue #597](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/597) V2 postgresql: :v:
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-dev.yunohost.org/ci/api/job/17232/badge)](https:/...
[19:13:08] <Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar pushed 18 commits to helpers-2.1 ([2d510fa04dc7...edefc82ab3b4](https://github.com/YunoHost-Apps/nextcloud_ynh/compare/2d510fa04dc7...edefc82ab3b4))
[19:13:16] <Yunohost Git/Infra notifications> [nextcloud_ynh] yunohost-bot [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/704#issuecomment-2259033630) on [issue #704](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/704) Helpers 2.1: :books: :worm:
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-bookworm-dev.yunohost.org/ci/api/job/2...
[19:13:17] <Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/704#issuecomment-2259033524) on [issue #704](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/704) Helpers 2.1: testme
[19:13:19] <Yunohost Git/Infra notifications> [nextcloud_ynh] yunohost-bot [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/704#issuecomment-2259033623) on [issue #704](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/704) Helpers 2.1: :carousel_horse:
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-dev.yunohost.org/ci/api/job/18018/ba...
[19:19:43] <kayou> > <@kayou:matrix.org> then, after there are the
> > find $install_dir/ -type f -print0 | xargs -r0 chmod 0644
> find $install_dir/ -type d -print0 | xargs -r0 chmod 0755
> find $data_dir/data/ -type f -print0 | xargs -r0 chmod 0640
> find $data_dir/data/ -type d -print0 | xargs -r0 chmod 0750
> stuff

Still running --'
[19:21:16] <Yunohost Git/Infra notifications> [nextcloud_ynh] kay0u [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/711#discussion_r1697463420) on pull request #711 find files before chown them: Thanks for the feedback, I think its a really great improvement
[19:32:23] <tituspijean> Small UX note:
```
yunohost app remove koel
Info: Removing koel…
Info: [####################] > Removal of koel completed
Info: Deprovisioning database...
Info: Deprovisioning apt...
Info: Deprovisioning permissions...
Info: Deprovisioning ports...
Info: Deprovisioning data_dir...
Info: Deprovisioning install_dir...
Info: Deprovisioning system_user...
Info: Deprovisioning sources...
Success! koel uninstalled
```

We might want to rephrase "Remove of $app completed", that would imply that there are no deprovisioning steps :)
[19:38:44] <Aleks (he/him/il/lui)> yeah hmf that's sort of legacy from packaging v1
[20:51:25] <Yunohost Git/Infra notifications> App gitlab-runner rises from level 6 to 8 in job [#29174](https://ci-apps.yunohost.org/ci/job/29174) !
[23:13:57] <Yunohost Git/Infra notifications> [nextcloud_ynh] alexAubin [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/417#discussion_r1697678047) on pull request #417 Add notify push option: Should we add a scenario in tests.yml where this is set to true ?