Wednesday, September 18, 2024
apps@conference.yunohost.org
September
Mon Tue Wed Thu Fri Sat Sun
            1
2
3 4 5 6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
           

[01:29:58] <Yunohost Git/Infra notifications> App mautrix_facebook failed all tests in job [#30633](https://ci-apps.yunohost.org/ci/job/30633) :(
[03:30:23] <Yunohost Git/Infra notifications> Autoupdater just ran, here are the results:

- 48 pending update PRs
- 9 new apps PRs
- 2 failed apps updates: fluffychat, mlmmj

See the full log here: http://paste.yunohost.org/raw/hemowazawu
[03:42:33] <Yunohost Git/Infra notifications> App onlyoffice goes down from level 8 to 6 in job [#30636](https://ci-apps.yunohost.org/ci/job/30636)
[09:19:46] <eric_G> I have an error on Nextcloud with helpers 2.1 : `/usr/share/yunohost/helpers.v2.1.d/utils: line 169: $1: unbound variable` -> https://ci-apps-dev.yunohost.org/ci/job/19480
[10:08:19] <Yunohost Git/Infra notifications> [nextcloud_ynh] ImaCrea opened [issue #731](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/731): Nextcloud text app dont sync well causing data loss
[10:08:21] <Yunohost Git/Infra notifications> [nextcloud_ynh] ImaCrea edited [issue #731](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/731): Nextcloud text app dont sync well causing data loss, need Nextcloud update for fix
[11:38:35] <orhtej2> ```
============================================
Basic bash syntax checks
============================================

backup: line 50: syntax error near unexpected token `('
backup: line 50: `ynh_print_info "Backup script completed for $app. (YunoHost will then actually copy those files to the archive)."'
change_url: line 31: unexpected EOF while looking for matching `''
change_url: line 40: syntax error: unexpected end of file
install: line 102: syntax error near unexpected token `('
install: line 102: `yunohost service add $app --description="Firefox Sync Server (Rust)" --log="/var/log/$app/$app.log"'
Error: Obvious syntax issues found which will make the scripts crash ... not running the actual tests until these are fixed
```

You wot m8?
[11:46:03] <orhtej2> > ```
> ============================================
> Basic bash syntax checks
> ============================================
>
> backup: line 50: syntax error near unexpected token `('
> backup: line 50: `ynh_print_info "Backup script completed for $app. (YunoHost will then actually copy those files to the archive)."'
> change_url: line 31: unexpected EOF while looking for matching `''
> change_url: line 40: syntax error: unexpected end of file
> install: line 102: syntax error near unexpected token `('
> install: line 102: `yunohost service add $app --description="Firefox Sync Server (Rust)" --log="/var/log/$app/$app.log"'
> Error: Obvious syntax issues found which will make the scripts crash ... not running the actual tests until these are fixed
> ```
>
> You wot m8?

ahhh I get it now, it actually IS wrong
[11:50:26] <Salamandar> shouldn't that be in the linter instead ?
[12:00:02] <Aleks (he/him/il/lui)> probably, i implemented this in emergency, the point is that we needed the package check to completely stop to avoid wasting CI time, and right now with the current code, the linter can't make the entire package check to stop
[12:00:21] <Aleks (he/him/il/lui)> feel free to refactor
[12:04:17] <orhtej2> I like the current implementation to be honest, `bash` being the one that validates the script syntax
[12:48:01] <Salamandar> yeah that's partly weird but I think that's the best and most solid may to check that
[12:58:19] <Yunohost Git/Infra notifications> [package_linter] Salamandar created new branch split
[12:58:23] <Yunohost Git/Infra notifications> [package_linter] Salamandar pushed 1 commit to split: Split package_linter into a lib file and tests files ([6d39381e](https://github.com/YunoHost/package_linter/commit/6d39381ed8c52368657d9004ef9101db978fc1fd))
[12:58:38] <Yunohost Git/Infra notifications> [package_linter] Salamandar opened [pull request #160](https://github.com/YunoHost/package_linter/pull/160): Split package_linter into a lib file and tests files
[13:01:18] <Yunohost Git/Infra notifications> [package_linter] Salamandar edited [pull request #160](https://github.com/YunoHost/package_linter/pull/160): Split package_linter into a lib file and tests files
[13:02:40] <Yunohost Git/Infra notifications> [package_linter] Salamandar pushed 1 commit to split: Update .gitignore ([6fea1756](https://github.com/YunoHost/package_linter/commit/6fea175663ce70c1e91d29ae0ddd29c91029057b))
[13:17:00] <Yunohost Git/Infra notifications> [package_linter] alexAubin approved [pull request #160](https://github.com/YunoHost/package_linter/pull/160#pullrequestreview-2312662491) Split package_linter into a lib file and tests files
[13:46:36] <Yunohost Git/Infra notifications> [package_linter] Salamandar merged [pull request #160](https://github.com/YunoHost/package_linter/pull/160): Split package_linter into a lib file and tests files
[13:46:39] <Yunohost Git/Infra notifications> [package_linter] Salamandar pushed 2 commits to master ([e9ecc228ba01...64bacb430188](https://github.com/YunoHost/package_linter/compare/e9ecc228ba01...64bacb430188))
[13:46:41] <Yunohost Git/Infra notifications> [package_linter] Salamandar deleted branch split
[13:47:24] <Yunohost Git/Infra notifications> [package_linter] github-actions[bot] created new branch actions/black
[13:47:33] <Yunohost Git/Infra notifications> [package_linter] github-actions[bot] pushed 1 commit to actions/black: :art: Format Python code with Black ([2e27b055](https://github.com/YunoHost/package_linter/commit/2e27b055e4b9d4a304ffade6b52c9284ef8d4e09))
[13:47:33] <Yunohost Git/Infra notifications> [package_linter] github-actions[bot] opened [pull request #161](https://github.com/YunoHost/package_linter/pull/161): Format Python code with Black
[13:51:57] <Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/731#issuecomment-2358533535) on [issue #731](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/731) Nextcloud text app dont sync well causing data loss, need Nextcloud update for fix: two updates are available and you shouldnt have any issue updating Nextcloud: - update Nextcloud to 29.0.7 -> sudo yun...
[13:53:06] <eric_G> can we merge this Nextcloud PR? https://github.com/YunoHost-Apps/nextcloud_ynh/pull/721
[13:54:04] <Yunohost Git/Infra notifications> [package_linter] ericgaspar approved [pull request #161](https://github.com/YunoHost/package_linter/pull/161#pullrequestreview-2312778041) Format Python code with Black
[13:54:09] <Yunohost Git/Infra notifications> [package_linter] ericgaspar merged [pull request #161](https://github.com/YunoHost/package_linter/pull/161): Format Python code with Black
[13:54:09] <Yunohost Git/Infra notifications> [package_linter] ericgaspar pushed 2 commits to master ([64bacb430188...29df9c49516a](https://github.com/YunoHost/package_linter/compare/64bacb430188...29df9c49516a))
[13:54:15] <Yunohost Git/Infra notifications> [package_linter] ericgaspar deleted branch actions/black
[14:18:13] <Yunohost Git/Infra notifications> [nextcloud_ynh] alexAubin pushed 2 commits to testing ([f43dc34f941f...7a1274d831ea](https://github.com/YunoHost-Apps/nextcloud_ynh/compare/f43dc34f941f...7a1274d831ea))
[14:18:29] <Yunohost Git/Infra notifications> [nextcloud_ynh/testing] Add comment about the cron check for high perf backend - Alexandre Aubin
[14:19:06] <Aleks (he/him/il/lui)> > <@ericg:matrix.org> can we merge this Nextcloud PR? https://github.com/YunoHost-Apps/nextcloud_ynh/pull/721

LGTM ✅️
[14:19:06] <Yunohost Git/Infra notifications> [nextcloud_ynh] alexAubin approved [pull request #721](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/721#pullrequestreview-2312855319) Testing
[14:19:09] <Yunohost Git/Infra notifications> [nextcloud_ynh] alexAubin [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/721#discussion_r1765151452) on pull request #721 Testing: "High performance backend" is just the way the Nextcloud team refers to it, cf https://help.nextcloud.com/t/nextcloud-hu...
[14:21:39] <Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar merged [pull request #721](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/721): Testing
[14:21:42] <Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar pushed 1 commit to master: Testing (#721) * Update manifest.toml * Auto-update READMEs * add pre upgrade warning for NC 29 * update to PHP8.3 ... ([129a8b72](https://github.com/YunoHost-Apps/nextcloud_ynh/commit/129a8b721904d9ae53479a9dd584db749d03aa6a))
[14:22:13] <Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar pushed 2 commits to testing ([7a1274d831ea...82bd58fc6ea1](https://github.com/YunoHost-Apps/nextcloud_ynh/compare/7a1274d831ea...82bd58fc6ea1))
[14:22:21] <Yunohost Git/Infra notifications> [nextcloud_ynh/testing] Testing (#721) * Update manifest.toml * Auto-update READMEs * add pre upgrade warning for NC 29 * update to PHP8.3 ... - eric_G
[14:22:37] <Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar pushed 5 commits to v2_PostgreSQL ([6c8718d7cd93...bb6200c6b299](https://github.com/YunoHost-Apps/nextcloud_ynh/compare/6c8718d7cd93...bb6200c6b299))
[14:22:37] <Yunohost Git/Infra notifications> [nextcloud_ynh/v2_PostgreSQL] Testing (#721) * Update manifest.toml * Auto-update READMEs * add pre upgrade warning for NC 29 * update to PHP8.3 ... - eric_G
[14:33:19] <TheSuperGeek> Hi, i've made a PR for fixing gitlab runner install/upgrade (the packages download links are broken) : https://github.com/YunoHost-Apps/gitlab-runner_ynh/pull/121
[14:36:37] <Aleks (he/him/il/lui)> cheers, merged to testing and triggered a test on the CI
[14:37:07] <TheSuperGeek> Nice thanks :)
[15:14:28] <orhtej2> ```
21384 INFO DEBUG - + sudo --preserve-env=PATH -u syncserver-rs PATH=/var/www/syncserver-rs/.cargo/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin cargo install diesel_cli --no-default-features --features mysql
21384 INFO DEBUG - sudo: cargo: command not found
```

Was there a way around this? Seeding `PATH` was unnecessary or smth?
[15:16:25] <Aleks (he/him/il/lui)> what's the exact original call ?
[15:16:45] <Aleks (he/him/il/lui)> supposedly the new version of `ynh_exec_as_app` fixed this
[15:18:31] <Aleks (he/him/il/lui)> ah yes you're probably looking at the bookworm test which doesnt have the fix
[15:46:34] <orhtej2> > <@Alekswag:matrix.org> ah yes you're probably looking at the bookworm test which doesnt have the fix

I'll have a look later, can this be merged to bookworm?
[16:33:48] <anubister> Hello, how can I collect the php-fpm (debug) logs to debug an app (movim)? I tried to set "log_level = debug" in /etc/php/8.3/fpm/php-fpm.conf but don't see any debug related message in syslog.
[16:38:56] <Aleks (he/him/il/lui)> did you look at /var/log/php*.log ?
[16:39:51] <anubister> yes, nothing relevant ([18-Sep-2024 07:18:29] NOTICE: configuration file /etc/php/8.3/fpm/php-fpm.conf test is successful)
[16:41:01] <Aleks (he/him/il/lui)> and you're sure it is a php issue ?
[16:54:01] <anubister> no but that was the advice of the Movim dev as I don't know any more in which direction to look for (a JS function return a HTML page with some JSON at the end when using the Yunohost app, while on a "bare" system it return directly the expected JSON file)
[16:55:39] <Aleks (he/him/il/lui)> doesn't sound like a php error to me
[17:24:47] <orhtej2> This finished job is somehow considered running: https://ci-apps-dev.yunohost.org/ci/job/19509
[17:25:57] <Aleks (he/him/il/lui)> yeah :|
[17:26:22] <Aleks (he/him/il/lui)> episode #76574 of "we should rewrite yunorunner using celery"
[17:51:34] <m606> hello, I read somewhere that permissions of an app directory is managed by the core in a "FIXME?" comment. Maybe related with helpers 2.1, although it is not very clear in my mind.
At the same time, I noted [this issue](https://github.com/YunoHost-Apps/privatebin_ynh/issues/42#issuecomment-2358839244) with privatebin_ynh.
Shall we add back [those 2 lines](https://github.com/YunoHost-Apps/privatebin_ynh/commit/a595e0ff34c0b00231e0fb4da8214db2aed59806#diff-6233345de4867c7ccf72bac1fc1067988d2a4c8e1ab9a746956eafccf88cfed2L17-L18) ? Manually applying line 18 after install solved the issue for me.
[17:52:54] <eric_G> m606: If you want to contact me I am in public chanel.
[17:54:35] <m606> @ericg:matrix.org yes sorry, for some reason the "@" sign did not trigger the nickname selection in my message hereinabove i wanted to tag you in
[17:56:26] <m606> > <@m606:matrix.org> hello, I read somewhere that permissions of an app directory is managed by the core in a "FIXME?" comment. Maybe related with helpers 2.1, although it is not very clear in my mind.
> At the same time, I noted [this issue](https://github.com/YunoHost-Apps/privatebin_ynh/issues/42#issuecomment-2358839244) with privatebin_ynh.
> Shall we add back [those 2 lines](https://github.com/YunoHost-Apps/privatebin_ynh/commit/a595e0ff34c0b00231e0fb4da8214db2aed59806#diff-6233345de4867c7ccf72bac1fc1067988d2a4c8e1ab9a746956eafccf88cfed2L17-L18) ? Manually applying line 18 after install solved the issue for me.

or is this now to be considered as a bug to be fixed in the core?
[19:11:05] <eric_G> m606: please feel free to open a PR with your fixes!
[19:13:41] <eric_G> mmmh, I guess permissions are not applied to this two files... `mkdir -p $install_dir/{data,tmp}`
[19:16:19] <eric_G> ok, the issue should be fixed with https://github.com/YunoHost-Apps/privatebin_ynh/pull/43
[19:37:52] <m606> thanks, I would have submitted the PR, but was wondering whether the core was now supposed to handle permissions in install script or whether we needed that `chown` line.
[19:38:04] <m606> thanks, I would have submitted the PR, but was wondering whether the core was now supposed to handle permissions in install script or whether we still needed that `chown` line.
[19:40:14] <eric_G> The core now handles permissions, but when created manually, files must have permission applied
[19:40:48] <m606> oh I see!
[19:42:38] <m606> it handles permissions only for files & folders created with `ynh_setup_source` I guess ?
[19:45:12] <m606> yes it is [there](https://github.com/YunoHost/yunohost/blob/5d15c00d921927825a0bf98b0c5d872dac57d1b7/helpers/helpers.v2.1.d/sources#L264)
[20:24:29] <orhtej2> discussion point regarding `_ynh_apply_default_permissions`: calling `ynh_setup_source --dest_dir="$install_dir/build"` should apply permissions as if it was `$install_dir` (same for `$data_dir`?). Current check works only for files, should also check subdirectories IMO. Or IDK, give it 600/$app:$app as it does for files

I can work around that by restoring old `chmod`/`chown`, but should I?

failure log https://paste.yunohost.org/raw/ajufedevay, source is set up but no additional permissions are set, failing subsequent `cargo` call as `$app` has no permission to newly created dir
[20:33:29] <orhtej2> > This finished job is somehow considered running: https://ci-apps-dev.yunohost.org/ci/job/19509

CI is having a general meltdown RN: https://ci-apps-dev.yunohost.org/ci/job/19515, none of the jobs report status and keep 'running' even if it's done
[21:10:01] <Aleks (he/him/il/lui)> sounds related to the changes in package_linter ...
[21:12:56] <orhtej2> same on bookworm https://ci-apps-bookworm-dev.yunohost.org/ci/ so general regression in <del>`package_check`</del> somewhere?
[21:54:57] <orhtej2> Idk if still relevant but autopatch changed mysql call into psql call [here](https://github.com/YunoHost-Apps/castopod_ynh/blob/13f323b98759d17010d501ddc4fe625b05e0bc01/scripts/upgrade#L63) to [this](https://github.com/yunohost-bot/castopod_ynh/blob/6deacd67c5bd21133cc405095410b9477c8242e3/scripts/upgrade#L53)
[21:57:24] <Aleks (he/him/il/lui)> ugh wtf
[21:58:31] <orhtej2> Also this did pass the test, only a warning on sudo call 🤷
[22:10:32] <geoma> I just installed Drupal and noticed that yunohost installed an old, outdated version (9)... actual version is 11... but shipped version is supposed to be from July 2024... https://github.com/YunoHost-Apps/drupal_ynh
[22:11:27] <geoma> any ideas?
[22:28:37] <Aleks (he/him/il/lui)> it ships commit f57a511 which is from 2 months ago : https://github.com/YunoHost-Apps/drupal_ynh/blob/master/manifest.toml#L64 / https://github.com/drupal-composer/drupal-project/commit/f57a511f2c5a078c0669cf7d5a2b7ae0f9696759
[22:59:24] <Yunohost Git/Infra notifications> [nextcloud_ynh] zamentur pushed 19 commits to manage-oldstable-version ([8fc95edaf7b1...599541ac8c8a](https://github.com/YunoHost-Apps/nextcloud_ynh/compare/8fc95edaf7b1...599541ac8c8a))
[22:59:31] <Yunohost Git/Infra notifications> [nextcloud_ynh/manage-oldstable-version] Testing (#721) * Update manifest.toml * Auto-update READMEs * add pre upgrade warning for NC 29 * update to PHP8.3 ... - eric_G
[23:00:18] <Yunohost Git/Infra notifications> [nextcloud_ynh] zamentur [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/714#issuecomment-2359595707) on [issue #714](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/714) Manage oldstable version: testme
[23:00:29] <Yunohost Git/Infra notifications> [nextcloud_ynh] yunohost-bot [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/714#issuecomment-2359595769) on [issue #714](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/714) Manage oldstable version: :books: :bug:
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-bookworm-dev.yunohost.org/ci/api/job/30...
[23:00:29] <Yunohost Git/Infra notifications> [nextcloud_ynh] yunohost-bot [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/714#issuecomment-2359595767) on [issue #714](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/714) Manage oldstable version: :sunflower:
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-dev.yunohost.org/ci/api/job/19520/badge)]...
[23:01:01] <Yunohost Git/Infra notifications> [nextcloud_ynh] zamentur approved [pull request #714](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/714#pullrequestreview-2313996977) Manage oldstable version: LGTM
[23:59:12] <geoma> > <@Alekswag:matrix.org> it ships commit f57a511 which is from 2 months ago : https://github.com/YunoHost-Apps/drupal_ynh/blob/master/manifest.toml#L64 / https://github.com/drupal-composer/drupal-project/commit/f57a511f2c5a078c0669cf7d5a2b7ae0f9696759

why then did it install version 9.5.11 to me?
[23:59:15] <geoma> https://aria.im/_matrix/media/v1/download/matrix.org/ujzazcoCUWRQxpRYZCWpUOQd
[23:59:57] <geoma> I am confused