[00:44:30]
<m606> Hello, could I use a GIthub Actions workflow to build a nodejs app in a YNH-Apps repo ?
[00:45:45]
<m606> and if so, how would it work with GITHUB_TOKEN ? I mean who should be its issuer ?
[10:55:16]
<Tag> Partially fixed ci-apps-dev
[11:08:25]
<orhtej2> > <@tag:lostpod.me> Partially fixed ci-apps-dev
it [is running the job](https://ci-apps-dev.yunohost.org/ci/job/3705) but [links the wrong CI](https://github.com/YunoHost-Apps/calibreweb_ynh/pull/147#issuecomment-2454398013)
Also, note the badge is broken even on CI page for some reason
[11:22:30]
<florent[m]> Last week, the upstream app of my package got a new version: https://github.com/gristlabs/grist-core/releases/tag/v1.2.1
However, no pull-request for an autoupdate has been opened: https://github.com/YunoHost-Apps/grist_ynh/pulls
I wonder if there is something wrong I did. My last commit included these changes to the manifest: https://github.com/YunoHost-Apps/grist_ynh/commit/cbf9794d983eed02ba8e8824016b540753302bc7#diff-06ac558c9cfca9e31a9a235f18d98e6d0c3bfee8bee0088108a29f2c60b318e3
[11:31:31]
<Tag> > it [is running the job](https://ci-apps-dev.yunohost.org/ci/job/3705) but [links the wrong CI](https://github.com/YunoHost-Apps/calibreweb_ynh/pull/147#issuecomment-2454398013)
> Also, note the badge is broken even on CI page for some reason
Thanks! Fixed for new comments ;)
[11:36:41]
<Tag> > Last week, the upstream app of my package got a new version: https://github.com/gristlabs/grist-core/releases/tag/v1.2.1
> However, no pull-request for an autoupdate has been opened: https://github.com/YunoHost-Apps/grist_ynh/pulls
>
> I wonder if there is something wrong I did. My last commit included these changes to the manifest: https://github.com/YunoHost-Apps/grist_ynh/commit/cbf9794d983eed02ba8e8824016b540753302bc7#diff-06ac558c9cfca9e31a9a235f18d98e6d0c3bfee8bee0088108a29f2c60b318e3
Don't panic! Digging this issue, I found that the autoupdater is disabled for now. I'll ping you once it's up and running again ✨
[11:59:36]
<florent[m]> > <@tag:lostpod.me> Don't panic! Digging this issue, I found that the autoupdater is disabled for now. I'll ping you once it's up and running again ✨
OK, thanks!
[13:16:11]
<eric_G> I have mixed feeling with this PR: https://github.com/YunoHost-Apps/nextcloud_ynh/pull/714
[13:16:43]
<eric_G> I understand the need for stability for Nextcloud in production, but it could become quite confusing to user what stable / oldstable means.
[13:18:47]
<eric_G> any thoughts on this?
[13:27:53]
<Aleks (he/him/il/lui)> hmmm yeah i don't know, to me that's a legit PR because it sounds like many people want to stay on the N-1 version for stability whereas some other people want absolutely the latest one because "zzomg version 30 has been out for 16 minutes where is teh upgrade !!?/!" - and we need a better flow than having to manually install/upgrade the app using a specific branch - but yeah we should make it clear what this means for users and the confusing thing is that Yunohost will display Nextcloud's version using the version from the manifest and not the actual version ...
[13:28:36]
<Aleks (he/him/il/lui)> so they're gonna be "I said I wanted oldstable but YunoHost says i'm on version 30 anyway !?!!"
[13:29:59]
<Aleks (he/him/il/lui)> also we're starting to have too many questions in the install manifest imho, imho the address book thing and notify push could be only in the config panel
[16:55:28]
<m606> Is it fine to use a github action workflow to build a nodeJs app for a YNH-Apps repo ? who should issue the related *secrets.GITHUB_TOKEN* in this case? Me (on a separate repo probably then) or Yunohost-Apps organization?
[16:58:37]
<Aleks (he/him/il/lui)> arent there automatic stuff under the hood in github actions that automagically create token somehow ?
[16:58:52]
<Aleks (he/him/il/lui)> i don't remember having to create token for the workflow to be able to push stuff back to the repo
[17:23:17]
<orhtej2> > <@Alekswag:matrix.org> i don't remember having to create token for the workflow to be able to push stuff back to the repo
Nope, you need to pass one in, likely as repo secret
[17:26:49]
<orhtej2> > <@m606:matrix.org> Is it fine to use a github action workflow to build a nodeJs app for a YNH-Apps repo ? who should issue the related *secrets.GITHUB_TOKEN* in this case? Me (on a separate repo probably then) or Yunohost-Apps organization?
Token is issued for the user, as long as you have proper access to repo you can use your own, you'll appear as release author
[17:54:56]
<Thomas> Could someone give me the rights for https://github.com/YunoHost-Apps/photoprism_ynh (I’m the "official" maintainer with no rights ^^)
[17:57:41]
<orhtej2> > <@thovi98:matrix.org> Could someone give me the rights for https://github.com/YunoHost-Apps/photoprism_ynh (I’m the "official" maintainer with no rights ^^)
Granted
[18:20:38]
<m606> > Token is issued for the user, as long as you have proper access to repo you can use your own, you'll appear as release author
Thanks, so I generate an app token on my personal account and then enter it as organization secret as explained there: https://docs.github.com/en/actions/security-for-github-actions/security-guides/using-secrets-in-github-actions#creating-secrets-for-an-environment ? But it means than any person with admin access to that YNH-Apps organization repo will be able to see my token, right (I'm not sure of the exact threat, but as it is deemed to be secret... 🫣) ?
[18:25:15]
<Aleks (he/him/il/lui)> that seems funky
[18:27:21]
<Aleks (he/him/il/lui)> https://aria.im/_matrix/media/v1/download/matrix.org/fXrNaaYhRiISchBzXJxmQrIo
[18:27:57]
<Aleks (he/him/il/lui)> https://aria.im/_matrix/media/v1/download/matrix.org/KsnjXJrULXeAdKsPRUfEiWlF
[18:28:07]
<Aleks (he/him/il/lui)> but maybe in your case you want to upload some artefact ?
[18:29:18]
<Aleks (he/him/il/lui)> https://stackoverflow.com/questions/65325879/add-artifact-from-github-actions-to-releases ?
[18:31:39]
<orhtej2> > <@m606:matrix.org> Thanks, so I generate an app token on my personal account and then enter it as organization secret as explained there: https://docs.github.com/en/actions/security-for-github-actions/security-guides/using-secrets-in-github-actions#creating-secrets-for-an-environment ? But it means than any person with admin access to that YNH-Apps organization repo will be able to see my token, right (I'm not sure of the exact threat, but as it is deemed to be secret... 🫣) ?
Hmm, a valid point.
otoh why do you need a token on gh againm
[18:51:12]
<Yunohost Git/Infra notifications> [apps] alexAubin [commented](https://github.com/YunoHost/apps/pull/2678#issuecomment-2455462118) on [issue #2678](https://github.com/YunoHost/apps/pull/2678) Format TOML with Taplo: (Dummy comment to test yunohost github webhooks on matrix? )
[18:52:25]
<Aleks (he/him/il/lui)> also i realize it's been a long time the CI didn't talk ?
[18:56:29]
<Yunohost Git/Infra notifications> [apps] alexAubin [commented](https://github.com/YunoHost/apps/pull/2678#issuecomment-2455462118) on [issue #2678](https://github.com/YunoHost/apps/pull/2678) Format TOML with Taplo: (Dummy comment to test yunohost github webhooks on matrix? )
[18:57:05]
<Aleks (he/him/il/lui)> > <@Alekswag:matrix.org> also i realize it's been a long time the CI didn't talk ?
probably because ci-apps-bookworm didn't have matrix-commander configured or something
[19:23:57]
<Salamandar> CI-apps-dev should be back on track.
[19:58:41]
<Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/735#issuecomment-2455587437) on [issue #735](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/735) Testing: testme
[19:58:42]
<Yunohost Git/Infra notifications> [nextcloud_ynh] yunohost-bot [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/735#issuecomment-2455587506) on [issue #735](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/735) Testing: Fingers crossed
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-bullseye-dev.yunohost.org/ci/api/job...
[19:58:43]
<Yunohost Git/Infra notifications> [nextcloud_ynh] yunohost-bot [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/735#issuecomment-2455587546) on [issue #735](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/735) Testing: :book: :worm:
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-dev.yunohost.org/ci/api/job/3713/badge)...
[21:07:24]
<Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar pushed 1 commit to testing: Update remove ([6adab0f2](https://github.com/YunoHost-Apps/nextcloud_ynh/commit/6adab0f22dd085aa1945aae9772b31418c02e353))
[21:31:33]
<m606> Interesting, I guess I was mixing Github Personal Access Token and Github Token: https://dev.to/github/the-githubtoken-in-github-actions-how-it-works-change-permissions-customizations-3cgp
@orhtej2 The workflow I'm talking about is meant to build the app, then prepare a draft release and add a comment to an existing PR.
For the 2 last actions, a GITHUB\_TOKEN is required to run third-party Github Actions scripts.
```
uses: softprops/action-gh-release@v2
with:
token: ${{ secrets.GITHUB_TOKEN }}
```
```
uses: thollander/actions-comment-pull-request@v1
with:
message: |
'Upstream upgrade is now built for YNH and ready to be released in the current repository: ${{ steps.draft_release.outputs.url }}
Make sure the release is published before merging this PR.'
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
```
So if I get it well, I've got nothing to do related to GITHUB\_TOKEN !
[21:32:21]
<m606> Interesting, I guess I was mixing Github Personal Access Token and Github Token: https://dev.to/github/the-githubtoken-in-github-actions-how-it-works-change-permissions-customizations-3cgp
orhtej2 The workflow I'm talking about is meant to build the app, then prepare a draft release and add a comment to an existing PR.
For the 2 last actions, a GITHUB\_TOKEN is required to run third-party Github Actions scripts.
```
uses: softprops/action-gh-release@v2
with:
token: ${{ secrets.GITHUB_TOKEN }}
```
```
uses: thollander/actions-comment-pull-request@v1
with:
message: |
'Upstream upgrade is now built for YNH and ready to be released in the current repository: ${{ steps.draft_release.outputs.url }}
Make sure the release is published before merging this PR.'
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
```
So if I get it well, I've got nothing to do related to GITHUB\_TOKEN !
[22:18:47]
<Yunohost Git/Infra notifications> [package_check] Salamandar pushed 2 commits to master ([a31421a01ac8...5907e2af37d1](https://github.com/YunoHost/package_check/compare/a31421a01ac8...5907e2af37d1))
[22:18:47]
<Yunohost Git/Infra notifications> [package_check] Salamandar merged [pull request #178](https://github.com/YunoHost/package_check/pull/178): Fix wrong asset 404 error
[22:18:50]
<Yunohost Git/Infra notifications> [package_check/master] Extract base tag href for resolving asset URLs - Florent
[22:18:50]
<Yunohost Git/Infra notifications> [package_check/master] Calculate full_url only once - Félix Piédallu
[22:18:58]
<Yunohost Git/Infra notifications> [package_check] github-actions[bot] pushed 1 commit to actions/black: :art: Format Python code with Black ([d5c0f45b](https://github.com/YunoHost/package_check/commit/d5c0f45b3914c7c6caec7663c5c01670c95e4710))
[22:18:58]
<Yunohost Git/Infra notifications> [package_check] github-actions[bot] created new branch actions/black
[22:19:00]
<Yunohost Git/Infra notifications> [package_check] github-actions[bot] opened [pull request #182](https://github.com/YunoHost/package_check/pull/182): Format Python code with Black
[22:20:35]
<Yunohost Git/Infra notifications> [package_check] Salamandar pushed 1 commit to btrfs: cleanup markdown, add instructions for a btrfs pool ([834bdf08](https://github.com/YunoHost/package_check/commit/834bdf088bdee770128e2526b57003d0058ed05a))
[22:20:41]
<Yunohost Git/Infra notifications> [package_check] Salamandar merged [pull request #180](https://github.com/YunoHost/package_check/pull/180): cleanup markdown, add instructions for a btrfs pool
[22:20:41]
<Yunohost Git/Infra notifications> [package_check] Salamandar pushed 1 commit to master: cleanup markdown, add instructions for a btrfs pool ([aad9cd01](https://github.com/YunoHost/package_check/commit/aad9cd011d9f6d1b53bbd3b65da06580880cd4a6))
[22:20:43]
<Yunohost Git/Infra notifications> [package_check] Salamandar deleted branch btrfs
[22:21:00]
<Yunohost Git/Infra notifications> [package_check] Salamandar pushed 1 commit to master: :art: Format Python code with Black ([e1441db7](https://github.com/YunoHost/package_check/commit/e1441db716f7c9b27f3ad689242eaca54b745ab6))
[22:21:00]
<Yunohost Git/Infra notifications> [package_check] Salamandar merged [pull request #182](https://github.com/YunoHost/package_check/pull/182): Format Python code with Black
[22:21:01]
<Yunohost Git/Infra notifications> [package_check] github-actions[bot] pushed 1 commit to actions/black: :art: Format Python code with Black ([d6813cb1](https://github.com/YunoHost/package_check/commit/d6813cb19543049a71fe87685b3a5bb60d9c5fb2))
[22:21:02]
<Yunohost Git/Infra notifications> [package_check] github-actions[bot] opened [pull request #183](https://github.com/YunoHost/package_check/pull/183): Format Python code with Black
[22:21:16]
<Yunohost Git/Infra notifications> [package_check] github-actions[bot] closed [pull request #183](https://github.com/YunoHost/package_check/pull/183): Format Python code with Black
[22:30:00]
<rodinux> comment fonctionne ce bout de code ?
```
case $YNH_ARCH in
amd64) arch="x86_64";;
arm64) arch="aarch64";;
armel|armhf) arch="armv7";;
esac
```
[22:31:23]
<rodinux> je voudrais faire une condition `yhn_die` dans mobilizon car depuis la version 4.1.0 il n'y a plus de paquet `arm64`...
[22:32:09]
<rodinux> la variable $YNH_ARCH existe ?
[22:32:48]
<Salamandar> > <@rodinux:matrix.org> la variable $YNH_ARCH existe ?
a priori oui :)
[22:33:00]
<Salamandar> > <@rodinux:matrix.org> comment fonctionne ce bout de code ?
> ```
> case $YNH_ARCH in
> amd64) arch="x86_64";;
> arm64) arch="aarch64";;
> armel|armhf) arch="armv7";;
> esac
> ```
c'est un switch/case donc grosso modo une série de "if else"
[22:33:33]
<Salamandar> ```
case $YNH_ARCH in
amd64) arch="x86_64";;
arm64) ynh_die "plus de paquet arm64" ;;
armel|armhf) arch="armv7";;
esac
```
[22:34:06]
<Salamandar> https://framagit.org/framasoft/mobilizon/-/releases/5.0.1
[22:34:10]
<Salamandar> ya du arm64 en v5 ;)
[22:35:25]
<rodinux> Et pas en v4.1.0 !!
[22:35:39]
<rodinux> comploqué tout de même ce paquet !!
[22:40:49]
<Salamandar> :D
[22:41:11]
<rodinux> en fait pour la v4.1.0 il y a un paquet `mobilizon_4.1.0_arm64-debian-bullseye.tar.gz ` mais pas pour bookworm !
[22:41:42]
<rodinux> https://packages.joinmobilizon.org/4.1.0/
[22:42:14]
<Salamandar> étrange…
[22:43:45]
<rodinux> Du coup, il faudrait passer directement de 4.0.1 à 5.0.1... c'est les nouveaux développeurs qui ont récupérer la maintenance qui vienne de sortir cette version, un peu toute fraîche...
[22:56:30]
<rodinux> Bon, un developpeur de Mobilizon me confirme avoir fait une mise à jour de la version 2.0.2 vers 5.0.1 sans étapes intermédiaire et c'est passé... donc pour que le paquet puisse être mis à jour sur bullseye et sur bookworm et soit compatible avec aussi les architectures arm64 il faudrait passer directement sur cette version !
[23:59:43]
<rodinux> Mauvaise nouvelle... en discutant un peu plus, l'image arm est builder pour buster ! https://framagit.org/framasoft/mobilizon/-/blob/main/.gitlab-ci.yml?ref_type=heads#L369