[00:46:20]
<Yunohost Git/Infra notifications> [apps] alexAubin [commented](https://github.com/YunoHost/apps/pull/2692#issuecomment-2465948385) on [issue #2692](https://github.com/YunoHost/apps/pull/2692) Add Domain Watchdog to wishlist: ... Again something that sounds super techy and nerdy ...
[08:32:39]
<Yunohost Git/Infra notifications> [apps] ericgaspar closed [pull request #2692](https://github.com/YunoHost/apps/pull/2692): Add Domain Watchdog to wishlist
[08:34:15]
<eric_G> > <@rodinux:matrix.org> just a question eric_G , I have a nextcloud app on branch v2_PostgreSQL, so I must care always upgrade it this branch only, you agree ?
Yes, as I am using this branch in production it is always super up-to-date 😬
[08:35:53]
<eric_G> > <@miro5001:matrix.org> OK, I got it working on my test server.
>
> You have to comment this line
> ```
> <bind-address>127.0.0.1</bind-address>
> ```
> It restricts the address of the source. Unless you will have your source on the server.
> I had to open the port and set the port from the config file (80 and 443 didn't work)
> I found this solution on stackoverflow
> https://stackoverflow.com/questions/51786404/icecast2-running-under-nginx-not-able-to-connect
> I didn't test it.
> If one of the apps in the catalog can send a stream it will be useful in conjunction with icecast2.
> (I have tested it using an android app)
OK so there is hope. I am working on the testing branch https://github.com/YunoHost-Apps/icecast2_ynh/tree/testing
[08:38:30]
<eric_G> right now I am not able to connect any client (It maybe me missing on specific setting to apply). Don't hesitate to add relevant changes to the PR
[08:49:55]
<Yunohost Git/Infra notifications> [apps] tituspijean [commented](https://github.com/YunoHost/apps/pull/2679#issuecomment-2466124012) on [issue #2679](https://github.com/YunoHost/apps/pull/2679) Add PySyft to wishlist: reject Huge requirements, no selfhosting documentation, niche use case.
[08:50:12]
<Yunohost Git/Infra notifications> [apps] yunohost-bot pushed 1 commit to add-to-wishlist-pysyft: Reject PySyft from catalog ([885bd763](https://github.com/YunoHost/apps/commit/885bd763e462fe9c6f358d820ca37cecf22afa0a))
[08:50:12]
<Yunohost Git/Infra notifications> [apps] yunohost-bot edited [pull request #2679](https://github.com/YunoHost/apps/pull/2679): Add PySyft to rejection list
[08:52:19]
<Yunohost Git/Infra notifications> [apps/add-to-wishlist-pysyft] Add PySyft to wishlist - yunohost-bot
[08:52:19]
<Yunohost Git/Infra notifications> [apps] tituspijean pushed 2 commits to add-to-wishlist-pysyft ([885bd763e462...b7112f560633](https://github.com/YunoHost/apps/compare/885bd763e462...b7112f560633))
[08:52:20]
<Yunohost Git/Infra notifications> [apps/add-to-wishlist-pysyft] Reject PySyft from catalog - yunohost-bot
[08:52:33]
<Yunohost Git/Infra notifications> [apps] github-actions[bot] pushed 1 commit to actions/toml: :art: Format TOML with Taplo ([de778457](https://github.com/YunoHost/apps/commit/de77845727c1dbaccb735eb5a36c538e73e84049))
[08:53:38]
<Yunohost Git/Infra notifications> [apps] tituspijean merged [pull request #2679](https://github.com/YunoHost/apps/pull/2679): Add PySyft to rejection list
[08:53:39]
<Yunohost Git/Infra notifications> [apps] tituspijean pushed 1 commit to master: Add PySyft to rejection list (#2679) ([e60461f7](https://github.com/YunoHost/apps/commit/e60461f7a5312632f81530a1db985f362304d444))
[08:53:40]
<Yunohost Git/Infra notifications> [apps] tituspijean edited [pull request #2693](https://github.com/YunoHost/apps/pull/2693): Format TOML with Taplo
[08:53:41]
<Yunohost Git/Infra notifications> [apps] tituspijean deleted branch add-to-wishlist-pysyft
[08:53:54]
<Yunohost Git/Infra notifications> [apps] github-actions[bot] pushed 1 commit to actions/toml: :art: Format TOML with Taplo ([19161393](https://github.com/YunoHost/apps/commit/19161393799542fcc59072243dfe01313171d245))
[08:57:58]
<Yunohost Git/Infra notifications> [apps] ericgaspar pushed 1 commit to master: :art: Format TOML with Taplo (#2693) Co-authored-by: tituspijean <8769166+tituspijean@users.noreply.github.com> ([c620bb1c](https://github.com/YunoHost/apps/commit/c620bb1c89d03aa2bd8776b835530159029ee423))
[08:57:58]
<Yunohost Git/Infra notifications> [apps] ericgaspar merged [pull request #2693](https://github.com/YunoHost/apps/pull/2693): Format TOML with Taplo
[08:57:59]
<Yunohost Git/Infra notifications> [apps] ericgaspar deleted branch actions/toml
[08:59:41]
<thomas> Hi all, I'm trying to run package_check on my laptop, but I get this error: "ModuleNotFoundError: No module named 'toml'". I s there a simple way to get rid of it? Like installing a python module using apt?
[09:07:31]
<tituspijean> Damn we should have a requirements.txt in the repo
[09:08:43]
<tituspijean> first create a virtual env:
`python3 -m venv venv`
and activate it:
`source venv/bin/activate`
[09:09:52]
<tituspijean> then install the toml package: `pip install toml`
[09:10:50]
<tituspijean> (you might need to `pip install` other packages, let us know if another error arises)
[09:26:17]
<Salamandar> yeah also uh that's not "supported" properly by yunorunner
[09:26:42]
<Salamandar> (tbh yunorunner is way too package_check-dependent, it should be agnostic)
[11:36:03]
<thomas> > (you might need to `pip install` other packages, let us know if another error arises)
All good, just needed to also add jsonschema. Package_check is running on my laptop
[13:34:44]
<Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar pushed 1 commit to helpers_2.1-3.0.1: Create .gitignore ([ceb0a768](https://github.com/YunoHost-Apps/nextcloud_ynh/commit/ceb0a76885296bf2370fb3fb830da695d9a72dcf))
[14:18:14]
<eric_G> this is not needed anymore with YNH 12 ?https://github.com/YunoHost/example_ynh/blob/09ce2ea730029839546f8f61703937b0dd51f306/conf/nginx.conf#L26-L27
[14:27:33]
<Salamandar> indeed we can start removing them
[15:21:28]
<Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar pushed 1 commit to helpers_2.1-3.0.1: Update install ([7ffd97ea](https://github.com/YunoHost-Apps/nextcloud_ynh/commit/7ffd97eab46210c34c1bbd75a610e3b742344ad0))
[15:22:13]
<Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar pushed 1 commit to helpers_2.1-3.0.1: Update upgrade ([087aa05e](https://github.com/YunoHost-Apps/nextcloud_ynh/commit/087aa05e7f760d8522cdc8365fe332744702cd9e))
[15:51:12]
<thomas> > All good, just needed to also add jsonschema. Package_check is running on my laptop
Hmm. Weird. package_check.sh works fine, but by the end it does not show the "Tests summary". I'm running it like this:
./package_check.sh ./path/to/my/app_ynh/
Am I forgetting an option?
[16:06:38]
<m606> Hello, if I `grep -rl * | xargs yhn_replace -match="" -replace=""` YNH install log says: `xargs: ynh_replace: No such file or directory`. Is that supposed to be so or should I dig further ? If I use sed instead I have no issue.
[16:07:26]
<m606> (manifest is set to helpers_version = "2.1")
[16:07:53]
<Aleks (he/him/il/lui)> i assume you mean you're in an app script
[16:08:01]
<m606> install/update yes
[16:08:28]
<Aleks (he/him/il/lui)> `xargs foobar` will not work if `foobar` is not an actual command, but `ynh_replace` is a bash function so it's not available in the context or `xargs`
[16:09:13]
<Aleks (he/him/il/lui)> (xargs just see strings as its argument, and then internally try to call that string as being a command name, but the command ynh_replace doesn't exist on the system, and it cannot know about the function that existed for its parent)
[16:09:34]
<Aleks (he/him/il/lui)> so yeah you gotta use a for loop i suppose
[16:38:13]
<m606> Thanks for the explaination. I've tried the following in the spririt in the spirit of [this](https://stackoverflow.com/questions/11003418/calling-shell-functions-with-xargs/11003457#11003457) and [that](https://www.geeksforgeeks.org/calling-shell-functions-with-xargs/#:~:text=Steps%20for%20calling%20shell%20functions%20with%20xargs)
```
export -f ynh_replace
grep -rli 'oldpattern' $install_dir/* | xargs -I {} bash -c 'ynh_replace --match="oldpattern" --replace="newpattern" "$@"' _ {}
export -f ynh_replace
grep -rli 'oldpattern' $install_dir/* | xargs -n 1 -I {} bash -c ynh_replace --match="oldpattern" --replace="newpattern" {}
```
But then the issue seems to be with internal helpers. Anyway it becomes probably too much of an edge case.
I wonder why is the CI complaining about `sed` instead of `yhn_replace`? I have met several times situations where I couldn't make with ynh_replace or equivalent what I could do with `sed` (or it would take quite much additional efforts).
[16:38:33]
<m606> Thanks for the explaination. I've tried the following in the spirit of [this](https://stackoverflow.com/questions/11003418/calling-shell-functions-with-xargs/11003457#11003457) and [that](https://www.geeksforgeeks.org/calling-shell-functions-with-xargs/#:~:text=Steps%20for%20calling%20shell%20functions%20with%20xargs)
```
export -f ynh_replace
grep -rli 'oldpattern' $install_dir/* | xargs -I {} bash -c 'ynh_replace --match="oldpattern" --replace="newpattern" "$@"' _ {}
export -f ynh_replace
grep -rli 'oldpattern' $install_dir/* | xargs -n 1 -I {} bash -c ynh_replace --match="oldpattern" --replace="newpattern" {}
```
But then the issue seems to be with internal helpers. Anyway it becomes probably too much of an edge case.
I wonder why is the CI complaining about `sed` instead of `yhn_replace`? I have met several times situations where I couldn't make with ynh_replace or equivalent what I could do with `sed` (or it would take quite much additional efforts).
[16:40:56]
<Aleks (he/him/il/lui)> this is like idk, 8 years old at least when we started introducing helpers, the point was to standardize things, and in particular having robust stuff when replacing strings containing special characters etc
[16:42:15]
<Aleks (he/him/il/lui)> at the time there wasnt even helpers for the nginx conf etc so every app had a whole bunch of sed / ynh_replace to replace every var
[16:46:30]
<m606> I mean overall the helpers are very useful, my point is only with `ynh_replace` which I find less flexible than `sed`
like for this `sed -Ei 's/(\.support-button[^]]*\]\{[^}]*)/\1;display:none/' "$install_dir/assets/$main_css" `, I need -E param for it to work which I can't get with ynh_replace, above example with xargs, etc.
But I guess it is not a big deal if I use `sed` for those.
[16:47:11]
<m606> despite CI's complaints
[16:48:52]
<Aleks (he/him/il/lui)> you could argue sed syntax quickly becomes more obscure and the point was to keep something accessible to less-tech-savvy people
[16:49:17]
<Aleks (he/him/il/lui)> but on the other hand i wouldnt be that schoked if you used it because in your case it's much simpler
[16:59:47]
<thomas> > Hmm. Weird. package_check.sh works fine, but by the end it does not show the "Tests summary". I'm running it like this:
> ./package_check.sh ./path/to/my/app_ynh/
> Am I forgetting an option?
Yup. pip install imgkit.
[17:06:33]
<m606> it seems that CI server is down - 504 Gateway Time-out
[17:07:35]
<m606> oh it's back!
[17:15:00]
<thomas> Quick question: if the package_check test is successful on my computer, can I skip the !testme comment on a pull request (i.e. if the CI server has some difficulties)?
[17:19:36]
<Salamandar> well yes and no, i'd say it's better to test on the official CI, but if you're confident on your changes (if it's just some bashism changes), that should be ok
[17:20:22]
<Salamandar> But know that if the PR breaks an app, you will be hang in public place
[17:21:06]
<Salamandar> https://aria.im/_matrix/media/v1/download/matrix.org/BLBzATfiKfjUjehnBzktLwXP
[17:24:42]
<thomas> Well, since the app is brand new and currently in a broken state, I guess my neck should be fine 🤪
[17:25:32]
<thomas> I mean, look at this beauty:
[17:25:41]
<thomas> https://im.discretos.fr:5443/upload/fb44a22e1b5e8650614030b49a71bbc4429abb8b/cdnIpOktlGyhar6F6vuLBUz1ZqRNSOAiaqMB1lvK/summary_0.png
[17:38:08]
<ghose> https://aria.im/_matrix/media/v1/download/tchncs.de/aa59cc19e2ca5edf075c6e7b22e725d9d305d7221855303756632031232
[17:38:31]
<ghose> what am I missing? that's my question. Thank you.
[17:40:22]
<Aleks (he/him/il/lui)> line 23 you have something like:
```
ynh_script_progression "Adding app's configuration file..."
ynh_config_add --template="" --destination="$install_dir/"
```
[17:40:27]
<Aleks (he/him/il/lui)> but then the "template" arg is empty
[17:40:46]
<Aleks (he/him/il/lui)> maybe that's something from the app generator about the "app-specific config" which aint needed in your case
[17:41:22]
<Aleks (he/him/il/lui)> naively i would remove the entire block "ADD A CONFIGURATION" (including the chmod and chown that come after these two lines)
[17:41:30]
<Aleks (he/him/il/lui)> and similarly in other scripts (upgrade etc)
[17:42:13]
<ghose> thank you! I will try 🤗
[17:43:28]
<Aleks (he/him/il/lui)> aaaand while we're at it
[17:43:53]
<Aleks (he/him/il/lui)> i see in the "INSTALL APP" block that you have the dummy "some_command --build" which will obviously fail too
[17:44:04]
<Aleks (he/him/il/lui)> same for `ynh_local_curl "/INSTALL_PATH" "key1=value1" "key2=value2" "key3=value3"`
[17:44:18]
<Aleks (he/him/il/lui)> if your app is purely static your don't need these either
[17:44:31]
<Aleks (he/him/il/lui)> so you should remove the "INSTALL APP" and "FINALIZE APP INSTALL WITH CURL" blocks too
[17:55:36]
<Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar pushed 1 commit to helpers_2.1-3.0.1: Update install ([72fd94d0](https://github.com/YunoHost-Apps/nextcloud_ynh/commit/72fd94d0afdbc5e9077da3c4eee2f39de0eb8287))
[17:56:11]
<Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar pushed 1 commit to helpers_2.1-3.0.1: Update _common.sh ([eda419eb](https://github.com/YunoHost-Apps/nextcloud_ynh/commit/eda419ebdeaab523ee101ef2fd76de12fdc9b2cd))
[17:57:05]
<ghose> > <@Alekswag:matrix.org> and similarly in other scripts (upgrade etc)
🥳 it's worked! I have now phanpy in my YNH from a yunohost package!
[17:58:32]
<ghose> tomorrow (next few days) I will contact you in order to apply to include this package/app. Of course, I have to also review and **test** the other scripts
[18:06:27]
<thomas> > > <@Alekswag:matrix.org> and similarly in other scripts (upgrade etc)
>
> 🥳 it's worked! I have now phanpy in my YNH from a yunohost package!
Yeah! Phanpy is one of the working clients for Mitra, which will be soon available too.
[18:45:49]
<Yunohost Git/Infra notifications> [appstore] Salamandar pushed 1 commit to main: CI results should just be cached ([110a86d1](https://github.com/YunoHost/appstore/commit/110a86d1c7472281356e0d09487d8abda553073c))
[18:46:11]
<Yunohost Git/Infra notifications> [appstore] Salamandar pushed 1 commit to main: oops, typo ([762b5920](https://github.com/YunoHost/appstore/commit/762b5920c202c6961486ec9730841181aa2c9d02))
[20:56:38]
<Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar pushed 4 commits to 30.0.0 ([f52e9b3a035f...1a7292dbfb7b](https://github.com/YunoHost-Apps/nextcloud_ynh/compare/f52e9b3a035f...1a7292dbfb7b))
[20:56:39]
<Yunohost Git/Infra notifications> [nextcloud_ynh/30.0.0] 29.0.9 (#747) * Testing (#735) * Update ADMIN.md (#734) Jai sorti High Performance Backend, qui était dans la sectio... - eric_G
[20:56:39]
<Yunohost Git/Infra notifications> [nextcloud_ynh/30.0.0] Merge branch master into testing - eric_G
[20:56:39]
<Yunohost Git/Infra notifications> [nextcloud_ynh/30.0.0] Merge branch testing into 30.0.0 - eric_G
[20:56:42]
<Yunohost Git/Infra notifications> [nextcloud_ynh] yunohost-bot pushed 1 commit to 30.0.0: Auto-update READMEs ([78cb0ebe](https://github.com/YunoHost-Apps/nextcloud_ynh/commit/78cb0ebe4da4e392e12ff51d5bfd626092fbf5e1))
[20:57:18]
<Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/704#issuecomment-2466457632) on [issue #704](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/704) Helpers 2.1: testme
[20:57:22]
<Yunohost Git/Infra notifications> [nextcloud_ynh] yunohost-bot [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/704#issuecomment-2466457649) on [issue #704](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/704) Helpers 2.1: Test it, book it, worm it, technologic. :robot: :notes:
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-ap...
[20:57:22]
<Yunohost Git/Infra notifications> [nextcloud_ynh] yunohost-bot [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/704#issuecomment-2466457647) on [issue #704](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/704) Helpers 2.1: Living in the past, are we? :cow::eye:
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-bullseye-dev.y...
[21:08:14]
<Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/730#issuecomment-2466460321) on [issue #730](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/730) V2 postgre sql helpers 2.1: testme
[21:08:21]
<Yunohost Git/Infra notifications> [nextcloud_ynh] yunohost-bot [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/730#issuecomment-2466460357) on [issue #730](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/730) V2 postgre sql helpers 2.1: Living in the past, are we? :cow::eye:
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-bullseye-dev.y...
[21:08:25]
<Yunohost Git/Infra notifications> [nextcloud_ynh] yunohost-bot [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/730#issuecomment-2466460341) on [issue #730](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/730) V2 postgre sql helpers 2.1: Test it, book it, worm it, technologic. :robot: :notes:
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-ap...
[22:10:37]
<Yunohost Git/Infra notifications> [appgenerator] ericgaspar opened [pull request #8](https://github.com/YunoHost/appgenerator/pull/8): Fix helper 2.1