Monday, December 23, 2024
apps@conference.yunohost.org
December
Mon Tue Wed Thu Fri Sat Sun
            1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
         

[00:00:51] <Yunohost Git/Infra notifications> Autoupdater just ran, here are the results:

- 71 pending update PRs
- 20 new apps PRs
- 9 failed apps updates: flood, fontcompare, gokapi, mitra, photoprism, shields, stremio, synapse-admin, tube

See the full log here: https://paste.yunohost.org/raw/obetujemap
[08:31:37] <Yunohost Git/Infra notifications> [piped_ynh] e​ricgaspar merged [pull request #164](https://github.com/YunoHost-Apps/piped_ynh/pull/164): Upgrade to v2024.12.21
[08:31:55] <Yunohost Git/Infra notifications> [piped_ynh] e​ricgaspar deleted branch ci-auto-update-2024.12.21
[08:31:58] <Yunohost Git/Infra notifications> [piped_ynh] e​ricgaspar opened [pull request #165](https://github.com/YunoHost-Apps/piped_ynh/pull/165): Testing
[08:32:00] <Yunohost Git/Infra notifications> [piped_ynh] e​ricgaspar merged [pull request #165](https://github.com/YunoHost-Apps/piped_ynh/pull/165): Testing
[08:32:00] <Yunohost Git/Infra notifications> [searxng_ynh] e​ricgaspar merged [pull request #354](https://github.com/YunoHost-Apps/searxng_ynh/pull/354): Upgrade to v2024.12.22
[08:32:01] <Yunohost Git/Infra notifications> [searxng_ynh] e​ricgaspar deleted branch ci-auto-update-2024.12.22
[08:32:01] <Yunohost Git/Infra notifications> [searxng_ynh] e​ricgaspar opened [pull request #355](https://github.com/YunoHost-Apps/searxng_ynh/pull/355): Testing
[08:32:02] <Yunohost Git/Infra notifications> [searxng_ynh] g​ithub-actions[bot] opened [pull request #356](https://github.com/YunoHost-Apps/searxng_ynh/pull/356): Upgrade master from testing
[08:32:02] <Yunohost Git/Infra notifications> [searxng_ynh] e​ricgaspar merged [pull request #355](https://github.com/YunoHost-Apps/searxng_ynh/pull/355): Testing
[08:32:04] <Yunohost Git/Infra notifications> [searxng_ynh] e​ricgaspar merged [pull request #356](https://github.com/YunoHost-Apps/searxng_ynh/pull/356): Upgrade master from testing
[11:41:04] <Yunohost Git/Infra notifications> [apps] S​alamandar opened [pull request #2756](https://github.com/YunoHost/apps/pull/2756): Manually fix redirect app.
[11:41:04] <Yunohost Git/Infra notifications> [apps] S​alamandar pushed 1 commit to fix_redirect: Manually fix redirect app. Its only borked because tests are relying on the yunohost.org/path/ that was not updated fo... ([cd8abad5](https://github.com/YunoHost/apps/commit/cd8abad5f6e2553a35293024c30006a2fa138f6c))
[11:41:04] <Yunohost Git/Infra notifications> [apps] S​alamandar pushed 1 commit to master: Manually fix redirect app. Its only borked because tests are relying on the yunohost.org/path/ that was not updated fo... ([1133c9c9](https://github.com/YunoHost/apps/commit/1133c9c935f39294eed1982aeae2dfd394ec0ae1))
[11:41:05] <Yunohost Git/Infra notifications> [apps] S​alamandar merged [pull request #2756](https://github.com/YunoHost/apps/pull/2756): Manually fix redirect app.
[11:41:05] <Yunohost Git/Infra notifications> [apps] S​alamandar deleted branch fix_redirect
[11:41:05] <Yunohost Git/Infra notifications> [apps] S​alamandar pushed 1 commit to fix_redirect: Manually fix redirect app. Its only borked because tests are relying on the yunohost.org/path/ that was not updated fo... ([5ca28934](https://github.com/YunoHost/apps/commit/5ca289348d6c1c07d2b2dcb7f7a878da1f78c9cd))
[11:41:05] <Yunohost Git/Infra notifications> [apps] S​alamandar edited [pull request #2756](https://github.com/YunoHost/apps/pull/2756): Manually fix redirect app.
[11:41:06] <Yunohost Git/Infra notifications> [apps] S​alamandar created new branch fix_redirect
[12:32:41] <miro5001> indico is failing the ci job on bookworm but not on bullseye :
https://ci-apps-dev.yunohost.org/ci/job/5102

```
2024-12-23 08:28:06,483: DEBUG - + yunohost service add indico-celery '--description=Celery for indico' --log=/var/log/indico/indico-celery
2024-12-23 08:28:06,513: WARNING - Traceback (most recent call last):
2024-12-23 08:28:06,513: WARNING - File "/usr/bin/yunohost", line 25, in <module>
2024-12-23 08:28:06,514: WARNING - import yunohost
2024-12-23 08:28:06,514: WARNING - ModuleNotFoundError: No module named 'yunohost'
```



[12:34:57] <miro5001> The install fails on yunohost 12.0.9
But I was able to install on a previous 12 version, don't remember which one
[12:38:49] <miro5001> https://github.com/YunoHost-Apps/indico_ynh/blob/2dd650760d6df2e1c69bc190d6b7b6ea57203b34/scripts/install#L95
[12:59:47] <Aleks (he/him/il/lui)> That's weird, it's similar to the issue with 'yunohost app shell' but uuuuh
[13:04:49] <orhtej2> > <@Alekswag:matrix.org> That's weird, it's similar to the issue with 'yunohost app shell' but uuuuh

Isn't there an issue open that we need to unset env prior to calling `yunohost` from app scripts?
[13:12:47] <Aleks (he/him/il/lui)> Ah virtualenv ?
[13:13:11] <Aleks (he/him/il/lui)> Could be that a venv was sourced and it fucks up the python path ?
[13:14:12] <Aleks (he/him/il/lui)> Naively we should never source venvs in app scripts ideally, always use venv/bin/python and venv/bin/pip instead
[13:15:56] <miro5001> ```
/usr/local/bin/python$py_vshort -m venv --upgrade-deps --prompt indico "$install_dir/.venv"
source "$install_dir/.venv/bin/activate"
echo "source $install_dir/.venv/bin/activate" >> $install_dir/.bashrc
```
[13:17:01] <miro5001> https://github.com/YunoHost-Apps/indico_ynh/blob/2dd650760d6df2e1c69bc190d6b7b6ea57203b34/scripts/install#L62
[13:52:21] <orhtej2> > <@Alekswag:matrix.org> Naively we should never source venvs in app scripts ideally, always use venv/bin/python and venv/bin/pip instead

May as well be https://github.com/YunoHost-Apps/indico_ynh/blob/2dd650760d6df2e1c69bc190d6b7b6ea57203b34/scripts/install#L63
[14:36:23] <chrichri ⚡> I
* installed an app (created a system user)
* installed another app (created another system user)
* made a backup of the app I installed first
* deleted the app I installed first
* restored the app I installed first from the backup

This failed. Reason seems to be:
* deleting the app the system user is deleted
* leaving a gap in the uids used in /etc/passwd
* restoring the app the system user is created, but
* the uid used is not the same as when it firstly had been installed
* the new uid seems to be choosen as `highest uid + 1`
* ynh_restore_file restores from the backup archive using the old uid that has not been reused when re-creating the system user
* file access fails, because files do not belong to the newly created app system user, but to the former (different) app system user

Is this known? Is it responsibility of the the app restore script to adjust the ownership of the files to match the newly during restore created system user?
[14:40:43] <orhtej2> > <@chrichri:ween.de> I
> * installed an app (created a system user)
> * installed another app (created another system user)
> * made a backup of the app I installed first
> * deleted the app I installed first
> * restored the app I installed first from the backup
>
> This failed. Reason seems to be:
> * deleting the app the system user is deleted
> * leaving a gap in the uids used in /etc/passwd
> * restoring the app the system user is created, but
> * the uid used is not the same as when it firstly had been installed
> * the new uid seems to be choosen as `highest uid + 1`
> * ynh_restore_file restores from the backup archive using the old uid that has not been reused when re-creating the system user
> * file access fails, because files do not belong to the newly created app system user, but to the former (different) app system user
>
> Is this known? Is it responsibility of the the app restore script to adjust the ownership of the files to match the newly during restore created system user?

Helpers v2.1 somewhat address that but yes, it's up to `restore` to ensure the permissions
[14:41:37] <chrichri ⚡> O.k., thanks - than I need to extend my restore script. _somewhat_ sounds like that this is independent of migrating to helpers 2.1, right?
[14:43:14] <chrichri ⚡> > <@chrichri:ween.de> O.k., thanks - than I need to extend my restore script. _somewhat_ sounds like that this is independent of migrating to helpers 2.1, right?

(I suspect that a clean solution could only be created if the uid of the sytem user on install would be saved to settings to have a reference to change the ownership from the old to the new uid/gid)
[16:27:50] <orhtej2> > <@chrichri:ween.de> (I suspect that a clean solution could only be created if the uid of the sytem user on install would be saved to settings to have a reference to change the ownership from the old to the new uid/gid)

May as well be, we could investigate if tar can be made to do it, otoh what about custm methods?
[16:27:51] <Yunohost Git/Infra notifications> [wallabag2_ynh/ci-auto-update-2.6.10] Upgrade sources - main v2.6.10: https://github.com/wallabag/wallabag/releases/tag/2.6.10 - Tagada
[16:27:51] <Yunohost Git/Infra notifications> [wallabag2_ynh] T​agadda pushed 3 commits to ci-auto-update-2.6.10 ([ddad1b856797...4e016e6a5079](https://github.com/YunoHost-Apps/wallabag2_ynh/compare/ddad1b856797...4e016e6a5079))
[16:27:52] <Yunohost Git/Infra notifications> [wallabag2_ynh/ci-auto-update-2.6.10] Auto-update READMEs - yunohost-bot
[16:27:52] <Yunohost Git/Infra notifications> [wallabag2_ynh/ci-auto-update-2.6.10] Auto-update READMEs - yunohost-bot
[16:29:22] <Thomas> > <@miro5001:matrix.org> indico is failing the ci job on bookworm but not on bullseye :
> https://ci-apps-dev.yunohost.org/ci/job/5102
>
> ```
> 2024-12-23 08:28:06,483: DEBUG - + yunohost service add indico-celery '--description=Celery for indico' --log=/var/log/indico/indico-celery
> 2024-12-23 08:28:06,513: WARNING - Traceback (most recent call last):
> 2024-12-23 08:28:06,513: WARNING - File "/usr/bin/yunohost", line 25, in <module>
> 2024-12-23 08:28:06,514: WARNING - import yunohost
> 2024-12-23 08:28:06,514: WARNING - ModuleNotFoundError: No module named 'yunohost'
> ```
>
>
>

I've just added a 'deactivate' a the end of my virtualenv operations to fix the issue
[16:29:34] <Yunohost Git/Infra notifications> [wallabag2_ynh] T​agadda [commented](https://github.com/YunoHost-Apps/wallabag2_ynh/pull/225#issuecomment-2559990749) on [issue #225](https://github.com/YunoHost-Apps/wallabag2_ynh/pull/225) Upgrade to v2.6.10: Rebased on testing testme
[16:30:57] <Yunohost Git/Infra notifications> [wallabag2_ynh] T​agadda pushed 1 commit to ci-auto-update-2.6.10: fix ([7cb5c1e0](https://github.com/YunoHost-Apps/wallabag2_ynh/commit/7cb5c1e0cea784aba1481c300d417f474b4f1653))
[16:36:45] <Yunohost Git/Infra notifications> [wallabag2_ynh] T​agadda pushed 1 commit to ci-auto-update-2.6.10: Update parameters for 2.6.10 ([56114502](https://github.com/YunoHost-Apps/wallabag2_ynh/commit/561145025fdd74ed6d2234d9e2d191f2317e4798))
[16:57:55] <Yunohost Git/Infra notifications> [wallabag2_ynh] T​agadda pushed 1 commit to ci-auto-update-2.6.10: Move patches ([141522ad](https://github.com/YunoHost-Apps/wallabag2_ynh/commit/141522ad2d4e55dc62cc1cb52ec4874ada7a4334))
[17:26:12] <miro5001> > <@thovi98:matrix.org> I've just added a 'deactivate' a the end of my virtualenv operations to fix the issue

It seems to have fixed it. The Ci job is still in progress but the install was successful
[18:30:35] <miro5001> Thanks a lot Thomas:
The job completed successfully and the app is not broken now