[15:42:11]
<m606> hmm I have almost sorted out the config panel I was working on lately, but I've just found a strange bug when trying to change `archives_paths` setting in the config panel. It appears in the config panel as multiline text box in which admin is supposed to enter one URI per line, which are then saved via custom getter/setter as a comma-separated string both in app config file and in settings (`bind="settings"` for that config panel entry). I say URI but there's no validation performed, so that could be any word as in below test.
I thought it was working, but it actually only partially works - I can save the setting provided I have at least two lines in the text box. If I have only one line or if I want to empty the text box (if I had saved something before), it doesn't work - YNH returns "Nothing have changed".
Here are two logs comparing on the left when I successfully save the following 2 lines:
```
whatever
new
````
and on the right when I try to empty the same text box and save (here YNH tells me "Nothing has changed" and does not update the setting), so both app file and settings.yml contains values `whatever, new`
Compared logs: https://www.diffchecker.com/3eTIQZTz/
I have trying to spot in the logs what is wrong in the second log, thinking maybe [my custom setter/getter](https://github.com/YunoHost-Apps/marl_ynh/blob/testing/scripts/config) might be involved, but I can't find where the comparison between old and new setting is failing here.
I guess this is supposed to happen there https://github.com/YunoHost/yunohost/blob/1bdff63749ba4cba010a2142e455eab14e45d11b/helpers/helpers.v2.1.d/config#L216
Which corresponds to line 507 of the log, but I don't get it as in both case it seems to compare similar stuffs.
[15:42:12]
<m606> hmm I have almost sorted out the config panel I was working on lately, but I've just found a strange bug when trying to change `archives_paths` setting in the config panel. It appears in the config panel as multiline text box in which admin is supposed to enter one URI per line, which are then saved via custom getter/setter as a comma-separated string both in app config file and in settings (`bind="settings"` for that config panel entry). I say URI but there's no validation performed, so that could be any word as in below test.
I thought it was working, but it actually only partially works - I can save the setting provided I have at least two lines in the text box. If I have only one line or if I want to empty the text box (if I had saved something before), it doesn't work - YNH returns "Nothing have changed".
Here are two logs comparing on the left when I successfully save the following 2 lines:
```
whatever
new
```
and on the right when I try to empty the same text box and save (here YNH tells me "Nothing has changed" and does not update the setting), so both app file and settings.yml contains values `whatever, new`
Compared logs: https://www.diffchecker.com/3eTIQZTz/
I have been trying to spot in the logs what is wrong in the second log, thinking maybe [my custom setter/getter](https://github.com/YunoHost-Apps/marl_ynh/blob/testing/scripts/config) might be involved, but I can't find where the comparison between old and new setting is failing here.
I guess this is supposed to happen there https://github.com/YunoHost/yunohost/blob/1bdff63749ba4cba010a2142e455eab14e45d11b/helpers/helpers.v2.1.d/config#L216
Which corresponds to line 507 of the log, but I don't get it as in both case it seems to compare similar stuffs.
[15:42:12]
<m606> hmm I have almost sorted out the config panel I was working on lately, but I've just found a strange bug when trying to change `archives_paths` setting in the config panel. It appears in the config panel as multiline text box in which admin is supposed to enter one URI per line, which are then saved via custom getter/setter as a comma-separated string both in app config file and in settings (`bind="settings"` for that config panel entry). I say URI but there's no validation performed, so that could be any word as in below test.
I thought it was working, but it actually only partially works - I can save the setting provided I have at least two lines in the text box. If I have only one line or if I want to empty the text box (if I had saved something before), it doesn't work - YNH returns "Nothing have changed".
Here are two logs comparing on the left when I successfully save the following 2 lines:
```
whatever
new
```
and on the right when I try to empty the same text box and save (here YNH tells me "Nothing has changed" and does not update the setting), so both app file and settings.yml contains values `whatever, new`
Compared logs: https://www.diffchecker.com/3eTIQZTz/
I have trying to spot in the logs what is wrong in the second log, thinking maybe [my custom setter/getter](https://github.com/YunoHost-Apps/marl_ynh/blob/testing/scripts/config) might be involved, but I can't find where the comparison between old and new setting is failing here.
I guess this is supposed to happen there https://github.com/YunoHost/yunohost/blob/1bdff63749ba4cba010a2142e455eab14e45d11b/helpers/helpers.v2.1.d/config#L216
Which corresponds to line 507 of the log, but I don't get it as in both case it seems to compare similar stuffs.
[15:42:34]
<m606> hmm I have almost sorted out the config panel I was working on lately, but I've just found a strange bug when trying to change `archives_paths` setting in the config panel. It appears in the config panel as multiline text box in which admin is supposed to enter one URI per line, which are then saved via custom getter/setter as a comma-separated string both in app config file and in settings (`bind="settings"` for that config panel entry). I say URI but there's no validation performed, so that could be any word as in below test.
I thought it was working, but it actually only partially works - I can save the setting provided I have at least two lines in the text box. If I have only one line or if I want to empty the text box (if I had saved something before), it doesn't work - YNH returns "Nothing have changed".
Here are two logs comparing on the left when I successfully save the following 2 lines:
```
whatever
new
```
and on the right when I try to empty the same text box and save (here YNH tells me "Nothing has changed" and does not update the setting), so both app file and settings.yml contains values `whatever, new`
Compared logs: https://www.diffchecker.com/3eTIQZTz/
I have been trying to spot what could go wrong in the second log, thinking maybe [my custom setter/getter](https://github.com/YunoHost-Apps/marl_ynh/blob/testing/scripts/config) might be involved, but I can't find where the comparison between old and new setting is failing here.
I guess this step is supposed to happen there https://github.com/YunoHost/yunohost/blob/1bdff63749ba4cba010a2142e455eab14e45d11b/helpers/helpers.v2.1.d/config#L216, which corresponds to line 507 of the log, but I don't get it as in both case it seems to compare similar stuffs.
Would you be able to explain that line to me?
[15:42:34]
<m606> hmm I have almost sorted out the config panel I was working on lately, but I've just found a strange bug when trying to change `archives_paths` setting in the config panel. It appears in the config panel as multiline text box in which admin is supposed to enter one URI per line, which are then saved via custom getter/setter as a comma-separated string both in app config file and in settings (`bind="settings"` for that config panel entry). I say URI but there's no validation performed, so that could be any word as in below test.
I thought it was working, but it actually only partially works - I can save the setting provided I have at least two lines in the text box. If I have only one line or if I want to empty the text box (if I had saved something before), it doesn't work - YNH returns "Nothing have changed".
Here are two logs comparing on the left when I successfully save the following 2 lines:
```
whatever
new
```
and on the right when I try to empty the same text box and save (here YNH tells me "Nothing has changed" and does not update the setting), so both app file and settings.yml contains values `whatever, new`
Compared logs: https://www.diffchecker.com/3eTIQZTz/
I have been trying to spot what could go wrong in the second log, thinking maybe [my custom setter/getter](https://github.com/YunoHost-Apps/marl_ynh/blob/testing/scripts/config) might be involved, but I can't find where the comparison between old and new setting is failing here.
I guess this is supposed to happen there https://github.com/YunoHost/yunohost/blob/1bdff63749ba4cba010a2142e455eab14e45d11b/helpers/helpers.v2.1.d/config#L216
Which corresponds to line 507 of the log, but I don't get it as in both case it seems to compare similar stuffs.
[15:42:34]
<m606> hmm I have almost sorted out the config panel I was working on lately, but I've just found a strange bug when trying to change `archives_paths` setting in the config panel. It appears in the config panel as multiline text box in which admin is supposed to enter one URI per line, which are then saved via custom getter/setter as a comma-separated string both in app config file and in settings (`bind="settings"` for that config panel entry). I say URI but there's no validation performed, so that could be any word as in below test.
I thought it was working, but it actually only partially works - I can save the setting provided I have at least two lines in the text box. If I have only one line or if I want to empty the text box (if I had saved something before), it doesn't work - YNH returns "Nothing have changed".
Here are two logs comparing on the left when I successfully save the following 2 lines:
```
whatever
new
```
and on the right when I try to empty the same text box and save (here YNH tells me "Nothing has changed" and does not update the setting), so both app file and settings.yml contains values `whatever, new`
Compared logs: https://www.diffchecker.com/3eTIQZTz/
I have been trying to spot what could go wrong in the second log, thinking maybe [my custom setter/getter](https://github.com/YunoHost-Apps/marl_ynh/blob/testing/scripts/config) might be involved, but I can't find where the comparison between old and new setting is failing here.
I guess this step is supposed to happen there https://github.com/YunoHost/yunohost/blob/1bdff63749ba4cba010a2142e455eab14e45d11b/helpers/helpers.v2.1.d/config#L216, which corresponds to line 507 of the log, but I don't get it as in both case it seems to compare similar stuffs.
[15:51:14]
<m606> I mean, even if the "validate" helper might not be able to manage multiline entry, why line 507 in the log is not `[[ '' != 'whatever, new' ]]` (i.e. new vs old) ?
[18:07:44]
<cippr> Hello,
The !testme seems not working here :
https://github.com/YunoHost-Apps/zulip_ynh/pull/7
And the !gogogadgetoci too ... Is the CI on strike ;-)
<3 to the Team !
[19:06:46]
<Yunohost Git/Infra notifications> [apps] ericgaspar pushed 1 commit to davis: Update apps.toml ([92416056](https://github.com/YunoHost/apps/commit/92416056e9a56403d14b2f4816fbc42e7525b05c))
[19:06:46]
<Yunohost Git/Infra notifications> [apps] ericgaspar created new branch davis
[19:07:57]
<Yunohost Git/Infra notifications> [apps] ericgaspar pushed 1 commit to davis: Create davis.png ([c3553b39](https://github.com/YunoHost/apps/commit/c3553b393381f2b46524138388e793bed6a1c88f))
[19:07:57]
<Yunohost Git/Infra notifications> [apps] ericgaspar opened [pull request #2921](https://github.com/YunoHost/apps/pull/2921): Update apps.toml
[19:11:38]
<Yunohost Git/Infra notifications> [apps] ericgaspar pushed 1 commit to master: Add Tuwunel to wishlist (#2920) ([ea50a1df](https://github.com/YunoHost/apps/commit/ea50a1dff1528304862ff748d781b433015f0f62))
[19:11:39]
<Yunohost Git/Infra notifications> [apps] ericgaspar deleted branch add-to-wishlist-tuwunel
[19:11:39]
<Yunohost Git/Infra notifications> [apps] ericgaspar merged [pull request #2920](https://github.com/YunoHost/apps/pull/2920): Add Tuwunel to wishlist
[19:12:01]
<Yunohost Git/Infra notifications> [apps] ericgaspar edited [pull request #2921](https://github.com/YunoHost/apps/pull/2921): Add Davis to catalog
[20:21:01]
<orhtej2> btw in my limited testing hooks seemed to work with the latest Sanic so perhaps a dep unfreeze is in order?
[22:21:16]
<Yunohost Git/Infra notifications> Autoupdater just ran, here are the results:
- 15 pending update PRs
- 12 new apps PRs
- 14 failed apps updates: dokos, funkwhale, khatru-pyramid, localai, ofbiz, opencloud, penpot, phpldapadmin, phpmyadmin, piped, pixelfedglitch, snweb, stirling-pdf, stremio
See the full log here: https://paste.yunohost.org/raw/idulinovox
[23:54:07]
<m606> for testing purposes I have modified a file on live system at /etc/yunohost/apps/$app/scripts/config
I have even rebooted the system afterwhile.
However when running that app's config panel, YNH still refers to the original `config` script. Am I looking at the wrong place? Is there a kind of cache?