[12:01:34]
<Yunohost Git/Infra notifications> [nextcloud_ynh] rodinux [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/800#issuecomment-2991260910) on [issue #800](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/800) Migration to Version 31, database errors due to changes in Nextcloud upstream "ROW_FORMAT=Dynamic": Seems same problem as seen here https://forum.yunohost.org/t/nextcloud-31-0-4-incorrect-format-row-format-dynamic/36540/...
[12:42:30]
<rodinux> Hello, I am still try fix a PR for node_exporter, having trouble upgrading from the version before in the script upgrade here https://github.com/YunoHost-Apps/node_exporter_ynh/blob/122d8953f0c532d4e027d046cb4cc8c2eb72a7e8/scripts/upgrade#L50-L61
[12:47:35]
<rodinux> This argument (variable) does not exist in the pervious version, but at the begin I have put
```
if [ -z "${bind_address:-}" ]; then
bind_address="127.0.0.1"
ynh_app_setting_set_default --app=$app --key=bind_address --value="$bind_address"
fi
```
[12:49:24]
<rodinux> and also
```
if [ -z "${external:-}" ]; then
external=false
ynh_app_setting_set_default --app=$app --key=external --value="$external"
fi
```
[12:53:29]
<rodinux> But in the CI I still have
```
5812 WARNING ./upgrade: line 50: false: unbound variable
6413 ERROR Could not upgrade node_exporter: An error occurred inside the app upgrade script
```
[12:56:28]
<rodinux> perhaps I need use the boleans like here ? https://github.com/YunoHost-Apps/nextcloud_ynh/blob/03832ac784f5795255334283319cbac4b0285f40/scripts/upgrade#L14C1-L32C1
[13:40:06]
<Aleks (he/him/il/lui)> if you're using `ynh_app_setting_set_default`, you dont have to check that the value exist with `if [ -z ${foo:-} ]` etc, the very purpose of `ynh_app_setting_set_default` is to avoid the complicated syntax
[13:40:31]
<Aleks (he/him/il/lui)> just write `ynh_app_setting_set_default --key=bind_address --value="127.0.0.1"` and voila
[13:41:22]
<Aleks (he/him/il/lui)> if the setting `bind_address` already exists, it does nothing
if it doesnt, then it initialize it with `127.0.0.1` and also initialize the `$bind_address` variable with that value
[13:47:45]
<rodinux> I am always have doubt with put quotes or not put quotes use bolean with `-eq "1"` or `-eq 1` or `== false`
[13:52:53]
<Aleks (he/him/il/lui)> depends what you are comparing to
[13:53:06]
<Aleks (he/him/il/lui)> but `-eq` is for numeric comparison
[13:53:32]
<Aleks (he/him/il/lui)> though everything is a string in bash so writing `1` or `"1"` is the same thing
[13:54:25]
<Aleks (he/him/il/lui)> and `false` and `"false"` too (but beware that `false` is also .. a command ..)
but `false` is not an integer so you can't use `-eq`
[13:55:10]
<Aleks (he/him/il/lui)> but anyway there's no "real" booleans in bash, so people tend to hack something with 0 / 1, but then "0 == false" is ... false
[13:56:12]
<Aleks (he/him/il/lui)> personally i find that using 0 / 1 is horrendous (especially combine with the fact that return code 0 actually means success..)
and there's essentially no reason to not store something more explicit such as false / true instead
[13:58:17]
<rodinux> Ok thanks for the explanation...
[15:05:15]
<Yunohost Git/Infra notifications> [apps] yunohost-bot opened [pull request #3023](https://github.com/YunoHost/apps/pull/3023): Update app levels according to CI results
[16:17:55]
<rodinux> Ok, Aleks (he/him/il/lui) or someone, could you just give me a feedback, I tried my package Yunohost to listen only my local IP address, I would like to see if someone can try do this command `curl http://monitor.rodinux.fr:9100/metrics` excepted you will not see any metrics
[16:18:26]
<rodinux> Ok, Aleks (he/him/il/lui) or someone, could you just give me a feedback, I tried my package Yunohost to listen only my publicIP address, I would like to see if someone can try do this command `curl http://monitor.rodinux.fr:9100/metrics` excepted you will not see any metrics
[16:19:49]
<Aleks (he/him/il/lui)> hmyeah i can't even open a connection to the domain / port (which i assume is expected because of the firewall rule ?)
[16:20:01]
<rodinux> yes
[16:20:46]
<Aleks (he/him/il/lui)> (but it works on port 80 for example)
[16:21:15]
<rodinux> An you can see metrics there ?
[16:21:34]
<Aleks (he/him/il/lui)> no, i can't even open a connection
[16:21:49]
<Aleks (he/him/il/lui)> ah sorry i mistyped before
[16:21:55]
<Aleks (he/him/il/lui)> i mean i *can't* talk to port 9100
[16:22:15]
<Aleks (he/him/il/lui)> eg `nc -w 3 -zv monitor.rodinux.fr 9100` reports that i can talk to the port (edit: i mean *cant*)
[16:22:45]
<rodinux> And if you're ok, I try put your IP, to see if it works ?
[16:24:33]
<Aleks (he/him/il/lui)> not sure what you're hoping to achieve, i have nothing listening on port 9100 x_X
[16:25:28]
<rodinux> See if I chnage the rule to an external IP to listen the metrics...
[16:25:44]
<Aleks (he/him/il/lui)> ah you mean my IP in your config yeah
[16:26:08]
<rodinux> If you all right (can be on MP)
[16:26:17]
<Aleks (he/him/il/lui)> done
[16:27:08]
<Aleks (he/him/il/lui)> yeah now it does work
[16:27:33]
<rodinux> Yep !! so it works !!
[16:27:47]
<rodinux> nice
[16:27:54]
<Aleks (he/him/il/lui)> i can see metrics such as `promhttp_metric_handler_requests_total{code="200"} 0`
[16:28:03]
<rodinux> ok
[16:28:30]
<rodinux> it take time to add metrics...
[16:29:40]
<rodinux> So I am ready now to push the PR on testing and perhaps be more explicit on the code how it works
[16:40:50]
<m606> @rodinux:matrix.org for me `curl` command kind of never resolves, and `nc` command times out
[16:42:07]
<m606> `nc: connect to monitor.rodinux.fr ({IPV6_or_IPV4_IP}) port 9100 (tcp) timed out: Operation now in progress`
[16:43:03]
<rodinux> Yes only the IP choosen in the panel_conf, it is what excepted to give external metrics only for IP(s) choosen
[16:53:15]
<rodinux> I have put it back on local only now (listening 127.0.0.1) by default
[17:05:52]
<rodinux> I ping Tagada first to review if it's OK before push the PR...
[18:15:13]
<Yunohost Git/Infra notifications> [nextcloud_ynh] zamentur pushed 2 commits to postgresql_reboot ([fe7f562d6c4e...4eee86bab5f9](https://github.com/YunoHost-Apps/nextcloud_ynh/compare/fe7f562d6c4e...4eee86bab5f9))
[18:15:13]
<Yunohost Git/Infra notifications> [nextcloud_ynh/postgresql_reboot] [fix] Upgrade remove executable perm for nc extension - ljf
[18:15:14]
<Yunohost Git/Infra notifications> [nextcloud_ynh/postgresql_reboot] [fix] Config upgrade + small fix double wc -l - ljf
[18:54:56]
<Yunohost Git/Infra notifications> [nextcloud_ynh] zamentur pushed 2 commits to postgresql_reboot ([4eee86bab5f9...85777a01195f](https://github.com/YunoHost-Apps/nextcloud_ynh/compare/4eee86bab5f9...85777a01195f))
[18:54:56]
<Yunohost Git/Infra notifications> [nextcloud_ynh/postgresql_reboot] [fix] Backup config file before to replace it - ljf
[18:54:57]
<Yunohost Git/Infra notifications> [nextcloud_ynh/postgresql_reboot] [fix] Remove warnings and check for free space - ljf
[19:12:39]
<Yunohost Git/Infra notifications> [nextcloud_ynh] zamentur pushed 1 commit to postgresql_reboot: [fix] free_space in MB instead of Bytes ([db259bc2](https://github.com/YunoHost-Apps/nextcloud_ynh/commit/db259bc2780760d4f9766040ff82dfd6568052e1))
[19:14:37]
<Yunohost Git/Infra notifications> [nextcloud_ynh] zamentur pushed 1 commit to testing: [fix] Unneeded warning ([4082af64](https://github.com/YunoHost-Apps/nextcloud_ynh/commit/4082af649d8e0be479b3ca48c1122f29d601f118))
[19:15:15]
<Yunohost Git/Infra notifications> [nextcloud_ynh] zamentur edited [pull request #818](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/818): Postgresql reboot
[19:15:30]
<Yunohost Git/Infra notifications> [nextcloud_ynh] zamentur just made [pull request #818](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/818) ready for review: Postgresql reboot
[19:15:38]
<Yunohost Git/Infra notifications> [nextcloud_ynh] zamentur edited [pull request #818](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/818): Postgresql reboot
[19:16:02]
<Yunohost Git/Infra notifications> [nextcloud_ynh] zamentur edited [pull request #818](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/818): Postgresql reboot
[19:16:10]
<Yunohost Git/Infra notifications> [nextcloud_ynh] zamentur edited [pull request #818](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/818): Postgresql reboot
[20:00:52]
<Yunohost Git/Infra notifications> [collabora_ynh] tio-trom opened [issue #104](https://github.com/YunoHost-Apps/collabora_ynh/issues/104): Fails to upgrade: GPG error
[20:01:21]
<Yunohost Git/Infra notifications> [collabora_ynh] tio-trom edited [issue #104](https://github.com/YunoHost-Apps/collabora_ynh/issues/104): Fails to upgrade: GPG error
[21:20:09]
<Yunohost Git/Infra notifications> [collabora_ynh] tio-trom closed [issue #104](https://github.com/YunoHost-Apps/collabora_ynh/issues/104): Fails to upgrade: GPG error
[21:20:09]
<Yunohost Git/Infra notifications> [collabora_ynh] tio-trom [commented](https://github.com/YunoHost-Apps/collabora_ynh/issues/104#issuecomment-2992968641) on [issue #104](https://github.com/YunoHost-Apps/collabora_ynh/issues/104) Fails to upgrade: GPG error: I added the key manually and it works:
sudo apt-key adv --keyserver keyserver.ubuntu.com --recv-keys D8915E456E7C440E...
[22:30:49]
<Yunohost Git/Infra notifications> Autoupdater just ran, here are the results:
- 30 pending update PRs
- 20 new apps PRs
- 4 failed apps updates: homebox, khatru-pyramid, prestashop, swingmusic
See the full log here: https://paste.yunohost.org/raw/izajulepec
Autoupdate dashboard: https://apps.yunohost.org/dash?filter=autoupdate