[08:18:45]
<Yunohost Git/Infra notifications> [synapse_ynh] lapineige [commented](https://github.com/YunoHost-Apps/synapse_ynh/issues/570#issuecomment-3283598802) on [issue #570](https://github.com/YunoHost-Apps/synapse_ynh/issues/570) Restoring fails : YNH_J2_FILTERS_FILE_PATH: unbound variable: Yes it is 😃
Thanks
[08:28:53]
<florent[m]> I don't know whether this is intended, I get an error reading both the value from the CLI or from the WebUI when I put this in the `config_panel.toml` and set an empty string (`""`) for the value of `logs_retention`:
```toml
[main.advanced.logs_retention]
ask.en = "Logs retention (in days)"
ask.fr = "Rétention des logs (en jours)"
type = "number"
min = 0
optional = true
```
[08:29:22]
<florent[m]> I don't know how to say: "this is optional, empty value means that the logs_retention is disabled"
[08:29:29]
<tituspijean[m]> what is the error? :p
[08:29:58]
<florent[m]> Oh sure! 🤦
```
Error: Pick a valid value for the argument 'logs_retention': Must be a number
```
[08:31:24]
<florent[m]> I could add a boolean to ask whether the service is enabled or not though, but I would say it's simpler this way
[08:31:45]
<florent[m]> My Yunohost version:
```
yunohost:
repo: unstable
version: 12.1.17.1+202509040245
```
[08:33:25]
<florent[m]> (I can report an issue if you think I don't make a mistake or agree that this is confusing)
[08:35:38]
<miro5001> Morning everyone,
I am having an issue with the packaging of https://github.com/YunoHost-Apps/librebooking_ynh
After change_url, the check on the ci returns 500, but on my machine I see no errors
https://ci-apps-dev.yunohost.org/ci/job/12820
[08:36:21]
<miro5001> Could it be that it requires some sleep before ending the script?
[08:41:49]
<florent[m]> ```
$ yunohost app config get borg main.advanced.logs_retention
> /usr/lib/python3/dist-packages/yunohost/utils/form.py(968)normalize()
-> if isinstance(value, int):
(Pdb) n
> /usr/lib/python3/dist-packages/yunohost/utils/form.py(971)normalize()
-> if isinstance(value, str):
(Pdb) n
> /usr/lib/python3/dist-packages/yunohost/utils/form.py(972)normalize()
-> value = value.strip()
(Pdb) n
> /usr/lib/python3/dist-packages/yunohost/utils/form.py(974)normalize()
-> if isinstance(value, str) and value.isdigit():
(Pdb) n
> /usr/lib/python3/dist-packages/yunohost/utils/form.py(977)normalize()
-> if value in [None, ""]:
(Pdb) n
> /usr/lib/python3/dist-packages/yunohost/utils/form.py(980)normalize()
-> option = option.dict() if isinstance(option, BaseOption) else option
(Pdb) value
'None'
```
[08:42:40]
<florent[m]> I need to go, I hope it can help.
I am noting to report an issue if that's still necessary, and maybe to work on it.
[08:46:47]
<florent[m]> Oh, by the way, the setter (in complement to the config_panel.toml part above):
```sh
set__logs_rentention() {
ynh_app_setting_set --app="$app" --key="logs_retention" --value="$logs_retention"
ynh_add_systemd_config --service="$app-cleanup-logs.service" --template="systemd-cleanup-logs.service"
systemctl daemon-reload
}
```
[09:01:49]
<tituspijean[m]> (inb4 Alesk yells about threads: Cinny has a way of handling them that you would like: they appear like any quote of a message)
[09:02:11]
<tituspijean[m]> https://aria.im/_bifrost/v1/media/download/ATT2Wq1MK_jCAQUfzCxDfChL6A7mwdoEvT6AbW4lXhHH-yRYKt1o4W5bUQLUZdZHIlAfgPyL9jdBkbjUgpLVQuZCeZQk-FFgAG1hdHJpeC5vcmcvQ2tCbEJWZUdzU0xmSUhMdUFXU21kb1Nh
[09:03:01]
<Aleks (he/him/il/lui)> https://aria.im/_bifrost/v1/media/download/Aa_WdmwynjtlKY6_jV3A75it5jpoasyRe9pGvoug1OWfyrwNwT3U_jmP3m0RVbXljIIPbXCFKiKg-_u9v_U9tXZCeZQlBHCQAG1hdHJpeC5vcmcvbWtMY2hUb3lrRENBU05lUmZaSFhaeEdG
[09:03:02]
<Aleks (he/him/il/lui)> 🫠
[09:03:22]
<Aleks (he/him/il/lui)> (at least I'm discovering that the thread sidebar can be resized now)
[09:03:31]
<florent[m]> Oh, sorry
[09:03:55]
<Aleks (he/him/il/lui)> yeah nvm you're not responsible for Matrix design 🫠
[09:35:52]
<Yunohost Git/Infra notifications> [synapse_ynh] croulibri [commented](https://github.com/YunoHost-Apps/synapse_ynh/issues/571#issuecomment-3284533085) on [issue #571](https://github.com/YunoHost-Apps/synapse_ynh/issues/571) element-call shows "waiting for media": @Josue-T I restarted the 2 services synapse-livekit and synapse-lk-jwt ... and Element calls seems to work again.
Bu...
[10:45:55]
<Yunohost Git/Infra notifications> [synapse_ynh] croulibri [commented](https://github.com/YunoHost-Apps/synapse_ynh/issues/571#issuecomment-3284533085) on [issue #571](https://github.com/YunoHost-Apps/synapse_ynh/issues/571) element-call shows "waiting for media": @Josue-T I restarted the 2 services synapse-livekit and synapse-lk-jwt ... and Element calls seems to work again.
Bu...
[10:46:30]
<Yunohost Git/Infra notifications> [synapse_ynh] croulibri [commented](https://github.com/YunoHost-Apps/synapse_ynh/issues/571#issuecomment-3284533085) on [issue #571](https://github.com/YunoHost-Apps/synapse_ynh/issues/571) element-call shows "waiting for media": @Josue-T I restarted the 2 services synapse-livekit and synapse-lk-jwt ... and Element calls seems to work again.
Bu...
[12:50:01]
<Yunohost Git/Infra notifications> [wireguard_ynh] ericgaspar pushed to testing: cleaning ([56c85167](https://github.com/YunoHost-Apps/wireguard_ynh/commit/56c85167463d53c6bd52b11840beb9c90f4c21db))
[12:51:39]
<Yunohost Git/Infra notifications> [wireguard_ynh] ericgaspar pushed to fix2: Auto-update READMEs ([02e7c1e2](https://github.com/YunoHost-Apps/wireguard_ynh/commit/02e7c1e259da6dd48522e0b02e15a6fc76cd0132))
[12:51:39]
<Yunohost Git/Infra notifications> [wireguard_ynh] ericgaspar pushed to fix2: Merge branch testing into fix2 ([5a0ffa9e](https://github.com/YunoHost-Apps/wireguard_ynh/commit/5a0ffa9eb7ce73c972f19cc904f3b764ea94619e))
[12:51:39]
<Yunohost Git/Infra notifications> [wireguard_ynh] ericgaspar pushed to fix2: cleaning ([56c85167](https://github.com/YunoHost-Apps/wireguard_ynh/commit/56c85167463d53c6bd52b11840beb9c90f4c21db))
[13:09:59]
<eric_G> I wonder if this [nextcloud-notify-push-watcher.service error](https://forum.yunohost.org/t/nextcloud-failing-upgrade-31-0-8-ynh2-to-31-0-9-ynh1/40031) on Nextcloud is not related to the changes I made...
https://github.com/YunoHost-Apps/nextcloud_ynh/pull/827/commits/84a0e2af96034a14c734f80ebd847066aea3d064#diff-a0aef3d805611cf48790455d49d677a5f2b6de3d292333afa113333a4d9de0ee
[13:11:21]
<tituspijean[m]> Maybe you can create a branch undoing that commit and ask them to try it?
[13:11:29]
<florent[m]> Here again with my issue with borg.
I found something interesting in `settings.yml`:
```yml
logs_retention: None
```
this is probably a serialization problem (should be `null` probably)
[13:12:40]
<orhtej2> > <@ericg:matrix.org> I wonder if this [nextcloud-notify-push-watcher.service error](https://forum.yunohost.org/t/nextcloud-failing-upgrade-31-0-8-ynh2-to-31-0-9-ynh1/40031) on Nextcloud is not related to the changes I made...
> https://github.com/YunoHost-Apps/nextcloud_ynh/pull/827/commits/84a0e2af96034a14c734f80ebd847066aea3d064#diff-a0aef3d805611cf48790455d49d677a5f2b6de3d292333afa113333a4d9de0ee
Very likely as nc user lacks the privilage to chmod nor systemctl
[13:12:52]
<orhtej2> what does this service do anyway?
[13:13:49]
<eric_G> It's designed to fail the upgrades 😅
[13:14:31]
<orhtej2> > <@ericg:matrix.org> It's designed to fail the upgrades 😅
Well then it's working! /s
[13:16:32]
<Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar pushed to testing: Update watcher.service ([21fa3fa5](https://github.com/YunoHost-Apps/nextcloud_ynh/commit/21fa3fa53d4a429ccb89d13b42bb4614c91abcc8))
[13:19:52]
<eric_G> tituspijean: is this ok to merge? https://ci-apps-dev.yunohost.org/ci/job/12833
[13:27:26]
<tituspijean[m]> Absolutely not xD
[13:27:57]
<tituspijean[m]> look at yalh did with the NGINX conf :)
[13:35:26]
<eric_G> brutal
[13:50:39]
<Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar pushed to testing: Update watcher.service ([b07b2ab6](https://github.com/YunoHost-Apps/nextcloud_ynh/commit/b07b2ab68f57ccb24d3202bdfe261ac8f8d0129b))
[13:51:34]
<Yunohost Git/Infra notifications> [nextcloud_ynh] ericgaspar pushed to testing: revert ([3d05ee04](https://github.com/YunoHost-Apps/nextcloud_ynh/commit/3d05ee04871da33fde5f458e0b6785e6d7520920))
[14:31:31]
<tituspijean[m]> it was for debugging purposes, so it's OK, but yeah it's the equivalent of `if fail or success return success`
[15:06:27]
<Yunohost Git/Infra notifications> [apps] yunohost-bot opened [pull request #3128](https://github.com/YunoHost/apps/pull/3128): Update app levels according to CI results
[15:44:54]
<wgrav> I'm trying to get a github action to run on esphome-ynh to automatically sync with upstream but it doesn't have the permission to open a pull request 😦
[17:24:01]
<Yunohost Git/Infra notifications> App wireguard rises from level 0 to 7 in job [#21261](https://ci-apps.yunohost.org/ci/job/21261) !
[17:27:29]
<Émy – OniriCorpe> you are trying to what? can you explain in details?
[17:55:12]
<Aleks (he/him/il/lui)> (Also there's already an autoupdater mechanism?)
[18:57:18]
<Yunohost Git/Infra notifications> [borg_ynh] fflorent pushed to test-config-empty-value: POC for issue with None values with config panel Branche can be removed as soon as the fix is merged ([adabd70c](https://github.com/YunoHost-Apps/borg_ynh/commit/adabd70c4877fdb98dcbfd8911192ff39a68625b))
[19:06:31]
<florent[m]> I propose a (simple) fix here:
https://github.com/YunoHost/yunohost/pull/2177
[19:13:16]
<Yunohost Git/Infra notifications> App redirect goes down from level 8 to 1 in job [#22154](https://ci-apps.yunohost.org/ci/job/22154)
[19:16:13]
<Yunohost Git/Infra notifications> App redmine failed all tests in job [#22155](https://ci-apps.yunohost.org/ci/job/22155) !
[19:17:49]
<Aleks (he/him/il/lui)> hmmm isn't there a null value ?
[19:18:16]
<Aleks (he/him/il/lui)> ah or `''` will mean it corresponds to `key: ` (with no value not even `''` ?)
[19:18:44]
<florent[m]> In yaml, there is `null`, but I think it can't be read
[19:19:22]
<Aleks (he/him/il/lui)> ```
>>> yaml.safe_load("foo:\nbar:")
{'foo': None, 'bar': None}
```
👍️
[19:19:29]
<tituspijean[m]> > <@yunohostinfra:matrix.org> App wireguard rises from level 0 to 7 in job [#21261](https://ci-apps.yunohost.org/ci/job/21261) !
Was something changed with the linter? Or did it get frightened by eric's proposal? 😅
[19:19:59]
<Aleks (he/him/il/lui)> last commit last year
[19:20:05]
<Aleks (he/him/il/lui)> wtf
[19:20:12]
<florent[m]> https://github.com/YunoHost/yunohost/blob/8708946f22df527da75fe1463d522a8e17a7e5a7/src/utils/form.py#L629-L632
[19:20:24]
<Aleks (he/him/il/lui)> tituspijean: naively that could be related to the security tweak in package_check but that's weird
[19:20:25]
<florent[m]> In the above piece of code, `''` is considered as `None`
[19:20:46]
<Aleks (he/him/il/lui)> hm moké
[19:22:13]
<tituspijean[m]> > <@Alekswag:matrix.org> last commit last year
Yeah there are two PRs on the app trying to debug it (real installs are fined, but there CI test was failing due to an obscure error with connection to NGINX)
[19:22:15]
<florent[m]> Still thinking, maybe `{"foo": None}` would be serialized as `foo: ` and it would work?
[19:22:24]
<tituspijean[m]> > <@Alekswag:matrix.org> last commit last year
Yeah there are two PRs on the app trying to debug it (real installs are fine, but there CI test was failing due to an obscure error with connection to NGINX)
[19:22:38]
<tituspijean[m]> > <@Alekswag:matrix.org> last commit last year
Yeah there are two PRs on the app trying to debug it (real installs are fine, but the CI test was failing due to an obscure error with connection to NGINX)
[19:23:55]
<Aleks (he/him/il/lui)> hmyeah ?
[19:23:55]
<Aleks (he/him/il/lui)> tituspijean: was thinking about https://github.com/YunoHost/package_check/pull/200
[19:25:53]
<florent[m]> Tried this:
```py
env = {key: str(value) if value is not None else None for key, value in form.dict().items()}
```
That didn't go well 😅 :
```
Traceback (most recent call last):
File "/usr/bin/yunohost", line 108, in <module>
main()
File "/usr/bin/yunohost", line 97, in main
yunohost.cli(
File "/usr/lib/python3/dist-packages/yunohost/__init__.py", line 59, in cli
ret = moulinette.cli(
^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/moulinette/__init__.py", line 143, in cli
).run(args, output_as=output_as, timeout=timeout)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/moulinette/interfaces/cli.py", line 530, in run
ret = self.actionsmap.process(args, timeout=timeout)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/moulinette/actionsmap.py", line 580, in process
return func(**arguments)
^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/yunohost/log.py", line 532, in func_wrapper
result = func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/yunohost/app.py", line 2265, in app_config_set
return config_.set(key, value, args, args_file, operation_logger=operation_logger)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/yunohost/utils/configpanel.py", line 607, in set
self._apply(self.form, self.config, previous_settings)
File "/usr/lib/python3/dist-packages/yunohost/app.py", line 2290, in _apply
return_content = self._call_config_script("apply", env=env)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/yunohost/app.py", line 2341, in _call_config_script
ret, values = hook_exec(config_script, args=[action], env=app_script_env)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/yunohost/hook.py", line 416, in hook_exec
returncode, returndata = _hook_exec_bash(
^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/yunohost/hook.py", line 486, in _hook_exec_bash
returncode = call_async_output(command, loggers, shell=False, cwd=chdir, env=_env)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/yunohost/utils/process.py", line 90, in call_async_output
p = subprocess.Popen(args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/subprocess.py", line 1024, in __init__
self._execute_child(args, executable, preexec_fn, close_fds,
File "/usr/lib/python3.11/subprocess.py", line 1821, in _execute_child
env_list.append(k + b'=' + os.fsencode(v))
^^^^^^^^^^^^^^
File "<frozen os>", line 812, in fsencode
TypeError: expected str, bytes or os.PathLike object, not NoneType
```
[19:27:17]
<florent[m]> When debugging, I get this:
```
(Pdb) env
{'logs_retention': None}
```
So the object is what I expected to be, but sounds like something does not like that 🤷
[19:27:33]
<Aleks (he/him/il/lui)> woot di fak
[19:28:55]
<Aleks (he/him/il/lui)> ah it's a setting and it wants to include it in the env variable
[19:28:56]
<Aleks (he/him/il/lui)> meh
[19:28:56]
<Aleks (he/him/il/lui)> yeah it should be a string somehow
[19:28:57]
<Aleks (he/him/il/lui)> i guess the only value that makes sense is `''` ?
[19:28:57]
<Aleks (he/him/il/lui)> though if i rmmber correctly there's also a `_none` thing somewhere in the bash code ...
[19:29:30]
<Aleks (he/him/il/lui)> >i guess the only value that makes sense is '' ?
i mean when serializing into bash env variables
[19:29:34]
<florent[m]> (I also saw YNH_NULL, don't know what it is)
[19:29:41]
<Aleks (he/him/il/lui)> ah yeah maybe ..
[19:30:38]
<florent[m]> I would say I think it is fine with `''`, but I am fully biased 🤣
[19:30:57]
<Aleks (he/him/il/lui)> i'm trying to think how it matters exactly since settings may be used when regenerating configuration files ... which ain't the case here
[19:31:23]
<Aleks (he/him/il/lui)> honestly to me the initial issue is that borg_ynh uses yunohost settings as a configuration file rather than having a proper configuration file on its own
[19:32:03]
<florent[m]> Ah yeah, but that's different
[19:32:04]
<Aleks (he/him/il/lui)> (which for example in turns implies that it needs sudo rights to access these settings somehow)
[19:32:24]
<florent[m]> Here, I make a systemd timer + service (cronjob-ish stuff) to suppress old logs
[19:32:34]
<Aleks (he/him/il/lui)> oh ok
[19:33:47]
<Aleks (he/him/il/lui)> hmm
[19:34:00]
<florent[m]> That being said, I don't know if that should not be in a unified rotated journal, simply, and stop polluting the `/var/log/borg/` folder with logs.
But anyway, I think my patch could benefit to other packages
[19:34:27]
<Aleks (he/him/il/lui)> idk that's still ambiguous to me (how that settings and other setting from borg) should be handled
[19:34:52]
<Aleks (he/him/il/lui)> i mean that's business logic for the app
[19:35:28]
<Aleks (he/him/il/lui)> and sometime we do store settings related to business logic (eg nextcloud parameter to enable/disable stuff etc) but mostly because we need to preserve them when regenerating the configuration file
[19:36:02]
<Aleks (he/him/il/lui)> but anyway i'm just saying borg setting management should be refactored but there's still some sort of existential question on how to serialize null/None values
[19:36:30]
<Yunohost Git/Infra notifications> App dont-code goes down from level 6 to 1 in job [#22185](https://ci-apps.yunohost.org/ci/job/22185)
[19:36:46]
<Aleks (he/him/il/lui)> and in the case of how to convert it when exporting those as bash env variables, the main question is "will it need to be deserialized"
[19:39:40]
<florent[m]> Hmm.
From my prospective, if I set this value:
```
yunohost app config set borg__2 main.advanced.logs_retention -v ""
```
And when the config script gets the `logs_retention` variable with `""` value, that should be stored that way in the settings.
And then, I guess bash scripts should retrieve this setting value as being `""`.
At least, it sounded a bit natural to me.
[19:40:34]
<florent[m]> But yes, I definitely agree that a great refactoration should be done at some point in this package, lots of complexity (logs, settings, etc)
[19:48:38]
<florent[m]> Thinking again on out conversation, I wonder if there is a misunderstanding. I used borg in my case, but I think I could reproduce the issue with other packages (where we would like an optional number)
[19:48:56]
<florent[m]> The diff is simply this one:
https://github.com/YunoHost-Apps/borg_ynh/compare/test-config-empty-value?expand=1
[19:49:10]
<florent[m]> Would it be clearer if I provide a POC with another package?
[19:49:37]
<Aleks (he/him/il/lui)> nah nah i get that the issue is more general than just borg ;P
[19:49:49]
<florent[m]> Ah right :)
[19:50:18]
<Aleks (he/him/il/lui)> i was just ranting that we wouldnt be asking those existential questions if borg was storing its conf in another file
[19:50:21]
<Aleks (he/him/il/lui)> maybe 🤔
[19:50:29]
<Aleks (he/him/il/lui)> actually maybe it wouldnt solve it
[19:51:06]
<Aleks (he/him/il/lui)> (because if that conf was templated and we'd want to expose it in the config panel we would still need to store the setting hmpf)
[19:51:20]
<Aleks (he/him/il/lui)> I declare
[19:51:25]
<Aleks (he/him/il/lui)> bankrupcyyyyyyyyyyyyyy
[19:51:36]
<Aleks (he/him/il/lui)> (that makes no sense but my brain wanted to scream)
[19:53:18]
<florent[m]> OK, that don't need to be reviewed absolutely that evening, you may consider that another day, you deserve to rest :P
[19:54:08]
<Aleks (he/him/il/lui)> axolotle may have some insight as he worked precisely on the topic of serializing/deserializing in the context of config panel, scripts etc
[19:54:29]
<Aleks (he/him/il/lui)> (essentially refactored the config panel system to include pydantic etc)
[19:55:35]
<florent[m]> FWIW, I plan to work on this issue:
https://github.com/YunoHost-Apps/borg\_ynh/issues/216
By setting an config file which will be sourced by the systemd service (thus would be available in the shell) and the scripts. I hope it will be a good step toward something simpler.
[21:21:09]
<Yunohost Git/Infra notifications> App n8n goes down from level 8 to 3 in job [#22232](https://ci-apps.yunohost.org/ci/job/22232)
[22:24:13]
<Yunohost Git/Infra notifications> Autoupdater just ran, here are the results:
- 58 pending update PRs
- 8 new apps PRs: forte, homarr, homeassistant, immich, jackett, paperless-ngx, snweb, streams
- 5 failed apps updates: litechat, onlyoffice, openemr, plakar, prestashop
See the full log here: https://paste.yunohost.org/raw/vovoxegena
Autoupdate dashboard: https://apps.yunohost.org/dash?filter=autoupdate
[22:24:40]
<wgrav> Trying to run a github action that updates the manifest.toml file every time upstream updates, and opens a pull request for me to manually review. It works, but it can't open the pull request due to the gh runner account requiring pull request permissions
[22:25:55]
<wgrav> could you please point me to that? I can't seem to find it in the packaging docs
[22:30:02]
<miro5001> > <@wgrav:matrix.org> could you please point me to that? I can't seem to find it in the packaging docs
Here https://doc.yunohost.org/fr/packaging/manifest/resources#sources
[22:34:28]
<wgrav> That's what I'm trying to update, I'm writing the action to put in the checksum and url into the sources section because it's quite tedious to do manually when I don't have much time to do anything myself
[22:35:16]
<miro5001> > <@wgrav:matrix.org> That's what I'm trying to update, I'm writing the action to put in the checksum and url into the sources section because it's quite tedious to do manually when I don't have much time to do anything myself
What app is it?
[22:35:47]
<wgrav> ESPHome
[22:39:45]
<miro5001> > <@wgrav:matrix.org> ESPHome
It's ok
https://github.com/YunoHost-Apps/esphome_ynh/blob/0674812abbfed2fcaf18693d30bee5ba831566c1/manifest.toml#L57
[22:39:54]
<miro5001> You don't have to do anything else
[22:40:26]
<miro5001> When a new version is released, yunohost bot will PR
[22:40:44]
<wgrav> It hasn't, and I've been running the package for months
[22:42:00]
<wgrav> Lemme check, upstream might not be doing tags
[22:43:21]
<wgrav> Gonna switch to latest github release and see what happens
[22:47:48]
<Émy – OniriCorpe> why not use our auto update bot? https://doc.yunohost.org/packaging/manifest/resources#regarding-autoupdate
[22:48:43]
<Émy – OniriCorpe> okay i just read the following discussion lol
[22:49:22]
<wgrav> Joke's on me for trying to write a whole github action because I had a misconfiguration in manifest.toml
[22:49:59]
<wgrav> Will it automatically trigger tests, or does that have to be done manually?
[22:50:43]
<orhtej2> > <@wgrav:matrix.org> Will it automatically trigger tests, or does that have to be done manually?
It will
[22:50:46]
<Émy – OniriCorpe> yes, it's automatic
[22:50:57]
<wgrav> lovely, thanks
[22:51:33]
<orhtej2> one of Today prs: https://github.com/YunoHost-Apps/jackett_ynh/pull/619
[22:51:46]
<orhtej2> (for reference)
[22:54:02]
<Émy – OniriCorpe> they are using tags, `latest_github_tag` should have been worked
[22:54:37]
<Émy – OniriCorpe> they are using tags, `latest_github_tag` should have worked
[22:55:04]
<Émy – OniriCorpe> i don't know where the issue was, but your config was fine