[00:26:19]
<orhtej2> > <@yunohostinfra:matrix.org> Autoupdater just ran, here are the results:
>
> - 39 pending update PRs
> - 8 new apps PRs: calcom, cloudlog, dagu, discourse, jackett, jenkins, n8n, piefed
> - 4 failed apps updates: benevalibre, fluffychat, lasuite-meet, vert
>
> See the full log here: https://paste.yunohost.org/raw/cijisumiji
> Autoupdate dashboard: https://apps.yunohost.org/dash?filter=autoupdate
Can we please merge https://github.com/YunoHost/apps_tools/pull/59 to get rid of daily discourse update?
[01:04:23]
<Yunohost Git/Infra notifications> App benevalibre stays broken (level 0) in job [#26005](https://ci-apps.yunohost.org/ci/job/26005)
[01:24:51]
<Yunohost Git/Infra notifications> App warpgate stays broken (level 0) in job [#26011](https://ci-apps.yunohost.org/ci/job/26011)
[01:38:09]
<Yunohost Git/Infra notifications> App streamlit rises from level 0 to 6 in job [#26012](https://ci-apps.yunohost.org/ci/job/26012) !
[02:00:20]
<Aleks (he/him/il/lui)> ooooh a hash, noice :O
[02:01:07]
<Yunohost Git/Infra notifications> [apps_tools] alexAubin merged [pull request #59](https://github.com/YunoHost/apps_tools/pull/59): Deduplicate autoupdate results
[02:01:53]
<Yunohost Git/Infra notifications> [apps_tools] alexAubin merged [pull request #52](https://github.com/YunoHost/apps_tools/pull/52): Auto format with Ruff and shfmt
[02:01:56]
<Yunohost Git/Infra notifications> [apps_tools] alexAubin deleted branch actions/auto-format
[09:47:47]
<Yunohost Git/Infra notifications> [apps] yunohost-bot opened [pull request #3260](https://github.com/YunoHost/apps/pull/3260): Add Babgond to wishlist
[13:22:49]
<m606> Could I be granted write permission on conduit_ynh repo ? I've come with a PR to patch a critical vulnerability
[13:27:07]
<Aleks (he/him/il/lui)> hmm i don't remember your github username 😬
[13:27:21]
<m606> oleole39
[13:27:42]
<Aleks (he/him/il/lui)> done 👍️
[13:40:24]
<miro5001> https://github.com/YunoHost-Apps/umap_ynh/tree/fix
[13:55:23]
<miro5001> davidbgk: package is ready here
If you could have a look at conf/umap.conf for any additions. These settings will be later changed from config panel
[14:16:01]
<ybon> Given we are using the SSO, I don't think we want to change this setting (that would allow users to change their username within umap) https://github.com/YunoHost-Apps/umap_ynh/blob/fix/conf/umap.conf#L50
[14:16:46]
<ybon> I don't think we want to hard code here the default settings, like here https://github.com/YunoHost-Apps/umap_ynh/blob/fix/conf/umap.conf#L65 Otherwise if we change the default value upstream, it will break
[14:17:06]
<ybon> So only people that know what they do should touch this kind of settings
[14:18:04]
<ybon> Does that mean that those are no more expose on the config panel ? https://github.com/YunoHost-Apps/umap_ynh/blob/fix/conf/umap.conf#L78-L81
[14:18:54]
<ybon> ah, sorry, now I see there is a PR, I could have answered there, I just clicked on your link blindly…
[14:19:21]
<ybon> Actually, there are two PRs, that's cool to see that! But I must say I'm a bit lost :p https://github.com/YunoHost-Apps/umap_ynh/pulls
[14:19:58]
<miro5001> I've just followed the instructions in the admin docs. We'll remove them
[14:22:10]
<miro5001> These are commented, to have them changed by the config panel, they must be initiated like https://github.com/YunoHost-Apps/umap_ynh/blob/fix/conf/umap.conf#L50
[14:26:01]
<miro5001> I am working on the fix branch that will be pushed to testing then to master. I prefer making changes on a separate branch then push to testing and as you may have noticed, all yunohost packages have a testing branch.
[14:26:39]
<ybon> Ok! And are you coordinating with the other PR ?
[14:28:41]
<ybon> Same here https://github.com/YunoHost-Apps/umap_ynh/blob/fix/conf/umap.conf#L84
[14:30:15]
<miro5001> No, this will be force pushed to testing > master. Autoupdate will auto PR to testing when new releases are available
[14:32:12]
<miro5001> Ah, not sure to understand why
[14:32:13]
<ybon> Not sure to follow you. What's about the other PR (https://github.com/YunoHost-Apps/umap_ynh/pull/1/files) ? Should it be closed or merged ?
[14:33:00]
<ybon> Also, I have to say it's hard for me to follow a PR without a descriptive name and without description and with 71 commits like "update xxxx.yml"
[14:34:12]
<miro5001> Yeah, it can be closed
[14:34:56]
<miro5001> Can you explain this?
[14:35:24]
<ybon> no need as we use the SSO ?
[14:40:44]
<miro5001> And for users that don't have accounts on the server but have an account on the app?
[14:41:33]
<ybon> Ah, I've misunderstood the SSO then, I thought this was the way to create an account on a YNH server, whatever the app used
[14:42:45]
<miro5001> But we don't have ldap config yet
[14:43:37]
<miro5001> And I didn't add api keys in the config file for github, etc..
[14:46:18]
<ybon> I may be missing a point: can't we "just" use the ynh SSO ? From my naive point of view, I thought that this was the main interest in deploying with ynh, do not have to create an account for each app
[14:53:47]
<miro5001> I may have missed ldap configuration in umap
[14:54:59]
<ybon> but the SSO currently work, isn't it ?
[14:55:15]
<florent[m]> You mean in the current app or in Yunohost?
[14:55:17]
<ybon> in the current installer for uMap
[14:57:07]
<florent[m]> The SSO in Yunohost works by injecting a header (through [ssowat](https://github.com/YunoHost/ssowat)). The app has to read the value from the header and authenticate accordingly.
[14:57:30]
<ybon> yeah, it is done in the current main branch
[14:57:36]
<florent[m]> I am taking a look at how the uMap package works.
[14:58:32]
<ybon> the current version of the intaller uses django-yunohost-integration, which does all this magic (plus a bit of config)
[15:06:46]
<florent[m]> Hmm, yeah, it would be then handled by this module:
https://github.com/YunoHost-Apps/django_yunohost_integration/blob/8e6063013a995d9075882470d01ea9788bd264f4/django_yunohost_integration/sso_auth/auth_middleware.py
Is `django-yunohost-integration` something you would like to keep or get rid of?
[15:07:40]
<ybon> To me it seems it does tha job, why would remove it ?
[15:14:31]
<florent[m]> Fair question. There are pros and cons from my point of view.
The main con I would say is that it adds a fair amount of complexity, and I don't know how much people control the code of this component ([only one person contributes to it](https://github.com/YunoHost-Apps/django_yunohost_integration/graphs/contributors)). Also it means that we have to rely on the work of its author and when this dependency is unmaintained, it would make harder to replace it.
[15:15:09]
<florent[m]> The most comfortable would be to have something similar in the core.
[15:16:38]
<florent[m]> But there are pros, as you mentions, it works, it provides features.
I don't have a strong opinion of what should be done, especially given I am not aware of everything on this package and this dependency.
[15:17:33]
<ybon> What's the plan B if we do not use this package (I mean today) ?
[15:18:45]
<florent[m]> You mean the dependency?
[15:19:01]
<ybon> yes
[15:21:31]
<miro5001> What do you mean today?
Now it works with classic login/password. I didn't know you were needing the sso part.
I didn't see ldap config in the docs, so I supposed it wasn't implemented yet.
[15:22:22]
<ybon> I don't understand why we would drop SSO support while it's working
[15:22:58]
<ybon> From my (poor) understanding, SSO is a key feature of YunoHost, am I wrong ?
[15:29:34]
<ybon> Can't we rely on this third party plugin until there is something more official in the core ?
[15:30:12]
<miro5001> I started from scratch following the admin docs of the app, that's the best way to get the app running. And I tried to make the package easier to understand and to maintain.
We can reintroduce it.
I didn't add yunohost dependencies cause I didn't understand why the django app was set https://github.com/umap-project/umap/blob/a383dc8627c33d9328db60fb4a3a0be75d99580e/pyproject.toml#L74
Using the fix branch, I have django 5.2.9 running on my home server.
[15:34:37]
<miro5001> Can we have a YUNOHOST_SERVER boolean in the config file?
[15:35:42]
<ybon> what for ?
[15:36:16]
<ybon> Django 5.2.x removed postgresql 13 support, which is the one in debian 12 iirc
[15:36:42]
<miro5001> I try to avoid using settings.py as template in the package, in case settings.py in upstream is modified
[15:37:09]
<ybon> umap.conf and settings.py is the same, just the name changes
[15:37:31]
<miro5001> If true add middleware etc...
[15:38:48]
<ybon> why not doing this in the package settings.py ?
[15:39:24]
<miro5001> Okey
[15:40:40]
<ybon> we may argue that the django-yunohost-integration is added in uMap itself, so we may want to add the related settings in uMap itself too
[15:41:32]
<miro5001> It's running using psql 16 on my server
[15:42:44]
<miro5001> Can you add it to the fix branch. I'm out and not sure when I will get home
[15:44:53]
<ybon> I'm a bit lost in this branch, I'd prefer let you manage it the way you prefer
[21:34:42]
<Yunohost Git/Infra notifications> ericgaspar created repository textarea_ynh https://github.com/YunoHost-Apps/textarea_ynh
[21:39:41]
<Yunohost Git/Infra notifications> ericgaspar edited repository textarea_ynh: Textaera package for YunoHost https://github.com/YunoHost-Apps/textarea_ynh
[21:40:25]
<Yunohost Git/Infra notifications> ericgaspar edited repository textarea_ynh: Textaera package for YunoHost https://github.com/YunoHost-Apps/textarea_ynh
[21:40:27]
<Yunohost Git/Infra notifications> ericgaspar edited repository textarea_ynh: Textaera package for YunoHost https://github.com/YunoHost-Apps/textarea_ynh
[21:42:54]
<eric_G> https://github.com/YunoHost-Apps/textarea_ynh -> A minimalist text editor that lives entirely in your browser and stores everything in the URL hash.
[21:57:53]
<Yunohost Git/Infra notifications> [apps] ericgaspar pushed to textarea: add textarea ([73ff366c](https://github.com/YunoHost/apps/commit/73ff366cfad4d9c843c26891f78562b96f1c9886))
[21:58:02]
<Yunohost Git/Infra notifications> [apps] ericgaspar opened [pull request #3261](https://github.com/YunoHost/apps/pull/3261): add textarea
[22:05:15]
<Yunohost Git/Infra notifications> [apps] ericgaspar pushed to main: add textarea (#3261) ([8949eba0](https://github.com/YunoHost/apps/commit/8949eba0cfbbf646f4eebc7d9fb0ae6cbec2034b))
[22:05:16]
<Yunohost Git/Infra notifications> [apps] ericgaspar merged [pull request #3261](https://github.com/YunoHost/apps/pull/3261): add textarea
[22:05:16]
<Yunohost Git/Infra notifications> [apps] ericgaspar deleted branch textarea
[22:28:08]
<Yunohost Git/Infra notifications> [wallabag2_ynh] ericgaspar pushed to ci-auto-update-2.6.10: Update 00-ldap-auth.patch (#242) ([910190d3](https://github.com/YunoHost-Apps/wallabag2_ynh/commit/910190d3a0d0bd042d36aff3da047f410ba1f6f7))
[22:28:09]
<Yunohost Git/Infra notifications> [wallabag2_ynh] ericgaspar merged [pull request #242](https://github.com/YunoHost-Apps/wallabag2_ynh/pull/242): Update 00-ldap-auth.patch
[22:28:10]
<Yunohost Git/Infra notifications> [wallabag2_ynh] ericgaspar deleted branch Fix
[22:29:45]
<Yunohost Git/Infra notifications> [wallabag2_ynh] ericgaspar closed [pull request #241](https://github.com/YunoHost-Apps/wallabag2_ynh/pull/241): Upgrade to v2.6.14
[23:08:52]
<Yunohost Git/Infra notifications> [freshrss_ynh] yunohost-bot opened [pull request #218](https://github.com/YunoHost-Apps/freshrss_ynh/pull/218): Upgrade to v1.28.0
[23:23:22]
<Yunohost Git/Infra notifications> [wallabag2_ynh] yunohost-bot opened [pull request #243](https://github.com/YunoHost-Apps/wallabag2_ynh/pull/243): Upgrade to v2.6.14
[23:24:45]
<Yunohost Git/Infra notifications> Autoupdater just ran, here are the results:
- 35 pending update PRs
- 12 new apps PRs: audiobookshelf, calcom, discourse, dolibarr, filerise, forgejo_runner, freshrss, jackett, localai, nodebb, sparkyfitness, wallabag2
- 6 failed apps updates: benevalibre, coin, fluffychat, lasuite-meet, textarea, vert
See the full log here: https://paste.yunohost.org/raw/ozijiniham
Autoupdate dashboard: https://apps.yunohost.org/dash?filter=autoupdate