[01:03:01]
<Yunohost Git/Infra notifications> Autoupdater just ran, here are the results:
- 70 pending update PRs
- 2 new apps PRs: bookwyrm, code-server
- 7 failed apps updates: adminer, arn_messager, gogs, jenkins, overleaf, passed, planka
See the full log here: https://paste.yunohost.org/raw/fawimivela
Autoupdate dashboard: https://apps.yunohost.org/dash?filter=autoupdate
[08:58:39]
<Yunohost Git/Infra notifications> [roundcube_ynh] DeMiro5001 merged [pull request #260](https://github.com/YunoHost-Apps/roundcube_ynh/pull/260): Upgrade to v1.6.14
[08:58:41]
<Yunohost Git/Infra notifications> [roundcube_ynh] DeMiro5001 deleted branch ci-auto-update-1.6.14
[08:59:09]
<Yunohost Git/Infra notifications> [roundcube_ynh] DeMiro5001 opened [pull request #261](https://github.com/YunoHost-Apps/roundcube_ynh/pull/261): Testing
[09:00:34]
<Yunohost Git/Infra notifications> [stirling-pdf_ynh] DeMiro5001 merged [pull request #143](https://github.com/YunoHost-Apps/stirling-pdf_ynh/pull/143): Upgrade to v2.7.3
[09:00:36]
<Yunohost Git/Infra notifications> [stirling-pdf_ynh] DeMiro5001 deleted branch ci-auto-update-2.7.3
[09:00:53]
<Yunohost Git/Infra notifications> [stirling-pdf_ynh] DeMiro5001 opened [pull request #144](https://github.com/YunoHost-Apps/stirling-pdf_ynh/pull/144): Testing
[09:01:06]
<Yunohost Git/Infra notifications> [stirling-pdf_ynh] DeMiro5001 merged [pull request #144](https://github.com/YunoHost-Apps/stirling-pdf_ynh/pull/144): Testing
[09:01:20]
<Yunohost Git/Infra notifications> [stirling-pdf_ynh] DeMiro5001 closed [pull request #142](https://github.com/YunoHost-Apps/stirling-pdf_ynh/pull/142): Upgrade to v2.7.2
[09:01:23]
<Yunohost Git/Infra notifications> [stirling-pdf_ynh] DeMiro5001 deleted branch ci-auto-update-2.7.2
[09:57:58]
<Yunohost Git/Infra notifications> [roundcube_ynh] ericgaspar pushed to testing: Testing (#251) * Update carddav version to 5.1.2 (#248) * [autopatch] Automatic patch to simplify proxy_pass/fastcg... ([9a0f9ac7](https://github.com/YunoHost-Apps/roundcube_ynh/commit/9a0f9ac71312dada8d49e85ddea743fc1beaad25))
[09:57:59]
<Yunohost Git/Infra notifications> [roundcube_ynh] ericgaspar pushed to testing: Merge branch master into testing ([775e5491](https://github.com/YunoHost-Apps/roundcube_ynh/commit/775e54918d549f40c7dfffe159196a2500d721a6))
[12:19:50]
<m606> for an app that requires sending notifications emails:
- is `[system_user] allow_email = "true"`(in manifest) required to send emails from `no-reply@__DOMAIN__` ?
- for the same purpose, should SMTP be configured to port 25 or can it be on 587 (starttls) or 465 (ssl) ?
[12:24:38]
<tituspijean[m]> 1. no, the default address would be `__APP__@__DOMAIN__`. To customize it, you need the `mail_user` setting. Check https://doc.yunohost.org/fr/dev/packaging/resources#system-user for more information
[12:25:34]
<tituspijean[m]> 2. with flarum I used port 587: https://github.com/YunoHost-Apps/flarum_ynh/blob/master/conf/mail.sql.template
[12:26:44]
<m606> thanks for the feedback
[12:28:21]
<m606> re 1) i wonder because the only app doing so is https://github.com/YunoHost-Apps/ghost_ynh/blob/798412c840bcc5f69a4092fc5555abe69765ab56/manifest.toml#L61 and they commented it out, whereas many other app use no-reply, with only defining `allow_email = "true"` and sometimes not even https://github.com/YunoHost-Apps/bookstack_ynh/blob/101196c5873877b32160cbd84643bbcbe9bc9588/conf/.env#L56
[12:31:30]
<Yunohost Git/Infra notifications> [borg_ynh] fflorent pushed to testing: Auto-update READMEs ([2044a867](https://github.com/YunoHost-Apps/borg_ynh/commit/2044a8672a39a29fb99e79a9fc23ccf45de1a678))
[12:31:30]
<Yunohost Git/Infra notifications> [borg_ynh] fflorent merged [pull request #253](https://github.com/YunoHost-Apps/borg_ynh/pull/253): Upgrade to v1.4.4
[12:31:30]
<Yunohost Git/Infra notifications> [borg_ynh] fflorent deleted branch ci-auto-update-1.4.4
[12:31:30]
<tituspijean[m]> re: ghost: too bad there's no explanation as to why it was removed.
re: bookstack: YunoHost would block the emails from noreply then :/
[12:31:30]
<Yunohost Git/Infra notifications> [borg_ynh] fflorent opened [pull request #254](https://github.com/YunoHost-Apps/borg_ynh/pull/254): Testing
[12:31:30]
<Yunohost Git/Infra notifications> [borg_ynh] fflorent pushed to testing: Upgrade sources - main v1.4.4: https://github.com/borgbackup/borg/releases/tag/1.4.4 ([8d742fd9](https://github.com/YunoHost-Apps/borg_ynh/commit/8d742fd9cbb16040f35d547b5890cb3c878b3b42))
[12:40:54]
<otm33> I smtp_host set to domain ?
[12:48:30]
<m606> ```
smtpServer:
host: localhost
port: 587
username: __APP__@__DOMAIN__
password: __MAIL_PWD__
```
I've just tried with port 25 but same issue
[12:50:53]
<otm33> what about trying
```
smtpServer:
host: __DOMAIN__ #main domain
port: 587
username: __APP__
password: __MAIL_PWD__
```
[12:51:52]
<otm33> what about trying
```
smtpServer:
host: __MAIN_DOMAIN__ #main domain
port: 587
username: __APP__
password: __MAIL_PWD__
```
[12:52:07]
<m606> `__DOMAIN__` here is comentario.mydomain.tld, do you mean I should enter DOMAIN as mydomain.tld ?
[12:52:34]
<m606> let me try anyway
[12:54:30]
<m606> with `host: comentario.mydomain.tld` it outputs at user registration `Error response: failed to send email to "test2@yopmail.com" 535 5.7.8 Error: authentication failed: (reason unavailable)`
[12:55:30]
<m606> and same error with `host: mydomain.tld`
[13:01:02]
<m606> ah
[13:01:03]
<m606> no
[13:01:05]
<m606> sotrry
[13:01:07]
<otm33> Did you try with username : `__APP__ ?
[13:01:31]
<otm33> Did you try with username : \`__APP__` ?
[13:01:40]
<m606> I did yesterday actually but it failed, but i try again with other domains
[13:01:57]
<otm33> Did you try with username : ```__APP__`` ?
[13:02:25]
<otm33> Did you try with username : `__APP__` ?
[13:04:50]
<miro5001> Check this config
https://github.com/YunoHost-Apps/indico_ynh/blob/71ba2782d634672e28b87962752f281a458e0785/conf/indico.conf#L15
[13:05:26]
<miro5001> With this manifest
https://github.com/YunoHost-Apps/indico_ynh/blob/71ba2782d634672e28b87962752f281a458e0785/manifest.toml#L58
[13:06:18]
<miro5001> And this for backward compatibility
https://github.com/YunoHost-Apps/indico_ynh/blob/71ba2782d634672e28b87962752f281a458e0785/scripts/upgrade#L10
[13:08:14]
<otm33> what about trying
```
smtpServer:
host: __DOMAIN__ #main domain
port: 587
username: __APP__
password: __MAIL_PWD__
```
[13:16:14]
<m606> so, when I use `username: __APP__` the service fails with this error: `Failed to load config: invalid 'From' email address "comentario": mail: missing '@' or angle-addr`(where `__APP__`= comentario).
Now if I add in smtp config the optional property `emailFrom: __APP__@__DOMAIN__` (which default to `$username` if not entered), then everything works.
[13:19:42]
<m606> and if i change `emailFrom` to `no-reply@__DOMAIN__`, then I get `Error response: failed to send email to "test2@yopmail.com": gomail: could not send email 1: 553 5.7.1 <no-reply@comentario.mydomain.tld>: Sender address rejected: not owned by user comentario`
[13:21:58]
<miro5001> Email from must be an email not a a username.
If you want to use noreply@domain then you have to define mail_user
[13:22:28]
<miro5001> And use mail_user@domain
[13:22:34]
<m606> and here why do you choose to set a user instead of using https://doc.yunohost.org/en/dev/packaging/resources#:~:text=mail_user
[13:22:35]
<m606> ?
[13:23:20]
<m606> I mean in indico case you want to let the admin choose whether contact or no-reply
[13:23:32]
<miro5001> Yes, if you want something different from app@domain
[13:24:11]
<m606> i think no-reply would be good but then would that be enough: https://github.com/YunoHost-Apps/ghost_ynh/blob/798412c840bcc5f69a4092fc5555abe69765ab56/manifest.toml#L61 ?
[13:24:14]
<miro5001> In install, yes
[13:25:09]
<m606> it is how I understand the doc, but as here it is commented out and that I cannot find other examples...
[13:25:11]
<miro5001> Because I already used app@domain in previous versions, which is a bit confusing for users
[13:26:07]
<miro5001> Tried that but didn't work
[13:26:39]
<m606> oh ok, let me try again and fix the doc. and I'll go for your way then.
[13:27:37]
<m606> @miro5001:matrix.org @otm33:matrix.org thanks to both of you!
[13:29:19]
<miro5001> The important thing is that yunohost postfix will reject an email different from the owned email user.
So app@domain will be default unless you define mail_user then use mail_user@domain
mail_user can be defined in manifest or in the scripts
[13:48:07]
<m606> I am a bit confused with this though, as I found quite many apps using `no-reply@__DOMAIN__` in a setting which configures the "From" email header, e.g.
https://github.com/YunoHost-Apps/invoiceshelf_ynh/blob/55133fab72efc3348162c2cd488fbd7507364f8f/conf/.env#L46 without creating a `no-reply` user in the manifest.
Or even using "no-reply" as smtp login without creating such user: https://github.com/YunoHost-Apps/plume_ynh/blob/74cbe401f131222d4c897fe86b9542126ac6486e/conf/.env#L28
[13:50:00]
<m606> and in the first case, could the use of a different FROM header than the actual SMTP account impact deliverability? like receiving server finding a mismatch and classifying email as spam or blocking it ?
[13:53:31]
<miro5001> Yes.
You can send from localhost with non authenticated email. But it will likely be rejected by some email servers
[14:09:28]
<m606> Did you try that via the manifest as here: https://github.com/YunoHost-Apps/ghost_ynh/blob/798412c840bcc5f69a4092fc5555abe69765ab56/manifest.toml#L61 ? I've just tried as well but this basically does nothing.
Now looking at https://github.com/YunoHost/yunohost/blob/c936c0b6017199bc812be7c5e899f98c6b8cb48e/src/app.py#L2625
I understand that probably what the doc actually suggests is `ynh_app_setting_set --key="mail_user" --value="no-reply"` in the scripts which will pass to postfix.
However does that fall in the case where it will likely be rejected by some emails servers (gmail and all)?
[14:10:19]
<miro5001> Yes, this didn't work for me
[14:11:30]
<m606> do you refer to my first paragraph AND second paragaph?
[14:39:36]
<miro5001> The manifest one
[14:45:14]
<m606> i've just finished testing the other solution, i.e. setting
- install script:
```
mail_user="no-reply"
ynh_app_setting_set --key="mail_user" --value="$mail_user"
```
- app smtp config
```
smtpServer:
host: __DOMAIN__
port: 587
username: __APP__
password: __MAIL_PWD__
emailFrom: __MAIL_USER__@__DOMAIN__
```
But I get that same error as before `Error response: failed to send email to "test2@yopmail.com": gomail: could not send email 1: 553 5.7.1 <no-reply@comentario.mydomain.tld>: Sender address rejected: not owned by user comentario`.
So that `mail_user` setting trick doesn't seem to help: https://github.com/YunoHost/yunohost/blob/c936c0b6017199bc812be7c5e899f98c6b8cb48e/src/app.py#L2625
Or at least `emailFrom` in app config precedes
[15:13:22]
<m606> i'll go for indico-style config.
Edit: sorry I misunderstood, declaring $mail_user var is bacially what indico package does. So not working for me here.
[15:14:54]
<m606> i'll go for indico-style config.
Edit: sorry I misunderstood, declaring $mail_user var is basically what indico package does. So not working for me here.
[15:33:48]
<Thomas> I've not followed everything: does it work with __APP__@__DOMAIN__ in the first place?
[15:34:25]
<Thomas> And did you try with the main_domain like https://github.com/YunoHost-Apps/overleaf_ynh/blob/c7c2cd9b7ec7bda1d64b5e3a48757b88af71333b/conf/variables.env#L63? (You have to set the setting first)
[15:35:21]
<miro5001> For me it works but it's not nice to have app@domain as noreply sender
[15:35:44]
<miro5001> It kinda confused some users
[16:00:39]
<Yunohost Git/Infra notifications> [apps] yunohost-bot opened [pull request #3395](https://github.com/YunoHost/apps/pull/3395): Update app levels according to CI results
[16:49:03]
<m606> in my case it works only with `emailFrom: __APP__@__DOMAIN__`.
But as @miro5001:matrix.org says, I would have preferred to set a `no-reply@__DOMAIN__` for notifications (currently the FROM email is `comentario@comentario.mydomain.tld` which doesn't look pretty).
However:
- I can't make it work so far with this app, as opposed to case for instance of miro5001 with indico_ynh where it works.
- I am worried about the fact that it impacts email deliverability (FROM header different than actual email account).
[17:31:40]
<m606> in my case it works only with `emailFrom: __APP__@__DOMAIN__`.
But as @miro5001:matrix.org says, I would have preferred to set a `no-reply@__DOMAIN__` for notifications (currently the FROM email is `comentario@comentario.mydomain.tld` which doesn't look pretty).
However:
- I can't make it work so far with this app, as opposed to case for instance of miro5001 with indico_ynh where it works (cf. https://matrix.to/#/#yunohost-apps:matrix.org/$V5j5G4ep_ivt5WeYWDoZf3q-paI5DaRyt__BJlFDvGo)
- I am worried about the fact that it impacts email deliverability (FROM header different than actual email account).
[17:31:51]
<otm33> m606: what does return `cat /etc/postfix/app_senders_login_maps` ? Can you see the no-reply address ?
[17:32:05]
<m606> got to go, thanks i'll check that in 1-2h and revert
@thovi98:matrix.org I can try also `__MAIN_DOMAIN__` which I haven't tried so far. But ideally I'd target `no-reply@__DOMAIN__` rather than `__MAIN_DOMAIN__`
[17:32:12]
<m606> `cat: /etc/postfix/app_senders_login_map: No such file or directory`
[17:32:17]
<m606> errr typo I had forgotten the "s". So the file exists but it is empty
[17:32:22]
<Thomas> > <@m606:matrix.org> got to go, thanks i'll check that in 1-2h and revert
>
> @thovi98:matrix.org I can try also `__MAIN_DOMAIN__` which I haven't tried so far. But ideally I'd target `no-reply@__DOMAIN__` rather than `__MAIN_DOMAIN__`
If it aleady works with __DOMAIN__ I'm not sure it will work with __MAIN_DOMAIN__ (TBF I don't understand why Overleaf works that way)
[18:02:27]
<otm33>
m606 Same here with docmost... The only fix I found is to run `yunohost tools regen-conf postfix --force`... Once done, emails sent from no-reply are properly delivered. But this is not a reliable solution
[18:11:28]
<m606> ok I will check this.
Why not reliable you think?
Also this still "fake" the FROM email header I guess? i.e. with a potential impact on delivery related to antispam/phising policies on receiver's side?
[18:16:45]
<Yunohost Git/Infra notifications> [roundcube_ynh] ericgaspar pushed to master: Testing (#261) * Update carddav version to 5.1.2 (#248) * [autopatch] Automatic patch to simplify proxy_pass/fastcg... ([b56244d1](https://github.com/YunoHost-Apps/roundcube_ynh/commit/b56244d18b6d27921c8d66fc882766a4c4e89e03))
[18:16:50]
<Yunohost Git/Infra notifications> [roundcube_ynh] ericgaspar merged [pull request #261](https://github.com/YunoHost-Apps/roundcube_ynh/pull/261): Testing
[18:25:05]
<Yunohost Git/Infra notifications> [mastodon_ynh] ericgaspar approved [pull request #556](https://github.com/YunoHost-Apps/mastodon_ynh/pull/556#pullrequestreview-3983323010) Testing
[18:25:14]
<Yunohost Git/Infra notifications> [mastodon_ynh] ericgaspar merged [pull request #556](https://github.com/YunoHost-Apps/mastodon_ynh/pull/556): Testing
[18:38:20]
<otm33> Well, regen-conf postfix --force is system-wide... But I think I got it : my guess is that the `app_senders_login_maps` is appended before reading the app's settings added via the install script. If `mail_user` is set in the install script, its value is not taken in account because the app_senders_login_maps is already filled with `$app` as mail_user (`$app` is the `mail_user` default value). Then, adding `mail_user` in the manifest as miro5001 did with indico is the right way. I will try this
[18:47:45]
<otm33> m606: Quick fix working :
https://github.com/otm33GH/docmost\_ynh/blob/36f6bf5f30a014659e4c6beb2ae66d1ef6c43c08/conf/.env#L38
https://github.com/otm33GH/docmost\_ynh/blob/36f6bf5f30a014659e4c6beb2ae66d1ef6c43c08/manifest.toml#L39
[19:18:21]
<Yunohost Git/Infra notifications> [apps] yunohost-bot opened [pull request #3396](https://github.com/YunoHost/apps/pull/3396): Add Keeper.sh to wishlist
[21:21:18]
<Yunohost Git/Infra notifications> [apps] yunohost-bot opened [pull request #3397](https://github.com/YunoHost/apps/pull/3397): Add Bagisto to wishlist
[21:21:20]
<Yunohost Git/Infra notifications> [apps] CodeShakingSheep [commented](https://github.com/YunoHost/apps/pull/3397#issuecomment-4101010840) on [issue #3397](https://github.com/YunoHost/apps/pull/3397) Add Bagisto to wishlist: Self-hosting docs: https://devdocs.bagisto.com/getting-started/installation.html Requires PHP, Composer, MySQL.
[21:42:24]
<Yunohost Git/Infra notifications> [apps] ericgaspar [commented](https://github.com/YunoHost/apps/pull/3397#issuecomment-4101091255) on [issue #3397](https://github.com/YunoHost/apps/pull/3397) Add Bagisto to wishlist: Et bien en avant
[21:58:31]
<miro5001> Good point.
Though I have added it to the scripts to handle upgrading from previous versions.
[22:24:33]
<otm33> Ok, so the upgrade script updates `app_senders_login_maps` ?
[22:26:59]
<miro5001> No, it handles the case where the manifest question has been introduced after the package was added to the catalog.
So people trying to upgrade will not have mail_user defined.
[22:44:08]
<otm33> That's what I don't understand : adding mail_user via ynh_app_setting_set is not sufficient, at least in install script, to append the login maps. Will give it a try in the upgrade script...
[22:53:23]
<otm33> No luck...😥
[23:22:46]
<otm33> Has the packaging of [cloudreve](https://github.com/cloudreve/Cloudreve) already been discussed/considered ? Any concern about it ? Looks promising.
[23:32:35]
<Yunohost Git/Infra notifications> Autoupdater just ran, here are the results:
- 44 pending update PRs
- 16 new apps PRs: dokos, filerise, ghost, gotosocial, homarr, homeassistant, invoiceninja5, jackett, liberaforms, phpsysinfo, piefed, tunarr, vikunja, wekan, yeswiki, zwave-js-ui
- 7 failed apps updates: adminer, arn_messager, gogs, jenkins, overleaf, passed, planka
See the full log here: https://paste.yunohost.org/raw/qovoqoneco
Autoupdate dashboard: https://apps.yunohost.org/dash?filter=autoupdate
[23:37:56]
<miro5001> It's already packaged by Eric here https://github.com/YunoHost-Apps/cloudreve_ynh
But not added to the catalog
[23:53:53]
<otm33> Same for docmost. And I packaged it from scratch... 😬
[23:56:56]
<miro5001> Next time, before starting a package, check the repos in https://github.com/YunoHost-Apps if it has been started but still not added to the catalog
[23:57:09]
<miro5001> 😁
[23:57:30]
<miro5001> It happened to me too a while ago 😜