[08:45:30]
<Yunohost Git/Infra notifications> [SSOwat] @tomhejra commented on issue #204 Fix auth_header parsing when password contains semicolon: Found same issue, fixed it in a similar way but my change was only: lua - _, _, user, password = string.find(ngx.d... https://github.com/YunoHost/SSOwat/pull/204#issuecomment-1379443358
[08:47:05]
<Yunohost Git/Infra notifications> [SSOwat] @tomhejra commented on issue #204 Fix auth_header parsing when password contains semicolon: Found same issue, fixed it in a similar way but my change was only: lua - _, _, user, password = string.find(ngx.d... https://github.com/YunoHost/SSOwat/pull/204#issuecomment-1379443358
[08:48:48]
<Yunohost Git/Infra notifications> [SSOwat] @tomhejra commented on issue #204 Fix auth_header parsing when password contains semicolon: Found same issue, fixed it in a similar way but my change was only: lua - _, _, user, password = string.find(ngx.d... https://github.com/YunoHost/SSOwat/pull/204#issuecomment-1379443358
[08:49:34]
<Yunohost Git/Infra notifications> [SSOwat] @tomhejra commented on issue #204 Fix auth_header parsing when password contains semicolon: Found same issue, fixed it in a similar way but my change was only: lua - _, _, user, password = string.find(ngx.d... https://github.com/YunoHost/SSOwat/pull/204#issuecomment-1379443358
[08:51:23]
<Yunohost Git/Infra notifications> [SSOwat] @tomhejra commented on issue #204 Fix auth_header parsing when password contains semicolon: Found same issue, fixed it in a similar way but my change was only: lua - _, _, user, password = string.find(ngx.d... https://github.com/YunoHost/SSOwat/pull/204#issuecomment-1379443358
[08:53:17]
<Yunohost Git/Infra notifications> [SSOwat] @tomhejra commented on issue #204 Fix auth_header parsing when password contains semicolon: Found same issue, fixed it in a similar way but my change was only: lua - _, _, user, password = string.find(ngx.d... https://github.com/YunoHost/SSOwat/pull/204#issuecomment-1379443358
[08:56:31]
<Yunohost Git/Infra notifications> [issues] @alexAubin opened issue #2127: Replace the current app wishlist with a system where user can vote etc. https://github.com/YunoHost/issues/issues/2127
[08:56:32]
<Yunohost Git/Infra notifications> [issues] @alexAubin labeled :birthday: feature on issue #2127: Replace the current app wishlist with a system where user can vote etc. https://github.com/YunoHost/issues/issues/2127
[09:34:51]
<Yunohost Git/Infra notifications> [SSOwat] @ewilly commented on issue #204 Fix auth_header parsing when password contains semicolon: Great to see someone else working on that issue :) Your proposal fit to my needs. I made some test here : [Online Lua C... https://github.com/YunoHost/SSOwat/pull/204#issuecomment-1380046278
[11:11:08]
<Yunohost Git/Infra notifications> [SSOwat] @tomhejra commented on issue #204 Fix auth_header parsing when password contains semicolon: Hmm.. I kinda like the Solution3 but it has other flaws although it handles "" user better (if "" user is allowed). Sol... https://github.com/YunoHost/SSOwat/pull/204#issuecomment-1380170170
[11:13:31]
<Yunohost Git/Infra notifications> [SSOwat] @tomhejra commented on issue #204 Fix auth_header parsing when password contains semicolon: Hmm.. I kinda like the Solution3 but it has other flaws although it handles "" user better (if "" user is allowed). Sol... https://github.com/YunoHost/SSOwat/pull/204#issuecomment-1380170170
[11:14:38]
<Yunohost Git/Infra notifications> [SSOwat] @tomhejra commented on issue #204 Fix auth_header parsing when password contains semicolon: Hmm.. I kinda like the Solution3 but it has other flaws although it handles "" user better (if "" user is allowed). Sol... https://github.com/YunoHost/SSOwat/pull/204#issuecomment-1380170170
[11:21:33]
<Yunohost Git/Infra notifications> [SSOwat] @tomhejra commented on issue #204 Fix auth_header parsing when password contains semicolon: Hmm.. I kinda like the Solution3 but it has other flaws although it handles "" user better (if "" user is allowed). Sol... https://github.com/YunoHost/SSOwat/pull/204#issuecomment-1380170170
[11:23:14]
<Yunohost Git/Infra notifications> [SSOwat] @tomhejra commented on issue #204 Fix auth_header parsing when password contains semicolon: Hmm.. I kinda like the Solution3 but it has other flaws although it handles "" user better (if "" user is allowed). Sol... https://github.com/YunoHost/SSOwat/pull/204#issuecomment-1380170170
[11:24:28]
<Yunohost Git/Infra notifications> [SSOwat] @tomhejra commented on issue #204 Fix auth_header parsing when password contains semicolon: Hmm.. I kinda like the Solution3 but it has other flaws although it handles "" user better (if "" user is allowed). Sol... https://github.com/YunoHost/SSOwat/pull/204#issuecomment-1380170170
[11:26:10]
<Yunohost Git/Infra notifications> [SSOwat] @tomhejra commented on issue #204 Fix auth_header parsing when password contains semicolon: Hmm.. I kinda like the Solution3 but it has other flaws although it handles "" user better (if "" user is allowed). Sol... https://github.com/YunoHost/SSOwat/pull/204#issuecomment-1380170170
[11:26:54]
<Yunohost Git/Infra notifications> [SSOwat] @tomhejra commented on issue #204 Fix auth_header parsing when password contains semicolon: Hmm.. I kinda like the Solution3 but it has other flaws although it handles "" user better (if "" user is allowed). Sol... https://github.com/YunoHost/SSOwat/pull/204#issuecomment-1380170170
[11:32:15]
<Yunohost Git/Infra notifications> [SSOwat] @tomhejra commented on issue #204 Fix auth_header parsing when password contains semicolon: Hmm.. I kinda like the Solution3 but it has other flaws although it handles "" user better (if "" user is allowed). Sol... https://github.com/YunoHost/SSOwat/pull/204#issuecomment-1380170170
[11:35:12]
<Yunohost Git/Infra notifications> [SSOwat] @tomhejra commented on issue #204 Fix auth_header parsing when password contains semicolon: Regarding this PR Id keep it to save this conversation about it. You will have to do rebase anyway, so Id recommend to... https://github.com/YunoHost/SSOwat/pull/204#issuecomment-1380196755
[12:33:25]
<tituspijean> https://matrix.to/#/!GevpWevrsZKluNMXsY:pijean.ovh/$f9Sgaycv46DVvBWkdLb9giz_J3Fn8m2eS-FJP6nC4wU?via=matrix.org&via=libera.chat&via=aria-net.org
I see in their screenshot subdomains of `net.nohost.me` and `com.nohost.me` that might be used for phishing attempts.
[13:51:11]
<Aleks (he/him/il/lui)> @_@
[13:51:38]
<Aleks (he/him/il/lui)> hmmm i cant easily access the screenshot thingy
[13:51:48]
<Aleks (he/him/il/lui)> you mean the folk on the support chatroom ?
[13:58:43]
<tituspijean> yup
[13:59:14]
<tituspijean> I don't quite understand their request and how they end up with such domains in their pi-hole instance though
[14:49:29]
<Yunohost Git/Infra notifications> @methbkts forked yunohost to methbkts/yunohost: https://github.com/methbkts/yunohost
[14:51:07]
<Yunohost Git/Infra notifications> [yunohost] @methbkts opened pull request #1566: chore: update actions version to use node 16 version https://github.com/YunoHost/yunohost/pull/1566
[14:53:22]
<Yunohost Git/Infra notifications> [yunohost] @tituspijean commented on issue #1566 chore: update actions version to use node 16 version: Note to self: do that with all Actions. https://github.com/YunoHost/yunohost/pull/1566#issuecomment-1380489635
[14:55:13]
<Yunohost Git/Infra notifications> [yunohost] @alexAubin merged pull request #1566: chore: update actions version to use node 16 version https://github.com/YunoHost/yunohost/pull/1566
[14:55:13]
<Yunohost Git/Infra notifications> [yunohost] @alexAubin pushed 2 commits to dev: https://github.com/YunoHost/yunohost/compare/2b6465d36da2...edd187eb90e2
[14:55:14]
<Yunohost Git/Infra notifications> [yunohost/dev] chore: update actions version to use node 16 version - Metin Bektas
[14:55:20]
<Yunohost Git/Infra notifications> [yunohost/dev] Merge pull request #1566 from methbkts/patch-1 chore: update actions version to use node 16 version - Alexandre Aubin
[15:00:32]
<Yunohost Git/Infra notifications> 🏗️ Starting build for yunohost/11.1.2.2+202301121500 for bullseye/unstable/all ...
[15:01:58]
<Yunohost Git/Infra notifications> ✔️ Completed build for yunohost/11.1.2.2+202301121500 for bullseye/unstable/all.
[15:19:27]
<Yunohost Git/Infra notifications> [yunohost] Pipeline failed on GitLab https://gitlab.com/yunohost/yunohost/-/pipelines/745609993 on commit https://github.com/YunoHost/yunohost/commit/edd187eb90e20228c14aedee8acaa8fa3a0b11d7 "Merge pull request #1566 from methbkts/patch-1 chore: update actions version to use node 16 version" by @GitHub on branches dev
[17:45:13]
<ljf[m]> > <@titus:pijean.ovh> I don't quite understand their request and how they end up with such domains in their pi-hole instance though
maybe it's because they receive spam email, and postfix does a FCrDNS check ?
[19:32:14]
<Yunohost Git/Infra notifications> [SSOwat] @ewilly commented on issue #204 Fix auth_header parsing when password contains semicolon: Nice thanks for your advices regarding git command and your lua expertise :) Apparently I successful rebase and update t... https://github.com/YunoHost/SSOwat/pull/204#issuecomment-1380908552
[19:32:32]
<Yunohost Git/Infra notifications> [SSOwat] @ewilly edited pull request #204: DRAFT Fix auth_header parsing when password contains semicolon https://github.com/YunoHost/SSOwat/pull/204
[20:17:54]
<Yunohost Git/Infra notifications> [SSOwat] @alexAubin commented on pull request #204 DRAFT Fix auth_header parsing when password contains semicolon: Ugh Ive read the discussion in diagonal but not sure to understand the whole thing about ([^:].-) ... not sure to und... https://github.com/YunoHost/SSOwat/pull/204#discussion_r1068611794
[20:25:52]
<Yunohost Git/Infra notifications> [SSOwat] @tomhejra commented on pull request #204 DRAFT Fix auth_header parsing when password contains semicolon: Correct. ([^:]+) is equivalent and makes sense... I was blinded by that .- approach. https://github.com/YunoHost/SSOwat/pull/204#discussion_r1068621007
[20:30:36]
<Yunohost Git/Infra notifications> [SSOwat] @tomhejra commented on pull request #204 DRAFT Fix auth_header parsing when password contains semicolon: It is completely different look at it, since it means "find as many non-semicolon characters as possible, at least one"b... https://github.com/YunoHost/SSOwat/pull/204#discussion_r1068625211
[20:33:10]
<Yunohost Git/Infra notifications> [SSOwat] @alexAubin commented on pull request #204 DRAFT Fix auth_header parsing when password contains semicolon: hmyeah but + also means "at least one char" so it wont match empty string P https://github.com/YunoHost/SSOwat/pull/204#discussion_r1068627902
[20:40:36]
<Yunohost Git/Infra notifications> [SSOwat] @tomhejra commented on pull request #204 DRAFT Fix auth_header parsing when password contains semicolon: None of these would match empty string. Some of those could match empty username (ewillys first one and (.-)) but it ... https://github.com/YunoHost/SSOwat/pull/204#discussion_r1068633231
[20:40:54]
<Yunohost Git/Infra notifications> [SSOwat] @tomhejra edited a comment on pull request #204 DRAFT Fix auth_header parsing when password contains semicolon: None of these would match empty string. Some of those could match empty username (ewillys first one and (.-)) but it ... https://github.com/YunoHost/SSOwat/pull/204#discussion_r1068633231
[21:29:47]
<Yunohost Git/Infra notifications> [SSOwat] @ewilly commented on pull request #204 DRAFT Fix auth_header parsing when password contains semicolon: commit updated with @alexAubin proposal which is working for me too. https://github.com/YunoHost/SSOwat/pull/204#discussion_r1068675424
[21:30:18]
<Yunohost Git/Infra notifications> [SSOwat] @ewilly edited pull request #204: Fix auth_header parsing when password contains semicolon https://github.com/YunoHost/SSOwat/pull/204
[22:13:15]
<Yunohost Git/Infra notifications> [yunohost] @zamentur pushed 1 commit to fix-postgresql-migration: [fix] Postgresql migration could not stop old cluster, please do that manually https://github.com/YunoHost/yunohost/commit/59bcd29cbb47998f304e02c5d4fe2c8cf5d4590e
[22:13:16]
<Yunohost Git/Infra notifications> [yunohost] @zamentur created new branch fix-postgresql-migration
[22:16:33]
<Yunohost Git/Infra notifications> [yunohost] @zamentur opened pull request #1567: [fix] Postgresql migration https://github.com/YunoHost/yunohost/pull/1567
[22:17:35]
<Yunohost Git/Infra notifications> [yunohost] @zamentur edited pull request #1567: [fix] Postgresql migration https://github.com/YunoHost/yunohost/pull/1567
[22:31:12]
<Yunohost Git/Infra notifications> [yunohost] @alexAubin commented on pull request #1567 [fix] Postgresql migration: Hmmm the sleep sounds legit but the || true sounds really like a big nope ... Like, if the cluster upgrade miserably f... https://github.com/YunoHost/yunohost/pull/1567#discussion_r1068733794
[22:34:15]
<Yunohost Git/Infra notifications> [yunohost] @zamentur commented on pull request #1567 [fix] Postgresql migration: thats what we know now o_O We are restoring our db backup... https://github.com/YunoHost/yunohost/pull/1567#discussion_r1068735809
[22:34:23]
<Yunohost Git/Infra notifications> [SSOwat] @alexAubin approved pull request #204 Fix auth_header parsing when password contains semicolon: LGTM, not merging yet just because I dont have time to release the patch for all versions right now .. https://github.com/YunoHost/SSOwat/pull/204#pullrequestreview-1246676635
[22:40:15]
<Yunohost Git/Infra notifications> [yunohost] Pipeline failed on GitLab https://gitlab.com/yunohost/yunohost/-/pipelines/745976414 on commit https://github.com/YunoHost/yunohost/commit/59bcd29cbb47998f304e02c5d4fe2c8cf5d4590e "[fix] Postgresql migration could not stop old cluster, please do that manually" by @GitHub on branches fix-postgresql-migration
[23:47:19]
<feelniceinc> Hi together :)