[06:27:37]
<Yunohost Git/Infra notifications> [yunohost] alexAubin [commented](https://github.com/YunoHost/yunohost/pull/1697#issuecomment-2068584544) on [issue #1697](https://github.com/YunoHost/yunohost/pull/1697) feature: new global setting options to enable SNI-forward to external domains: cf https://github.com/YunoHost/yunohost/pull/1697#discussion_r1292130209 and the X-Real-IP header Basically if you enab...
[06:27:58]
<Yunohost Git/Infra notifications> [yunohost] alexAubin [commented](https://github.com/YunoHost/yunohost/pull/1697#issuecomment-2068584544) on [issue #1697](https://github.com/YunoHost/yunohost/pull/1697) feature: new global setting options to enable SNI-forward to external domains: cf https://github.com/YunoHost/yunohost/pull/1697#discussion_r1292130209 and the X-Real-IP header Basically if you enab...
[06:30:37]
<Yunohost Git/Infra notifications> [yunohost] alexAubin [commented](https://github.com/YunoHost/yunohost/pull/1697#issuecomment-2068584544) on [issue #1697](https://github.com/YunoHost/yunohost/pull/1697) feature: new global setting options to enable SNI-forward to external domains: cf https://github.com/YunoHost/yunohost/pull/1697#discussion_r1292130209 and the X-Real-IP header Basically if you enab...
[11:17:22]
<jeroenroose> oh, sorry, formatting messed up. I'm not familiar with Matrix webclient
[11:22:09]
<jeroenroose> Hi, I'm trying to package icecast but fail to understand how to get config templating working. To illustrate :
```
\[test@test icecast\_ynh\]$ grep **DOMAIN** conf/icecast.xml
\<hostname>**DOMAIN**\</hostname>
\[test@test icecast\_ynh\]$ grep add\_conf scripts/install
ynh\_add\_config --template="../conf/icecast.xml" --destination="$install\_dir/.config/icecast/icecast.xml"
\[test@test icecast\_ynh\]$ sudo grep DOMAIN /etc/yunohost/apps/icecast/conf/icecast.xml
\<hostname>**DOMAIN**\</hostname>
```
[11:29:28]
<jeroenroose> Basically I fail to understand how to template a config file with the domain, I expected ynh_add_config to take care of this but it doesn;t work for me
[11:39:09]
<jeroenroose> Hi, I'm trying to package icecast but fail to understand how to get config templating working. To illustrate :
```
[test@test icecast\_ynh\]$ grep __DOMAIN__ conf/icecast.xml
<hostname>__DOMAIN__</hostname>
[test@test icecast\_ynh\]$ grep add_conf scripts/install
ynh_add_config --template="../conf/icecast.xml" --destination="$install\_dir/.config/icecast/icecast.xml"
[test@test icecast\_ynh\]$ sudo grep DOMAIN /etc/yunohost/apps/icecast/conf/icecast.xml
<hostname>__DOMAIN__</hostname>
```
[11:51:37]
<tituspijean> btw packaging questions are in #yunohost-apps:matrix.org 😉
[11:51:43]
<tituspijean> `ynh_add_config`replaces the `__VARIABLES__` by `$variables` iff there are corresponding variables declared within the script. I see you are manually calling the helper, try declaring `domain=domain.tld` beforehand
[11:53:18]
<tituspijean> try `grep hostname $install\_dir/.config/icecast/icecast.xml` instead
[11:53:30]
<tituspijean> and also you are checking/grepping the result in the package configuration file in `/etc/yunohost/apps`, this one is exepected _not_ to change.
[11:53:52]
<tituspijean> and also you are checking/grepping the result in the package configuration file in `/etc/yunohost/apps`, this one is not expected to change.
[11:55:01]
<tituspijean> `ynh_add_config`replaces the `__VARIABLES__` by `$variables` iff there are corresponding variables declared within the script. I see you are manually calling the helper, try declaring `domain=domain.tld` beforehand. In standard conditions (ie install/upgrading the app), this variable is already created by yunohost.
[12:15:25]
<jeroenroose> Thanks! I did work after all but I was looking at the wrong file.
[14:39:17]
<Yunohost Git/Infra notifications> [yunohost-admin] Axolotle pushed 1 commit to dev: fix: config panel "tags" turned into "select" ([5a805463](https://github.com/YunoHost/yunohost-admin/commit/5a805463bb461ccc4546a3be4caa809fdff22ba5))
[14:40:30]
<Yunohost Git/Infra notifications> [issues] Axolotle closed [issue #2374](https://github.com/YunoHost/issues/issues/2374): Config panel - type tags not respected when we set also choice choices
[14:40:43]
<Yunohost Git/Infra notifications> [issues] Axolotle [commented](https://github.com/YunoHost/issues/issues/2374#issuecomment-2069704680) on [issue #2374](https://github.com/YunoHost/issues/issues/2374) Config panel - type tags not respected when we set also choice choices: fixed with https://github.com/YunoHost/yunohost-admin/commit/5a805463bb461ccc4546a3be4caa809fdff22ba5
[14:46:02]
<Yunohost Git/Infra notifications> 🏗️ Starting build for yunohost-admin/11.2.5+202404221445 for bullseye/unstable/all ...
[14:50:11]
<Yunohost Git/Infra notifications> ✔️ Completed build for yunohost-admin/11.2.5+202404221445 for bullseye/unstable/all.
[18:29:38]
<Yunohost Git/Infra notifications> [issues] chri2 labeled :space_invader: bug on [issue #2379](https://github.com/YunoHost/issues/issues/2379): helper ynh_string_random returns empty string on length > 255
[18:29:39]
<Yunohost Git/Infra notifications> [issues] chri2 opened [issue #2379](https://github.com/YunoHost/issues/issues/2379): helper ynh_string_random returns empty string on length > 255
[18:30:00]
<ChriChri> > <@yunohostinfra:matrix.org> [issues] chri2 opened [issue #2379](https://github.com/YunoHost/issues/issues/2379): helper ynh_string_random returns empty string on length > 255
This could be a security issue depending on the context of use in apps.
[18:33:30]
<Yunohost Git/Infra notifications> [issues] chri2 [commented](https://github.com/YunoHost/issues/issues/2379#issuecomment-2070573896) on [issue #2379](https://github.com/YunoHost/issues/issues/2379) helper ynh_string_random returns empty string on length > 255: man 7 regex > A bound is { followed by an unsigned decimal integer, possibly followed by , possibly followed by ...
[18:33:57]
<ChriChri> https://codeberg.org/ChriChri/flohmarkt_ynh/issues/26
[18:47:44]
<Yunohost Git/Infra notifications> [issues] OniriCorpe labeled :cake: enhancement on [issue #2378](https://github.com/YunoHost/issues/issues/2378): yunohost-ci remove test
[18:47:45]
<Yunohost Git/Infra notifications> [issues] OniriCorpe unlabeled :birthday: feature on [issue #2378](https://github.com/YunoHost/issues/issues/2378): yunohost-ci remove test
[18:48:34]
<Yunohost Git/Infra notifications> [issues] OniriCorpe created label 🚦 CI
[18:48:49]
<Yunohost Git/Infra notifications> [issues] OniriCorpe labeled 🚦 CI on [issue #2378](https://github.com/YunoHost/issues/issues/2378): yunohost-ci remove test
[18:50:07]
<Yunohost Git/Infra notifications> [issues] OniriCorpe labeled 🚦 CI on [issue #2217](https://github.com/YunoHost/issues/issues/2217): Support automatic merging in autoupdate after successful tests
[18:53:32]
<Yunohost Git/Infra notifications> [issues] OniriCorpe created label 🤓 helpers
[18:53:43]
<Yunohost Git/Infra notifications> [issues] OniriCorpe labeled 🤓 helpers on [issue #2379](https://github.com/YunoHost/issues/issues/2379): helper ynh_string_random returns empty string on length > 255
[18:54:13]
<Yunohost Git/Infra notifications> [issues] OniriCorpe labeled :package: App packaging on [issue #2379](https://github.com/YunoHost/issues/issues/2379): helper ynh_string_random returns empty string on length > 255
[18:55:53]
<Yunohost Git/Infra notifications> [issues] OniriCorpe labeled 🤓 helpers on [issue #1779](https://github.com/YunoHost/issues/issues/1779): Logging helper miserably fails when password contains quotes
[18:55:54]
<Yunohost Git/Infra notifications> [issues] OniriCorpe labeled 🤓 helpers on [issue #2367](https://github.com/YunoHost/issues/issues/2367): Composer helper : allow run as other user
[18:55:54]
<Yunohost Git/Infra notifications> [issues] OniriCorpe labeled 🤓 helpers on [issue #1874](https://github.com/YunoHost/issues/issues/1874): Automatic node-update cron creates a mess eating up space, its not clear how to clean it...
[18:55:55]
<Yunohost Git/Infra notifications> [issues] OniriCorpe labeled 🤓 helpers on [issue #2364](https://github.com/YunoHost/issues/issues/2364): Problem with nodejs helper
[18:55:55]
<Yunohost Git/Infra notifications> [issues] OniriCorpe labeled 🤓 helpers on [issue #2017](https://github.com/YunoHost/issues/issues/2017): ynh_replace_string and others not escaping & and \ for sed
[18:56:45]
<Yunohost Git/Infra notifications> [issues] chri2 edited [issue #2379](https://github.com/YunoHost/issues/issues/2379): helper ynh_string_random returns empty string on length > 254
[18:56:54]
<Yunohost Git/Infra notifications> [issues] chri2 edited [issue #2379](https://github.com/YunoHost/issues/issues/2379): helper ynh_string_random returns empty string on length > 254
[18:57:47]
<Yunohost Git/Infra notifications> [issues] alexAubin edited [issue #2378](https://github.com/YunoHost/issues/issues/2378): app ci: more thorough tests that all the files related to the app are properly removed after removal of the app