[01:55:09]
<Yunohost Git/Infra notifications> webclinic017 forked yunohost to [webclinic017/yunohost](https://github.com/webclinic017/yunohost)
[02:18:55]
<Yunohost Git/Infra notifications> [yunodevtools] OniriCorpe created new branch autoupdater-show-updated-apps
[02:18:59]
<Yunohost Git/Infra notifications> [yunodevtools] OniriCorpe pushed 1 commit to autoupdater-show-updated-apps: autoupdater: list updated apps on the matrix message ([82244409](https://github.com/YunoHost/yunodevtools/commit/82244409aa512030806e2c11659f7ebed07b6f89))
[02:19:10]
<Yunohost Git/Infra notifications> [yunodevtools] OniriCorpe opened [pull request #3](https://github.com/YunoHost/yunodevtools/pull/3): autoupdater: list updated apps on the matrix message
[02:27:40]
<Yunohost Git/Infra notifications> [yunodevtools] OniriCorpe deleted branch autoupdater-show-updated-apps
[02:27:40]
<Yunohost Git/Infra notifications> [yunodevtools] OniriCorpe merged [pull request #3](https://github.com/YunoHost/yunodevtools/pull/3): autoupdater: list updated apps on the matrix message
[02:27:40]
<Yunohost Git/Infra notifications> [yunodevtools] OniriCorpe edited [pull request #3](https://github.com/YunoHost/yunodevtools/pull/3): autoupdater: list updated apps on the matrix message
[02:27:40]
<Yunohost Git/Infra notifications> [yunodevtools] OniriCorpe pushed 1 commit to main: autoupdater: list updated apps on the matrix message ([4ef9ef59](https://github.com/YunoHost/yunodevtools/commit/4ef9ef59e4946f26f3698aabea5afb4f1e59bc78))
[13:26:30]
<Yunohost Git/Infra notifications> [install_script] alexAubin [commented](https://github.com/YunoHost/install_script/pull/74#discussion_r1591013024) on pull request #74 Give time for Internet connection to be setup, and ensure curl is installed: suggestion ping -c 1 -W 2 yunohost.org >/dev/null && return 0
[13:26:30]
<Yunohost Git/Infra notifications> [install_script] alexAubin edited review [pull request #74](https://github.com/YunoHost/install_script/pull/74#pullrequestreview-2040779893): Give time for Internet connection to be setup, and ensure curl is installed
[13:26:30]
<Yunohost Git/Infra notifications> [install_script] alexAubin [commented](https://github.com/YunoHost/install_script/pull/74#discussion_r1591011987) on pull request #74 Give time for Internet connection to be setup, and ensure curl is installed: suggestion ping -c 1 -W 2 yunohost.org >/dev/null && return 0
[14:24:36]
<selfhoster1312> ```
4/5 • Adding YunoHost repository to apt
gpg: no valid OpenPGP data found.
Hit:1 http://deb.debian.org/debian bookworm InRelease
Get:2 http://forge.yunohost.org/debian bookworm InRelease [15.3 kB]
Err:2 http://forge.yunohost.org/debian bookworm InRelease
The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 5D09F2273DAC3BD5
Reading package lists...
W: GPG error: http://forge.yunohost.org/debian bookworm InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 5D09F2273DAC3BD5
E: The repository 'http://forge.yunohost.org/debian bookworm InRelease' is not signed.
[FAIL] Setting up deb package sources failed
```
[14:26:51]
<Aleks (he/him/il/lui)> >gpg: no valid OpenPGP data found.
🤔
[14:27:32]
<Aleks (he/him/il/lui)> can you check that `curl --fail --silent https://forge.yunohost.org/yunohost_bookworm.asc` works on your side ?
[14:28:39]
<selfhoster1312> i just did it fetches correct key i'm trying to see where it failed
[14:30:38]
<selfhoster1312> hmm looks like download failed in the container
[14:30:41]
<selfhoster1312> (file is empty)
[14:35:07]
<selfhoster1312> oh
[14:35:29]
<selfhoster1312> ```
root@template:/# curl https://yunohost.org
curl: (77) error setting certificate file: /etc/ssl/certs/ca-certificates.crt
root@template:/# apt install ca-certificates
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
The following additional packages will be installed:
openssl
The following NEW packages will be installed:
ca-certificates openssl
```
[14:36:01]
<selfhoster1312> maybe openssl and ca-certificates should be dependency of yunohost installer ^^"
[14:36:19]
<Aleks (he/him/il/lui)> well they probably are but the point of this is precisely to install yunohost ...
[14:39:44]
<selfhoster1312> i added it to the dependencies in my template :)
[14:40:32]
<selfhoster1312> works better 😎️
[14:44:20]
<selfhoster1312> ah that's probably because:
https://github.com/YunoHost/install_script/blob/main/bookworm#L276
you removed apt_get_wrapper in this new version apparently but still merged this ^^
[14:44:43]
<selfhoster1312> (my bad i forced pushed the PR commit in order to test so it was merged before i finished testing...)
[14:45:43]
<Aleks (he/him/il/lui)> 😬
[14:46:08]
<Aleks (he/him/il/lui)> `s/apt_get_wrapper --yes install curl/apt_install curl/`
[14:46:17]
<selfhoster1312> more dragons
```
51124 ERROR Could not run script: /usr/share/yunohost/hooks/conf_regen/01-yunohost
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/yunohost/hook.py", line 298, in hook_callback
hook_return = hook_exec(
^^^^^^^^^^
File "/usr/lib/python3/dist-packages/yunohost/hook.py", line 418, in hook_exec
raise YunohostError("hook_exec_failed", path=path)
yunohost.utils.error.YunohostError: Could not run script: /usr/share/yunohost/hooks/conf_regen/01-yunohost
```
[14:46:38]
<selfhoster1312> (but at the end it's SUCCESS)
[14:46:41]
<Aleks (he/him/il/lui)> wtf
[14:47:01]
<Aleks (he/him/il/lui)> no other message before this ?
[14:47:18]
<selfhoster1312> 66760 other messages before this my shell history is not long enough XD
[14:47:31]
*selfhoster1312 investigating
[14:50:16]
<Salamandar> @Alekswag:matrix.org didn't you want to amend https://github.com/YunoHost-Apps/borg_ynh/pull/148/commits/9b1f830c56253568ca416501cdc23c5c8a900bcb ?
[14:58:20]
<selfhoster1312> ok my bad it failed because of `systemctl enable proc-hidepid --quiet --now` because of security policy on the machine prevents namespace manipulation by yunohost
[14:58:45]
<selfhoster1312> which is not a problem but probably proc-hidepid should not be critical to the hook success
[14:59:22]
<selfhoster1312> more problematic is now yunohost-portal-api also depends on NS manipulation :) :)
[14:59:39]
<selfhoster1312> ```
May 06 14:59:24 yunohost-bookworm-32527 (rtal-api)[1679]: yunohost-portal-api.service: Failed to set up mount namespacing: Permission denied
May 06 14:59:24 yunohost-bookworm-32527 (rtal-api)[1679]: yunohost-portal-api.service: Failed at step NAMESPACE spawning /usr/bin/yunohost-portal-api: Permission denied
```
[14:59:59]
<selfhoster1312> i'll make the policy more lax to make it work in htis instance
[15:11:07]
<Aleks (he/him/il/lui)> > <@Salamandar:matrix.org> @Alekswag:matrix.org didn't you want to amend https://github.com/YunoHost-Apps/borg_ynh/pull/148/commits/9b1f830c56253568ca416501cdc23c5c8a900bcb ?
yes but i've been running all over the place sorry
[15:11:20]
<Aleks (he/him/il/lui)> but uuuuh i'll keep the tab open an amend it at some point tonight
[15:12:19]
<Aleks (he/him/il/lui)> > <selfhoster1312> ```
> May 06 14:59:24 yunohost-bookworm-32527 (rtal-api)[1679]: yunohost-portal-api.service: Failed to set up mount namespacing: Permission denied
> May 06 14:59:24 yunohost-bookworm-32527 (rtal-api)[1679]: yunohost-portal-api.service: Failed at step NAMESPACE spawning /usr/bin/yunohost-portal-api: Permission denied
> ```
yes i've seen this several times since at least the buster era I think, like many debian systemd service need this ... e.g. redis I think ?
[15:14:16]
<selfhoster1312> yep a lot of services do
[15:15:29]
<selfhoster1312> ok i think i got the setup script running again :)
[15:16:02]
<selfhoster1312> now i think i'm gonna do some benchmarking because adding users is really slow and i'm wondering why... or maybe i'll do the same with adding domain ?
[15:18:49]
<selfhoster1312> 31s on my quad core with SSD to add a user ^^
[15:19:58]
<Aleks (he/him/il/lui)> urgh
[15:20:20]
<Aleks (he/him/il/lui)> related: https://github.com/YunoHost/issues/issues/2088
[15:21:01]
<Aleks (he/him/il/lui)> >It seems to hang on processing (waiting for results of) the modify_ext_s.
[15:22:06]
<selfhoster1312> last time i checked it was the LDAP library taking a long time, but not sure why
[15:22:07]
<Aleks (he/him/il/lui)> https://github.com/YunoHost/yunohost/blob/bookworm/src/utils/ldap.py#L282
[15:22:16]
<Aleks (he/him/il/lui)> yeah
[15:22:26]
<Aleks (he/him/il/lui)> same conclusion in that thread
[15:22:35]
<selfhoster1312> yeah from what i remember it was that line
[15:22:43]
<selfhoster1312> i'm just not sure if we can do another way ?
[15:22:53]
<Aleks (he/him/il/lui)> ¯\_(ツ)_/¯
[15:22:56]
<Aleks (he/him/il/lui)> it's still pretty puzzling
[15:22:58]
<selfhoster1312> like maybe reconcile the LDAP state in python and apply the result directly
[15:23:00]
<selfhoster1312> i'll check it out
[15:23:09]
<selfhoster1312> if i can't add a user in 1s i'm gonna cry :P
[15:23:10]
<Aleks (he/him/il/lui)> naively we could try to profile *inside* the ldap lib but hmpf
[15:32:17]
<selfhoster1312> i think it scales linearly with the number of users, but i'll wait for the 300 user creation benchmark to finish for sure ^^
[15:50:48]
<Aleks (he/him/il/lui)> > <@Alekswag:matrix.org> yes but i've been running all over the place sorry
https://github.com/YunoHost-Apps/borg_ynh/pull/148#discussion_r1591200726
[15:58:19]
<selfhoster1312> ```
1 existing users: 0:01.15
50 existing users: 0:02.32
100 existing users: 0:03.42
150 existing users: 0:04.68
200 existing users: 0:05.67
250 existing users: 0:07.41
300 existing users: 0:08.44
```
[15:58:33]
<selfhoster1312> linear or close, just super slow
[15:58:48]
<Aleks (he/him/il/lui)> `1 existing users: 0:01.15`
[15:58:51]
<Aleks (he/him/il/lui)> 1 minute or 1 second o.O
[15:58:54]
<selfhoster1312> 1 second
[15:58:59]
<selfhoster1312> XD
[15:59:13]
<Aleks (he/him/il/lui)> ah, so "only" 8 second with 300 users ?
[15:59:30]
<selfhoster1312> on this super beefy 12 core server yes
[16:00:34]
<selfhoster1312> 31s for 185 users on my production server (beefy x86)
[16:00:47]
<Aleks (he/him/il/lui)> maybe the time increases if there's more apps installed, because of all the permissions "links" idk
[16:00:52]
<selfhoster1312> the difference is not due to hardware but production server has more groups/apps
[16:00:54]
<selfhoster1312> yes
[16:01:40]
<selfhoster1312> i'll run more tests but according to issue it's related to `permission_sync_to_user`
[16:01:43]
<Aleks (he/him/il/lui)> it's not 100% clear to me how the user/group/permission system works in deep details, like i don't know if there's a real concept of "many2one/one2many" in ldap or
[16:02:12]
<selfhoster1312> yes there's groups in LDAP if that's what you mean?
[16:02:31]
<selfhoster1312> the problem if i understand it is we try to keep permissions in 2 places
[16:02:36]
<selfhoster1312> in groups DN in users DN
[16:02:43]
<selfhoster1312> so we need to sync it for every operation
[16:03:00]
<Aleks (he/him/il/lui)> yes but we also have the `permission_sync_to_user` which basically reproduces some sort of automatic many2many, i don't have the exact topology in mind
[16:03:09]
<Aleks (he/him/il/lui)> ah yes
[16:03:34]
<selfhoster1312> sooo we could be clever about what parts to resync (instead of performing tons of operations), or we could just have one source of truth
[16:04:55]
<selfhoster1312> i mean actual permissions are: group permissions + user permissions overlaid
so with a python shim performing the operation we could probably stop syncing altogether
[16:04:57]
<Aleks (he/him/il/lui)> ah yeah because if i understand correctly we do tons of modify operations which "commit" the changes everytime instead of having a single transaction etc?
[16:04:58]
<Aleks (he/him/il/lui)> LDAP is such a depressing technology :|
[16:05:21]
<selfhoster1312> well the problem is not really LDAP... from what i undertand it's our DB architecture that's the problem
[16:05:28]
<selfhoster1312> we would have the same problem in a SQL DB...
[16:05:35]
<selfhoster1312> (maybe faster though :P)
[16:06:11]
<Aleks (he/him/il/lui)> a python shim ? 🤔
[16:07:04]
<selfhoster1312> i need to check to be sure, but i assume right now portal-api gets permission from user field without querying groups
we would need to change this logic to check groups then special user permissions
[16:08:33]
<selfhoster1312> (so modifications in the user/groups would be much faster, but checking permissions would take longer... but portal-api could cache the permissions for faster access)
[16:08:59]
<selfhoster1312> is there a yunohost policy for caching the LDAP state? like is it supported/documented that we should or should not edit the LDAP DB outside of yunohost?
[16:09:28]
<selfhoster1312> if nobody except yunohost should *write* to LDAP then caching is easy and we can optimize everything
[16:10:46]
<Aleks (he/him/il/lui)> hmmm but to me the whole "user<->permission" relationship thing is more about LDAP configuration on the app side
[16:10:53]
<Aleks (he/him/il/lui)> it's not clear to me ugh
[16:11:24]
<selfhoster1312> what do you mean?
[16:12:11]
<Aleks (he/him/il/lui)> regarding caching : the thing is that invalidating the cache aint easy because we have the CLI, the admin API, and the new portal API wanting to read the info (though maybe the portal API could read the ACL directly from the ssowat conf.json ? Or does it do this already ? I'm not sure)
[16:12:45]
<Aleks (he/him/il/lui)> > <selfhoster1312> what do you mean?
for example this query : https://github.com/YunoHost-Apps/nextcloud_ynh/blob/master/conf/config.json#L51
[16:13:01]
<selfhoster1312> ah right it's in the json
[16:13:15]
<selfhoster1312> so the reconciliation is already there maybe it doesn't need to be in LDAP too?
[16:13:57]
<Aleks (he/him/il/lui)> i drank to much coffee and doing too many things at once to be able to have my brain focus xD
[16:14:58]
<selfhoster1312> my LDAP is rusty but ` "ldap_login_filter": "(&(|(objectclass=posixAccount))(uid=%uid)(permission=cn=__APP__.main,ou=permission,dc=yunohost,dc=org))",`
doesn't that mean check the permissions ou for the given user in the __APP__.main entry?
[16:15:03]
<selfhoster1312> or is it the other way around?
[16:15:18]
<selfhoster1312> you know what we should probably write some tests for that kind of logic :P
[16:18:42]
<selfhoster1312> well feel free to drink more coffee i'll try to cook up some login/permission tests using this nextcloud app
[16:56:48]
<selfhoster1312> can't i choose the app id from yunohost app install CLI?
[17:00:03]
<selfhoster1312> looks like it's hardcoded, and i can't find info about app via label i have to use id
[17:09:12]
<Aleks (he/him/il/lui)> you can customize the label but not the app id
[17:09:12]
<Aleks (he/him/il/lui)> regarding LDAP : in an ideal world, I would have as much source of truth in flat files, i.e. maybe we could have all the permission info in the app's settings.yml ... maybe even the user<->group relationship in a new flat file somehow ... and then we could regenerate the LDAP info when needed
[17:09:16]
<Aleks (he/him/il/lui)> i mean i'm not even sure we really need to have domains in LDAP ... the only reason right now is that we have some `ldap:whatever` in postfix config, but we could also change this to use a flat file / map autoregenerated
[17:32:47]
<selfhoster1312> is it weird that i can't login on the new with a user i just created? the user i created during postinstall works fine
[17:34:15]
<selfhoster1312> at least with teh web interface, let me try to hit the API directly...
[17:52:33]
<Aleks (he/him/il/lui)> so in some case a new user may not be able to log in
[17:52:33]
<Aleks (he/him/il/lui)> that's related to trying to handle the "multi tenant" case / shared hosting / having "several main domain"
[17:52:33]
<Aleks (he/him/il/lui)> on the new portal, you can only log in if you have access to at least one app - or you have a mail address corresponding to the domain
[17:52:33]
<Aleks (he/him/il/lui)> can't login on SSH ? yes, only member of the "admins" group can log in on ssh or the webadmin
[17:52:33]
<Aleks (he/him/il/lui)> ah yes on the new portal
[18:01:06]
<selfhoster1312> yes on the web interface... i don't understand i can't reproduce but same login/password worked after a while (and restarting portal-api)
[18:02:19]
<selfhoster1312> gonna try again from scratch
[18:07:49]
<selfhoster1312> ah yes you're right, i found it strange because i named "testuser1" admin of nextcloud but it cannot connect
[18:10:04]
<Yunohost Git/Infra notifications> [install_script] selfhoster1312 opened [pull request #77](https://github.com/YunoHost/install_script/pull/77): Fix apt install curl, add error message
[18:19:08]
<Yunohost Git/Infra notifications> [install_script] alexAubin merged [pull request #77](https://github.com/YunoHost/install_script/pull/77): Fix apt install curl, add error message
[18:19:09]
<Yunohost Git/Infra notifications> [install_script] alexAubin pushed 2 commits to main ([60d390567852...060cf535592f](https://github.com/YunoHost/install_script/compare/60d390567852...060cf535592f))
[18:19:09]
<Yunohost Git/Infra notifications> [install_script/main] Fix apt install curl, add error message - selfhoster1312
[18:35:43]
<selfhoster1312> how could DOMAIN_USER_ACL_DICT[domain]["mtime"] be over time.time() when it's supposed to be a date in the past?
[18:35:57]
<selfhoster1312> i don't understand what this condition is for
[18:38:34]
<selfhoster1312> but so the problem seems to be that a user without an app permission is not added to /etc/yunohost/portal/domain.tld.json
[18:45:18]
<selfhoster1312> ah there is no specific portal permission to add them to
[18:45:41]
<selfhoster1312> i'll open an issue to document the expected behavior
[18:56:03]
<Yunohost Git/Infra notifications> [issues] selfhoster1312 labeled :space_invader: bug on [issue #2384](https://github.com/YunoHost/issues/issues/2384): User cannot login to the portal before having access to an app
[18:56:09]
<Yunohost Git/Infra notifications> [issues] selfhoster1312 opened [issue #2384](https://github.com/YunoHost/issues/issues/2384): User cannot login to the portal before having access to an app
[18:59:13]
<Yunohost Git/Infra notifications> [issues] alexAubin edited [issue #2384](https://github.com/YunoHost/issues/issues/2384): Bookworm: User cannot login to the portal before having access to an app
[19:02:06]
<Aleks (he/him/il/lui)> ah right now there's no check on the user's emails ?
[19:02:09]
<Aleks (he/him/il/lui)> I though I implemented those
[19:12:47]
<Yunohost Git/Infra notifications> [issues] alexAubin [commented](https://github.com/YunoHost/issues/issues/2384#issuecomment-2096716290) on [issue #2384](https://github.com/YunoHost/issues/issues/2384) Bookworm: User cannot login to the portal before having access to an app: Hmmyeah I thought I implemented it but in fact not yet : In this function https://github.com/YunoHost/yunohost/blob/bo...
[19:18:32]
<Yunohost Git/Infra notifications> [issues] selfhoster1312 [commented](https://github.com/YunoHost/issues/issues/2384#issuecomment-2096733870) on [issue #2384](https://github.com/YunoHost/issues/issues/2384) Bookworm: User cannot login to the portal before having access to an app: If we do it there, at this point we did a bind to the LDAP but we dont have the full user info. We would need to perfor...
[19:20:14]
<Yunohost Git/Infra notifications> [issues] selfhoster1312 edited [issue #2384](https://github.com/YunoHost/issues/issues/2384): Bookworm: User cannot login to the portal before having access to an app
[19:22:42]
<selfhoster1312> maybe i have an alternative idea
[19:23:08]
<Yunohost Git/Infra notifications> [issues] OniriCorpe [commented](https://github.com/YunoHost/issues/issues/2342#issuecomment-2096743130) on [issue #2342](https://github.com/YunoHost/issues/issues/2342) mirror all our repos outside of github: TODO : - [ ] clone issues and PR too, using ???
[19:23:42]
<Yunohost Git/Infra notifications> [issues] OniriCorpe edited [issue #2342](https://github.com/YunoHost/issues/issues/2342): mirror all our repos outside of github
[19:24:26]
<Yunohost Git/Infra notifications> [issues] selfhoster1312 [commented](https://github.com/YunoHost/issues/issues/2384#issuecomment-2096733870) on [issue #2384](https://github.com/YunoHost/issues/issues/2384) Bookworm: User cannot login to the portal before having access to an app: If we do it there, at this point we did a bind to the LDAP but we dont have the full user info. We would need to perfor...
[19:25:24]
<selfhoster1312> tbh i feel like the multi-domain / user/app separation across multiple portals requires careful thinking and design, is there a document like this somewhere?
[19:25:41]
<Yunohost Git/Infra notifications> [issues] alexAubin [commented](https://github.com/YunoHost/issues/issues/2384#issuecomment-2096747496) on [issue #2384](https://github.com/YunoHost/issues/issues/2384) Bookworm: User cannot login to the portal before having access to an app: meh idk to me this shouldnt be in ssowatconf since this info would be used only by the portal api, not the SSO (though t...
[19:27:57]
<Yunohost Git/Infra notifications> [issues] alexAubin [commented](https://github.com/YunoHost/issues/issues/2384#issuecomment-2096751704) on [issue #2384](https://github.com/YunoHost/issues/issues/2384) Bookworm: User cannot login to the portal before having access to an app: >Alternatively, we could just give permission to any user on the system to access portal by matching URI start with /yun...
[19:28:25]
<Aleks (he/him/il/lui)> > <selfhoster1312> tbh i feel like the multi-domain / user/app separation across multiple portals requires careful thinking and design, is there a document like this somewhere?
¯\_(ツ)_/¯
[19:28:43]
<Aleks (he/him/il/lui)> we discussed it IRL with axolotle mostly
[19:29:37]
<Aleks (he/him/il/lui)> i mean there was general discussions about this for a while but not going into the super detailed specification of "who can access what under which condition and how do we properly explicit this in terms of user UI and admin UI"
[19:31:53]
<Aleks (he/him/il/lui)> There's still stuff to iron out or clarify such as "if you have access to `foo.tld` and `bar.tld`, should you see `bar`'s apps when connected on `foo`'s portal ?" ... i think right now there's a toggle for this on the domain's config panel
[19:45:52]
<selfhoster1312> i think i read some code about this
[19:46:12]
<selfhoster1312> but given it's a major architecture choice, it should be documented somewhere :)
[19:47:50]
<Aleks (he/him/il/lui)> documentation ? uuuugh we don't do that here 😬
[19:56:46]
<selfhoster1312> 🤷♀️️💣️👹️
[20:24:47]
<Yunohost Git/Infra notifications> [yunohost] selfhoster1312 opened [pull request #1822](https://github.com/YunoHost/yunohost/pull/1822): Allow users to access their own domain portal without app permission
[20:25:13]
<Yunohost Git/Infra notifications> [yunohost] selfhoster1312 [commented](https://github.com/YunoHost/yunohost/pull/1822#discussion_r1591516951) on pull request #1822 Allow users to access their own domain portal without app permission: Id really like to have an explanation for this :)
[20:26:19]
<Émy - OniriCorpe> > <@Alekswag:matrix.org> documentation ? uuuugh we don't do that here 😬
[a](https://youtu.be/yBLdQ1a4-JI)
[20:29:56]
<Yunohost Git/Infra notifications> [yunohost] alexAubin [commented](https://github.com/YunoHost/yunohost/pull/1822#discussion_r1591519347) on pull request #1822 Allow users to access their own domain portal without app permission: Feels like a typo ... the if next line should probably be : if domain not in DOMAIN_USER_ACL_DICT or DOMAIN_USER_A...
[20:29:57]
<Yunohost Git/Infra notifications> [yunohost] alexAubin approved [pull request #1822](https://github.com/YunoHost/yunohost/pull/1822#pullrequestreview-2041620597) Allow users to access their own domain portal without app permission: LGTM unless you want to test if and/or fix the weird if mtime thing
[20:29:57]
<Émy - OniriCorpe> [aa](https://www.youtube.com/watch?v=q4kXuW5wT_k) cw loud sound
[20:35:23]
<selfhoster1312> i'm off to bed thanks and see you tomorrow <3
[20:35:24]
<Yunohost Git/Infra notifications> [yunohost] selfhoster1312 [commented](https://github.com/YunoHost/yunohost/pull/1822#issuecomment-2096863014) on [issue #1822](https://github.com/YunoHost/yunohost/pull/1822) Allow users to access their own domain portal without app permission: Ok i fixed a typo and tested this is all good on my side. > LGTM unless you want to test if and/or fix the weird if mti...
[20:35:24]
<Yunohost Git/Infra notifications> [yunohost] selfhoster1312 edited [pull request #1822](https://github.com/YunoHost/yunohost/pull/1822): Allow users to access their own domain portal without app permission
[20:39:02]
<Yunohost Git/Infra notifications> [yunohost] alexAubin [commented](https://github.com/YunoHost/yunohost/pull/1822#issuecomment-2096871629) on [issue #1822](https://github.com/YunoHost/yunohost/pull/1822) Allow users to access their own domain portal without app permission: >What is the entire condition supposed to check/prevent? Its supposed to cache the relevant info from {domain}.json ...
[21:25:49]
<Yunohost Git/Infra notifications> [yunorunner] dependabot[bot] labeled dependencies on [pull request #61](https://github.com/YunoHost/yunorunner/pull/61): Bump jinja2 from 3.1.3 to 3.1.4
[21:25:50]
<Yunohost Git/Infra notifications> [yunorunner] dependabot[bot] created new branch dependabot/pip/jinja2-3.1.4
[21:25:50]
<Yunohost Git/Infra notifications> [yunorunner] dependabot[bot] opened [pull request #61](https://github.com/YunoHost/yunorunner/pull/61): Bump jinja2 from 3.1.3 to 3.1.4
[22:12:47]
<Yunohost Git/Infra notifications> [yunorunner] alexAubin pushed 2 commits to master ([1ef4703101d6...e109903b4560](https://github.com/YunoHost/yunorunner/compare/1ef4703101d6...e109903b4560))
[22:12:48]
<Yunohost Git/Infra notifications> [yunorunner] alexAubin merged [pull request #61](https://github.com/YunoHost/yunorunner/pull/61): Bump jinja2 from 3.1.3 to 3.1.4
[22:12:54]
<Yunohost Git/Infra notifications> [yunorunner] dependabot[bot] deleted branch dependabot/pip/jinja2-3.1.4
[22:13:05]
<Yunohost Git/Infra notifications> [yunorunner] dependabot[bot] edited [pull request #58](https://github.com/YunoHost/yunorunner/pull/58): Bump idna from 2.8 to 3.7
[22:13:25]
<Yunohost Git/Infra notifications> [yunorunner] dependabot[bot] edited [pull request #58](https://github.com/YunoHost/yunorunner/pull/58): Bump idna from 2.8 to 3.7
[22:13:26]
<Yunohost Git/Infra notifications> [yunorunner] dependabot[bot] pushed 1 commit to dependabot/pip/idna-3.7: Bump idna from 2.8 to 3.7 Bumps [idna](https://github.com/kjd/idna) from 2.8 to 3.7. - [Release notes](https://github.c... ([5c3625eb](https://github.com/YunoHost/yunorunner/commit/5c3625eb7d2c3939c29c3d7a1d957b75505d2096))
[22:13:29]
<Yunohost Git/Infra notifications> [yunorunner] dependabot[bot] edited [pull request #58](https://github.com/YunoHost/yunorunner/pull/58): Bump idna from 2.8 to 3.7
[22:13:39]
<Yunohost Git/Infra notifications> [yunorunner] alexAubin merged [pull request #59](https://github.com/YunoHost/yunorunner/pull/59): Bump aiohttp from 3.9.2 to 3.9.4
[22:13:39]
<Yunohost Git/Infra notifications> [yunorunner] alexAubin pushed 2 commits to master ([e109903b4560...4251f3fbbc97](https://github.com/YunoHost/yunorunner/compare/e109903b4560...4251f3fbbc97))
[22:13:44]
<Yunohost Git/Infra notifications> [yunorunner/master] Bump aiohttp from 3.9.2 to 3.9.4 Bumps [aiohttp](https://github.com/aio-libs/aiohttp) from 3.9.2 to 3.9.4. - [Release n... - dependabot[bot]
[22:13:45]
<Yunohost Git/Infra notifications> [yunorunner] dependabot[bot] deleted branch dependabot/pip/aiohttp-3.9.4
[22:13:49]
<Yunohost Git/Infra notifications> [yunorunner/master] Merge pull request #59 from YunoHost/dependabot/pip/aiohttp-3.9.4 Bump aiohttp from 3.9.2 to 3.9.4 - Alexandre Aubin
[22:14:08]
<Yunohost Git/Infra notifications> [yunorunner] dependabot[bot] edited [pull request #58](https://github.com/YunoHost/yunorunner/pull/58): Bump idna from 2.8 to 3.7
[22:14:11]
<Yunohost Git/Infra notifications> [yunorunner] dependabot[bot] pushed 1 commit to dependabot/pip/idna-3.7: Bump idna from 2.8 to 3.7 Bumps [idna](https://github.com/kjd/idna) from 2.8 to 3.7. - [Release notes](https://github.c... ([f78f4152](https://github.com/YunoHost/yunorunner/commit/f78f41525d362a9af45b495781aee2d10d034f42))