[04:29:16]
<Yunohost Git/Infra notifications> [issues] tituspijean [commented](https://github.com/YunoHost/issues/issues/2398#issuecomment-2132620621) on [issue #2398](https://github.com/YunoHost/issues/issues/2398) Custom app permissions are overridden after every app update: To make sure your custom modifications are redone upon every upgrade of an app, you should [write a hook](https://yunoho...
[04:29:47]
<Yunohost Git/Infra notifications> [issues] tituspijean [commented](https://github.com/YunoHost/issues/issues/2398#issuecomment-2132620621) on [issue #2398](https://github.com/YunoHost/issues/issues/2398) Custom app permissions are overridden after every app update: To make sure your custom modifications are redone upon every upgrade of an app, you should [write a hook](https://yunoho...
[06:39:35]
<Yunohost Git/Infra notifications> [issues] FranzMari edited [issue #2404](https://github.com/YunoHost/issues/issues/2404): Edge case in port availability check
[06:42:53]
<Yunohost Git/Infra notifications> [issues] FranzMari edited [issue #2404](https://github.com/YunoHost/issues/issues/2404): Edge case in port availability check
[10:53:01]
<ChriChri> haha, no `eval`in `ynh_handle_getopts_args` anymore 😂
[11:06:49]
<ChriChri> but still a corner case: `ynh_replace_string '--match_string=^#root_path_only' --replace_string= --target_file=/etc/nginx/conf.d/fl.tst.d/flohmarkt.conf` is supposed to work with $replace_string being empty after getting opts...
[12:34:00]
<Yunohost Git/Infra notifications> [issues] Salamandar opened [issue #2405](https://github.com/YunoHost/issues/issues/2405): doc: gandi dns doc is out of date
[12:34:00]
<Yunohost Git/Infra notifications> [issues] Salamandar labeled :space_invader: bug on [issue #2405](https://github.com/YunoHost/issues/issues/2405): doc: gandi dns doc is out of date
[13:05:52]
<Yunohost Git/Infra notifications> [issues] alexAubin edited [issue #2403](https://github.com/YunoHost/issues/issues/2403): Helpers 2.1 wishlist
[13:15:14]
<Salamandar> > <@yunohostinfra:matrix.org> [issues] alexAubin edited [issue #2403](https://github.com/YunoHost/issues/issues/2403): Helpers 2.1 wishlist
TBH maybe we can merge https://github.com/YunoHost/yunohost/pull/1717 and then iterate / experiment on helpers v2
[13:17:44]
<Yunohost Git/Infra notifications> [yunohost] selfhoster1312 [commented](https://github.com/YunoHost/yunohost/pull/1717#issuecomment-2133469667) on [issue #1717](https://github.com/YunoHost/yunohost/pull/1717) Create versionned directories of the helpers: Great idea Why not add a helpers_version to manifest.toml so that we can easily detect repo-wide which apps need to ...
[13:21:54]
<Yunohost Git/Infra notifications> [yunohost] alexAubin [commented](https://github.com/YunoHost/yunohost/pull/1717#issuecomment-2133476857) on [issue #1717](https://github.com/YunoHost/yunohost/pull/1717) Create versionned directories of the helpers: hmmyeah i guess we could have something like toml [integration] yunohost = ">= 11.2" helpers = "2.1" or pa...
[13:22:59]
<Aleks (he/him/il/lui)> > <@Salamandar:matrix.org> TBH maybe we can merge https://github.com/YunoHost/yunohost/pull/1717 and then iterate / experiment on helpers v2
zblerg yeah, but the branch needs to have master re-merged in it or redone because of the conflcts x_x
[14:05:27]
<Salamandar> weird, i rebased the branch yesterday
[14:06:16]
<Aleks (he/him/il/lui)> 🤔
[14:07:03]
<Aleks (he/him/il/lui)> did you push ? 😬
[14:07:17]
<Aleks (he/him/il/lui)> the commit still appears to be from before january
[14:07:26]
<Salamandar> ah wait
[14:07:33]
<Salamandar> this branch was on my personal fork
[14:08:25]
<Yunohost Git/Infra notifications> [yunohost] Salamandar pushed 2 commits to helpers ([251b3f9324be...5d3131b494d2](https://github.com/YunoHost/yunohost/compare/251b3f9324be...5d3131b494d2))
[14:08:33]
<Yunohost Git/Infra notifications> [yunohost/helpers] Create versionned directories of the helpers - Félix Piédallu
[14:08:34]
<Yunohost Git/Infra notifications> [yunohost] alexAubin deleted branch ci-format-debian/11.1.5.4
[14:08:39]
<Yunohost Git/Infra notifications> [yunohost] alexAubin deleted branch ci-format-debian/11.1.5.5
[14:08:39]
<Salamandar> fixed
[14:08:39]
<Yunohost Git/Infra notifications> [yunohost] alexAubin deleted branch ci-format-debian/11.1.6
[14:08:49]
<Yunohost Git/Infra notifications> [yunohost] alexAubin deleted branch 4.4.3
[14:08:51]
<Yunohost Git/Infra notifications> [yunohost] alexAubin deleted branch 11.0.11
[14:08:54]
<Yunohost Git/Infra notifications> [yunohost] alexAubin deleted branch 11.1.1.2
[14:08:54]
<Yunohost Git/Infra notifications> [yunohost] alexAubin deleted branch 11.1.1.1
[14:09:21]
<Yunohost Git/Infra notifications> [yunohost] alexAubin deleted branch fix-yunohost-api-restart
[14:09:47]
<Yunohost Git/Infra notifications> [yunohost] Salamandar [commented](https://github.com/YunoHost/yunohost/pull/1717#issuecomment-2133564922) on [issue #1717](https://github.com/YunoHost/yunohost/pull/1717) Create versionned directories of the helpers: I think I prefer the first suggestion, because its less about the format and more about "dependencies" like yunohost ve...
[14:11:07]
<Yunohost Git/Infra notifications> [yunohost] Salamandar edited [pull request #1717](https://github.com/YunoHost/yunohost/pull/1717): Create versionned directories of the helpers
[14:13:00]
<Aleks (he/him/il/lui)> can i replace `YNH_APP_HELPERS_VERSION` by `YNH_HELPERS_VERSION` ? because these helpers are also used by the core in fact
[14:13:10]
<Aleks (he/him/il/lui)> (eg regenconf)
[14:17:54]
<Salamandar> ah yeis
[14:17:56]
<Salamandar> agreed
[14:24:43]
<Aleks (he/him/il/lui)> i'll also add the logic in `ynh_make_env_for_app_something` to auto add the variable with the info from the manifest or fallback to packaging version
[14:48:30]
<Aleks (he/him/il/lui)> sooo hmmm now we should test it but meh because it's made from a fork it doesnt trigger the pipeline
[14:48:43]
<Aleks (he/him/il/lui)> yolo i guess
[14:49:17]
<Yunohost Git/Infra notifications> [yunohost] alexAubin pushed 5 commits to dev ([6aa9d0537284...c1b3c3f78557](https://github.com/YunoHost/yunohost/compare/6aa9d0537284...c1b3c3f78557))
[14:49:17]
<Yunohost Git/Infra notifications> [yunohost] alexAubin merged [pull request #1717](https://github.com/YunoHost/yunohost/pull/1717): Create versionned directories of the helpers
[14:49:24]
<Yunohost Git/Infra notifications> [yunohost/dev] YNH_APP_HELPERS_DIR -> YNH_HELPERS_DIR - Alexandre Aubin
[14:49:45]
<Salamandar> > <@Alekswag:matrix.org> sooo hmmm now we should test it but meh because it's made from a fork it doesnt trigger the pipeline
yeah that's not great from outside forks :(
[14:49:45]
<Yunohost Git/Infra notifications> [yunohost] github-actions[bot] opened [pull request #1852](https://github.com/YunoHost/yunohost/pull/1852): Format Python code with Black
[14:49:45]
<Yunohost Git/Infra notifications> [yunohost] github-actions[bot] created new branch actions/black
[14:49:45]
<Yunohost Git/Infra notifications> [yunohost] github-actions[bot] pushed 1 commit to actions/black: :art: Format Python code with Black ([68db59a2](https://github.com/YunoHost/yunohost/commit/68db59a28ef96c9c59f257823554e93ac6d1aee6))
[14:50:57]
<Yunohost Git/Infra notifications> [issues] alexAubin edited [issue #2403](https://github.com/YunoHost/issues/issues/2403): Helpers 2.1 wishlist
[14:52:22]
<Aleks (he/him/il/lui)> so to me https://github.com/YunoHost/yunohost/pull/1720 really feels like 2.2 or 3.0 version because of all the radical naming sceme change which looks cool but at the same time it's kinda big and will break some stuff in the package linter etc because it greps ynh\_stuff etc
[14:53:23]
<Aleks (he/him/il/lui)> i'd really like instead if we can focus on cleaning up the mess : backporting the changes from bookworm to remove legacy bullshit, remove the legacy mode of getopts, cleaning up packaging-v1 related stuff etc
[14:53:39]
<Aleks (he/him/il/lui)> on the other hand this kinda duplicates the helper codes so hmf
[14:56:25]
<Yunohost Git/Infra notifications> [yunohost] Salamandar created new branch helpers_2.1
[14:56:30]
<Yunohost Git/Infra notifications> [yunohost] Salamandar pushed 2 commits to helpers_2.1 ([00971d5cb9b5^...a7fbecb20b7a](https://github.com/YunoHost/yunohost/compare/00971d5cb9b5^...a7fbecb20b7a))
[14:57:36]
<Yunohost Git/Infra notifications> [yunohost] Salamandar closed [pull request #1720](https://github.com/YunoHost/yunohost/pull/1720): Draft: Helpers 2.1
[14:57:47]
<Yunohost Git/Infra notifications> [yunohost] alexAubin pushed 1 commit to dev: helpers: we need helpers.v2.d to be a symlink to helpers.v1.d? ([2047d536](https://github.com/YunoHost/yunohost/commit/2047d536be92bd5cb6bc9ec1bf3f24cbc7ae319f))
[14:57:56]
<Yunohost Git/Infra notifications> [yunohost] Salamandar pushed 1 commit to helpersv2: Add new versions of helpers. Based on bash-modules. ([8b9a0253](https://github.com/YunoHost/yunohost/commit/8b9a02539e1953f668ff3ee37442789c4f25887f))
[14:58:00]
<Yunohost Git/Infra notifications> [yunohost] Salamandar created new branch helpersv2
[14:58:08]
<Aleks (he/him/il/lui)> > <@yunohostinfra:matrix.org> [yunohost] Salamandar closed [pull request #1720](https://github.com/YunoHost/yunohost/pull/1720): Draft: Helpers 2.1
we should keep digging it tho
[14:58:11]
<Yunohost Git/Infra notifications> [yunohost] github-actions[bot] pushed 1 commit to actions/black: :art: Format Python code with Black ([e3282f23](https://github.com/YunoHost/yunohost/commit/e3282f2329381a1de2c9c193ea7fab0750e5d32f))
[14:58:23]
<Yunohost Git/Infra notifications> [yunohost] Salamandar opened [pull request #1853](https://github.com/YunoHost/yunohost/pull/1853): [WIP] Add new versions of helpers. Based on bash-modules.
[14:58:25]
<Salamandar> ye ye
[14:58:34]
<Salamandar> i just pushed the branch to the yunohost org instead of my fork
[14:58:48]
<Yunohost Git/Infra notifications> [yunohost] alexAubin merged [pull request #1852](https://github.com/YunoHost/yunohost/pull/1852): Format Python code with Black
[14:58:49]
<Yunohost Git/Infra notifications> [yunohost] alexAubin pushed 2 commits to dev ([2047d536be92...55cfc46cdd73](https://github.com/YunoHost/yunohost/compare/2047d536be92...55cfc46cdd73))
[14:58:57]
<Yunohost Git/Infra notifications> [yunohost/dev] :art: Format Python code with Black - alexAubin
[14:58:58]
<Yunohost Git/Infra notifications> [yunohost] alexAubin deleted branch actions/black
[14:59:24]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#1307308779](https://gitlab.com/YunoHost/yunohost/-/pipelines/1307308779) failed on branch
[14:59:33]
<Aleks (he/him/il/lui)> uuuh
[14:59:33]
<Aleks (he/him/il/lui)> `Helpers are not available in version 'init'.`
[15:00:00]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#1307308796](https://gitlab.com/YunoHost/yunohost/-/pipelines/1307308796) failed on branch dev, helpersv2
[15:00:20]
<Aleks (he/him/il/lui)> parsing `$1` doesn't work because helpers are sources using ... `source` so $1 is the arg from the "real" script ?
[15:00:31]
<Yunohost Git/Infra notifications> 🏗️ Starting build for yunohost/11.2.12+202405271500 for bullseye/unstable/all ...
[15:02:26]
<Yunohost Git/Infra notifications> ✔️ Completed build for yunohost/11.2.12+202405271500 for bullseye/unstable/all.
[15:07:10]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#1307317010](https://gitlab.com/YunoHost/yunohost/-/pipelines/1307317010) failed on branch dev
[15:11:29]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#1307317017](https://gitlab.com/YunoHost/yunohost/-/pipelines/1307317017) failed on branch helpersv2
[15:12:37]
<Aleks (he/him/il/lui)> #AleksBrokeEverythingAgain
[15:21:59]
<Salamandar> > Helpers are not available in version
where is that coming from ?
[15:22:12]
<Salamandar> ah init
[15:22:13]
<Salamandar> why init
[15:23:52]
<Salamandar> ah that's my fault i guess
[15:24:32]
<Salamandar> huuu
[15:24:54]
<Salamandar> if no arg is passed to `source helpers` then the main script arguments are "passed"
[15:24:58]
<Salamandar> so uh
[15:25:00]
<Salamandar> pr incoming
[15:27:12]
<Yunohost Git/Infra notifications> [yunohost] Salamandar pushed 1 commit to fix_helpers: Fix helpers: actually that might be a bad idea to read arguments as if source helpers has no arguments passed, @ is t... ([af2a5601](https://github.com/YunoHost/yunohost/commit/af2a56012ff49f41ff7bf1ed2acb16fc546af6b0))
[15:27:13]
<Yunohost Git/Infra notifications> [yunohost] Salamandar created new branch fix_helpers
[15:27:25]
<Salamandar> https://github.com/YunoHost/yunohost/pull/1854
[15:27:26]
<Yunohost Git/Infra notifications> [yunohost] Salamandar opened [pull request #1854](https://github.com/YunoHost/yunohost/pull/1854): Fix helpers: actually that might be a bad idea to read arguments
[15:28:31]
<Yunohost Git/Infra notifications> [yunohost] Salamandar deleted branch helpers
[15:28:33]
<Yunohost Git/Infra notifications> [yunohost] Salamandar deleted branch helpers_2.1
[15:28:52]
<Yunohost Git/Infra notifications> [yunohost] Salamandar deleted branch fix_app_upgradable
[15:29:05]
<Yunohost Git/Infra notifications> [yunohost] Salamandar deleted branch autoblacks
[15:29:09]
<Yunohost Git/Infra notifications> [yunohost] alexAubin merged [pull request #1854](https://github.com/YunoHost/yunohost/pull/1854): Fix helpers: actually that might be a bad idea to read arguments
[15:29:11]
<Yunohost Git/Infra notifications> [yunohost] alexAubin pushed 2 commits to dev ([55cfc46cdd73...06dc3da3f409](https://github.com/YunoHost/yunohost/compare/55cfc46cdd73...06dc3da3f409))
[15:29:17]
<Yunohost Git/Infra notifications> [yunohost/dev] Fix helpers: actually that might be a bad idea to read arguments as if source helpers has no arguments passed, @ is t... - Félix Piédallu
[15:29:21]
<Yunohost Git/Infra notifications> [yunohost] alexAubin deleted branch fix_helpers
[15:30:21]
<Yunohost Git/Infra notifications> 🏗️ Starting build for yunohost/11.2.12+202405271530 for bullseye/unstable/all ...
[15:31:53]
<Yunohost Git/Infra notifications> ✔️ Completed build for yunohost/11.2.12+202405271530 for bullseye/unstable/all.
[15:57:44]
<Yunohost Git/Infra notifications> [issues] Salamandar [commented](https://github.com/YunoHost/issues/issues/2403#issuecomment-2133757949) on [issue #2403](https://github.com/YunoHost/issues/issues/2403) Helpers 2.1 wishlist: About app settings. What is the use of if [[ key =~ (unprotected|protected|skipped)_ ]] then found at htt...
[15:59:21]
<Yunohost Git/Infra notifications> [issues] alexAubin [commented](https://github.com/YunoHost/issues/issues/2403#issuecomment-2133762410) on [issue #2403](https://github.com/YunoHost/issues/issues/2403) Helpers 2.1 wishlist: this is legacy stuff from the old permission system, it was cleaned up in bookworm Im working on a PR to backport most...
[16:23:25]
<selfhoster1312> reading the new bookworm config panel... why do we want bools with custom output?
https://github.com/YunoHost/yunohost/blob/bookworm/src/utils/form.py#L994
[16:23:47]
<selfhoster1312> i was curious why yunohost settings get --full now has `yes` and `no` fields in the options ^^
[16:29:36]
<Yunohost Git/Infra notifications> [issues] alexAubin edited [issue #2403](https://github.com/YunoHost/issues/issues/2403): Helpers 2.1 wishlist
[16:30:34]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#1307355612](https://gitlab.com/YunoHost/yunohost/-/pipelines/1307355612) failed on branch dev
[16:42:31]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#1307366494](https://gitlab.com/YunoHost/yunohost/-/pipelines/1307366494) failed on branch dev
[16:48:57]
<Yunohost Git/Infra notifications> [yunohost] alexAubin created new branch helpers-2.1
[16:48:57]
<Yunohost Git/Infra notifications> [yunohost] alexAubin pushed 6 commits to helpers-2.1 ([204800e87817^...0915a6a70b61](https://github.com/YunoHost/yunohost/compare/204800e87817^...0915a6a70b61))
[16:49:02]
<Yunohost Git/Infra notifications> [yunohost/helpers-2.1] helpers 2.1: remove unecessary --app=app in internals ynh_app_setting_get/set calls - Alexandre Aubin
[16:53:41]
<Yunohost Git/Infra notifications> [yunohost] alexAubin opened [pull request #1855](https://github.com/YunoHost/yunohost/pull/1855): Helpers 2.1
[16:58:50]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#1307452381](https://gitlab.com/YunoHost/yunohost/-/pipelines/1307452381) failed on branch helpers-2.1
[17:18:53]
<selfhoster1312> https://xmpp-upload.kl.netlib.re/upload/0iveYmcW220333/cc6c8482350a58b5997fb3d33723966f.jpg
[17:19:19]
<selfhoster1312> it seems bookworm config panel is even slower than before?!
[17:19:25]
<selfhoster1312> https://xmpp-upload.kl.netlib.re/upload/x6E4wJ3m4DB0365/3549f839-45ae-4ac9-b614-8ff6c669cdaf.png
[17:20:18]
<selfhoster1312> other commands are like 10-50ms slower so refactoring elsewhere doesn't explain why settings are 500ms slower u_u
[17:28:37]
<Émy - OniriCorpe> it's fine, `yunohost user` is faster 😌
[17:29:09]
<selfhoster1312> yes, nice :)
[17:29:38]
<selfhoster1312> i think i can make user_info faster in python, fyi... maybe not by much
[17:30:40]
<selfhoster1312> doveadm CLI is super slow because it connects to the dovecot socket... manual parsing is like 10x faster (at least in rust) -> https://github.com/selfhoster1312/yunohost-rs/commit/37f786971e6469cd577b15a774daaa76dce0f0b8
[17:31:16]
<selfhoster1312> the file is not hard it's like:
```
HEADER
SIZE COUNT
SIZE COUNT
```
just add all the sizes (skipping first header line) and divide by 1024 and you got the mail dir size :)
[17:51:17]
<selfhoster1312> hmm it appears more or less negligible (~0.5s out of 11s on the raspberry pi)
[19:43:19]
<Yunohost Git/Infra notifications> [issues] Salamandar [commented](https://github.com/YunoHost/issues/issues/2403#issuecomment-2133980338) on [issue #2403](https://github.com/YunoHost/issues/issues/2403) Helpers 2.1 wishlist: Fix the ynh_secure_remove clusterfuck about symlinks https://github.com/YunoHost/yunohost/pull/1716
[21:48:43]
<Yunohost Git/Infra notifications> [yunohost] alexAubin pushed 16 commits to helpers-2.1 ([0915a6a70b61...346f42643b15](https://github.com/YunoHost/yunohost/compare/0915a6a70b61...346f42643b15))
[21:48:48]
<Yunohost Git/Infra notifications> [yunohost/helpers-2.1] helpers 2.1: remove legacy ynh_legacy_permissions_exists and ynh_legacy_permissions_delete_all - Alexandre Aubin
[21:53:10]
<Yunohost Git/Infra notifications> [yunohost] alexAubin edited [pull request #1855](https://github.com/YunoHost/yunohost/pull/1855): Helpers 2.1
[21:55:35]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#1307643399](https://gitlab.com/YunoHost/yunohost/-/pipelines/1307643399) failed on branch helpers-2.1
[22:01:24]
<Yunohost Git/Infra notifications> [yunohost] alexAubin edited [pull request #1855](https://github.com/YunoHost/yunohost/pull/1855): Helpers 2.1
[22:02:52]
<Yunohost Git/Infra notifications> [yunohost/helpers-2.1] Fix helpers: actually that might be a bad idea to read arguments as if source helpers has no arguments passed, @ is t... - Félix Piédallu
[22:02:52]
<Yunohost Git/Infra notifications> [yunohost] alexAubin pushed 3 commits to helpers-2.1 ([346f42643b15...6835a664c79e](https://github.com/YunoHost/yunohost/compare/346f42643b15...6835a664c79e))
[22:02:57]
<Yunohost Git/Infra notifications> [yunohost/helpers-2.1] Merge pull request #1854 from YunoHost/fix_helpers Fix helpers: actually that might be a bad idea to read arguments - Alexandre Aubin
[22:09:14]
<Yunohost Git/Infra notifications> [yunohost] alexAubin pushed 1 commit to helpers-2.1: helpers 2.1: ynh_if_upgrading_from_... -> ynh_app_upgrading_from_... ([80f07a99](https://github.com/YunoHost/yunohost/commit/80f07a9974e89445cdcaada1bb962d7e7f68173b))
[22:09:31]
<Yunohost Git/Infra notifications> [yunohost] alexAubin edited [pull request #1855](https://github.com/YunoHost/yunohost/pull/1855): Helpers 2.1
[22:12:39]
<Yunohost Git/Infra notifications> [yunohost] ✖️ Pipeline [#1307653826](https://gitlab.com/YunoHost/yunohost/-/pipelines/1307653826) canceled on branch helpers-2.1
[22:39:23]
<Yunohost Git/Infra notifications> [yunohost] Josue-T pushed 1 commit to add-jinja-support-to-ynh-add-config: Update doc about helper ynh_add_config ([4a9a3ba1](https://github.com/YunoHost/yunohost/commit/4a9a3ba138373a474d30fcb7d60df39b25d2cbb4))
[22:40:29]
<Yunohost Git/Infra notifications> [yunohost] Josue-T approved [pull request #1851](https://github.com/YunoHost/yunohost/pull/1851#pullrequestreview-2081509668) helpers: Add a --jinja option to ynh_add_config: Pushed some improvements on doc side. Tested on one of my apps it look good. Thanks
[22:46:21]
<Yunohost Git/Infra notifications> [pepettes] OniriCorpe edited [issue #11](https://github.com/YunoHost/pepettes/issues/11): Clarifying who receives donations
[23:14:06]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#1307657471](https://gitlab.com/YunoHost/yunohost/-/pipelines/1307657471) failed on branch helpers-2.1