[07:03:15]
<Yunohost Git/Infra notifications> [yunohost] zamentur pushed 1 commit to swap: [enh] Configure swappiness ([beff899e](https://github.com/YunoHost/yunohost/commit/beff899e5ff4940598def317d1ab8726c95f42b5))
[07:09:33]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/1858#issuecomment-2141362621) on [issue #1858](https://github.com/YunoHost/yunohost/pull/1858) Implement config panel for swap management: I have had a swappiness configuration to avoid to write on ssd if not necessary (in order to extend its service life). ...
[07:09:44]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/1858#issuecomment-2141362621) on [issue #1858](https://github.com/YunoHost/yunohost/pull/1858) Implement config panel for swap management: I had a swappiness configuration to avoid to write on ssd if not necessary (in order to extend its service life). I won...
[08:06:25]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#1312899906](https://gitlab.com/YunoHost/yunohost/-/pipelines/1312899906) failed on branch swap
[08:08:30]
<Salamandar> TBH i think i will write some official helper that does that
[08:08:43]
<Salamandar> then with packaging v3 we will remove this helper and move the logic to the core :p
[08:24:39]
<Salamandar> @Alekswag:matrix.org I "kinda" like the few apps that have a `ynh_maintenance_mode_OFF/ON` helper to put a "app under maintenance" placeholder in nginx, it would be nice to make that in the core instead
[08:25:57]
<Salamandar> For the few apps that won't want that (not sure there will be though), we could add a `maintenance_503_page = False` in the manifest `integration` section
[08:27:26]
<Salamandar> the only issue is that I could see it interfere with `ynh_local_curl`
[08:27:30]
<Aleks (he/him/il/lui)> hmpf i don't know i'd just like to have a consistent strategy, either we try to generalize something, either we remove the few apps that do this because meh, why those and not the others
[08:27:44]
<Salamandar> ah yes agreed why those and not the others
[08:28:26]
<tituspijean> > <@Salamandar:matrix.org> @Alekswag:matrix.org I "kinda" like the few apps that have a `ynh_maintenance_mode_OFF/ON` helper to put a "app under maintenance" placeholder in nginx, it would be nice to make that in the core instead
cf. https://github.com/YunoHost/issues/issues/2045
[08:28:27]
<Aleks (he/him/il/lui)> to me it doesnt feel like the biggest issue ever to have this maintenance mode, it's not like upgrade leads to problem because people interact with the app while it's upgrading or something
[08:28:50]
<Salamandar> > because people interact with the app while it's upgrading or something
Not for apps with a systemd service that is stopped/restarted
[08:29:34]
<Salamandar> And for other apps (php), i always found it fishy that nginx/php continues to serve a install_dir that is currently being modified… that's asking for problems
[08:30:05]
<Salamandar> i mean, i'm not really concerned about huge issues because no one complained already
[08:30:09]
<Salamandar> but eh \shrug
[08:32:26]
<Aleks (he/him/il/lui)> to me we should just get rid of this helper in the 7ish app that use it, and either implement something declaratively in the manifest like mainteance_during_upgrade = True or whatever, but please no more stupid helpers for unecessary stuff idk
[08:32:50]
<Aleks (he/him/il/lui)> or at least we should have a clear rationale
[08:33:56]
<Aleks (he/him/il/lui)> or packaging v3 could handle this like "at the beginning of the upgrade, if the app has an nginx conf, it gets replaced with the maintenance mode"
[08:34:08]
<Aleks (he/him/il/lui)> but yeah that's going to interfere with local_curl etc
[08:34:29]
<Aleks (he/him/il/lui)> to me it feels like this whole things tries to fix an issue which doesn't exists so zzzz
[08:36:04]
<Salamandar> ha ha
[08:36:08]
<Salamandar> yeah i understand your position
[08:36:13]
<Salamandar> can be in the wishlist
[08:37:23]
<Yunohost Git/Infra notifications> [issues] Salamandar [commented](https://github.com/YunoHost/issues/issues/2136#issuecomment-2141504866) on [issue #2136](https://github.com/YunoHost/issues/issues/2136) Packaging v3 wishlist: Have a "under maintenance" 503 page during upgrade / change_url like some apps do (discourse wordpress etherpad lutim ac...
[09:36:40]
<Yunohost Git/Infra notifications> [yunohost] Salamandar pushed 1 commit to helper_swap: Add swap helpers. This provides yunohost 2 things: * Remove duplication and centralize code and bugfixes for easier mai... ([dae76795](https://github.com/YunoHost/yunohost/commit/dae767959919ffc9b96e9975d02e6074c10ee112))
[09:36:41]
<Yunohost Git/Infra notifications> [yunohost] Salamandar created new branch helper_swap
[09:37:31]
<Yunohost Git/Infra notifications> [yunohost] Salamandar opened [pull request #1859](https://github.com/YunoHost/yunohost/pull/1859): Add swap helpers.
[10:15:06]
<Yunohost Git/Infra notifications> [yunohost] tituspijean [commented](https://github.com/YunoHost/yunohost/pull/1859#issuecomment-2141704876) on [issue #1859](https://github.com/YunoHost/yunohost/pull/1859) Add swap helpers.: Conflicts with https://github.com/YunoHost/yunohost/pull/1858 ?
[10:18:05]
<Yunohost Git/Infra notifications> [yunohost] tituspijean [commented](https://github.com/YunoHost/yunohost/pull/1858#issuecomment-2141362621) on [issue #1858](https://github.com/YunoHost/yunohost/pull/1858) Implement config panel for swap management: I add a swappiness configuration to avoid to write on ssd if not necessary (in order to extend its service life). I won...
[10:37:24]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#1313107584](https://gitlab.com/YunoHost/yunohost/-/pipelines/1313107584) failed on branch helper_swap
[11:02:22]
<chrichri ⚡> > <@Salamandar:matrix.org> the only issue is that I could see it interfere with ynh_local_curl
Couldn't that be extended to connect by default to the un-proxied port? That would make the 'briefly change the permission to visitor'-hack obsolete, too.
[11:10:15]
<Salamandar> @titus:pijean.ovh i don't really understand the point of these helpers in your PR
[11:10:23]
<Salamandar> what i mean is
[11:10:54]
<Salamandar> The helper called by the app scripts could instead set the global yunohost swap setting, right ?
[11:11:11]
<Aleks (he/him/il/lui)> > <@chrichri:ween.de> Couldn't that be extended to connect by default to the un-proxied port? That would make the 'briefly change the permission to visitor'-hack obsolete, too.
maybe for reverse-proxied apps, but not for php apps i suppose
[11:19:01]
<Yunohost Git/Infra notifications> [yunohost] Salamandar edited review [pull request #1858](https://github.com/YunoHost/yunohost/pull/1858#pullrequestreview-2090583488): Implement config panel for swap management
[11:19:01]
<Yunohost Git/Infra notifications> [yunohost] Salamandar [commented](https://github.com/YunoHost/yunohost/pull/1858#discussion_r1622269342) on pull request #1858 Implement config panel for swap management: Thats really dangerous. Lets imagine this situation: * RAM is 1GB, usage 900MB, Swapfile is 1GB, usage 500MB * you wan...
[11:19:01]
<Yunohost Git/Infra notifications> [yunohost] Salamandar [commented](https://github.com/YunoHost/yunohost/pull/1858#discussion_r1622270537) on pull request #1858 Implement config panel for swap management: I completely rewrote those helpers, see https://github.com/YunoHost/yunohost/pull/1859, Ill change my PRs target branc...
[11:19:03]
<Yunohost Git/Infra notifications> [yunohost] Salamandar changes_requested [pull request #1858](https://github.com/YunoHost/yunohost/pull/1858#pullrequestreview-2090583488) Implement config panel for swap management
[11:22:01]
<Yunohost Git/Infra notifications> [yunohost] Salamandar [commented](https://github.com/YunoHost/yunohost/pull/1858#discussion_r1622279728) on pull request #1858 Implement config panel for swap management: Two better solutions would be : * just create a second swap file of size = difference (in my example, 2GB(total) - 1GB(e...
[11:23:20]
<Yunohost Git/Infra notifications> [yunohost] Salamandar [commented](https://github.com/YunoHost/yunohost/pull/1858#issuecomment-2141822942) on [issue #1858](https://github.com/YunoHost/yunohost/pull/1858) Implement config panel for swap management: All in all… I would prefer if swap file creation was NOT linked to apps requesting swap especially, but rather to the RA...
[14:05:52]
<Yunohost Git/Infra notifications> [yunohost] tituspijean [commented](https://github.com/YunoHost/yunohost/pull/1858#discussion_r1622477184) on pull request #1858 Implement config panel for swap management: Ah good, thank you for giving some thoughts into this. :) I had added a very lazy "Beware, if you reduce its current siz...
[14:07:27]
<Yunohost Git/Infra notifications> [yunohost] tituspijean [commented](https://github.com/YunoHost/yunohost/pull/1858#discussion_r1622480532) on pull request #1858 Implement config panel for swap management: yunohost settings set got me in an infinite config panel loop last night, we need to be careful with calling hooks fro...
[14:09:16]
<Yunohost Git/Infra notifications> [yunohost] tituspijean [commented](https://github.com/YunoHost/yunohost/pull/1858#issuecomment-2142289051) on [issue #1858](https://github.com/YunoHost/yunohost/pull/1858) Implement config panel for swap management: I completely agree, thats why this is a system config panel, not a general apps config panel. Maybe we could add a warn...
[14:09:25]
<Yunohost Git/Infra notifications> [yunohost] tituspijean [commented](https://github.com/YunoHost/yunohost/pull/1858#discussion_r1622483049) on pull request #1858 Implement config panel for swap management: Great :)
[14:18:59]
<Yunohost Git/Infra notifications> [yunohost] Salamandar [commented](https://github.com/YunoHost/yunohost/pull/1858#issuecomment-2142324556) on [issue #1858](https://github.com/YunoHost/yunohost/pull/1858) Implement config panel for swap management: > I completely agree, thats why this is a system config panel, not a general apps config panel. Maybe we could add a wa...
[14:33:02]
<Yunohost Git/Infra notifications> [yunohost] Salamandar pushed 7 commits to swap ([beff899e5ff4...5c400169aff9](https://github.com/YunoHost/yunohost/compare/beff899e5ff4...5c400169aff9))
[14:33:32]
<Yunohost Git/Infra notifications> [yunohost] Salamandar edited [pull request #1859](https://github.com/YunoHost/yunohost/pull/1859): Add swap helpers.
[14:34:46]
<Yunohost Git/Infra notifications> [yunohost] Salamandar closed [pull request #1859](https://github.com/YunoHost/yunohost/pull/1859): Add swap helpers.
[14:35:03]
<Salamandar> woopsies pushed on the wrong branch, reverted
[14:35:37]
<Yunohost Git/Infra notifications> [yunohost] Salamandar reopened [pull request #1859](https://github.com/YunoHost/yunohost/pull/1859): Add swap helpers.
[14:43:06]
<Yunohost Git/Infra notifications> [yunohost] ✖️ Pipeline [#1313511543](https://gitlab.com/YunoHost/yunohost/-/pipelines/1313511543) canceled on branch helper_swap
[15:44:50]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#1313528330](https://gitlab.com/YunoHost/yunohost/-/pipelines/1313528330) failed on branch helper_swap
[15:49:36]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#1313528389](https://gitlab.com/YunoHost/yunohost/-/pipelines/1313528389) failed on branch helper_swap, swap
[15:55:52]
<ChriChri> > <@Alekswag:matrix.org> maybe for reverse-proxied apps, but not for php apps i suppose
In my ynh_local_curl I already wrote a TODO to look into getting rid of the permission change. Good to know that'd be needed for apps running directly in nginx. Maybe the ynh_local_curl could login to use an app or nginx could be configured to allow certain requests (no idea atm about the spec, something like localhost and ???)?
[16:15:56]
<Aleks (he/him/il/lui)> related : https://github.com/YunoHost/SSOwat/pull/181 but for some reason i never moved forward with it and now the sso cookie mechanism got rewritten
[16:31:51]
<tituspijean> I hope my answer on the PR was clear? :) I want to move the swap management away from the apps and into the core.
I think we worked on the same helpers a few hours apart. :p
[17:19:08]
<Salamandar> > <@titus:pijean.ovh> I hope my answer on the PR was clear? :) I want to move the swap management away from the apps and into the core.
> I think we worked on the same helpers a few hours apart. :p
yeah agreed on the 2 sentences ah ah
[17:23:31]
<Salamandar> i would agree on 1 thing : on the app install page, if ram required > available then show a warning (already done) + a button that redirects to the admin page to handle the swap
[17:24:13]
<Salamandar> maybe an additional key in the manifest for apps REALLY wanting swap, to ALWAYS show the button even if ram is sufficient
[17:25:02]
<Salamandar> anyways if swap is handled by the core, why implement this with helpers and not python ?
[17:25:29]
<Aleks (he/him/il/lui)> the "worst" case should be apps *temporarily* adding swap eg to allow for builds that take a stupid amount of ram to build static js/hmtl/css assets because we walked on the moon with 32kb of ram but writing .html files takes 4GB for some reason
[17:26:12]
<Aleks (he/him/il/lui)> sorry, 4KB* of RAM, 32KB hard disk
[17:29:39]
<chrichri ⚡> > <@Alekswag:matrix.org> related : https://github.com/YunoHost/SSOwat/pull/181 but for some reason i never moved forward with it and now the sso cookie mechanism got rewritten
What is the status of https://github.com/YunoHost/yunohost/pull/1857 from your point of view? If it could be accepted (sorry to say, along with the however improved/fixed version of https://github.com/YunoHost/yunohost/pull/1856) I could integrate it there for helpers v1.
[17:30:35]
<Aleks (he/him/il/lui)> merf i need to sit down and think about it but reading the code of the getopts is like "urhggrhj"
[17:32:01]
<Aleks (he/him/il/lui)> and also i'd like to kill the "legacy"-that-is-10-years-old positional arg mode (cf the PR about helpers 2.1) and Salamandar has its other lib with new syntax which seems more convenient but on the other hand is more long term so ugggh idk wat we do
[17:41:00]
<Salamandar> ye but apollo did not serve nodejs files eh
[17:41:36]
<Salamandar> > <@Alekswag:matrix.org> and also i'd like to kill the "legacy"-that-is-10-years-old positional arg mode (cf the PR about helpers 2.1) and Salamandar has its other lib with new syntax which seems more convenient but on the other hand is more long term so ugggh idk wat we do
not so long term, just gotta rewrite everything ™
[17:56:55]
<chrichri ⚡> > <@Alekswag:matrix.org> merf i need to sit down and think about it but reading the code of the getopts is like "urhggrhj"
Yes true. I already Bad ideas how to refactor it, but it'd take time (again). If it'd be worth it (my only goal has been options to use in ynh_local_curl) I might try it...
[21:59:10]
<Yunohost Git/Infra notifications> tomtaozhou forked yunohost to [tomtaozhou/yunohost](https://github.com/tomtaozhou/yunohost)
[22:01:19]
<Yunohost Git/Infra notifications> [issues] ndx1905-github labeled :space_invader: bug on [issue #2409](https://github.com/YunoHost/issues/issues/2409): rspamd shipped with ynh crashes with SEGFAULT - fix available
[22:01:20]
<Yunohost Git/Infra notifications> [issues] ndx1905-github opened [issue #2409](https://github.com/YunoHost/issues/issues/2409): rspamd shipped with ynh crashes with SEGFAULT - fix available