[02:32:54]
<Yunohost Git/Infra notifications> [yunohost] alexAubin edited [pull request #1855](https://github.com/YunoHost/yunohost/pull/1855): Helpers 2.1
[02:32:55]
<Yunohost Git/Infra notifications> [yunohost] alexAubin pushed 1 commit to helpers-2.1: helpers2.1: rework the apt helper: effectivement call them ynh_install/remove_apt_dependencies (instead of app_depend... ([8f807098](https://github.com/YunoHost/yunohost/commit/8f8070983d78b26fa387f21ee55d282b9cb77e6f))
[02:38:07]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#1338122462](https://gitlab.com/YunoHost/yunohost/-/pipelines/1338122462) failed on branch helpers-2.1
[08:44:36]
<Yunohost Git/Infra notifications> [yunohost] Salamandar created new branch helpers-2.1-copy-from-v1
[08:44:58]
<Yunohost Git/Infra notifications> [yunohost] Salamandar edited [pull request #1855](https://github.com/YunoHost/yunohost/pull/1855): Helpers 2.1
[08:47:25]
<Yunohost Git/Infra notifications> [yunohost] Salamandar edited [pull request #1855](https://github.com/YunoHost/yunohost/pull/1855): Helpers 2.1
[12:52:07]
<Yunohost Git/Infra notifications> [yunohost] Salamandar [commented](https://github.com/YunoHost/yunohost/pull/1855#discussion_r1646108180) on pull request #1855 Helpers 2.1: > --is_big behavior is replaced by checking if the path is data_dir (or a child) or /var/log/app Yeah that might be a...
[12:52:26]
<Yunohost Git/Infra notifications> [yunohost] Salamandar [commented](https://github.com/YunoHost/yunohost/pull/1855#discussion_r1645706653) on pull request #1855 Helpers 2.1: suggestion mysqlshow | grep -q "^| database *|"
[12:52:40]
<Yunohost Git/Infra notifications> [yunohost] Salamandar [commented](https://github.com/YunoHost/yunohost/pull/1855#discussion_r1646123552) on pull request #1855 Helpers 2.1: Please use patches/{src_id}/*.patch instead, as by default git names patch files with a numbering prefix.
[12:53:06]
<Yunohost Git/Infra notifications> [yunohost] Salamandar approved [pull request #1855](https://github.com/YunoHost/yunohost/pull/1855#pullrequestreview-2127536269) Helpers 2.1
[12:53:14]
<Yunohost Git/Infra notifications> [yunohost] Salamandar [commented](https://github.com/YunoHost/yunohost/pull/1855#discussion_r1645813464) on pull request #1855 Helpers 2.1: getopts ?
[12:53:20]
<Yunohost Git/Infra notifications> [yunohost] Salamandar [commented](https://github.com/YunoHost/yunohost/pull/1855#discussion_r1645739640) on pull request #1855 Helpers 2.1: TODO maybe : stop downloading composer.phar to the workdir, store it in /opt/yunohost or equivalent instead.
[12:53:21]
<Yunohost Git/Infra notifications> [yunohost] Salamandar [commented](https://github.com/YunoHost/yunohost/pull/1855#discussion_r1645838130) on pull request #1855 Helpers 2.1: TBH I would like to see full_replace as the default, and disabled by something like --merge-with-existing or --unclea...
[12:53:23]
<Yunohost Git/Infra notifications> [yunohost] Salamandar edited review [pull request #1855](https://github.com/YunoHost/yunohost/pull/1855#pullrequestreview-2127536269): Helpers 2.1
[12:53:24]
<Yunohost Git/Infra notifications> [yunohost] Salamandar [commented](https://github.com/YunoHost/yunohost/pull/1855#discussion_r1646109385) on pull request #1855 Helpers 2.1: Also packagingv3™ but those directories could be declared in manifest.
[12:53:25]
<Yunohost Git/Infra notifications> [yunohost] Salamandar [commented](https://github.com/YunoHost/yunohost/pull/1855#discussion_r1645809866) on pull request #1855 Helpers 2.1: Maybe yunohost could depend on yq that can parse/output json, yaml, toml (its just a wrapper over jq so 100% compat...
[12:53:25]
<Yunohost Git/Infra notifications> [yunohost] alexAubin [commented](https://github.com/YunoHost/yunohost/pull/1855#discussion_r1646153893) on pull request #1855 Helpers 2.1: suggestion mysqlshow | grep -qE "^|\s+database\s+|"
[12:53:26]
<Yunohost Git/Infra notifications> [yunohost] alexAubin [commented](https://github.com/YunoHost/yunohost/pull/1855#discussion_r1646155435) on pull request #1855 Helpers 2.1: hmmmmaybe but not every app use the same composer version ... though i dont know what are the implications or if we sho...
[12:55:25]
<Yunohost Git/Infra notifications> [yunohost] Salamandar pushed 1 commit to helpers-2.1: helpers-2.1: Fix mysqlshow regex to list existing databases Co-authored-by: Alexandre Aubin <4533074+alexAubin@users.no... ([ec354d44](https://github.com/YunoHost/yunohost/commit/ec354d443ddc4601e473a1613d31f7f327f0f9d1))
[12:55:39]
<Yunohost Git/Infra notifications> [yunohost] alexAubin [commented](https://github.com/YunoHost/yunohost/pull/1855#discussion_r1646158607) on pull request #1855 Helpers 2.1: yeah, only in bookworm tho : https://packages.debian.org/bookworm/yq (or ... backports *spooky noises*)
[12:58:35]
<Yunohost Git/Infra notifications> [yunohost] alexAubin [commented](https://github.com/YunoHost/yunohost/pull/1855#discussion_r1646162707) on pull request #1855 Helpers 2.1: hmmmyeah agreed, just didnt want to go the rabbit hole of patching it but maybe we can still do it
[13:00:44]
<Yunohost Git/Infra notifications> [yunohost] Salamandar created new branch fpu_helpers
[13:00:55]
<Yunohost Git/Infra notifications> [yunohost] Salamandar pushed 1 commit to fpu_helpers: helpers.v2.1/php: Download composer in /opt/yunohost/composer instead of in workdir. ([79d9cba5](https://github.com/YunoHost/yunohost/commit/79d9cba5bc675777ec7164e379523e66372011a5))
[13:01:31]
<Yunohost Git/Infra notifications> [yunohost] Salamandar opened [pull request #1870](https://github.com/YunoHost/yunohost/pull/1870): Helpers v2.1 suggestions
[13:03:32]
<Yunohost Git/Infra notifications> [yunohost] alexAubin [commented](https://github.com/YunoHost/yunohost/pull/1855#discussion_r1646169338) on pull request #1855 Helpers 2.1: >Yeah that might be a bit restrictive and what if data_dir/some_important_config_file.json ? yeah idk, i tried to stud...
[13:05:25]
<Yunohost Git/Infra notifications> [yunohost] alexAubin [commented](https://github.com/YunoHost/yunohost/pull/1855#discussion_r1646172215) on pull request #1855 Helpers 2.1: meh idk im tired of having getopts to parse single args etc...
[13:06:24]
<Yunohost Git/Infra notifications> [yunohost] Salamandar pushed 1 commit to fpu_helpers: helpers.v2.1/utils: ynh_setup_source : replace --full_replace with --no_clean, making cleanup before installation the de... ([091aeb8b](https://github.com/YunoHost/yunohost/commit/091aeb8b50c075b54cd65fe264f790de0e226ab0))
[13:06:45]
<Yunohost Git/Infra notifications> [yunohost] Salamandar edited [pull request #1870](https://github.com/YunoHost/yunohost/pull/1870): Helpers v2.1 suggestions
[13:07:16]
<Aleks (he/him/il/lui)> "no_clean", ew
[13:08:19]
<Aleks (he/him/il/lui)> i like `--merge-with-existing` better, it's more explicit about what it does, though we could add an adjective to discourage people from using it
[13:11:05]
<Aleks (he/him/il/lui)> 368 occurneces of ynh\_setup\_source with no --full\_replace T\_T in upgrade scripts
[13:15:22]
<Salamandar> > <@Alekswag:matrix.org> i like `--merge-with-existing` better, it's more explicit about what it does, though we could add an adjective to discourage people from using it
alrite
[13:15:27]
<Salamandar> > <@Alekswag:matrix.org> 368 occurneces of ynh\_setup\_source with no --full\_replace T\_T in upgrade scripts
yeah…
[13:15:39]
<Salamandar> that's why i did the automated PRs
[13:17:03]
<Yunohost Git/Infra notifications> [yunohost] ✖️ Pipeline [#1338973232](https://gitlab.com/YunoHost/yunohost/-/pipelines/1338973232) canceled on branch fpu_helpers
[13:18:09]
<Yunohost Git/Infra notifications> [yunohost] Salamandar pushed 2 commits to fpu_helpers ([091aeb8b50c0...00ea51a16a05](https://github.com/YunoHost/yunohost/compare/091aeb8b50c0...00ea51a16a05))
[13:18:17]
<Yunohost Git/Infra notifications> [yunohost/fpu_helpers] helpers.v2.1: Add ynh_in_ci to check if the scripts are running in CI or not - Félix Piédallu
[13:18:32]
<Yunohost Git/Infra notifications> [yunohost] Salamandar edited [pull request #1870](https://github.com/YunoHost/yunohost/pull/1870): Helpers v2.1 suggestions
[13:19:09]
<Yunohost Git/Infra notifications> [yunohost] Salamandar pushed 1 commit to fpu_helpers: helpers.v2.1: ynh_setup_source now takes its patches from patches/source_id/*.patch instead of patches/source_id-*.patch ([d0799ff5](https://github.com/YunoHost/yunohost/commit/d0799ff5059879db7fb7aa384d199e7e26991cd9))
[13:20:22]
<Yunohost Git/Infra notifications> [yunohost] Salamandar pushed 1 commit to fpu_helpers: helpers.v2.1: ynh_setup_source now fails in CI if patches cant apply ([d2c7c92e](https://github.com/YunoHost/yunohost/commit/d2c7c92e2e6af2b94a302c84a226586017c5d433))
[13:20:23]
<Yunohost Git/Infra notifications> [yunohost] Salamandar edited [pull request #1870](https://github.com/YunoHost/yunohost/pull/1870): Helpers v2.1 suggestions
[13:20:45]
<Salamandar> @Alekswag:matrix.org my PR is ready
[13:20:51]
<Salamandar> to be read i mean
[13:21:11]
<kayou> https://github.com/YunoHost/yunohost/pull/1870/files#diff-fe0deb906af7aa060ce581e9dc870f481d41ab8df68265a5477d533b852d4935R623-R632
[13:21:30]
<kayou> > usage: ynh_in_ci [--free|--total]
no args ;)
[13:21:51]
<Salamandar> wut
[13:22:44]
<Salamandar> woopsies
[13:23:06]
<Aleks (he/him/il/lui)> can i `s/ynh_in_ci/ynh_during_ci_tests/g` 😬
[13:23:18]
<Aleks (he/him/il/lui)> or `ynh_in_ci_tests` idk
[13:23:35]
<kayou> we don't need a `return` in bash `[ some_cond ]` is the same as `return some_cond `?
[13:23:54]
<Yunohost Git/Infra notifications> [yunohost] Salamandar pushed 3 commits to fpu_helpers ([d2c7c92e2e6a...a245e88dcf2d](https://github.com/YunoHost/yunohost/compare/d2c7c92e2e6a...a245e88dcf2d))
[13:24:02]
<Aleks (he/him/il/lui)> (just to make it less obscure for people that may not know what a ci is)
[13:24:03]
<Salamandar> > <@Alekswag:matrix.org> or `ynh_in_ci_tests` idk
oh yeah i like it
[13:24:05]
<Yunohost Git/Infra notifications> [yunohost/fpu_helpers] helpers.v2.1: Add ynh_in_ci to check if the scripts are running in CI or not - Félix Piédallu
[13:24:07]
<Salamandar> > <@kayou:matrix.org> we don't need a `return` in bash `[ some_cond ]` is the same as `return some_cond `?
i think we don't
[13:24:07]
<Salamandar> but let me check
[13:24:09]
<Aleks (he/him/il/lui)> because bash™
[13:24:09]
<Aleks (he/him/il/lui)> bash returns the return code of the last command inside the function
[13:24:09]
<Salamandar> https://aria.im/_matrix/media/v1/download/matrix.org/HUUtoXgcaUEsanbHEEZjDamg
[13:24:10]
<Aleks (he/him/il/lui)> the most efficient* syntax in town
[13:24:16]
<Aleks (he/him/il/lui)> *ᶠᵒʳ ˢᵒᵐᵉ ᵈᵉᶠⁱⁿⁱᵗⁱᵒⁿ ᵒᶠ ᵉᶠᶠⁱᶜⁱᵉⁿᶜʸ ʷʰⁱᶜʰ ᵈᵒⁿ'ᵗ ⁱⁿᵛᵒˡᵛᵉ ˢᵃᵛⁱⁿᵍ ᵈᵉᵛᵉˡᵒᵖᵉʳˢ ᵐᵉⁿᵗᵃˡ ˢᵃⁿⁱᵗʸ
[13:25:09]
<Salamandar> renamed, pushed
[13:25:22]
<Aleks (he/him/il/lui)> btw for helpers 2.2 i suggest we rename `ynh_install_nodejs` etc to `ynh_i_can_haz_nodejs`
[13:25:39]
<Yunohost Git/Infra notifications> [yunohost] Salamandar pushed 3 commits to fpu_helpers ([a245e88dcf2d...a65b4218b73e](https://github.com/YunoHost/yunohost/compare/a245e88dcf2d...a65b4218b73e))
[13:25:44]
<Yunohost Git/Infra notifications> [yunohost/fpu_helpers] helpers.v2.1: Add ynh_in_ci_tests to check if the scripts are running in CI or not - Félix Piédallu
[13:25:44]
<kayou> > <@Alekswag:matrix.org> *ᶠᵒʳ ˢᵒᵐᵉ ᵈᵉᶠⁱⁿⁱᵗⁱᵒⁿ ᵒᶠ ᵉᶠᶠⁱᶜⁱᵉⁿᶜʸ ʷʰⁱᶜʰ ᵈᵒⁿ'ᵗ ⁱⁿᵛᵒˡᵛᵉ ˢᵃᵛⁱⁿᵍ ᵈᵉᵛᵉˡᵒᵖᵉʳˢ ᵐᵉⁿᵗᵃˡ ˢᵃⁿⁱᵗʸ
LLM will soon replace developers anyway
[13:25:59]
<Salamandar> > <@Salamandar:matrix.org> renamed, pushed
oops did not rename the usages
[13:27:11]
<Yunohost Git/Infra notifications> [yunohost] Salamandar pushed 3 commits to fpu_helpers ([a65b4218b73e...37f7d327715e](https://github.com/YunoHost/yunohost/compare/a65b4218b73e...37f7d327715e))
[13:27:35]
<Yunohost Git/Infra notifications> [yunohost] ✖️ Pipeline [#1338996617](https://gitlab.com/YunoHost/yunohost/-/pipelines/1338996617) canceled on branch fpu_helpers
[13:30:21]
<Aleks (he/him/il/lui)> on a more serious note, any opinion about trashing the goddamn ynh_cron_upgrade_node thing which duplicates node version just for the sake of somehow upgrading them (because idk, security?) but then it takes a huge space without actually restarting the services
[13:30:28]
<Yunohost Git/Infra notifications> [yunohost] Salamandar [commented](https://github.com/YunoHost/yunohost/pull/1855#discussion_r1646209123) on pull request #1855 Helpers 2.1: Yeah see my PR, i just download composer to a file whose name contains the version. Also we can prevent multiple downloa...
[13:31:25]
<Salamandar> > <@Alekswag:matrix.org> i like `--merge-with-existing` better, it's more explicit about what it does, though we could add an adjective to discourage people from using it
does getops save `--merge-with-existing` in `$merge_with_existing` ?
[13:31:37]
<Aleks (he/him/il/lui)> probably yes
[13:32:22]
<Aleks (he/him/il/lui)> i think it parses both `--foo_bar_baz` and `--foo-bar-baz`
[13:32:29]
<Aleks (he/him/il/lui)> which is ugh good and bad
[13:32:42]
<Aleks (he/him/il/lui)> but maybe i'm mistaking
[13:33:42]
<Salamandar> can't find any occurence of --x-y-z in the helpers
[13:34:06]
<Aleks (he/him/il/lui)> yeah nvm maybe i hallucinated 😬
[13:34:14]
<Salamandar> well i mean just the helpers code
[13:34:15]
<Salamandar> maybe apps do --x-y sometimes
[13:34:20]
<Salamandar> and it works by chance
[13:35:41]
<Yunohost Git/Infra notifications> [yunohost] Salamandar pushed 4 commits to fpu_helpers ([37f7d327715e...c1bc8248702e](https://github.com/YunoHost/yunohost/compare/37f7d327715e...c1bc8248702e))
[13:35:44]
<Salamandar> ok arg renamed
[13:35:54]
<Yunohost Git/Infra notifications> [yunohost/fpu_helpers] helpers.v2.1: Add ynh_in_ci_tests to check if the scripts are running in CI or not - Félix Piédallu
[13:36:03]
<Aleks (he/him/il/lui)> https://i.imgflip.com/8uccg2.jpg
[13:36:41]
<Yunohost Git/Infra notifications> [yunohost] ✖️ Pipeline [#1339014828](https://gitlab.com/YunoHost/yunohost/-/pipelines/1339014828) canceled on branch
[13:36:54]
<Salamandar> ok now maybe work on $dayjob
[13:52:07]
<Aleks (he/him/il/lui)> Salamandar: (and others that may be interested) : are we "go" to also rename e.g. `ynh_add_nginx_config` to `ynh_nginx_add_config` to always have the `ynh_{technology}_` prefix ?
[13:52:46]
<Salamandar> oh yes
[13:53:00]
<Salamandar> it could be `ynh_config_add_nginx` also, if we consider `config_file` to be the namespace
[13:53:08]
<Salamandar> but eh, `ynh_{technology}_*` sounds way more logical to me
[13:56:08]
<kayou> `ynh_config_add_*`, `ynh_config_remove_*`, `ynh_config_backup_*`...
[13:56:21]
<kayou> i say yes
[14:12:13]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/1855#discussion_r1646283688) on pull request #1855 Helpers 2.1: I am wondering about the cost in time of getopts helpers... I beleive its pretty high, so it seems to be an argument to...
[14:14:03]
<Nathanaël H> > The info should already be there, just a matter of rendering? https://github.com/YunoHost/apps/blob/019d2b200f46d5d8f48bc4e755cb8eb840e438c2/store/fetch_main_dashboard.py#L45
Hello, I can send a PR to add a column with the issues number.
[14:14:53]
<Nathanaël H> https://aria.im/_matrix/media/v1/download/isidorus.fr/xuodwShJxKkDNCGGQUtpTznu
[14:22:07]
<Salamandar> > <@kayou:matrix.org> `ynh_config_add_*`, `ynh_config_remove_*`, `ynh_config_backup_*`...
ah you prefer that ?
[14:22:09]
<Salamandar> alrite
[14:22:57]
<Aleks (he/him/il/lui)> > <@nathanael:isidorus.fr> Hello, I can send a PR to add a column with the issues number.
https://static.wikia.nocookie.net/star-wars-memes/images/6/6d/Dew-it-galactic-republic.gif
[14:24:21]
<Yunohost Git/Infra notifications> [yunohost] ericgaspar [commented](https://github.com/YunoHost/yunohost/pull/1855#discussion_r1646300988) on pull request #1855 Helpers 2.1: full_replace as default will break many apps
[14:24:39]
<kayou> > <@Salamandar:matrix.org> ah you prefer that ?
or idc, `ynh_nginx_config_{add,rm,backup}` is better than the current one
[14:24:52]
<Salamandar> > <@kayou:matrix.org> or idc, `ynh_nginx_config_{add,rm,backup}` is better than the current one
yeah this is nice
[14:25:12]
<Salamandar> anything *not `ynh_add_{domain}_config` is good
[14:30:12]
<Yunohost Git/Infra notifications> [yunohost] alexAubin [commented](https://github.com/YunoHost/yunohost/pull/1855#discussion_r1646308859) on pull request #1855 Helpers 2.1: Yeah i dont know either, I was initially pretty enthusiast about "lets roll getopts with keyword args everywhere such ...
[14:34:06]
*Aleks (he/him/il/lui) refactoring helpers like
[14:34:14]
<Aleks (he/him/il/lui)> https://aria.im/_matrix/media/v1/download/matrix.org/kJCgFtSrlGQsgvMeRrqUPeMH
[14:37:54]
<kayou> getops sounds like the 3 dots war in the translation files
[14:42:05]
<Salamandar> hahahaha
[14:44:30]
<Aleks (he/him/il/lui)> > <@kayou:matrix.org> getops sounds like the 3 dots war in the translation files
i just want ... an actual programming language T_T ... where one can call commands like bash but also **not** like bash T_T
[14:55:41]
<Yunohost Git/Infra notifications> [issues] GoustiFruit [commented](https://github.com/YunoHost/issues/issues/2404#issuecomment-2178912795) on [issue #2404](https://github.com/YunoHost/issues/issues/2404) Edge case in port availability check: It made it for me. Thanks
[15:06:44]
<Yunohost Git/Infra notifications> [yunohost] alexAubin pushed 1 commit to helpers-2.1: helpers2.1: rename everything again, i.e. ynh_{nodejs|ruby|composer|...}_install/remove (to have a proper ynh_{tech}_ pr... ([218bf107](https://github.com/YunoHost/yunohost/commit/218bf107fbb674caa8b34fa579695ac90f7899db))
[18:37:16]
<Yunohost Git/Infra notifications> [issues] utzer opened [issue #2411](https://github.com/YunoHost/issues/issues/2411): Exclude .snapshots folders from backups - Kind of a bug
[18:37:17]
<Yunohost Git/Infra notifications> [issues] utzer labeled :birthday: feature on [issue #2411](https://github.com/YunoHost/issues/issues/2411): Exclude .snapshots folders from backups - Kind of a bug
[21:45:52]
<Yunohost Git/Infra notifications> [yunohost] alexAubin pushed 3 commits to helpers-2.1 ([218bf107fbb6...b8a1a3a66022](https://github.com/YunoHost/yunohost/compare/218bf107fbb6...b8a1a3a66022))
[21:45:58]
<Yunohost Git/Infra notifications> [yunohost/helpers-2.1] helpers2.1: ynh_systemd_action --line_match -> --wait_until - Alexandre Aubin