[00:01:51]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#1412356512](https://gitlab.com/YunoHost/yunohost/-/pipelines/1412356512) failed on branch bookworm
[00:05:14]
<Yunohost Git/Infra notifications> 🏗️ Starting build for yunohost/12.0.2+202408132345 for bookworm/unstable/all ...
[00:05:14]
<Yunohost Git/Infra notifications> [yunohost] alexAubin pushed 1 commit to bookworm: ci: try to fix coverage remembering absolute path instead of relative paths ? ([2fe24424](https://github.com/YunoHost/yunohost/commit/2fe24424fb1a1b363b697149afdcadc5bf66b20c))
[00:07:08]
<Yunohost Git/Infra notifications> ✔️ Completed build for yunohost/12.0.2+202408132345 for bookworm/unstable/all.
[00:22:15]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#1412419424](https://gitlab.com/YunoHost/yunohost/-/pipelines/1412419424) failed on branch bookworm
[01:05:11]
<Aleks (he/him/il/lui)> https://gitlab.com/YunoHost/yunohost/-/jobs/7578265121 🤔
[07:35:04]
<kayou> check a random test: https://gitlab.com/YunoHost/yunohost/-/jobs/7578265101
that's the same result
[07:45:50]
<kayou> I think the --cov=src was needed (or [--cov=yunohost?](https://github.com/YunoHost/yunohost/blob/c104dc64494f14f46716db5337077246c9658385/.gitlab/ci/test.gitlab-ci.yml#L37))
[07:49:43]
<kayou> btw, if we want [this tab](https://gitlab.com/YunoHost/yunohost/-/pipelines/1374667275/test_report?job_name=full-tests) to continue working, we need to keep `--junitxml=report.xml` and https://github.com/YunoHost/yunohost/blob/c104dc64494f14f46716db5337077246c9658385/.gitlab/ci/test.gitlab-ci.yml#L46-L48
[07:51:50]
<kayou> orrrr... add back this line to get a proper coverage resulthttps://github.com/YunoHost/yunohost/commit/b887545c3e2326da74834ec6e61398f9c9b053ae#diff-8769a4702e3c26668f38118a26262d4f9de006279ba4bd7bcfe715f4cbe7c8f4R49
[07:51:53]
<kayou> orrrr... add back this line to get a proper coverage result https://github.com/YunoHost/yunohost/commit/b887545c3e2326da74834ec6e61398f9c9b053ae#diff-8769a4702e3c26668f38118a26262d4f9de006279ba4bd7bcfe715f4cbe7c8f4R49
[07:52:09]
<kayou> orrrr... add back [this line](https://github.com/YunoHost/yunohost/commit/b887545c3e2326da74834ec6e61398f9c9b053ae#diff-8769a4702e3c26668f38118a26262d4f9de006279ba4bd7bcfe715f4cbe7c8f4R49) to get a proper coverage result
[11:20:06]
<Yunohost Git/Infra notifications> [yunohost] alexAubin pushed 3 commits to bookworm ([2fe24424fb1a...0bbc14f54b4d](https://github.com/YunoHost/yunohost/compare/2fe24424fb1a...0bbc14f54b4d))
[11:22:34]
<Aleks (he/him/il/lui)> > <@kayou:matrix.org> I think the --cov=src was needed (or [--cov=yunohost?](https://github.com/YunoHost/yunohost/blob/c104dc64494f14f46716db5337077246c9658385/.gitlab/ci/test.gitlab-ci.yml#L37))
i moved the source definition to .coveragesrc, because it was recommended to do so when using relative_files = True in their doc, i think the issue should be fixed by https://github.com/YunoHost/yunohost/commit/0bbc14f54b4d35d809e62774cf6be77bb95215db but not 100% confident
[11:23:01]
<Aleks (he/him/il/lui)> > <@kayou:matrix.org> btw, if we want [this tab](https://gitlab.com/YunoHost/yunohost/-/pipelines/1374667275/test_report?job_name=full-tests) to continue working, we need to keep `--junitxml=report.xml` and https://github.com/YunoHost/yunohost/blob/c104dc64494f14f46716db5337077246c9658385/.gitlab/ci/test.gitlab-ci.yml#L46-L48
wtf i never saw this tab o.o
[11:23:53]
<Aleks (he/him/il/lui)> i savagely removed the junitxml thing because dint understood what it was achieving
[11:30:29]
<Yunohost Git/Infra notifications> 🏗️ Starting build for yunohost/12.0.2+202408141130 for bookworm/unstable/all ...
[11:31:57]
<Yunohost Git/Infra notifications> ✔️ Completed build for yunohost/12.0.2+202408141130 for bookworm/unstable/all.
[11:34:22]
<Aleks (he/him/il/lui)> > <@Alekswag:matrix.org> i moved the source definition to .coveragesrc, because it was recommended to do so when using relative_files = True in their doc, i think the issue should be fixed by https://github.com/YunoHost/yunohost/commit/0bbc14f54b4d35d809e62774cf6be77bb95215db but not 100% confident
well ... nope ...
[11:40:02]
<Aleks (he/him/il/lui)> hmgn when i do run pytest in local it works T_T
[11:58:23]
<Yunohost Git/Infra notifications> [yunohost] alexAubin pushed 2 commits to bookworm ([0bbc14f54b4d...2976e7bf602e](https://github.com/YunoHost/yunohost/compare/0bbc14f54b4d...2976e7bf602e))
[11:58:28]
<Yunohost Git/Infra notifications> [yunohost/bookworm] ci: remove tmp --debug, issue was due to hideproc failing to enable because the container wasnt running with the proper ... - Alexandre Aubin
[11:59:08]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#1413102714](https://gitlab.com/YunoHost/yunohost/-/pipelines/1413102714) failed on branch bookworm
[12:00:28]
<Yunohost Git/Infra notifications> 🏗️ Starting build for yunohost/12.0.2+202408141200 for bookworm/unstable/all ...
[12:02:11]
<Yunohost Git/Infra notifications> ✔️ Completed build for yunohost/12.0.2+202408141200 for bookworm/unstable/all.
[12:12:26]
<Aleks (he/him/il/lui)> thank god it weurks
[12:37:00]
<kayou> i have no idea how all these stuff works
[12:37:02]
<kayou> but
[12:37:09]
<kayou> https://github.com/YunoHost/yunohost/blob/2976e7bf602e2266a78a6c4e84fbf86dbb8539ef/.gitlab/ci/test.gitlab-ci.yml#L8
https://github.com/YunoHost/yunohost/blob/2976e7bf602e2266a78a6c4e84fbf86dbb8539ef/.gitlab/ci/test.gitlab-ci.yml#L12
[12:37:28]
<kayou> if you replace --cov=src by --cov=yunohost here
[12:38:08]
<kayou> is there any chance to fix the issue without create this symlink?
[12:38:51]
<Aleks (he/him/il/lui)> hmmm not really, the issue was about the fact that if you want to `import yunohost.foobar` then some folder called "yunohost" must be available in the python path
[12:38:55]
<kayou> (--cov was set to yunohost before your big refactor, so...)
[12:39:10]
<kayou> ha, yeah
[12:39:21]
<Aleks (he/him/il/lui)> which is the case with /usr/lib/python3/dist-packages, there's a yunohost folder containing the content of ... src
[12:39:35]
<Aleks (he/him/il/lui)> but yeah the symlink is a bit hackish but idk it works
[12:39:46]
<Aleks (he/him/il/lui)> (i'm running out of battery)
[12:39:51]
<kayou> why it was working then?
[12:40:35]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#1413152883](https://gitlab.com/YunoHost/yunohost/-/pipelines/1413152883) failed on branch bookworm
[12:41:23]
<Aleks (he/him/il/lui)> > <@kayou:matrix.org> why it was working then?
i think the import was importing stuff from /usr/lib/python3/dist-packages instead of the "git clone"
[12:41:43]
<Aleks (he/him/il/lui)> iirc there was some confusion in the result, it listed some files from the git clone and some other from /usr/lib
[12:41:52]
<Aleks (he/him/il/lui)> not sure
[12:41:58]
<kayou> which is supposed to be the same, since we built the .deb from this sources
[12:42:18]
<Aleks (he/him/il/lui)> yeah but pytest / coverage doesnt realize they are the same
[12:42:34]
<kayou> ¯\_(ツ)_/¯ anyway, it make sense now
[12:42:39]
<Aleks (he/him/il/lui)> i mean it would say "I ran trough 32 lines in src/domains.py and 97 lines in /usr/lib/.../domains.py"
[12:43:43]
<Aleks (he/him/il/lui)> https://gitlab.com/YunoHost/yunohost/-/jobs/7582579245
[12:43:46]
<Aleks (he/him/il/lui)> 56% 👌
[12:46:39]
<kayou> https://gitlab.com/YunoHost/yunohost/-/jobs/7440710866
[12:47:19]
<kayou> 60% on bullseye, it seems correct
[18:27:00]
<Yunohost Git/Infra notifications> [yunohost] alexAubin pushed 1 commit to bookworm: ci: fix mypy complains ([4ee8d4e8](https://github.com/YunoHost/yunohost/commit/4ee8d4e8ca09e8f21014ff0df62a4aa99249cfc7))
[18:30:33]
<Yunohost Git/Infra notifications> 🏗️ Starting build for yunohost/12.0.2+202408141830 for bookworm/unstable/all ...
[18:31:51]
<Yunohost Git/Infra notifications> ✔️ Completed build for yunohost/12.0.2+202408141830 for bookworm/unstable/all.