[08:16:55]
<Salamandar> > <selfhoster1312> don't merge yet !
yeah I got some comments
[08:17:07]
<selfhoster1312> great!
[08:17:08]
<Salamandar> like remove the useless makefile
[08:18:00]
<Salamandar> and pass -sr to shfmt
[08:18:01]
<Salamandar> also I wanted to first pass a pull request that only changes whitespaces (tabs to space)
[08:18:03]
<Salamandar> if that's fine with you
[08:18:05]
<Salamandar> just to reduce the diff of your PR
[08:18:06]
<Salamandar> @Alekswag:matrix.org He targetted the dev branch, shouldn't we merge bookworm in dev ?
[08:18:12]
<Salamandar> and maybe have a `stale` branch for bullseye support
[08:18:32]
<selfhoster1312> > a simple easy-to-remember command to fix what's expected
because of this comment by Aleks (he/him/il/lui) i added a make/just file :)
[08:19:11]
<selfhoster1312> everyone has a habit to check those files for common tasks :)
[08:19:15]
<selfhoster1312> every developer *
[08:19:32]
<selfhoster1312> (and just even has `just list` to discover those tasks)
[08:19:58]
<Salamandar> > <selfhoster1312> > a simple easy-to-remember command to fix what's expected
>
> because of this comment by Aleks (he/him/il/lui) i added a make/just file :)
also what the justfile is for ?
[08:20:10]
<Salamandar> > <selfhoster1312> everyone has a habit to check those files for common tasks :)
nah first time i see a justfile
[08:20:20]
<Salamandar> and now makefile is less and less present
[08:20:26]
<Salamandar> just put a script in maintenance/ i think
[08:20:28]
<selfhoster1312> just is like a modern make... much better and simpler
[08:20:48]
<Salamandar> (like you already did actually)
[08:25:00]
<Salamandar> Indeed it looks way better than make
[08:25:01]
<Salamandar> but i don't think we have the use for that (yet)
[08:25:06]
<Salamandar> I guess maybe make a PR with an added just file
[08:25:32]
<Salamandar> we could use that to run release process etc
[08:25:48]
<Salamandar> that might be interesting
[08:25:49]
<Salamandar> but your PR is not the place to discuss the addition of such a tool as a dependency for our workflow ;)
[08:31:38]
<Yunohost Git/Infra notifications> [yunohost] Salamandar pushed 4 commits to tabs2space ([3f9b57785141^...4267ab751e54](https://github.com/YunoHost/yunohost/compare/3f9b57785141^...4267ab751e54))
[08:31:51]
<Yunohost Git/Infra notifications> [yunohost] Salamandar opened [pull request #1942](https://github.com/YunoHost/yunohost/pull/1942): Fix tabs and indentations in metronome, helpers, hooks
[08:32:01]
<Yunohost Git/Infra notifications> [yunohost] Salamandar created new branch tabs2space
[08:32:06]
<Yunohost Git/Infra notifications> [yunohost/tabs2space] Fix tabs in hooks script - Félix Piédallu
[09:01:34]
<Yunohost Git/Infra notifications> [yunohost] Salamandar pushed 4 commits to dev ([5b37936d11e7...b91e9dd8f479](https://github.com/YunoHost/yunohost/compare/5b37936d11e7...b91e9dd8f479))
[09:01:34]
<Yunohost Git/Infra notifications> [yunohost] Salamandar merged [pull request #1942](https://github.com/YunoHost/yunohost/pull/1942): Fix tabs and indentations in metronome, helpers, hooks
[09:01:36]
<Yunohost Git/Infra notifications> [yunohost] Salamandar deleted branch tabs2space
[09:01:37]
<Yunohost Git/Infra notifications> [yunohost/dev] Fix tabs in hooks script - Félix Piédallu
[09:02:51]
<Salamandar> @_bifrost_selfhoster1312=2fdev=40conference.yunohost.org:aria-net.org just discovered i had misread your nickname. And… Nice 👌
[09:05:32]
<Salamandar> Also just rebased your PR branch after my merge of whitespace changes
[09:06:03]
<selfhoster1312> Salamandar, make/just doesn't become a "dependency" in that branch it's just an option for people to use tools they're comfortable with :)
[09:06:52]
<selfhoster1312> (you can still run the workflow/script without just or make)
[09:08:21]
<Salamandar> > <selfhoster1312> Salamandar, make/just doesn't become a "dependency" in that branch it's just an option for people to use tools they're comfortable with :)
Yeah, I get what you mean. That's interesting TBH. But that triggers a different discussion than the shfmt subject ;)
[09:08:53]
<selfhoster1312> i don't think supporting more workflows without adding a dependency requires much discussion, but sure we can move that out of the PR
[09:12:55]
<Salamandar> Hmmm I see one thing where shfmt isn't good
[09:13:07]
<Salamandar> https://aria.im/_matrix/media/v1/download/matrix.org/YOTxFEQxqwJsDbzkJtLQAWEl
[09:15:23]
<Yunohost Git/Infra notifications> 🏗️ Starting build for yunohost/11.2.29+202408310915 for bullseye/unstable/all ...
[09:16:05]
<Salamandar> > <@Salamandar:matrix.org> Capture d’écran du 2024-08-31 11-12-58.png
Although I understand why. But that would be nice if it supported this coding style…
[09:16:26]
<Salamandar> maybe with
```
pushd mydir
{
internal code
}
popd
```
[09:16:41]
<Salamandar> `{}` doesn't create a subshell so we're fine
[09:16:54]
<Aleks (he/him/il/lui)> still convinced that denying PR not passing the shfmt thing is a bad thing if it's not automatized somehow. This is just code formatting, it's not like it's gonna break thing if it misses a space of wrote the if/then/fi not in the standard manner
[09:16:58]
<Yunohost Git/Infra notifications> ✔️ Completed build for yunohost/11.2.29+202408310915 for bullseye/unstable/all.
[09:17:13]
<Aleks (he/him/il/lui)> imho we should just have shfmt and black run every time we create a tag and voila
[09:18:40]
<Salamandar> ```
~ ❯❯❯ hyperfine -u microsecond "bash ./test.sh" # Without curly braces
Benchmark 1: bash ./test.sh
Time (mean ± σ): 1131.5 µs ± 167.5 µs [User: 828.4 µs, System: 619.5 µs]
Range (min … max): 813.2 µs … 2129.0 µs 1432 runs
~ ❯❯❯ hyperfine -u microsecond "bash ./test.sh" # With curly braces
Benchmark 1: bash ./test.sh
Time (mean ± σ): 1156.9 µs ± 196.2 µs [User: 833.3 µs, System: 630.6 µs]
Range (min … max): 830.9 µs … 2676.4 µs 1390 runs
```
[09:22:38]
<selfhoster1312> Salamandar, that sounds good! looks like it's the recommended shfmt way to do things
[09:23:16]
<selfhoster1312> Aleks (he/him/il/lui), well making it a CI check places the burden of readability/correctness on the contributor, instead of the maintainers... imagine never having to merge a black PR ever again XD
[09:23:59]
<Aleks (he/him/il/lui)> sure and that totally won't end up in "contributor doesn't understand what they did wrong, and maintainer has to fix their shit"
[09:24:08]
<selfhoster1312> it's good practice, especially if it's easier for people to run the "tests" (lints) locally, and the feedback is faster in CI
[09:25:03]
<Aleks (he/him/il/lui)> also i'm not sure github workflow run on external contributions
[09:25:47]
<Aleks (he/him/il/lui)> so that's more like "PR gets created but workflow on't run -> merge -> workflow runs -> suddenly the main branch is broken"
[09:26:44]
<Aleks (he/him/il/lui)> (also true for the gitlab CI which actually do run unit test instead of shfmt / black which are essentially cosmetics)
[09:26:47]
<Yunohost Git/Infra notifications> [yunohost] Salamandar [commented](https://github.com/YunoHost/yunohost/pull/1941#discussion_r1739646080) on pull request #1941 Deny PRs where shfmt doesnt pass: Actually this is handled by the -sr argument to shfmt, so thats good. Please dont manually fix that, just let shfmt ...
[09:26:55]
<Yunohost Git/Infra notifications> [yunohost] Salamandar [commented](https://github.com/YunoHost/yunohost/pull/1941#discussion_r1739645757) on pull request #1941 Deny PRs where shfmt doesnt pass: suggestion shfmt -sr -bn -i 4 -d helpers/helpers shfmt -sr -bn -i 4 -d helpers/helpers.v2.1.d/* shfmt -sr -bn -i 4 -d...
[09:26:55]
<Yunohost Git/Infra notifications> [yunohost] Salamandar changes_requested [pull request #1941](https://github.com/YunoHost/yunohost/pull/1941#pullrequestreview-2273784615) Deny PRs where shfmt doesnt pass
[09:26:55]
<Yunohost Git/Infra notifications> [yunohost] Salamandar [commented](https://github.com/YunoHost/yunohost/pull/1941#discussion_r1739645952) on pull request #1941 Deny PRs where shfmt doesnt pass: suggestion shfmt -sr -bn -i 4 -d helpers/helpers shfmt -sr -bn -i 4 -d helpers/helpers.v2.1.d/* shfmt -sr -bn -i 4 -d...
[09:26:56]
<Yunohost Git/Infra notifications> [yunohost] Salamandar [commented](https://github.com/YunoHost/yunohost/pull/1941#discussion_r1739634429) on pull request #1941 Deny PRs where shfmt doesnt pass: Nah, leave the space after >.
[09:26:56]
<Yunohost Git/Infra notifications> [yunohost] Salamandar [commented](https://github.com/YunoHost/yunohost/pull/1941#discussion_r1739634297) on pull request #1941 Deny PRs where shfmt doesnt pass: Out of the scope of this PR but if then fi is way more readable IMHO.
[09:26:56]
<Yunohost Git/Infra notifications> [yunohost] Salamandar [commented](https://github.com/YunoHost/yunohost/pull/1941#discussion_r1739645459) on pull request #1941 Deny PRs where shfmt doesnt pass: suggestion #/usr/bin/env bash set -Eeuo pipefail No space in shebang add some more error handling options.
[09:26:57]
<Yunohost Git/Infra notifications> [yunohost] Salamandar [commented](https://github.com/YunoHost/yunohost/pull/1941#discussion_r1739634116) on pull request #1941 Deny PRs where shfmt doesnt pass: Uuuuuh why a makefile ? Please dont add a makefile just for check. This will mislead people.
[09:27:20]
<Yunohost Git/Infra notifications> [yunohost] Salamandar [commented](https://github.com/YunoHost/yunohost/pull/1941#discussion_r1739646134) on pull request #1941 Deny PRs where shfmt doesnt pass: Crap, bad network -> duplicate comments
[09:53:45]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#1434545200](https://gitlab.com/YunoHost/yunohost/-/pipelines/1434545200) failed on branch
[09:54:03]
<Salamandar> @_bifrost_selfhoster1312=2fdev=40conference.yunohost.org:aria-net.org don't take it the wrong way please. I'm going to commit my suggested changes to your remote branch so that we can merge your PR. The rest of the discussion can happen in another PR ;)
[10:15:00]
<Salamandar> Actually the "add a space after `<<<` and `>` is not as clear as I thought… `2>/dev/null` looks better without a space but `> $logfile` looks better WITH a space… @Alekswag:matrix.org what's your opinion ?
[10:17:34]
<Aleks (he/him/il/lui)> :|
[10:17:49]
<Aleks (he/him/il/lui)> yeah same
[10:18:52]
<Aleks (he/him/il/lui)> but honestly there are better things to do in life than discuss formatting result from shfmt, the point of these tools is that you just apply them to be able to have standardized format and focus on real life problems
[10:19:00]
<Aleks (he/him/il/lui)> just like black, which also has debattable formatings
[10:19:16]
<Salamandar> yeah agreed
[10:19:31]
<Salamandar> FYI i merge the formatting
[10:19:47]
<Salamandar> and for the rest (github workflow etc) let's open a second PR
[10:20:00]
<Aleks (he/him/il/lui)> 👍️
[10:20:19]
<Salamandar> but i'm afraid this will break dev to bookworm merge ?
[10:20:44]
<Salamandar> > <@Alekswag:matrix.org> 👍️
what message does it refer to xD
[10:21:50]
<Aleks (he/him/il/lui)> the "merge formatting, open another PR for workflows"
[10:23:04]
<Yunohost Git/Infra notifications> [yunohost] Salamandar pushed 2 commits to dev ([b91e9dd8f479...8a5f2808a161](https://github.com/YunoHost/yunohost/compare/b91e9dd8f479...8a5f2808a161))
[10:23:04]
<Yunohost Git/Infra notifications> [yunohost] Salamandar merged [pull request #1941](https://github.com/YunoHost/yunohost/pull/1941): Deny PRs where shfmt doesnt pass
[10:25:03]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#1434556631](https://gitlab.com/YunoHost/yunohost/-/pipelines/1434556631) failed on branch dev
[10:27:31]
<Yunohost Git/Infra notifications> [yunohost] Salamandar created new branch shfmt_action
[10:27:31]
<Yunohost Git/Infra notifications> [yunohost] Salamandar pushed 4 commits to shfmt_action ([701725bbfb9d^...a8c8eacc6c89](https://github.com/YunoHost/yunohost/compare/701725bbfb9d^...a8c8eacc6c89))
[10:27:32]
<Yunohost Git/Infra notifications> [yunohost] Salamandar [commented](https://github.com/YunoHost/yunohost/pull/1941#issuecomment-2322854594) on [issue #1941](https://github.com/YunoHost/yunohost/pull/1941) Deny PRs where shfmt doesnt pass: Thank you @selfhoster1312 <3 For the rest of your commits I pushed the shfmt_action branch, you can open a PR yourself...
[10:30:42]
<Yunohost Git/Infra notifications> 🏗️ Starting build for yunohost/11.2.29+202408311030 for bullseye/unstable/all ...
[10:32:10]
<Yunohost Git/Infra notifications> ✔️ Completed build for yunohost/11.2.29+202408311030 for bullseye/unstable/all.
[11:37:18]
<selfhoster1312> > also i'm not sure github workflow run on external contributions
your workflow autoblack doesn't run on PRs because it explicitly says to not do it
[11:37:28]
<selfhoster1312> gitlab CI is entirely different and to be honest more annoying
[11:44:04]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#1434584028](https://gitlab.com/YunoHost/yunohost/-/pipelines/1434584028) failed on branch dev, shfmt_action
[11:48:03]
<selfhoster1312> Salamandar, now that's just a weird way to do things... running your maintenance/shfmt.sh will neither point out the problem nor fix it
[11:48:49]
<selfhoster1312> why did you force push my branch with huge modifications without my permissions again? u_u sorry maybe i'm a little conservative in some regards but i find it's bad etiquette except for minor changes/rebase
[11:49:14]
<selfhoster1312> i mean right now the script is useless because you have to guess that you need to pass it "-d" or "-w" for it to become useful, which you won't know unless you already know how shfmt works :'(
[13:18:51]
<Salamandar> > <selfhoster1312> i mean right now the script is useless because you have to guess that you need to pass it "-d" or "-w" for it to become useful, which you won't know unless you already know how shfmt works :'(
That can be changed :)
[13:27:48]
<eric_G> Is it possible to add a filter discriminating apps using helper v1 in https://apps.yunohost.org/dash?
[13:29:18]
<Aleks (he/him/il/lui)> yeah, gotta think about how to fetch the info properly but that's the goal i suppose
[13:30:54]
<eric_G> so far the recurring problem is with node path : `ynh_hide_warnings ynh_exec_as_app node_load_PATH: command not found`
[13:31:28]
<Aleks (he/him/il/lui)> yeah i'm seeing that too, i don't even remember what's the new design is lulz 😬
[13:31:46]
<Aleks (he/him/il/lui)> but if the fix is obvious i could try to apply another patch on all the affected apps
[13:53:13]
<eric_G> https://github.com/YunoHost-Apps/tiddlywiki_ynh/pull/53/commits/b2fddb197cdeb27a791176e740e67568a9322e63
[16:51:36]
<Yunohost Git/Infra notifications> [yunohost] Josue-T pushed 1 commit to fix_ynh_restore_everything: Fix ynh_restore_everything ([917cf251](https://github.com/YunoHost/yunohost/commit/917cf251fb585ac5cabde49ac68ebea06f527f52))
[16:51:36]
<Yunohost Git/Infra notifications> [yunohost] Josue-T created new branch fix_ynh_restore_everything
[16:55:20]
<Yunohost Git/Infra notifications> [yunohost] Josue-T opened [pull request #1943](https://github.com/YunoHost/yunohost/pull/1943): Fix ynh_restore_everything
[16:59:57]
<Yunohost Git/Infra notifications> [yunohost] alexAubin merged [pull request #1943](https://github.com/YunoHost/yunohost/pull/1943): Fix ynh_restore_everything
[16:59:58]
<Yunohost Git/Infra notifications> [yunohost] alexAubin pushed 2 commits to dev ([8a5f2808a161...6e84e3532a6f](https://github.com/YunoHost/yunohost/compare/8a5f2808a161...6e84e3532a6f))
[17:00:01]
<Yunohost Git/Infra notifications> [yunohost] alexAubin deleted branch fix_ynh_restore_everything
[17:00:08]
<Yunohost Git/Infra notifications> [yunohost/dev] Fix ynh_restore_everything - Josué Tille
[17:00:49]
<Yunohost Git/Infra notifications> 🏗️ Starting build for yunohost/11.2.29+202408311700 for bullseye/unstable/all ...
[17:03:41]
<Yunohost Git/Infra notifications> ✔️ Completed build for yunohost/11.2.29+202408311700 for bullseye/unstable/all.
[17:30:26]
<Yunohost Git/Infra notifications> 🏗️ Starting build for yunohost/11.2.30+202408311730 for bullseye/unstable/all ...
[17:30:56]
<Yunohost Git/Infra notifications> [yunohost] alexAubin pushed 1 commit to dev: Update changelog for 11.2.30 ([a5049a8a](https://github.com/YunoHost/yunohost/commit/a5049a8a13bd1f5c91425ea357462f9800544f3a))
[17:32:07]
<Yunohost Git/Infra notifications> [yunohost] ✖️ Pipeline [#1434728096](https://gitlab.com/YunoHost/yunohost/-/pipelines/1434728096) canceled on branch dev
[17:32:14]
<Yunohost Git/Infra notifications> ✔️ Completed build for yunohost/11.2.30+202408311730 for bullseye/unstable/all.
[17:32:49]
<selfhoster1312> Salamandar, yes we can always fix things, it's just easier before merge! :)
and i hope i wasn't too rude i'm just having a not-good-day :s
[17:33:15]
<selfhoster1312> Aleks (he/him/il/lui), so you said you'd like the fmt/linter to push directly on the PR branch right?
[17:33:25]
<selfhoster1312> (i can do it with black too)
[17:34:15]
<Aleks (he/him/il/lui)> sounds like the easiest workflow, or i'd even say only having it done when we push tags or idk, or only when pushing to the main branch
[17:37:21]
<selfhoster1312> i'm torn on that one... on one hand pushing on people's branch is bad ®, on the other hand it's much better to enforce formatting/linting before review...
[17:37:52]
<selfhoster1312> if we can find a git one-liner to teach people to force pull the edited version... :)
[17:38:07]
<Aleks (he/him/il/lui)> we ain't pushing to people's branch if we only push on the main branch, and we don't need perfect formatting to review PRs...
[17:45:15]
<Yunohost Git/Infra notifications> [yunohost] alexAubin pushed 17 commits to bookworm ([dd1853ee1566...d6167c558670](https://github.com/YunoHost/yunohost/compare/dd1853ee1566...d6167c558670))
[17:45:26]
<Yunohost Git/Infra notifications> 🏗️ Starting build for yunohost/12.0.2+202408311745 for bookworm/unstable/all ...
[17:49:17]
<Yunohost Git/Infra notifications> ✔️ Completed build for yunohost/12.0.2+202408311745 for bookworm/unstable/all.
[17:56:24]
<Yunohost Git/Infra notifications> [yunohost] alexAubin pushed 1 commit to bookworm: Update changelog for 12.0.3 ([0496cada](https://github.com/YunoHost/yunohost/commit/0496cadade5ae1d5abe70b861f4366c9bba2270d))
[17:57:15]
<Yunohost Git/Infra notifications> [yunohost] ✖️ Pipeline [#1434745528](https://gitlab.com/YunoHost/yunohost/-/pipelines/1434745528) canceled on branch bookworm
[17:57:17]
<Yunohost Git/Infra notifications> [yunohost-portal] alexAubin pushed 7 commits to dev ([eb8a2e4ec2fa...3b4bbe7299dc](https://github.com/YunoHost/yunohost-portal/compare/eb8a2e4ec2fa...3b4bbe7299dc))
[17:57:23]
<Yunohost Git/Infra notifications> [yunohost-portal] alexAubin merged [pull request #11](https://github.com/YunoHost/yunohost-portal/pull/11): Translations update from Weblate
[18:00:28]
<Yunohost Git/Infra notifications> 🏗️ Starting build for yunohost/12.0.3+202408311800 for bookworm/unstable/all ...
[18:01:24]
<Yunohost Git/Infra notifications> [yunohost-portal] alexAubin pushed 2 commits to debian/12.0.2 ([5855def2bfd6^...5a790a849b88](https://github.com/YunoHost/yunohost-portal/compare/5855def2bfd6^...5a790a849b88))
[18:01:24]
<Yunohost Git/Infra notifications> [yunohost-portal] alexAubin created new tag debian/12.0.2
[18:01:59]
<Yunohost Git/Infra notifications> ✔️ Completed build for yunohost/12.0.3+202408311800 for bookworm/unstable/all.
[18:02:10]
<Yunohost Git/Infra notifications> 🏗️ Starting build for yunohost-portal/12.0.1+202408311800 for bookworm/unstable/all ...
[18:02:44]
<Yunohost Git/Infra notifications> [yunohost-portal] alexAubin deleted tag debian/12.0.2
[18:03:11]
<selfhoster1312> i don't know it would give me the shivers to give a bot permission to write on my project, but well i'm not the maintainer so i'll do as you say :P
[18:03:29]
<Yunohost Git/Infra notifications> [yunohost-portal] alexAubin pushed 2 commits to dev ([3b4bbe7299dc...bf96e01f2d9c](https://github.com/YunoHost/yunohost-portal/compare/3b4bbe7299dc...bf96e01f2d9c))
[18:03:29]
<Yunohost Git/Infra notifications> [yunohost-portal] alexAubin created new tag debian/11.0.2
[18:03:29]
<Yunohost Git/Infra notifications> [yunohost-portal] alexAubin pushed 2 commits to debian/12.0.2 ([5855def2bfd6^...5a790a849b88](https://github.com/YunoHost/yunohost-portal/compare/5855def2bfd6^...5a790a849b88))
[18:03:47]
<Yunohost Git/Infra notifications> [yunohost-portal] alexAubin created new tag debian/12.0.2
[18:03:51]
<Yunohost Git/Infra notifications> [yunohost-portal] alexAubin deleted tag debian/11.0.2
[18:04:20]
<Aleks (he/him/il/lui)> i'll take shivers over mental sanity and PR/CI notifications overflow any day
[18:04:36]
<selfhoster1312> sure
[18:05:05]
<Aleks (he/him/il/lui)> we already have yunohost-bot pushing auto README updates to every app repo automagically
[18:05:17]
<selfhoster1312> 👍️
[18:06:08]
<Yunohost Git/Infra notifications> ✔️ Completed build for yunohost-portal/12.0.1+202408311800 for bookworm/unstable/all.
[18:06:08]
<Aleks (he/him/il/lui)> i guess security-wise the biggest question is "is the branch marked as protected to not be able to rewrite history"
[18:08:20]
<Yunohost Git/Infra notifications> [yunohost-portal] alexAubin created new tag debian/12.0.2
[18:08:21]
<Yunohost Git/Infra notifications> [yunohost-portal] alexAubin deleted tag debian/12.0.2
[18:09:04]
<Yunohost Git/Infra notifications> [yunohost-admin] alexAubin pushed 4 commits to dev ([26fdebc57b5c...99873caa7cd8](https://github.com/YunoHost/yunohost-admin/compare/26fdebc57b5c...99873caa7cd8))
[18:09:04]
<Yunohost Git/Infra notifications> [yunohost-admin] alexAubin merged [pull request #577](https://github.com/YunoHost/yunohost-admin/pull/577): Translations update from Weblate
[18:12:12]
<Yunohost Git/Infra notifications> [yunohost-admin] alexAubin pushed 1 commit to bookworm: Update changelog for 12.0.2 ([f578b191](https://github.com/YunoHost/yunohost-admin/commit/f578b1913071215beaa522561a052f32fd30bf0e))
[18:14:13]
<Yunohost Git/Infra notifications> [moulinette] alexAubin created new tag debian/12.0.2
[18:14:14]
<Yunohost Git/Infra notifications> [moulinette] alexAubin pushed 1 commit to bookworm: Update changelog for 12.0.2 ([709585be](https://github.com/YunoHost/moulinette/commit/709585be83304cbbe2eb8dedb75005fafdf3291f))
[18:15:27]
<Yunohost Git/Infra notifications> 🏗️ Starting build for moulinette/12.0.2+202408311815 for bookworm/unstable/all ...
[18:16:51]
<Yunohost Git/Infra notifications> 🏗️ Starting build for yunohost/11.2.30 for bullseye/stable/all ...
[18:17:56]
<Yunohost Git/Infra notifications> 🏗️ Starting build for yunohost-admin/11.2.8+202408311815 for bullseye/unstable/all ...
[18:19:33]
<Yunohost Git/Infra notifications> ✔️ Completed build for yunohost/11.2.30 for bullseye/stable/all.
[18:19:33]
<Yunohost Git/Infra notifications> 🏗️ Starting build for yunohost-portal/12.0.2 for bookworm/testing/all ...
[18:23:55]
<Yunohost Git/Infra notifications> ✔️ Completed build for yunohost-admin/11.2.8+202408311815 for bullseye/unstable/all.
[18:24:25]
<Yunohost Git/Infra notifications> 🏗️ Starting build for yunohost-admin/12.0.2+202408311815 for bookworm/unstable/all ...
[18:24:29]
<selfhoster1312> oh noes, Salamandar did you try your shfmt.sh script? it fails with a syntax problem here
[18:24:36]
<Yunohost Git/Infra notifications> ✔️ Completed build for yunohost-portal/12.0.2 for bookworm/testing/all.
[18:24:43]
<selfhoster1312> > ./shfmt.sh
> flag provided but not defined: -indent
[18:24:57]
<Yunohost Git/Infra notifications> 🏗️ Starting build for moulinette/12.0.2 for bookworm/testing/all ...
[18:28:19]
<selfhoster1312> ah the long flags don't exist, they're EditorConfig options apparently?
[18:28:19]
<Yunohost Git/Infra notifications> ✔️ Completed build for yunohost-admin/12.0.2+202408311815 for bookworm/unstable/all.
[18:29:52]
<Yunohost Git/Infra notifications> ✔️ Completed build for moulinette/12.0.2 for bookworm/testing/all.
[19:02:49]
<Yunohost Git/Infra notifications> [yunohost] selfhoster1312 edited [pull request #1944](https://github.com/YunoHost/yunohost/pull/1944): Add maintenance/pre-commit.sh script
[19:02:54]
<Yunohost Git/Infra notifications> [yunohost] selfhoster1312 opened [pull request #1944](https://github.com/YunoHost/yunohost/pull/1944): Add maintenance/pre-commit.sh script
[19:18:57]
<Aleks (he/him/il/lui)> https://blocks.md/
[19:21:30]
<Aleks (he/him/il/lui)> Ah well apparently MDX is something similar with wider features i suppose
[19:27:50]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#1434747732](https://gitlab.com/YunoHost/yunohost/-/pipelines/1434747732) failed on branch bookworm
[19:46:43]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#1434741825](https://gitlab.com/YunoHost/yunohost/-/pipelines/1434741825) failed on branch dev, bookworm
[19:57:23]
<Salamandar> > <selfhoster1312> oh noes, Salamandar did you try your shfmt.sh script? it fails with a syntax problem here
hmmm yes i did
[19:58:08]
<Salamandar> > <selfhoster1312> ah the long flags don't exist, they're EditorConfig options apparently?
I see --indent here https://github.com/mvdan/sh/blob/master/cmd/shfmt/shfmt.1.scd#printer-flags
[19:58:19]
<Salamandar> and it works at home™
[19:58:43]
<selfhoster1312> maybe i have the wrong version then? :O
[19:59:57]
<selfhoster1312> yeah i'm a bit late to the party: https://github.com/mvdan/sh/commit/bdb1e1d6f392bee6b90afe93954d1e6098a16ce7 :D
[20:06:03]
<Salamandar> > <selfhoster1312> yeah i'm a bit late to the party: https://github.com/mvdan/sh/commit/bdb1e1d6f392bee6b90afe93954d1e6098a16ce7 :D
ouch oupsies, indeed i stumbled on this fork first before finding the (real?), living project :D
[23:44:42]
<Yunohost Git/Infra notifications> [yunohost] Salamandar [commented](https://github.com/YunoHost/yunohost/pull/1944#discussion_r1739927814) on pull request #1944 Add maintenance/pre-commit.sh script: The long args work with the more recent version as you saw )
[23:59:00]
<Yunohost Git/Infra notifications> [yunohost] Salamandar [commented](https://github.com/YunoHost/yunohost/pull/1944#discussion_r1739927962) on pull request #1944 Add maintenance/pre-commit.sh script: I see one major flaw at calling multiple times shfmt: if you use check, and you have issues in multiple helpers dirs, ...