[01:30:16]
<rodinux> humm, c'est un soucis dans le core ce genre de message `'Depends' field, missing package name, or garbage where package name expected`
[01:32:04]
<Aleks (he/him/il/lui)> https://aria.im/_bifrost/v1/media/download/AZNKl9Z_IqF8MtlznEBo5beSMGbuVOwVPBcJ3QpJsS_99Utj5mquru53rt2pPcXTioOyCZlnnpe8x0FQ-HUa14xCeT5tfUQAAG1hdHJpeC5vcmcvWUFlRnhvTnBVZmFmVGlESE1BTUNRZmNG
[01:33:31]
<rodinux> I am try understand users in the forum having trouble when updating 2 nextcloud here a paste https://paste.yunohost.org/raw/abipezuguy
[01:34:07]
<rodinux> and in the forum https://forum.yunohost.org/t/nextcloud-update-29-0-10-ynh2-30-0-4-ynh1-fails-due-to-an-error-with-dpkg-query/32673/2
[01:34:25]
<Aleks (he/him/il/lui)> >Failed to connect to the database: An exception occurred in the driver
that's typically the phpX.Y-mysql package missing
[01:36:44]
<rodinux> I imagine the first upgrade first nextcloud have install a phpX.Y-mysql, and the second loose a dependencie ?
[01:37:27]
<rodinux> perhaps because of this part https://github.com/YunoHost-Apps/nextcloud_ynh/blob/5a97169205403eab2bd8db13612a8964e4fa0e0d/scripts/upgrade#L75C1-L84C7
[01:39:21]
<Aleks (he/him/il/lui)> yeah it assumes the -ynh-deps virtual packge exists but if it disappeared for some reason it miserably explodes i guess
[01:39:53]
<Aleks (he/him/il/lui)> ah yes it tries to replace the X.Y (php version) in the dep list but the dep list is empty
[01:39:54]
<Aleks (he/him/il/lui)> merpdf
[01:41:27]
<Aleks (he/him/il/lui)> hmmmm
[01:41:30]
<Aleks (he/him/il/lui)> confusion intensifies
[01:42:11]
<Aleks (he/him/il/lui)> zaaaaaah
[01:42:26]
<Aleks (he/him/il/lui)> $app is nextcloud__2 but should be nextcloud--2 ?
[01:42:34]
<Aleks (he/him/il/lui)> (i mean for the ynh-deps stuff)
[01:42:53]
<Aleks (he/him/il/lui)> ~_~
[01:43:00]
<Aleks (he/him/il/lui)> well at least that's an easy fix
[01:45:30]
<rodinux> underscore... cool you found it !
[01:46:28]
<Aleks (he/him/il/lui)> (that's also why it wasnt caught in the ci tests because it only happens when upgrading from a __2 instance)
[01:47:33]
<rodinux> I see on my server when 2 apps is $app--2-ynh-deps
[01:49:17]
<Aleks (he/him/il/lui)> (cant write the fix right now but if you want to work on it, the weird bash syntax that does it is somewhere in helpers/helpers.v2.0.d/apt (or 2.1 too)
[01:51:56]
<rodinux> local app_ynh_deps="${app//_/-}-ynh-deps" # Replace all '_' by '-', and append -ynh-deps
[01:54:26]
<rodinux> humm... well i full of regex... I am little affraid
[01:57:57]
<rodinux> or just keep it like `local app_ynh_deps="${app}-ynh-deps"`
[01:58:55]
<Aleks (he/him/il/lui)> https://i.imgur.com/DUOKnkM.png
[01:59:18]
<Aleks (he/him/il/lui)> the issue ain't in the core, it's in the nextcloud_ynh upgrade code
[01:59:23]
<Aleks (he/him/il/lui)> https://github.com/YunoHost-Apps/nextcloud_ynh/blob/5a97169205403eab2bd8db13612a8964e4fa0e0d/scripts/upgrade#L77
[01:59:38]
<Aleks (he/him/il/lui)> just gotta replace `${app}-ynh-deps` with the horrendous `${app///-}-ynh-deps`
[01:59:56]
<Aleks (he/him/il/lui)> (it's actually not regex, it's worse than regex, it's bash parameter expansion)
[02:01:39]
<rodinux>
Ok so in the nextcloud upgrade script just replace by `${app///-}-ynh-deps` ?
[02:14:12]
<rodinux> in the helper it is `${app//_/-}-ynh-deps`
[02:14:48]
<rodinux> I put the same ? the line before is not needed ?
[02:15:09]
<rodinux> ```
# Add a comma for each space between packages. But not add a comma if the space separate a version specification. (See below)
local dependencies="$(sed 's/\([^\<=\>]\)\ \([^(]\)/\1, \2/g' <<< "$@" | sed 's/|/ | /')"
local version=$(ynh_read_manifest "version")
local app_ynh_deps="${app//_/-}-ynh-deps" # Replace all '_' by '-', and append -ynh-deps
```
[02:15:12]
<Aleks (he/him/il/lui)> ah yes
[02:15:34]
<Aleks (he/him/il/lui)> the _ disappeared in the chat because of matrix markdown formatting x_x
[14:03:09]
<Salamandar> (TBH I would love if we used a paradigm like git-flow)
[14:03:11]
<Salamandar> https://aria.im/_bifrost/v1/media/download/AUcDYhteFKIwakokLwCQe81SNlpd6oSQnM_UoHo3nBvSjvCf5JwlUqVr6EVKE2GkICIrz0ke8Fd37eddOczwSaNCeT6Yd9PgAG1hdHJpeC5vcmcvWmVIRFNQcHlyU09ycm5mR0NIS0dIdURW
[15:26:37]
<Salamandar> That way we could have :
* `main` for releases and hotfixes (for 12.0.x)
* the existing `dev` for main versions (for 12.1, 12.2)
* `trixie` for "debian next"
[15:27:02]
<Salamandar> Currently we can't have in parallel hotfixes and main versions
[15:28:12]
<Salamandar> also that would clear up a bit what is `stable` (last release), `unstable` (main HEAD?) and `testing` (`dev`)
[19:12:00]
<Yunohost Git/Infra notifications> [yunohost] Salamandar edited [pull request #2011](https://github.com/YunoHost/yunohost/pull/2011): firewall.py complete revamp
[19:12:25]
<Salamandar> FYI https://github.com/YunoHost/yunohost/pull/2011 is ready to go imho. Thanks @axolotle:matrix.org for your work on the webadmin <3
[19:33:04]
<Yunohost Git/Infra notifications> [yunohost] Salamandar pushed 12 commits to firewall ([293432b50eb8...6802b91e3af5](https://github.com/YunoHost/yunohost/compare/293432b50eb8...6802b91e3af5))
[19:33:06]
<Yunohost Git/Infra notifications> [yunohost/firewall] DONOTMERGE apt update before install - Félix Piédallu
[19:33:06]
<Yunohost Git/Infra notifications> [yunohost/firewall] Replace yunohost-firewall.service with an override on nftables.service to call yunohost hooks on start/reload - Félix Piédallu
[19:33:06]
<Yunohost Git/Infra notifications> [yunohost/firewall] firewall: Add a custom script that run-parts the hooks instead of calling yunohost hook that takes lock - Félix Piédallu
[19:38:09]
<Yunohost Git/Infra notifications> [yunohost] Salamandar pushed 1 commit to firewall: app resources: Fix firewall, exposed can be a bool too ([a1cfdf18](https://github.com/YunoHost/yunohost/commit/a1cfdf18379f2e017af4c1448a3583c005725ea8))
[19:40:31]
<Yunohost Git/Infra notifications> [issues] Tagadda labeled :mailbox: Email on [issue #2487](https://github.com/YunoHost/issues/issues/2487): New subdomains not using DKIM
[19:40:31]
<Yunohost Git/Infra notifications> [issues] Tagadda labeled :book: documentation on [issue #2487](https://github.com/YunoHost/issues/issues/2487): New subdomains not using DKIM
[19:40:31]
<Yunohost Git/Infra notifications> [issues] Tagadda labeled :link: Network on [issue #2487](https://github.com/YunoHost/issues/issues/2487): New subdomains not using DKIM
[19:40:31]
<Yunohost Git/Infra notifications> [issues] Tagadda unlabeled :link: Network on [issue #2487](https://github.com/YunoHost/issues/issues/2487): New subdomains not using DKIM
[19:40:31]
<Yunohost Git/Infra notifications> [issues] Tagadda unlabeled :book: documentation on [issue #2487](https://github.com/YunoHost/issues/issues/2487): New subdomains not using DKIM
[19:40:32]
<Yunohost Git/Infra notifications> [yunohost] github-advanced-security[bot] [commented](https://github.com/YunoHost/yunohost/pull/2011#discussion_r1894324293) on pull request #2011 firewall.py complete revamp: ## Unnecessary else clause in loop
This for statement has a redundant else as no break is present in the body.
...
[19:40:32]
<Tag> Touchscreenz /o\
[19:42:29]
<Yunohost Git/Infra notifications> [yunohost] Salamandar pushed 1 commit to firewall: app resources: Fix firewall, exposed can be a bool too ([43666cf7](https://github.com/YunoHost/yunohost/commit/43666cf7b477fc2157394295e0b7c0bc5df05676))