[08:15:06]
<Yunohost Git/Infra notifications> [ynh-dev] zamentur pushed 1 commit to enh-debug: [fix] bash linter ([2c2d5cf6](https://github.com/YunoHost/ynh-dev/commit/2c2d5cf607cd810a1282916fd53b88df9ee0402a))
[08:38:23]
<eric_G> what about `!testme` only triggering Bookworm CI instead of Bookworm and Bullseye?
[09:31:43]
<orhtej2> https://ci-apps-bullseye-dev.yunohost.org/ci/
[09:31:56]
<orhtej2> Perhaps it's just not commenting?
[09:32:21]
<orhtej2> Also the bug 'im running the same job twice' is concerning
[11:01:57]
<Yunohost Git/Infra notifications> [yunohost] zamentur changes_requested [pull request #1953](https://github.com/YunoHost/yunohost/pull/1953#pullrequestreview-2577625836) Storage mangment API: disks infos: I suggest to split into 2 commands yunohos storage disk list yunohos storage disk info <disk>
[11:01:57]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/1953#discussion_r1931959769) on pull request #1953 Storage mangment API: disks infos: We probably need the accurate value in B and a more human value.
[11:01:57]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/1953#discussion_r1931944602) on pull request #1953 Storage mangment API: disks infos: What if there are no disks at all ? We probably should display a message or something. Currently, its just like this: ...
[11:01:57]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/1953#discussion_r1931830462) on pull request #1953 Storage mangment API: disks infos: We might add udisks2 suggested package to be sure those package will be installed on arm. suggestion , udisks2, udis...
[11:01:58]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/1953#discussion_r1931959022) on pull request #1953 Storage mangment API: disks infos: suggestion rotation_rate = drive.get("RotationRate", -2) I am not totally sure this params is still avail...
[11:01:58]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/1953#discussion_r1931961815) on pull request #1953 Storage mangment API: disks infos: About --human-readable we are doing this in several part of the app, but regarding the cli is often use by a human, i as...
[11:01:58]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/1953#discussion_r1931939035) on pull request #1953 Storage mangment API: disks infos: I suggest to be more consistent with the existing other command lines by splitting in 2 commands: yunohost storage...
[11:01:58]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/1953#discussion_r1931953743) on pull request #1953 Storage mangment API: disks infos: I have tested on my computer with an USB key, and i got -1 suggestion "type": "HDD" if rotation_rate <= 0...
[11:01:58]
<Yunohost Git/Infra notifications> [yunohost] zamentur edited review [pull request #1953](https://github.com/YunoHost/yunohost/pull/1953#pullrequestreview-2577625836): Storage mangment API: disks infos
[11:04:12]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/1953#issuecomment-2618677992) on [issue #1953](https://github.com/YunoHost/yunohost/pull/1953) Storage mangment API: disks infos: I tried to test into an incus container, but drives are not discovered by dbus (lsblk does). Its due to the fact that t...
[11:16:39]
<Yunohost Git/Infra notifications> [yunohost] zamentur pushed 16 commits to enh-perf-ldap-update ([1e1e80f0934f...c7e99af83ab1](https://github.com/YunoHost/yunohost/compare/1e1e80f0934f...c7e99af83ab1))
[11:16:39]
<Yunohost Git/Infra notifications> [yunohost/enh-perf-ldap-update] [enh] Use add instead of update Co-authored-by: Alexandre Aubin <4533074+alexAubin@users.noreply.github.com> - ljf (zamentur)
[11:16:39]
<Yunohost Git/Infra notifications> [yunohost/enh-perf-ldap-update] [enh] Dont use list anymore for ldap upgrade - ljf
[11:16:40]
<Yunohost Git/Infra notifications> [yunohost/enh-perf-ldap-update] [fix] Mypy typing warning - ljf
[21:12:02]
<Yunohost Git/Infra notifications> [yunohost] zamentur pushed 2 commits to enh-perf-ldap-update ([c7e99af83ab1...5ffc2189cf24](https://github.com/YunoHost/yunohost/compare/c7e99af83ab1...5ffc2189cf24))
[21:12:02]
<Yunohost Git/Infra notifications> [yunohost/enh-perf-ldap-update] [fix] python linter - ljf
[21:12:03]
<Yunohost Git/Infra notifications> [yunohost/enh-perf-ldap-update] [fix] python linter - ljf
[21:29:56]
<Yunohost Git/Infra notifications> [synapse_python_build] Gredin67 opened [pull request #1](https://github.com/YunoHost-Apps/synapse_python_build/pull/1): Add script to build rust-unreferenced-states tool
[21:30:46]
<Yunohost Git/Infra notifications> [synapse_python_build] Gredin67 edited [pull request #1](https://github.com/YunoHost-Apps/synapse_python_build/pull/1): Add script to build rust-unreferenced-states tool
[21:44:38]
<Yunohost Git/Infra notifications> [yunohost] zamentur pushed 1 commit to enh-perf-ldap-update: [fix] mypy linter ([ecb6829e](https://github.com/YunoHost/yunohost/commit/ecb6829edb3359adeca1ff3a07f35400c9cd5ae4))
[22:15:12]
<orhtej2> Regarding https://forum.yunohost.org/t/error-restoring-funkwhale/35069: I was trying to implement `--no-remove-on-failure` equivalent for restore, but the interface of `BackupManager` is quite different than the one of `app_*` scripts.
Is there major refactor incoming (to hold off any hackery) or is hacking in a thing that would be considered for merging?
[22:17:39]
<Aleks (he/him/il/lui)> LGTM, don't think there's any particular refactoring incoming for that part