[14:27:42]
<Yunohost Git/Infra notifications> [yunohost] alexAubin pushed 1 commit to app-upgradability-check-requirements: tests: fix apps tests? ([5650d755](https://github.com/YunoHost/yunohost/commit/5650d75546694743da8e6001be67abe2e2447dc8))
[14:54:47]
<Yunohost Git/Infra notifications> [issues] au8st opened [issue #2618](https://github.com/YunoHost/issues/issues/2618): Failiure to set Webadmin IP allowlist
[15:43:33]
<Yunohost Git/Infra notifications> [yunohost] alexAubin pushed 1 commit to app-upgradability-check-requirements: tests: fix apps tests? ([7090c0c5](https://github.com/YunoHost/yunohost/commit/7090c0c5e22c605d5a88cafb8f8eff51f78fe156))
[16:36:07]
<Yunohost Git/Infra notifications> [yunohost] alexAubin pushed 2 commits to app-upgradability-check-requirements ([7090c0c5e22c...ad4c0a58074c](https://github.com/YunoHost/yunohost/compare/7090c0c5e22c...ad4c0a58074c))
[16:36:08]
<Yunohost Git/Infra notifications> [yunohost/app-upgradability-check-requirements] tests: propagate changes to app tests - Alexandre Aubin
[16:36:43]
<Yunohost Git/Infra notifications> [yunohost/app-upgradability-check-requirements] tests: Mokay whatever, fuck coverage, because its flooding the logs with error when calling subprocesses... - Alexandre Aubin
[17:11:14]
<Yunohost Git/Infra notifications> [yunohost/app-upgradability-check-requirements] tests: Mokay whatever, fuck coverage, because its flooding the logs with error when calling subprocesses... - Alexandre Aubin
[17:11:14]
<Yunohost Git/Infra notifications> [yunohost/app-upgradability-check-requirements] tests: propagate changes to app tests - Alexandre Aubin
[17:11:14]
<Yunohost Git/Infra notifications> [yunohost] alexAubin pushed 2 commits to app-upgradability-check-requirements ([ad4c0a58074c...11b0103ef85b](https://github.com/YunoHost/yunohost/compare/ad4c0a58074c...11b0103ef85b))
[18:59:22]
<Yunohost Git/Infra notifications> [yunohost] alexAubin pushed 1 commit to app-upgradability-check-requirements: tests: propagate changes to app tests ([dacdc9ce](https://github.com/YunoHost/yunohost/commit/dacdc9ceceac2aa9f8a2aea56b0e99cb3f0b5d09))
[20:02:49]
<Yunohost Git/Infra notifications> [yunohost/app-upgradability-check-requirements] typing: undefined typed, switch to str-type-name - Alexandre Aubin
[20:02:49]
<Yunohost Git/Infra notifications> [yunohost] alexAubin pushed 31 commits to app-upgradability-check-requirements ([dacdc9ceceac...921d64820d91](https://github.com/YunoHost/yunohost/compare/dacdc9ceceac...921d64820d91))
[20:02:50]
<Yunohost Git/Infra notifications> [yunohost/app-upgradability-check-requirements] Merge remote-tracking branch origin/dev into app-upgradability-check-requirements - Alexandre Aubin
[20:02:50]
<Yunohost Git/Infra notifications> [yunohost/app-upgradability-check-requirements] typing: undefined typed, switch to str-type-name - Alexandre Aubin
[20:04:32]
<Yunohost Git/Infra notifications> [yunohost] github-advanced-security[bot] [commented](https://github.com/YunoHost/yunohost/pull/2115#discussion_r2249378534) on pull request #2115 apps: rework the upgrade info mechanism to also check requirements + allow to have a different upgrade source (eg testing branch) + group system package by categories to improve UI/UX : ## break or return statement in finally
return in a finally block will swallow any exceptions raised.
[Show more...
[20:19:47]
<Yunohost Git/Infra notifications> [yunohost] alexAubin pushed 1 commit to app-upgradability-check-requirements: typing: Unions with | dont work with string-type-names ([710df154](https://github.com/YunoHost/yunohost/commit/710df15451bb305a52cd359c2d84da5c437710d8))
[20:38:05]
<Salamandar> > <@yunohostinfra:matrix.org> [yunohost] alexAubin pushed 1 commit to app-upgradability-check-requirements: typing: Unions with | dont work with string-type-names ([710df154](https://github.com/YunoHost/yunohost/commit/710df15451bb305a52cd359c2d84da5c437710d8))
[@Alekswag:matrix.org](https://matrix.to/#/@Alekswag:matrix.org) you just need to quote the whole type hint `"mystringedtype | int"`
[20:38:19]
<Aleks (he/him/il/lui)> ¯\_(ツ)_/¯
[20:38:29]
<Salamandar> Or from future import annotations
[20:40:36]
<Aleks (he/him/il/lui)> idk i'm just trying to make the tests pass ...
[20:41:14]
<Aleks (he/him/il/lui)> `dev` aint supposed to be completely broken
[21:54:54]
<Aleks (he/him/il/lui)> zzzzz mypy doesn't understand that `dict[str, A]` is an ok type when expecting `dict[str, A | B]`
[21:57:48]
<orhtej2> well technically they're not the same
[21:57:57]
<orhtej2> (in this wtf typed language)
[21:58:15]
<Aleks (he/him/il/lui)> i suppose yeah but it's a subset sooooo ?
[21:58:42]
<orhtej2> this requires understanding (by the lang/linter) concept of covariance
[21:59:22]
<Aleks (he/him/il/lui)> 😭
[21:59:36]
<orhtej2> which i.e. .net did not till a couple of years into its development
[22:00:06]
<Aleks (he/him/il/lui)> i just wanted to save the wurld from FAANGS, not teach type algebra to computers 😭
[22:01:08]
<orhtej2> I offer no solution as my python coding skills are 'i can judge if copilot is totally making up syntax'
[22:05:21]
<orhtej2> after skimming through [the docs](https://mypy.readthedocs.io/en/stable/generics.html) I offer even less insight 🤷
[22:12:51]
<Aleks (he/him/il/lui)> maybe that's about replacing dict with Mapping
[22:16:36]
<orhtej2> come to think about, it refuses to accept `dict[str, A | B]` as `dict[str, A]` (which is not a case as you need to explicitly filter out `B` elements) or actually what?
[22:16:55]
<orhtej2> Accept `dict[str, A]` as `dict[str, A | B]`?
[22:18:47]
<Aleks (he/him/il/lui)> (`Mapping` instead of `dict` seems to do the trick)
the context is something like a `create_record(name: str, data: dict[str, str | list[str]])` and then the code calls `create_record(...)` with the second arg being "just" a `dict[str, str]`
[22:19:27]
<Aleks (he/him/il/lui)> (in fact I'm talking about `ldap.add` and `ldap.update` in yunohost code)
[22:52:01]
<Yunohost Git/Infra notifications> [yunohost] alexAubin pushed 2 commits to app-upgradability-check-requirements ([710df15451bb...33873923daff](https://github.com/YunoHost/yunohost/compare/710df15451bb...33873923daff))
[22:52:06]
<Yunohost Git/Infra notifications> [yunohost/app-upgradability-check-requirements] typing: bunch of typing fixes / improvements - Alexandre Aubin
[22:52:10]
<Yunohost Git/Infra notifications> [yunohost/app-upgradability-check-requirements] Fix apps tests? - Alexandre Aubin
[22:53:45]
<Yunohost Git/Infra notifications> [yunohost] github-advanced-security[bot] [commented](https://github.com/YunoHost/yunohost/pull/2115#discussion_r2249448763) on pull request #2115 apps: rework the upgrade info mechanism to also check requirements + allow to have a different upgrade source (eg testing branch) + group system package by categories to improve UI/UX : ## Module-level cyclic import
DNSRecord may not be defined if module [src.dns](1) is imported before module [src.doma...
[22:53:49]
<Yunohost Git/Infra notifications> [yunohost] github-advanced-security[bot] [commented](https://github.com/YunoHost/yunohost/pull/2115#discussion_r2249448764) on pull request #2115 apps: rework the upgrade info mechanism to also check requirements + allow to have a different upgrade source (eg testing branch) + group system package by categories to improve UI/UX : ## Syntax error
Syntax Error (in Python 3).
[Show more details](https://github.com/YunoHost/yunohost/security/code-sca...
[22:53:50]
<Yunohost Git/Infra notifications> [yunohost] github-advanced-security[bot] [commented](https://github.com/YunoHost/yunohost/pull/2115#discussion_r2249448761) on pull request #2115 apps: rework the upgrade info mechanism to also check requirements + allow to have a different upgrade source (eg testing branch) + group system package by categories to improve UI/UX : ## Unused import
Import of AbstractSetIntStr is not used.
Import of MappingIntStrAny is not used.
[Show more detai...
[23:41:20]
<Yunohost Git/Infra notifications> [yunohost] alexAubin pushed 1 commit to app-upgradability-check-requirements: Fix apps tests? ([81cbd9ef](https://github.com/YunoHost/yunohost/commit/81cbd9ef9461c73fe3abd21a8695e92f49423bde))