[00:00:06]
<Yunohost Git/Infra notifications> 🏗️ Starting build for yunohost/12.1.20+202509090200 for bookworm/unstable/all...
[00:02:11]
<Yunohost Git/Infra notifications> ✔️ Completed distribution for yunohost/12.1.20+202509090200 for bookworm/unstable.
[00:02:11]
<Yunohost Git/Infra notifications> ✔️ Completed build for yunohost/12.1.20+202509090200 for bookworm/unstable/all.
[00:02:59]
<miro5001> https://aria.im/_bifrost/v1/media/download/AcTIKcsVrgtsHB5MZu3T1AYEQiN7us8hv774QAO_CibiclvuCXHY2SYP9atl6BGbdZLeD0ghkGM4yHwk771iyWxCeZMO7JqQAG1hdHJpeC5vcmcvZVRiTVBJdGtORVNmS3J0Q01MUlVmSUpk
[00:06:44]
<Aleks (he/him/il/lui)> emeged look at teh time
[00:06:52]
<Aleks (he/him/il/lui)> its starcraft oclock
[00:10:56]
<Émy – OniriCorpe> Early morning ☕️
[00:11:29]
<miro5001> Bug fix qui aurait pu ne pas être fait
[00:14:09]
<Émy – OniriCorpe> https://aria.im/_bifrost/v1/media/download/AdXHB0-9FUjaGWSpYyvwOoMsaFyd_SPGiSNEN1FrAvPh4SmczADEKW4mOx2g_8o5fIe-j_MBBm7p548wyMAp9RVCeZMPkBIwAGltLmVtZWx5bmUuZXUvcEl4WkRzUWtSUnBHUGFKRWhnWUR0ZHpL
[00:14:53]
<Aleks (he/him/il/lui)> :blobmelt:
[09:16:34]
<Yunohost Git/Infra notifications> [issues] Enthouane [commented](https://github.com/YunoHost/issues/issues/2474#issuecomment-3269690333) on [issue #2474](https://github.com/YunoHost/issues/issues/2474) If top-level domain is hosted on another server, SSO is unavailable: I have the same issue :
- domain.tld is a wordpress site hosted by wordpress
- sub.domain.tld are every yunohost app
I...
[09:22:23]
<mrflos> hi, anyone else gets the following warning that stops app upgrades (forgejo in my case)? `Warning: /usr/share/yunohost/helpers.v2.1.d/templating: line 114: YNH_J2_FILTERS_FILE_PATH : unbound variable` cf. https://paste.yunohost.org/raw/aqamocohok
[09:26:22]
<miro5001> https://github.com/YunoHost-Apps/synapse_ynh/issues/570
[09:28:30]
<mrflos> ok i'm trying to upgrade after commenting this line https://github.com/YunoHost/yunohost/blob/f35a46f11b6d6b69983859322ba9fb05ca957af5/helpers/helpers.v2.1.d/templating#L115
I suppose the helper needs a test so that it doesn't generate an error if not set\
[09:46:41]
<mrflos> returning to the former `j2 "$template\_path" -f env -o "$destination"` solves the forgrjo upgrade
[09:52:10]
<mrflos> i can make a yolo PR with something like:
```bash
if [ -z ${YNH_J2_FILTERS_FILE_PATH+x} ];
then j2 "$template_path" -f env -o "$destination";
else
j2 "$template_path" -f env \
--filters "$YNH_J2_FILTERS_FILE_PATH" \
-o "$destination";
fi
```
spoiler alert: i'm bad in bash
[10:03:49]
<mrflos> i can make a yolo PR with something like:
```bash
if [ -z ${YNH_J2_FILTERS_FILE_PATH+x} ]; then
j2 "$template_path" -f env -o "$destination"
else
j2 "$template_path" -f env \
--filters "$YNH_J2_FILTERS_FILE_PATH" \
-o "$destination"
fi
```
spoiler alert: i'm bad in bash
[10:11:55]
<miro5001> focus on what you are good at
[10:13:49]
<mrflos> i'm good at fixing things so i will make a PR so that bash people can check it
[10:29:37]
<Yunohost Git/Infra notifications> [yunohost] mrflos opened [pull request #2172](https://github.com/YunoHost/yunohost/pull/2172): fix(helpers): test not initialized var
[10:52:47]
<Yunohost Git/Infra notifications> [yunohost] mrflos edited [pull request #2172](https://github.com/YunoHost/yunohost/pull/2172): fix(helpers): test not initialized var
[13:53:25]
<Yunohost Git/Infra notifications> [yunohost] alexAubin [commented](https://github.com/YunoHost/yunohost/pull/2172#discussion_r2333733852) on pull request #2172 fix(helpers): test not initialized var: suggestion if [ -z "{YNH_J2_FILTERS_FILE_PATH:-}" ] then
[13:54:01]
<Yunohost Git/Infra notifications> [yunohost] alexAubin edited [pull request #2172](https://github.com/YunoHost/yunohost/pull/2172): fix(helpers): YNH_J2_FILTERS_FILE_PATH may not exist
[13:54:16]
<Yunohost Git/Infra notifications> [yunohost] alexAubin merged [pull request #2172](https://github.com/YunoHost/yunohost/pull/2172): fix(helpers): YNH_J2_FILTERS_FILE_PATH may not exist
[14:00:08]
<Yunohost Git/Infra notifications> 🏗️ Starting build for yunohost/12.1.20+202509091600 for bookworm/unstable/all...
[14:01:34]
<Yunohost Git/Infra notifications> ✔️ Completed build for yunohost/12.1.20+202509091600 for bookworm/unstable/all.
[14:01:35]
<Yunohost Git/Infra notifications> ✔️ Completed distribution for yunohost/12.1.20+202509091600 for bookworm/unstable.
[15:40:43]
<Yunohost Git/Infra notifications> [yunohost] Josue-T pushed to fix_jinja_filter: Revert "Merge pull request #2172 from mrflos/repair-helper" This reverts commit 5205718cc8638e088cb3ab68137617974470d9d... ([6e453a25](https://github.com/YunoHost/yunohost/commit/6e453a256d2bb16a39f6a5c1d25739c16d2d588e))
[15:40:44]
<Yunohost Git/Infra notifications> [yunohost] Josue-T pushed to fix_jinja_filter: Fix unset variable YNH_J2_FILTERS_FILE_PATH ([77929656](https://github.com/YunoHost/yunohost/commit/77929656f237c2e1d3ead991e96e7f88bf444d15))
[15:42:43]
<Yunohost Git/Infra notifications> [yunohost] Josue-T opened [pull request #2173](https://github.com/YunoHost/yunohost/pull/2173): fix again (helpers): YNH_J2_FILTERS_FILE_PATH may not exist
[19:41:07]
<Yunohost Git/Infra notifications> [yunohost] Josue-T pushed to jinja_filters_tests: Avoid test marked as pass even if it fail. Note doing if my_cmd then ... fi have the effect to disable set -eu for the... ([a2bb07f2](https://github.com/YunoHost/yunohost/commit/a2bb07f23c64ed6013a4191423ff460c37b62be6))
[19:41:07]
<Yunohost Git/Infra notifications> [yunohost] Josue-T pushed to jinja_filters_tests: Fix composer, ruby and go tests ([f6b23456](https://github.com/YunoHost/yunohost/commit/f6b234567d12f5a291fea3a4d85886a29721e0bd))
[19:41:07]
<Yunohost Git/Infra notifications> [yunohost] Josue-T pushed to jinja_filters_tests: Add more templating test with jinja filters ([a30dae77](https://github.com/YunoHost/yunohost/commit/a30dae773fd19e109d4adc7425136ee01f2c6546))
[19:49:43]
<Yunohost Git/Infra notifications> [yunohost] Josue-T opened [pull request #2174](https://github.com/YunoHost/yunohost/pull/2174): Fix helpers tests
[19:53:16]
<Josué> Was really surprised about the effect of bash on this... and we might have some other part of code which is broken because of this...
[20:18:40]
<Aleks (he/him/il/lui)> >doing `if my_cmd` have the effect in bash to disable `set -eu` even in the sub-shell...
[20:18:47]
<Aleks (he/him/il/lui)> wat
[20:21:28]
<Aleks (he/him/il/lui)> Josué: i don't get why in the second case, `b`'s return code is 1 ?
[20:22:41]
<Josué> because b call a which call `false` which make a failing which then make b failing
[20:23:07]
<Aleks (he/him/il/lui)> ah yes because of set -e
[20:23:08]
<Aleks (he/him/il/lui)> hmmm
[20:23:17]
<Aleks (he/him/il/lui)> but then why is it 0 in the first case :D
[20:26:43]
<Josué> because when you have something like `if my_function_call`. If you call `set -e` in `my_function_call` it's ignored... even is sub-shell
[20:26:52]
<Aleks (he/him/il/lui)> simpler version :
```bash
foo() {
(
set -eux
non_existing_command
true
)
}
foo && echo OK || echo Not OK
foo
result=$?
[ $result -eq 0 ] && echo OK || echo Not OK
```
[20:27:17]
<Aleks (he/him/il/lui)> simpler version :
```bash
foo() {
(
set -eux
non_existing_command
true
)
}
foo && echo OK || echo Not OK
foo
result=$?
[ $result -eq 0 ] && echo OK || echo Not OK
```
and result:
```
+ non_existing_command
gni.sh: line 4: non_existing_command: command not found
+ true
OK
+ non_existing_command
gni.sh: line 4: non_existing_command: command not found
Not OK
```
[20:27:30]
<Aleks (he/him/il/lui)> wtf...
[20:28:05]
<Josué> yes... 😱
[20:28:36]
<Aleks (he/him/il/lui)> someone please save us and make a modern version of bash ffs
[20:29:17]
<Josué> I think I've probably some part of code buggy because of that... because I was never supposing having an effect like this..
[20:29:54]
<Aleks (he/him/il/lui)> i suppose it wouldnt change much things if set -eu was just enabled everywhere all the time by default ?
[20:30:04]
<Josué> even better, we should just use only python in packaging v3...
[20:30:34]
<Aleks (he/him/il/lui)> or at least reduce the bash codebase, yeah, i'm on it ... i have a POC for the apt helpers using python
[20:30:48]
<Josué> no it dont change anything...
[20:31:44]
<Josué> Probably the good way to do this is this way: https://github.com/YunoHost-Apps/seafile_ynh/blob/77f106ffcc94d2c357410f8fd757aae1bf9f98c8/auto_update/auto_update.sh#L96-L100
[20:33:45]
<Josué> because if you just enable `set -e` and then call your command, if the command fail the script fail and it's not what you want... And if you add something like `my_command || true` to catch the error, `set -e` is disabled in the sub-command...
[20:37:27]
<Aleks (he/him/il/lui)> https://c.tenor.com/L66gfL1eMUsAAAAC/tenor.gif
[20:47:33]
<Yunohost Git/Infra notifications> [yunohost] Josue-T pushed to jinja_filters_tests: Try fix tests ([372bb6f3](https://github.com/YunoHost/yunohost/commit/372bb6f3068544a67deebc26b5dfaeffb9e3e2b1))