[13:57:32]
<Yunohost Git/Infra notifications> [yunohost] Salamandar pushed to fpu-fix_dnsmasq: debug ([ec3cbda2](https://github.com/YunoHost/yunohost/commit/ec3cbda26d8f747e8f59fbadd66510e515db481d))
[13:57:50]
<Yunohost Git/Infra notifications> [yunohost] Salamandar opened [pull request #2276](https://github.com/YunoHost/yunohost/pull/2276): debug
[15:18:56]
<Yunohost Git/Infra notifications> [yunohost] Salamandar pushed to fpu-fix_dnsmasq: debug ([234d5eb3](https://github.com/YunoHost/yunohost/commit/234d5eb391d4a02e978587b8cc01d01be533195f))
[16:00:58]
<Yunohost Git/Infra notifications> [yunohost] Salamandar pushed to fpu-fix_dnsmasq: debug again ([b3e96e65](https://github.com/YunoHost/yunohost/commit/b3e96e65510984f66e27fe243e97f340ddc0dd37))
[16:17:16]
<Yunohost Git/Infra notifications> [yunohost] Salamandar pushed to fpu-fix_dnsmasq: debian/postinst: Fix dnsmasq do_init_regen, YNH_SETTINGS should not be empty Signed-off-by: Félix Piédallu <felix@pieda... ([b3a89576](https://github.com/YunoHost/yunohost/commit/b3a895769792d7b8a4186d9d41348bc1f85b704f))
[17:55:11]
<Yunohost Git/Infra notifications> [yunohost] Salamandar pushed to dev: debian/postinst: Fix dnsmasq do_init_regen, YNH_SETTINGS should not be empty Signed-off-by: Félix Piédallu <felix@pieda... ([49339ced](https://github.com/YunoHost/yunohost/commit/49339ced0ddca491fe3cd98fac9ef3d0ccef4e26))
[17:55:26]
<Yunohost Git/Infra notifications> [yunohost] Salamandar deleted branch fpu-fix_dnsmasq
[17:55:30]
<Yunohost Git/Infra notifications> [yunohost] Salamandar closed [pull request #2276](https://github.com/YunoHost/yunohost/pull/2276): debug
[18:00:16]
<Yunohost Git/Infra notifications> 🏗️ Starting build for yunohost/12.1.39+202602111900 for bookworm/unstable/all...
[18:01:54]
<Yunohost Git/Infra notifications> ✔️ Completed build for yunohost/12.1.39+202602111900 for bookworm/unstable/all.
[18:01:54]
<Yunohost Git/Infra notifications> ✔️ Completed distribution for yunohost/12.1.39+202602111900 for bookworm/unstable.
[20:00:11]
<Josué> Hello hello,
If someone have some time to review the PR https://github.com/YunoHost/package_linter/pull/183 it would be nice as it is blocking the merge on master of synapse.
I can also just merge it, but having a other opinion about this would be nice.
[21:33:56]
<Salamandar> nitpick but the content of the PR should be in the commit message
[21:37:12]
<Josué> Nerver heard about this best practice but why not 😅 Note I think if we leave the PR number when we do the merge it's quite easy to find the PR.
[21:38:42]
<Salamandar> yeah but rebase merge will lose link with the PR
[21:38:48]
<Salamandar> most of the big projects have this practice
[21:39:04]
<Salamandar> when doing git log you don't have github.com open :)
[21:39:21]
<Salamandar> commits should be self-explanatory (and at yunohost we are bad students of that)
[21:39:54]
<Salamandar> tbh i'm trying to understand the changes and it's kinda difficult. Why did you change the regex, etc
[21:43:03]
<Salamandar> aaah but there are 2 changes there
[21:43:13]
<Josué> ah yes good question. Because currently the regex just return a list with the parameter name but not the value. Now we need to check if the value is the default value which is used
[21:43:42]
<Salamandar> the one around `include_params_with_auth_at_last_in_one_conf` and the one around the greylist
[21:44:44]
<Salamandar> could it please be possible to split your commit in half ? The first is OK i guess but the stuff around the greylist… might be a bit more discutable
[21:46:05]
<Josué> yes 😅 there are the grey/black list and other stuff one change which is more a bug fix about the check when sso=true
[21:54:56]
<Josué> done
[22:15:14]
<Salamandar> Thank you that's way more readable :D
The first commit is ok for me
[22:17:03]
<Salamandar> the second is OK for me too