[09:57:23]
<Renard> Hi ! I tried the update from 7.3.0~ynh2 to 8.0.1~ynh1 (testing branch) and the upgrade worked fine (from a blank Peertube fresh installed) : https://paste.yunohost.org/raw/leqekupunu
I'm was not sure if the Yunorunner try the upgrade from old versions like that
[10:49:29]
<orhtej2> > <@renarrdd:matrix.org> Hi ! I tried the update from 7.3.0~ynh2 to 8.0.1~ynh1 (testing branch) and the upgrade worked fine (from a blank Peertube fresh installed) : https://paste.yunohost.org/raw/leqekupunu
>
> I'm was not sure if the Yunorunner try the upgrade from old versions like that
It does
[10:50:27]
<orhtej2> have you tried installing 7.x, fixing ldap by reinstalling ldap plugin and only then upgrading? Imo that's the failing scenario
[12:38:18]
<wazdra> Hey ! I'd like to encrypt at rest my /home partition. My main trouble with this is that I'd need to make sure that this partition is correctly mounted before the whole boot process starts (to avoid failed services on each boot). Is there a good way to do this ?
[16:35:08]
<Chatpitaine Caverne> eric_G: Hello Eric,
I see the PR Testing #517 has been merged to master branch. I don't see a -ynh2 update, still `(peertube) de 7.3.0~ynh2 à 8.0.1~ynh1`
Does this mean we can try an upgrade with the hope of issue corrected ?
If yes, I have a general backup tonight and I could try an upgrade tomorrow.
Thank you.
[16:53:06]
<eric_G> No guarantees, no refunds. 😶🌫️
[16:57:48]
<Chatpitaine Caverne> No worries, I have no funds to refund (even if I like, when I can, to help a little bit Yunohost project with some donations, but donation is donation, not buy).
However I have a 300Go Peertube Instance and it's really pain in the a.s to restore when crashed. So if someone with a small instance can try, I'd be safer.
[17:05:00]
<eric_G> The fix was related to installing the plugin with pnpm during installation and upgrades. I'm not sure about the bugs reported during the transition from Yarn to Pnpm. (I can't test Peertube on my server right now.)
[17:06:14]
<Renard> I’ve just tried again: I installed version 7.3.0, completed the configuration, reinstalled the LDAP plugin from the PeerTube web interface, then upgraded to the current testing branch and everything worked correctly.
I still opened a ""security"" pull request here: https://github.com/YunoHost-Apps/peertube\_ynh/pull/518
.
The goal is to clean up old Yarn configuration files that can break plugin installation during the upgrade to PeerTube 8, as PNPM refuses to run when legacy Yarn files are still present.
I tested this on a clean machine with a freshly installed PeerTube instance, so I’m not entirely sure I can reliably reproduce the original bug from my side. I might be missing something, as I’m not very strong in code, but this fix (i hope) should make upgrades more robust for existing installations that have gone through multiple versions.
[17:06:58]
<otm33> Do yunohost app upgrade peertube -b -F and yunohost app upgrade peertube -u https://github.com/YunoHost-Apps/peertube\_ynh -F -b do exactly the same thing?
[17:09:47]
<otm33> Do `yunohost app upgrade peertube -b -F` and `yunohost app upgrade peertube -u https://github.com/YunoHost-Apps/peertube\_ynh -F -b do exactly the same thing?
[17:10:00]
<otm33> Do `yunohost app upgrade peertube -b -F` and \`yunohost app upgrade peertube -u https://github.com/YunoHost-Apps/peertube\_ynh -F -b` do exactly the same thing?
[17:10:10]
<otm33> Do `yunohost app upgrade peertube -b -F` and `yunohost app upgrade peertube -u https://github.com/YunoHost-Apps/peertube\_ynh -F -b` do exactly the same thing?
[17:10:32]
<otm33> Do `yunohost app upgrade peertube -b -F` and `yunohost app upgrade peertube -u https://github.com/YunoHost-Apps/peertube_ynh -F -b` do exactly the same thing?
[17:18:11]
<otm33> ..because one fails and the other works... ¯\\_(ツ)\_/¯ (install from 7.3.0)
[17:19:34]
<Chatpitaine Caverne> I would say "computers were a mistake, and we should burn them all" but maybe there is an explanation.
[17:34:48]
<mathieuw> > <@chatpitaine:cirkau.art> I would say "computers were a mistake, and we should burn them all" but maybe there is an explanation.
The two statements are not contradictory IMHO: even if there is an explanation, we will have to resign ourselves to burning the computers someday.
[18:02:36]
<otm33> Step 1
```
yunohost app remove peertube
rm -rf /home/yunohost.app/peertube
yunohost app install https://github.com/YunoHost-Apps/peertube_ynh/tree/c200ab3b8fd2c001b1d619fa8a69db2699149a48 --force
```
ackage.json content :
Step 2
`yunohost app upgrade peertube -b -F` log : https://paste.yunohost.org/raw/esiqoluhat
Step 1
Step 2
`yunohost app upgrade peertube -u https://github.com/YunoHost-Apps/peertube_ynh -F -b` log : https://paste.yunohost.org/raw/osizugowem
[18:03:21]
<otm33> Step 1
```
yunohost app remove peertube
rm -rf /home/yunohost.app/peertube
yunohost app install https://github.com/YunoHost-Apps/peertube_ynh/tree/c200ab3b8fd2c001b1d619fa8a69db2699149a48 --force
```
package.json content : ```{
"packageManager": "yarn@1.22.22+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e",
"dependencies": {
"peertube-plugin-auth-ldap": "0.0.14",
"peertube-plugin-livechat": "14.0.2"
}
``
Step 2
`yunohost app upgrade peertube -b -F` log : https://paste.yunohost.org/raw/esiqoluhat
---
Step 1
Step 2
`yunohost app upgrade peertube -u https://github.com/YunoHost-Apps/peertube_ynh -F -b` log : https://paste.yunohost.org/raw/osizugowem
[18:03:40]
<otm33> Step 1
```
yunohost app remove peertube
rm -rf /home/yunohost.app/peertube
yunohost app install https://github.com/YunoHost-Apps/peertube_ynh/tree/c200ab3b8fd2c001b1d619fa8a69db2699149a48 --force
```
package.json content : ``{
"packageManager": "yarn@1.22.22+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e",
"dependencies": {
"peertube-plugin-auth-ldap": "0.0.14",
"peertube-plugin-livechat": "14.0.2"
}
\`\`
Step 2
`yunohost app upgrade peertube -b -F` log : https://paste.yunohost.org/raw/esiqoluhat
Step 1
Step 2
`yunohost app upgrade peertube -u https://github.com/YunoHost-Apps/peertube_ynh -F -b` log : https://paste.yunohost.org/raw/osizugowem
[18:04:20]
<otm33> Step 1
```
yunohost app remove peertube
rm -rf /home/yunohost.app/peertube
yunohost app install https://github.com/YunoHost-Apps/peertube_ynh/tree/c200ab3b8fd2c001b1d619fa8a69db2699149a48 --force
```
package.json content : \`\`\{
"packageManager": "yarn@1.22.22+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e",
"dependencies": {
"peertube-plugin-auth-ldap": "0.0.14",
"peertube-plugin-livechat": "14.0.2"
}
\`\`\
Step 2
`yunohost app upgrade peertube -b -F` log : https://paste.yunohost.org/raw/esiqoluhat
2d try
Step 1
Step 2
`yunohost app upgrade peertube -u https://github.com/YunoHost-Apps/peertube_ynh -F -b` log : https://paste.yunohost.org/raw/osizugowem
[18:05:07]
<otm33> Step 1
```
yunohost app remove peertube
rm -rf /home/yunohost.app/peertube
yunohost app install https://github.com/YunoHost-Apps/peertube_ynh/tree/c200ab3b8fd2c001b1d619fa8a69db2699149a48 --force
```
package.json content : `` {
"packageManager": "yarn@1.22.22+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e",
"dependencies": {
"peertube-plugin-auth-ldap": "0.0.14",
"peertube-plugin-livechat": "14.0.2"
}
```
Step 2
`yunohost app upgrade peertube -b -F` log : https://paste.yunohost.org/raw/esiqoluhat
2d try
Step 1
Step 2
`yunohost app upgrade peertube -u https://github.com/YunoHost-Apps/peertube_ynh -F -b` log : https://paste.yunohost.org/raw/osizugowem
[18:05:41]
<otm33> Step 1
```
yunohost app remove peertube
rm -rf /home/yunohost.app/peertube
yunohost app install https://github.com/YunoHost-Apps/peertube_ynh/tree/c200ab3b8fd2c001b1d619fa8a69db2699149a48 --force
```
package.json content :
```
{
"packageManager": "yarn@1.22.22+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e",
"dependencies": {
"peertube-plugin-auth-ldap": "0.0.14",
"peertube-plugin-livechat": "14.0.2"
}
```
Step 2
`yunohost app upgrade peertube -b -F` log : https://paste.yunohost.org/raw/esiqoluhat
2d try
Step 1
Step 2
`yunohost app upgrade peertube -u https://github.com/YunoHost-Apps/peertube_ynh -F -b` log : https://paste.yunohost.org/raw/osizugowem
```
[18:06:07]
<otm33> Step 1
```
yunohost app remove peertube
rm -rf /home/yunohost.app/peertube
yunohost app install https://github.com/YunoHost-Apps/peertube_ynh/tree/c200ab3b8fd2c001b1d619fa8a69db2699149a48 --force
```
package.json content :
```
{
"packageManager": "yarn@1.22.22+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e",
"dependencies": {
"peertube-plugin-auth-ldap": "0.0.14",
"peertube-plugin-livechat": "14.0.2"
}
```
Step 2
`yunohost app upgrade peertube -b -F` log : https://paste.yunohost.org/raw/esiqoluhat
2d try
Step 1
Step 2
`yunohost app upgrade peertube -u https://github.com/YunoHost-Apps/peertube_ynh -F -b` log : https://paste.yunohost.org/raw/osizugowem
[18:18:47]
<otm33> `yunohost app upgrade peertube -b -F` seems to use the upgrade script from <del>the app's script folder</del> whereas `yunohost app upgrade peertube -u https://github.com/YunoHost-Apps/peertube_ynh -F -b` uses the repo upgrade file.
[18:20:55]
<otm33> `yunohost app upgrade peertube -b -F` seems to use the upgrade script from ??? <del>the app's script folder</del> whereas `yunohost app upgrade peertube -u https://github.com/YunoHost-Apps/peertube_ynh -F -b` uses the repo upgrade file.
[18:26:40]
<otm33> `yunohost app upgrade peertube -b -F` seems to use the upgrade script from ??? <del>the app's script folder</del>(version 7.3.0) whereas `yunohost app upgrade peertube -u https://github.com/YunoHost-Apps/peertube_ynh -F -b` uses the repo upgrade file (8.0.1).
[19:41:36]
<Chatpitaine Caverne> I assume the GUI lauch of an upgrade uses the repo's script. ??
[19:59:16]
<otm33> `yunohost app upgrade peertube -b -F` uses the upgrade script from /var/cache/yunohost/gitclones/xxxx/scripts/upgrade = <del>version 7.3.0 upgrade.</del> 8.0.1 version without yesterday's changes. So it fails...
[20:19:14]
<otm33> Seems to be the problem : Fetching https://github.com/YunoHost-Apps/peertube_ynh (branch=master, revision=**773a86d944883017ebad05c7a02faf38e2a3f6bf**
[21:13:40]
<Spok> I'm not sure if stomping `package.json` is the way to go, pnpm comes with `pnpm import` where theoretically you can delete `node_modules` and ask it to `pnpm import` and it **should** re-generate the lock file
[21:13:47]
<Spok> but IDK, I'm not NodeJS programmer
[21:14:24]
<Spok> also plugins are or are not in `pnpm` workspace so using proper dir is more demanding :shrug
[21:14:41]
<orhtej2> also I should stop alternating between accounts
[21:37:06]
<Renard> aaah... Sorry, i should not touch things like that, though it was a good idea
[23:09:19]
<otm33> `yunohost app upgrade peertube -b -F` seems to use the upgrade script from ??? <del>the app's script folder (version 7.3.0)</del> outdated 8.0.1 whereas `yunohost app upgrade peertube -u https://github.com/YunoHost-Apps/peertube_ynh -F -b` uses the repo latest upgrade file (8.0.1).