[01:54:00]
<Yunohost Git/Infra notifications> App pagure failed all tests in job [#15702](https://ci-apps.yunohost.org/ci/job/15702) :(
[07:00:50]
<Yunohost Git/Infra notifications> App peertube-search-index failed all tests in job [#15704](https://ci-apps.yunohost.org/ci/job/15704) :(
[11:15:32]
<Yunohost Git/Infra notifications> App photonix failed all tests in job [#15708](https://ci-apps.yunohost.org/ci/job/15708) :(
[13:24:56]
<benjamin> Salut tout le monde. Est-ce qu'on parle francais ici, ou est anglais d'accord aussi?
[13:47:36]
<Aleks (he/him/il/lui)> whichever you are most comfortabl with
[13:50:10]
<benjamin> Ah, thank you, that's great, as my French has never been good. Gonna be reading mostly for the next time, to get an idea what's happening here.
[16:28:23]
<Tag> zblerg... bash again :(
```
63. if [ -z "$password" ]; then
64. password=$(ynh_read_var_in_file --file="$install_dir/.env" --key="MINIO_ROOT_PASSWORD")
65. fi
```
gives me
```
15431 INFO WARNING - ./upgrade: line 63: password: unbound variable
```
but that's exactly what i want to test here ><
[16:32:50]
<Aleks (he/him/il/lui)> eeeeh
[16:33:11]
<Aleks (he/him/il/lui)> ah yes
[16:33:12]
<Aleks (he/him/il/lui)> because set -eu is set and you're testing ${password} is empty
[16:33:25]
<Aleks (he/him/il/lui)> you want to have `if [ -z "${password:-}"]` i think
[17:03:26]
<Tag> > <@Alekswag:matrix.org> because set -eu is set and you're testing ${password} is empty
This is new from packaging v2 ?
[17:03:48]
<Aleks (he/him/il/lui)> hmmmm not really, this is standard bash behavior once you have set -eu haha
[17:03:49]
<Aleks (he/him/il/lui)> but
[17:03:59]
<Aleks (he/him/il/lui)> your specific case may be related to packaging v2
[17:04:26]
<Aleks (he/him/il/lui)> because in v1 settings were explicitly loaded with `password=$(ynh_app_setting_get foo bar)`
[17:04:53]
<Aleks (he/him/il/lui)> but because now they are implicly loaded, sometimes you don't know if a var exist just by reading the script file
[17:05:29]
<Aleks (he/him/il/lui)> and also `ynh_app_setting_get foo bar` returned empty string if the setting didnt exist
[17:06:09]
<Aleks (he/him/il/lui)> hence why we had many `if [[ -z "$foobar" ]]` in the past but now we gotta have `if [[ -z "${foobar:-}" ]]`
[17:21:25]
<Yunohost Git/Infra notifications> [nextcloud_ynh] @oleole39 opened [issue #572](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/572): Deleting a user from YNH does not remove completely from Nextcloud DB, causing issues with Nextcloud Mail
[19:33:04]
<Yunohost Git/Infra notifications> App pufferpanel stays at level 1 in job [#15715](https://ci-apps.yunohost.org/ci/job/15715)
[20:13:38]
<Yunohost Git/Infra notifications> App question2answer stays at level 2 in job [#15716](https://ci-apps.yunohost.org/ci/job/15716)