[04:15:52]
<Yunohost Git/Infra notifications> [dokuwiki_ynh] @yunohost-bot created new branch ci-auto-update-2023.4.4
[04:15:52]
<Yunohost Git/Infra notifications> [dokuwiki_ynh] @yunohost-bot pushed 1 commit to ci-auto-update-2023.4.4: Upgrade to v2023.4.4 ([1aef70f9](https://github.com/YunoHost-Apps/dokuwiki_ynh/commit/1aef70f9d9c682bfe2aa60fa0ee88efc5a992d6c))
[04:16:02]
<Yunohost Git/Infra notifications> [dokuwiki_ynh] @yunohost-bot [commented](https://github.com/YunoHost-Apps/dokuwiki_ynh/pull/103#issuecomment-1738407216) on [issue #103](https://github.com/YunoHost-Apps/dokuwiki_ynh/pull/103) Upgrade to v2023.4.4: :rocket:
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-dev.yunohost.org/ci/api/job/9922/badge)](htt...
[04:16:02]
<Yunohost Git/Infra notifications> [dokuwiki_ynh] @yunohost-bot opened [pull request #103](https://github.com/YunoHost-Apps/dokuwiki_ynh/pull/103): Upgrade to v2023.4.4
[08:10:33]
<orhtej2> > <@Alekswag:matrix.org> hmmm yeah maybe it doesnt have the `--wait-until-pattern` thing (i don't remember how it's called)
there actually is such check here https://github.com/YunoHost-Apps/jellyfin_ynh/blob/master/scripts/upgrade#L55C1-L55C88 but IIRC there's a nice race condition in the check itself. Perhaps let's not bother?
[08:15:19]
<Salamandar> WHAT IF
[08:15:20]
<Salamandar> `!testme only=upgrade_from.e20afb4d5c7247df84a8a9a4d5d05ae7205aebb5`
[08:15:21]
<Salamandar> to prevent commits like https://github.com/YunoHost-Apps/transmission_ynh/pull/102/commits/303615960b33f66322b0240832e833a99c8147ec
[08:15:21]
<Salamandar> https://ci-apps-dev.yunohost.org/ci/job/9924
[08:15:21]
<Salamandar> o no
[08:15:39]
<orhtej2> > <@Salamandar:matrix.org> to prevent commits like https://github.com/YunoHost-Apps/transmission_ynh/pull/102/commits/303615960b33f66322b0240832e833a99c8147ec
I meeeeean have you ever seen https://i.gifer.com/kkL.gif
[08:15:52]
<Salamandar> haha
[08:15:59]
<Salamandar> yeah but when you're trackinrg a fix for a specific bug…
[08:29:32]
<Salamandar> ok so ynh_secure_remove doesn't remove symlinks ??
[08:32:07]
<Salamandar> oh yeah it's following the symlink… ><'
[08:34:45]
<Salamandar> https://github.com/YunoHost/yunohost/blob/465f6da5cd4d716bbcb802dfd742114083034235/helpers/utils#L873
errors out when the symlink's target doesn't exist
[08:35:02]
<Salamandar> I hate bugs with symlinks, episode 2
[08:36:06]
<Salamandar> Also ynh\_secure\_remove should be renamed ynh\_safe\_remove because "secure" supposes it's calling shred or whatever
[08:41:39]
<Salamandar> yeah it says the symlink doesn't exist
[08:41:39]
<orhtej2> > <@Salamandar:matrix.org> ok so ynh_secure_remove doesn't remove symlinks ??
Does it print any warning?
[08:41:39]
<orhtej2> https://github.com/YunoHost/yunohost/blob/465f6da5cd4d716bbcb802dfd742114083034235/helpers/utils#L873
[08:41:53]
<orhtej2> It should either delete or tell you why it did not
[08:42:13]
<Salamandar> but the symlink DOES exist. The test is faulty because it tests for the symlink's target…
[09:00:36]
<Salamandar> I see a lot of apps calling ynh_secure_remove without --file, but it's not supported by the function…
[09:02:35]
<Salamandar> Ah maybe that's what legacy_array is for
[09:05:58]
<Aleks (he/him/il/lui)> Yeah
[09:06:22]
<Aleks (he/him/il/lui)> A day may come where everything will be consistent
[09:06:28]
<Aleks (he/him/il/lui)> But it is not this day
[09:06:54]
<Aleks (he/him/il/lui)> whenpackagingv3willbeoutyouwontneedhelpers.jpg
[09:07:23]
<Salamandar> 😐️
[09:07:25]
<Salamandar> hehe
[09:10:23]
<Salamandar> oh arg arrays are ;-separated…
[09:10:27]
<Salamandar> ☹️
[09:56:30]
<orhtej2> > <@Salamandar:matrix.org> ok so ynh_secure_remove doesn't remove symlinks ??
```sh
$ source /usr/share/yunohost/helpers
$ touch file
$ ln -s file file2
$ ls -la
-rw-r--r-- 1 orhtej2 orhtej2 0 Sep 28 11:53 file
lrwxrwxrwx 1 orhtej2 orhtej2 4 Sep 28 11:53 file2 -> file
$ ynh_secure_remove --file="file2"
+ set +o xtrace
$ ls -la
-rw-r--r-- 1 orhtej2 orhtej2 0 Sep 28 11:53 file
```
WFM
[10:02:52]
<Salamandar> Oh, it DOES remove the symlink, but only if the target exists
[10:03:02]
<Salamandar> if you make a dangling symlink, it won't be removed
[10:03:48]
<Aleks (he/him/il/lui)> *computers*
[10:07:35]
<Salamandar> ```
[felix@framed yunohost]$ source helpers/logging
[felix@framed yunohost]$ source helpers/getopts
[felix@framed yunohost]$ source helpers/utils
[felix@framed yunohost]$ ln -s does_not_exist the_symlink
[felix@framed yunohost]$ ls -lah the_symlink
lrwxrwxrwx 1 felix felix 14 28 sept. 12:03 the_symlink -> does_not_exist
[felix@framed yunohost]$ ynh_secure_remove --file=the_symlink
+ ynh_secure_remove --file=the_symlink
+ local legacy_args=f
+ args_array=(['f']='file=')
+ local -A args_array
+ local file
+ ynh_handle_getopts_args --file=the_symlink
+ set +o xtrace
+ set +o xtrace
+ echo ''\''the_symlink'\'' wasn'\''t deleted because it doesn'\''t exist.'
bash: $YNH_STDINFO : redirection ambiguë
+ set -o xtrace
++ echo -ne '\033]0;felix@framed:~/tmp/Yunohost/yunohost\007'
[felix@framed yunohost]$ ls -lah the_symlink
+ ls --color=auto -lah the_symlink
lrwxrwxrwx 1 felix felix 14 28 sept. 12:03 the_symlink -> does_not_exist
++ echo -ne '\033]0;felix@framed:~/tmp/Yunohost/yunohost\007'
```
[11:08:52]
<Yunohost Git/Infra notifications> [dokuwiki_ynh] @Tagadda merged [pull request #103](https://github.com/YunoHost-Apps/dokuwiki_ynh/pull/103): Upgrade to v2023.4.4
[11:08:52]
<Yunohost Git/Infra notifications> [dokuwiki_ynh] @Tagadda pushed 1 commit to testing: Upgrade to v2023.4.4 (#103) ([6fe54699](https://github.com/YunoHost-Apps/dokuwiki_ynh/commit/6fe546992bded965a067f57242d87bddd1d1891e))
[11:09:46]
<Yunohost Git/Infra notifications> [dokuwiki_ynh] @Tagadda [commented](https://github.com/YunoHost-Apps/dokuwiki_ynh/pull/102#issuecomment-1738942631) on [issue #102](https://github.com/YunoHost-Apps/dokuwiki_ynh/pull/102) Testing: testme
[11:31:57]
<Yunohost Git/Infra notifications> App seafile rises from level 0 to 6 in job [#18907](https://ci-apps.yunohost.org/ci/job/18907) !
[11:39:12]
<orhtej2> lapineige: yologen creates `conf/php_extra-fpm.conf` even if 'use PHP' is unchecked
[11:39:28]
<orhtej2> bugtracker where ;)
[12:06:32]
<lapineige> Yes it's a known issue (because I made it quick and dirty...)
[12:25:04]
<orhtej2> aslo it generates `_common_sh` not `_common.sh`
[12:33:19]
<Aleks (he/him/il/lui)> <whisper>[release early release often](https://en.wikipedia.org/wiki/Release_early,_release_often)</whisper>
[12:36:51]
<eric_G> Yes! it's also my motto (with: release with bugs)
[12:38:09]
<Aleks (he/him/il/lui)> i guess that's precisely the statement of "release early release often" ;P having bugged released is better than having supposedly perfect releases in one year, which will be bugged anyway ;P
[12:41:34]
<Aleks (he/him/il/lui)> all computers are broken anyway
[12:43:32]
<orhtej2> also it URL-encodes config and parts of manifest :/
[12:43:49]
<orhtej2> ```toml
architectures = "['all']" # TODO : handle the "all" option (no ["all"])
```
[12:49:26]
<edhelas> Hi everyone
[13:04:36]
<orhtej2> > <@Alekswag:matrix.org> <whisper>[release early release often](https://en.wikipedia.org/wiki/Release_early,_release_often)</whisper>
that's why I'm using it and reporting bugs ;)
[13:04:43]
<orhtej2> 'it' being yologen
[13:17:39]
<Yunohost Git/Infra notifications> App gogs goes down from level 8 to 1 in job [#18910](https://ci-apps.yunohost.org/ci/job/18910)
[13:19:53]
<Tag> (about yologen) we 👏 need 👏 source 👏 repo 👏 (to send PRs)
[13:31:36]
<tituspijean> shamelessly pinging lapineige ^
[13:37:53]
<orhtej2> any way of specifying i.e. `build-essential` as install-time `apt` dependency in packaging v2?
[13:39:14]
<tituspijean> https://yunohost.org/oc/packaging_apps_resources#apt ?
[13:41:39]
<Tag> We can add it to packaging v3 wishlist :D
[13:42:59]
<Tag> I think orhtej2 meant like "build dependencies", so packages like `build-essential` are removed at the end of the install script
[13:45:52]
<orhtej2> > <@tag:lostpod.me> I think orhtej2 meant like "build dependencies", so packages like `build-essential` are removed at the end of the install script
exactly this
[14:26:47]
<Aleks (he/him/il/lui)> (I think Tag actually tried to draft something like this at some point)
[14:28:59]
<Tag> huh? 🤔 *all memories are gone*
[14:31:03]
<Aleks (he/him/il/lui)> yeah we discussed this at the bar the other day xD
[14:31:10]
<Aleks (he/him/il/lui)> maybe there's even a PR ?
[14:31:40]
<Aleks (he/him/il/lui)> hmm nah no PR nvm
[14:32:11]
<Tag> wait the other day was...... at least a year ago, right??
[14:32:11]
<Tag> xD
[14:32:27]
<Aleks (he/him/il/lui)> yes xD
[14:32:38]
<Tag> okay! I'm not sleep walking far from home!
[14:33:23]
<Aleks (he/him/il/lui)> maybe 2
[14:33:28]
<Aleks (he/him/il/lui)> 😛
[14:33:55]
<Tag> :psykokwak:
[14:49:01]
<Yunohost Git/Infra notifications> [apps] @Tagadda created new branch remove-doc-old-link
[14:53:05]
<Yunohost Git/Infra notifications> [apps] @Tagadda pushed 1 commit to remove-doc-old-link: Remove link to the old documentation Packagers should include those in the package, as ADMIN.md... ([4e7115c6](https://github.com/YunoHost/apps/commit/4e7115c60667a23a4e126d8a7290a6271d8c423a))
[14:54:43]
<Yunohost Git/Infra notifications> [apps] @Tagadda opened [pull request #1759](https://github.com/YunoHost/apps/pull/1759): Remove link to the documentation
[15:08:51]
<Yunohost Git/Infra notifications> [apps] @alexAubin pushed 2 commits to master ([21ee6cdcf726...17375daee6e7](https://github.com/YunoHost/apps/compare/21ee6cdcf726...17375daee6e7))
[15:08:52]
<Yunohost Git/Infra notifications> [apps] @alexAubin merged [pull request #1759](https://github.com/YunoHost/apps/pull/1759): Remove link to the documentation
[15:08:56]
<Yunohost Git/Infra notifications> [apps/master] Remove link to the old documentation Packagers should include those in the package, as ADMIN.md... - Tagada
[15:08:59]
<Yunohost Git/Infra notifications> [apps/master] Merge pull request #1759 from YunoHost/remove-doc-old-link Remove link to the documentation - Alexandre Aubin
[15:18:30]
<Tag> > <@Alekswag:matrix.org> yeah we discussed this at the bar the other day xD
sadly I don't remember the content of the discussion :( I tried to think about it again, but it's not obvious to me how to trigger the AppRessource stuff at the end of the install script (without adding lots of stuff)
[15:21:02]
<Aleks (he/him/il/lui)> i think it was about Buster->Bullseye migration and the fact that a lot of conflict packages came from stuff related to build/makefile/c++configure whatever, and that they werent really needed for regular operation of the server, hence that would save a lot of headaches later if we had a way to install build dependencies only when ... building the app
[15:21:07]
<Aleks (he/him/il/lui)> but yeah the technical design is not straightforward
[15:22:04]
<Tag> oh wokay and packaging v2 was not merged yet!
[15:22:26]
<Aleks (he/him/il/lui)> yup
[15:22:52]
<Aleks (he/him/il/lui)> anyway that's yet another yakafokons ;P
[15:24:33]
<Yunohost Git/Infra notifications> [dokuwiki_ynh] @croulibri [commented](https://github.com/YunoHost-Apps/dokuwiki_ynh/pull/103#issuecomment-1739524891) on [issue #103](https://github.com/YunoHost-Apps/dokuwiki_ynh/pull/103) Upgrade to v2023.4.4: Hello, May I ask you why to upgrade from release-2023-04-04a (released the 15th of May) to the release-2023-04-04 (relea...
[15:34:07]
<Yunohost Git/Infra notifications> [dokuwiki_ynh] @alexAubin [commented](https://github.com/YunoHost-Apps/dokuwiki_ynh/pull/103#issuecomment-1739549482) on [issue #103](https://github.com/YunoHost-Apps/dokuwiki_ynh/pull/103) Upgrade to v2023.4.4: well it sounds related to the fact that its unclear what "a" means ... "a" could be interpreted as "alpha" ... Also I d...
[15:55:11]
<Yunohost Git/Infra notifications> [dokuwiki_ynh] @Tagadda [commented](https://github.com/YunoHost-Apps/dokuwiki_ynh/pull/102#issuecomment-1739602139) on [issue #102](https://github.com/YunoHost-Apps/dokuwiki_ynh/pull/102) Testing: Hold the merge Looking at [this comment](https://github.com/YunoHost-Apps/dokuwiki_ynh/pull/103#issuecomment-1739524891...
[15:55:11]
<Yunohost Git/Infra notifications> WARNING: unknown pull_request action: converted_to_draft
[16:58:21]
<eric_G> https://ci-apps-dev.yunohost.org/ci/ #cestpété?
[17:00:09]
<Aleks (he/him/il/lui)> >toml.decoder.TomlDecodeError: Unbalanced quotes 🤔
[17:01:27]
<Tag> https://github.com/YunoHost-Apps/diagramsnet_ynh/blob/ci-auto-update-22.0.0/manifest.toml#L8
[17:01:37]
<Tag> but why tho?
[17:01:44]
<Aleks (he/him/il/lui)> 🤔
[17:02:02]
<Tag> AH
[17:02:04]
<Tag> Ok i know
[17:02:06]
<Tag> lol
[17:02:50]
<Tag> fixing it
[17:02:53]
<Aleks (he/him/il/lui)> https://github.com/YunoHost/apps/commit/1352b4253e1029344469d8f69ce874ec3b7db58b oopsies
[17:03:14]
<Salamandar> o no
[17:03:36]
<Yunohost Git/Infra notifications> [apps] @Tagadda created new branch Tagadda-patch-1
[17:03:38]
<Yunohost Git/Infra notifications> [apps] @Tagadda pushed 1 commit to Tagadda-patch-1: Add a missing quote in autoupdate_app_sources.py ([10082422](https://github.com/YunoHost/apps/commit/10082422038aab324da1613efe71dc375cec261e))
[17:03:57]
<Yunohost Git/Infra notifications> [apps] @Tagadda opened [pull request #1760](https://github.com/YunoHost/apps/pull/1760): Add a missing quote in autoupdate_app_sources.py
[17:04:49]
<Tag> ^
[17:05:57]
<Yunohost Git/Infra notifications> [apps] @alexAubin merged [pull request #1760](https://github.com/YunoHost/apps/pull/1760): Add a missing quote in autoupdate_app_sources.py
[17:05:58]
<Yunohost Git/Infra notifications> [apps] @alexAubin pushed 2 commits to master ([17375daee6e7...9530e16e0dc7](https://github.com/YunoHost/apps/compare/17375daee6e7...9530e16e0dc7))
[17:06:05]
<Yunohost Git/Infra notifications> [apps/master] Add a missing quote in autoupdate_app_sources.py - Tagada
[17:06:05]
<Yunohost Git/Infra notifications> [apps] @alexAubin deleted branch Tagadda-patch-1
[17:06:06]
<Yunohost Git/Infra notifications> [apps/master] Merge pull request #1760 from YunoHost/Tagadda-patch-1 Add a missing quote in autoupdate_app_sources.py - Alexandre Aubin
[17:06:28]
<Tag> I'll delete those weird branches
[17:07:13]
<Aleks (he/him/il/lui)> (my internet is too epicly lagging, feel free to close/delete the various apps branches and re-trigger the auto-update from the infra)
[17:07:27]
<Aleks (he/him/il/lui)> (yeah see i'm lagging xD)
[17:07:30]
<Tag> xD
[17:08:19]
<Tag> on a des carte sim 4G chez aquilenet stv 👀
[17:09:09]
<Aleks (he/him/il/lui)> mwé j'ai de la 3G/4G (enfin ptete juste de la 3G) mais la 3G est naze dans le bar aussi du coup j'suis juste en PLS
[17:09:32]
<Tag> aïe
c'est LE bar ? 👀
[17:09:39]
<Aleks (he/him/il/lui)> d'habitude je dev surtout en local alors c'est pas grave, c'est limite mieux, mais aujourdhui j'avais besoin de `npm install` et telecharger des LXC bookworm et bref x_x
[17:09:41]
<Aleks (he/him/il/lui)> wi
[17:10:25]
<Tag> ouch oui pas pratique
[17:11:54]
<Aleks (he/him/il/lui)> TFW you run your first post install in webadmin in the past 4 months and the process it's just smooth AF :o
[17:12:16]
<Aleks (he/him/il/lui)> (except the lack of feedback during the postinstall itself meh)
[17:13:14]
<Aleks (he/him/il/lui)> and suddently ... 500 Internal Server Error (it's ssowat on bookworm 😬)
[17:14:21]
<Tag> > <@Alekswag:matrix.org> TFW you run your first post install in webadmin in the past 4 months and the process it's just smooth AF :o
the progress is displayed on the webadmin ? I remember an issue about that
[17:14:34]
<Tag> ah
[17:14:40]
<Tag> didn't read the 2nd message x)
[17:19:00]
<orhtej2> > <@Alekswag:matrix.org> https://github.com/YunoHost/apps/commit/1352b4253e1029344469d8f69ce874ec3b7db58b oopsies
Sorry 😕
[17:20:00]
<Tag> It's ok! Modifying toml as raw text is dangerous!!!
[17:23:13]
<orhtej2> https://aria.im/_matrix/media/v1/download/circledsquareroot.ovh/36bd8742d64c9fd452f322e44645e437465e868cc089656fab0f798b4394fe66
[17:23:51]
<orhtej2> > <@tag:lostpod.me> It's ok! Modifying toml as raw text is dangerous!!!
Should have tested 💀
[17:24:31]
<Tag> The CI is here to do the testing :p
[17:24:45]
<Aleks (he/him/il/lui)> testing is doubting
[17:47:33]
<Yunohost Git/Infra notifications> [gitlab_ynh] @rodinux [commented](https://github.com/YunoHost-Apps/gitlab_ynh/pull/230#issuecomment-1739762861) on [issue #230](https://github.com/YunoHost-Apps/gitlab_ynh/pull/230) Testing: Hello, is it really necessary keep the test from this commit https://github.com/YunoHost-Apps/gitlab_ynh/commit/722fa8db...
[19:59:56]
<Aleks (he/him/il/lui)> orhtej2: btw i wouldnt focus too much energy on yunomonitor, my guess is that at most there are maybe 2 people in the world using this app, and i would actually be surprised if that was 2, more like 1 ...
[20:56:32]
<Yunohost Git/Infra notifications> [dokuwiki_ynh] @croulibri [commented](https://github.com/YunoHost-Apps/dokuwiki_ynh/pull/103#issuecomment-1739992213) on [issue #103](https://github.com/YunoHost-Apps/dokuwiki_ynh/pull/103) Upgrade to v2023.4.4: I fully agree with you @alexAubin , this versioning scheme is confusing. But if you look again, "DokuWiki 2023-04-04a "...
[21:09:46]
<lapineige> > <@tag:lostpod.me> omg thanks orhtej2 !! https://github.com/YunoHost/package_check/pull/142 was a great idea !
> mastodon_ynh was 2 hours+ and now it's only 1h20!!
That's optional, right ?
[21:11:01]
<orhtej2> > <@Alekswag:matrix.org> orhtej2: btw i wouldnt focus too much energy on yunomonitor, my guess is that at most there are maybe 2 people in the world using this app, and i would actually be surprised if that was 2, more like 1 ...
It's an easy fix i guess
[21:11:23]
<orhtej2> > That's optional, right ?
What's optional?
[21:16:29]
<lapineige> > aslo it generates `_common_sh` not `_common.sh`
I should have fixed that... Maybe it's still on my computer
[21:18:15]
<lapineige> Pushing a new version to my server is already so much work that I often forget ^^
[21:18:59]
<lapineige> > also it URL-encodes config and parts of manifest :/
Oh yes it's definetly not the last version
[21:19:04]
<lapineige> All of this is fixed
[21:20:05]
<lapineige> > <@Alekswag:matrix.org> <whisper>[release early release often](https://en.wikipedia.org/wiki/Release_early,_release_often)</whisper>
I fully agree with the idea.
Yet...
Releasing takes a shitload of time and energy 😅
[21:20:36]
<lapineige> > ```toml
> architectures = "['all']" # TODO : handle the "all" option (no ["all"])
> ```
As you can see, it's known ^^
[21:21:01]
<lapineige> > <@tag:lostpod.me> (about yologen) we 👏 need 👏 source 👏 repo 👏 (to send PRs)
I know
[21:21:49]
<lapineige> (Won't happen until weeks, I'm out of free time)
[21:22:41]
<orhtej2> > (Won't happen until weeks, I'm out of free time)
Thats ok, take your time
[21:24:08]
<lapineige> > What's optional?
The PR to not backup on upgrade
[21:53:36]
<orhtej2> > The PR to not backup on upgrade
Thats for CI
[21:55:15]
<lapineige> Oh, Nice !