Monday, August 15, 2022
dev@conference.yunohost.org
August
Mon Tue Wed Thu Fri Sat Sun
1 2 3 4 5 6 7
8 9 10 11 12 13
14
15
16
17
18
19 20
21
22
23
24 25 26
27
28
29
30
31
       
             

[09:07:32] <tituspijean> https://aria.im/_matrix/media/v1/download/matrix.org/ncgtKJgfKrBBwJPDICLCmZFg
[09:08:01] <tituspijean> Bug in the Redirect app manifest, the last question should be a drop-down `choice` list, but it's a text box
[11:46:29] <Aleks> ...
[11:47:18] <Aleks> ljf: in case you know how to fix this ̣̣^
[15:35:40] <ljf> seems an other issues than the one in config panel, i think it's on yunohost-admin side
[15:36:33] <ljf> sadly my `./ynh-dev use-git yunohost-admin` is broken
[17:38:43] <Tag> > <@Alekswag:matrix.org> ljf: in case you know how to fix this ̣̣^

the `type` is `string` in the manifest and should be `select`
[17:39:27] <Tag> but it should work with `string` too actually...
[17:39:27] <Aleks> 👀
[17:41:02] <Tag> https://github.com/YunoHost/yunohost-admin/blob/dev/app/src/helpers/yunohostArguments.js#L76-L79
why dis dont work /o\
[17:41:11] <Aleks> uuugh yeah there seem to be a shitload of apps with `choices` and `type: string`
[17:41:36] <Aleks> or could it be it's only when choices is a dict and not a list ?
[17:41:56] <Tag> dict got length ?
[17:43:31] <Aleks> idk
[17:44:07] <Aleks> i don't have access to a yunohost with a webadmin but we could check the hypothesis by trying to install wordpress which as a `choices` for the language
[17:52:26] <Tag> Yup, an Object don't have a .length
[17:53:03] <Aleks> ogod...
[17:53:52] <Aleks> well it kinda makes sense but hmgn
[17:57:19] <Tag> `Object.keys(choices).length` ... /o\
[18:10:48] <Tag> it works o/
[18:12:28] <Aleks> \o/
[18:12:39] <Tag> PR inc
[18:13:58] <Tag> https://github.com/YunoHost/yunohost-admin/pull/460
[18:15:47] <Aleks> Tag: is it always an object tho ? 🤔
[18:18:12] <Tag> well...??? /o\
[18:18:14] <Tag> wait
[18:18:35] <Tag> yes, it should, since it's generated from the same code than the config panel stuff now ?
[18:22:10] <Aleks> Ah yes maybe
[18:22:22] <Tag> mmh
[18:22:30] <Tag> MMMMMH
[18:22:36] <Aleks> But that mean even the install form for wordpress was broken ?
[18:22:47] <Aleks> xD
[18:22:54] <Aleks> Thinking intensifies
[18:24:24] <Tag> nope, was not broken
[19:03:06] <Tag> But now with Object.keys(choices), choices can be an Array or an Object, it doesn't matter
[19:03:06] <Aleks> ah yes indeed it works with array too 👍️
[19:03:06] <Aleks> mergin'