[07:30:35]
<Yunohost Git/Infra notifications> [yunohost] @fflorent [commented](https://github.com/YunoHost/yunohost/pull/1656#discussion_r1200072660) on pull request #1656 Offer a shell into an app environment: The naming suggests that we only load the app environment, but we rather log as the app user (using the su command). ...
[07:30:35]
<Yunohost Git/Infra notifications> [yunohost] @fflorent edited review [pull request #1656](https://github.com/YunoHost/yunohost/pull/1656#pullrequestreview-1435949781): Offer a shell into an app environment
[07:30:36]
<Yunohost Git/Infra notifications> [yunohost] @fflorent [commented](https://github.com/YunoHost/yunohost/pull/1656#discussion_r1200077189) on pull request #1656 Offer a shell into an app environment: If I am correct, we could also suggest using this command as follow: suggestion # examples: # ynh_load_app_environ...
[09:44:44]
<Yunohost Git/Infra notifications> [yunohost-ci] @kay0u pushed 3 commits to use-snapshot ([79a410b8f557...a89298382ea6](https://github.com/YunoHost/yunohost-ci/compare/79a410b8f557...a89298382ea6))
[09:44:46]
<Yunohost Git/Infra notifications> [yunohost-ci/use-snapshot] add a default value to current_branch - Kay0u
[09:44:50]
<Yunohost Git/Infra notifications> [yunohost-ci/use-snapshot] add git and hub to the preinstall deps - Kay0u
[09:44:52]
<Yunohost Git/Infra notifications> [yunohost-ci/use-snapshot] remove old containers after an auto upgrade - Kay0u
[09:46:39]
<Yunohost Git/Infra notifications> [yunohost-ci] @kay0u pushed 1 commit to use-snapshot: add snap/bin to the PATH for cron task ([eb74089b](https://github.com/YunoHost/yunohost-ci/commit/eb74089b8991edf93253468c573810b0a691373b))
[09:51:50]
<Yunohost Git/Infra notifications> [yunohost-ci] @kay0u pushed 1 commit to use-snapshot: add some logs ([43bc8390](https://github.com/YunoHost/yunohost-ci/commit/43bc8390f706ffc128791fecda10e3c198cff26a))
[10:12:01]
<Yunohost Git/Infra notifications> [yunohost-ci] @kay0u pushed 1 commit to use-snapshot: auto_upgrade_container remove old containers ([e2bf5953](https://github.com/YunoHost/yunohost-ci/commit/e2bf59539b1bd9b42ef738830b76d5d516faad36))
[10:29:25]
<kayou> I'll migrate the ci-core to the version with snapshots
[10:42:49]
<Yunohost Git/Infra notifications> [yunohost-ci] @kay0u pushed 1 commit to use-snapshot: remove mac address each time we create a new snapshot ([33a8934c](https://github.com/YunoHost/yunohost-ci/commit/33a8934c0dc04bc7bf29feff2278ee3f751d3595))
[10:44:05]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#874496242](https://gitlab.com/yunohost/yunohost/-/pipelines/874496242) failed on branch dev
[10:48:28]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#874506873](https://gitlab.com/yunohost/yunohost/-/pipelines/874506873) failed on branch dev
[10:51:29]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#874506873](https://gitlab.com/yunohost/yunohost/-/pipelines/874506873) failed on branch dev
[10:54:07]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#874506873](https://gitlab.com/yunohost/yunohost/-/pipelines/874506873) failed on branch dev
[10:59:31]
<Yunohost Git/Infra notifications> [yunohost-ci] @kay0u pushed 2 commits to use-snapshot ([33a8934c0dc0...1abb4d602d3a](https://github.com/YunoHost/yunohost-ci/compare/33a8934c0dc0...1abb4d602d3a))
[10:59:34]
<Yunohost Git/Infra notifications> [yunohost-ci/use-snapshot] force remove mac address after restoring snapshot - Kay0u
[10:59:37]
<Yunohost Git/Infra notifications> [yunohost-ci/use-snapshot] simplify the detection of the presence of the BASE IMAGE - Kay0u
[10:59:59]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#874515195](https://gitlab.com/yunohost/yunohost/-/pipelines/874515195) failed on branch dev
[11:01:54]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#874525097](https://gitlab.com/yunohost/yunohost/-/pipelines/874525097) failed on branch dev
[11:04:19]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#874528368](https://gitlab.com/yunohost/yunohost/-/pipelines/874528368) failed on branch dev
[11:09:18]
<Yunohost Git/Infra notifications> [yunohost] ✖️ Pipeline [#874533986](https://gitlab.com/yunohost/yunohost/-/pipelines/874533986) canceled on branch dev
[11:11:58]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#874537009](https://gitlab.com/yunohost/yunohost/-/pipelines/874537009) failed on branch dev
[11:14:44]
<Yunohost Git/Infra notifications> [yunohost] ✖️ Pipeline [#874539788](https://gitlab.com/yunohost/yunohost/-/pipelines/874539788) canceled on branch dev
[11:21:21]
<Yunohost Git/Infra notifications> [yunohost] ✖️ Pipeline [#874545422](https://gitlab.com/yunohost/yunohost/-/pipelines/874545422) canceled on branch dev
[11:30:03]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#874555501](https://gitlab.com/yunohost/yunohost/-/pipelines/874555501) failed on branch dev
[11:33:40]
<kayou> i. dont. understand.
> lxc info $container | grep -q "somestring"
sometime doesn't work
> lxc info $container | grep "somestring"
works
[11:33:42]
<kayou> O.o
[11:35:41]
<Yunohost Git/Infra notifications> [yunohost] ✖️ Pipeline [#874567508](https://gitlab.com/yunohost/yunohost/-/pipelines/874567508) canceled on branch dev
[11:55:08]
<Yunohost Git/Infra notifications> [yunohost-ci] @kay0u pushed 1 commit to use-snapshot: match the whole word ([84b27c25](https://github.com/YunoHost/yunohost-ci/commit/84b27c25ed139c95f955f7817168bd63f847d148))
[12:20:07]
<tituspijean> kayou: easy. `-q` means `--quizás` 🙃
[12:20:55]
<kayou> well, now it works, i removed the -q, and add > /dev/null
[12:20:57]
<kayou> ¯\_(ツ)_/¯
[12:21:52]
<kayou> I just got this message:
```
/opt/yunohost-ci/run.sh: line 39: 3480264 Killed lxc exec "$CONTAINER_IMAGE" /bin/bash < "${1}"
```
[12:22:35]
<kayou> idk why
[12:22:56]
<Yunohost Git/Infra notifications> [yunohost-ci] @kay0u opened [pull request #2](https://github.com/YunoHost/yunohost-ci/pull/2): Use snapshot
[12:23:37]
<Yunohost Git/Infra notifications> [yunohost-ci] @kay0u pushed 26 commits to master ([c08a409fe31f...4676dca07546](https://github.com/YunoHost/yunohost-ci/compare/c08a409fe31f...4676dca07546))
[12:23:39]
<Yunohost Git/Infra notifications> [yunohost-ci] @kay0u deleted branch use-snapshot
[12:23:40]
<Yunohost Git/Infra notifications> [yunohost-ci/master] simplify the detection of the presence of the BASE IMAGE - Kay0u
[12:23:43]
<Yunohost Git/Infra notifications> [yunohost-ci/master] Merge pull request #2 from YunoHost/use-snapshot Use snapshot - Kayou
[12:23:44]
<Yunohost Git/Infra notifications> [yunohost-ci/master] match the whole word - Kay0u
[13:02:47]
<eric_G> why is the CI : https://ci-apps.yunohost.org/ci/ so far behind?
[13:05:04]
<Aleks (he/him/il/lui)> ogod
[13:08:58]
<Aleks (he/him/il/lui)> sounds like a lot of tests were restarted
[13:09:27]
<Aleks (he/him/il/lui)> ah or nvm it's just the difference between time submitted and time started
[13:09:50]
<Aleks (he/him/il/lui)> idk, maybe the CI is slower than usual
[13:10:17]
<Aleks (he/him/il/lui)> and in the past even when the CI was working "well" it had a hard time catching up with all the tests
[13:10:39]
<eric_G> yes, It can't cope with all the work 😅
[13:11:13]
<Aleks (he/him/il/lui)> yeah we gotta start thinking about a way of either improving the test speed or adding another worker idk
[13:20:16]
<eric_G> also, in a different topic, I will love to see some kind of statistics about how many time the apps are installed.
[13:21:23]
<eric_G> there's a lot of work done on apps that probably no one has installed
[13:23:09]
<eric_G> with the amount of apps in the catalog now, having this kind of info should help to invest time where it is needed
[13:29:38]
<Yunohost Git/Infra notifications> [yunohost] @kay0u pushed 1 commit to bookworm: ci: preinstall more package ([85b08e44](https://github.com/YunoHost/yunohost/commit/85b08e44c9ee03151cae1c35ef20902ffdb7ddd4))
[13:30:30]
<Yunohost Git/Infra notifications> 🏗️ Starting build for yunohost/12.0.0+202305221330 for bookworm/unstable/all ...
[13:31:44]
<Yunohost Git/Infra notifications> ✔️ Completed build for yunohost/12.0.0+202305221330 for bookworm/unstable/all.
[14:08:35]
<kayou> wtf
[14:09:28]
<kayou> it doesn't pass on my computer, and end at [prompt] not NotImplementedError
[14:09:41]
<kayou> why this test pass:
https://gitlab.com/yunohost/yunohost/-/jobs/4326101173 (`test_app_from_catalog`) while there is a new `phpversion` arg, and it's not provided
[14:10:07]
<kayou> why this test pass:
https://gitlab.com/yunohost/yunohost/-/jobs/4326101173 (`test_app_from_catalog`) while there is a new `phpversion` arg, and it's [not provided](https://github.com/YunoHost/yunohost/blob/db9aa8e6c7f022687e9eabeefd2e109c8cf2f1e6/src/tests/test_apps.py#L333)
[14:10:29]
<kayou> it doesn't pass on my computer, and end at [prompt](https://github.com/YunoHost/yunohost/blob/db9aa8e6c7f022687e9eabeefd2e109c8cf2f1e6/src/tests/conftest.py#L80) not NotImplementedError
[14:16:35]
<Aleks (he/him/il/lui)> kayou: not sure to understand why it would/should crash ?
[14:16:51]
<Aleks (he/him/il/lui)> ah, didnt see the end of your message
[14:17:00]
<kayou> because, we end up in Moulinette.prompt, and we're not supposed to
[14:18:00]
<Aleks (he/him/il/lui)> ah this installs my_webapp from the catalog
[14:18:01]
<Aleks (he/him/il/lui)> hmmm
[14:18:01]
<Aleks (he/him/il/lui)> and there's no default value ?
[14:18:40]
<kayou> no, but my question is more, why we don't have the same result
[14:18:45]
<kayou> there is another test that fails
[14:18:55]
<kayou> https://github.com/YunoHost/yunohost/blob/db9aa8e6c7f022687e9eabeefd2e109c8cf2f1e6/src/tests/test_backuprestore.py#L58
[14:19:05]
<kayou> is_public is missing
[14:19:07]
<Aleks (he/him/il/lui)> yeah i'm thinking maybe somehow when you test locally pytest sort of understand that you're in an interactive tty
[14:19:14]
<Aleks (he/him/il/lui)> while the CI is not in interactive tty
[14:19:31]
<Aleks (he/him/il/lui)> there's some `if is_tty` somewhere
[14:19:42]
<kayou> it's probably something like that yes
[14:19:42]
<Aleks (he/him/il/lui)> or `os.tty` something
[14:19:58]
<Aleks (he/him/il/lui)> both in conftest.py and in the question-handling code
[14:20:06]
<kayou> or we don't trigger https://github.com/YunoHost/yunohost/blob/db9aa8e6c7f022687e9eabeefd2e109c8cf2f1e6/src/tests/conftest.py#L68-L85
[14:22:43]
<tituspijean> > <@ericg:matrix.org> also, in a different topic, I will love to see some kind of statistics about how many time the apps are installed.
IIRC all we could have is the number of `git clone`s made per repository on Github, but it's a tad unreliable (if the maintainers, like yourself, are quite active, the CI will clone the repo much more than a "forgotten" app). For a more detailed one there is still https://github.com/YunoHost/issues/issues/1670.
(bingo issue, also :p)
[14:23:41]
<Aleks (he/him/il/lui)> yeah there's the convoluted thing I proposed but we could also go for something more conventional like opt-in statistics
[14:23:42]
<tituspijean> I could draft up a small script within the week to get the Github API info
[14:24:33]
<Aleks (he/him/il/lui)> hmyeah but honestly checking the `git clone` count is really not giving much info
[14:24:53]
<Aleks (he/him/il/lui)> like you could have a lot of people trying to install an app, but for some reason it fails and they don't actually use it
[14:25:18]
<Aleks (he/him/il/lui)> (or like, if the install fail they may retry and still fail, which artificially increases the git clone count ...)
[14:25:30]
<tituspijean> but eh, it's an indicator the app is wanted and/or maintained 🙂
[14:25:39]
<Aleks (he/him/il/lui)> hmyeah I suppose 😅
[14:27:14]
<tituspijean> (off-topic: I'm voluntarily using the Ignore feature from Discourse on our dearest German friend from now on: I won't bother understanding his issues anymore)
[14:28:52]
<Aleks (he/him/il/lui)> ah good tip
[14:29:16]
<Aleks (he/him/il/lui)> and yeah i don't know what to do, i thought he would get tired but it's just getting worse ..
[14:31:26]
<tituspijean> it seems he has an issue somewhere within his logorrhea, but I don't know what it is. He tends to do that: post his issue, then be extremely "active" (but not pertinent) across plenty other threads (even necrobumping some)
[14:38:03]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#874590385](https://gitlab.com/yunohost/yunohost/-/pipelines/874590385) failed on branch dev
[14:47:39]
<Yunohost Git/Infra notifications> [yunohost-ci] @kay0u pushed 1 commit to master: update URL and default branch ([079a4679](https://github.com/YunoHost/yunohost-ci/commit/079a467942e4a83214fcf6cadcae20ff1c12b042))
[15:30:51]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#874716578](https://gitlab.com/yunohost/yunohost/-/pipelines/874716578) failed on branch bookworm
[17:20:55]
<kayou> > <@Alekswag:matrix.org> there's some `if is_tty` somewhere
https://github.com/YunoHost/yunohost/blob/db9aa8e6c7f022687e9eabeefd2e109c8cf2f1e6/src/utils/form.py#L257
[17:21:17]
<kayou> in the ci, os.isatty(1) is false
[17:21:30]
<kayou> true when i trigger it manually
[17:21:56]
<kayou> i can monkeypatch it, or.... we don't really care :)
[17:22:32]
<Aleks (he/him/il/lui)> 😬
[17:22:33]
<Aleks (he/him/il/lui)> yeah idk
[17:22:44]
<Aleks (he/him/il/lui)> i think there's already some monkeypatching about this somewhere
[17:23:33]
<Aleks (he/him/il/lui)> yeah, `grep -nr tty` in src/tests/ gives a bunch of result
[17:23:42]
<kayou> hmm ok
[17:24:10]
<kayou> i'll assume that we don't want to test that during the app install then
[17:26:24]
<Aleks (he/him/il/lui)> i mean go for it if you feel like it, it's indeed better to not have inconsistencies between running manually and running in the CI
but imho the current result on the CI is the right one : if there's a default value for the phpversion question AND we're not in a tty, then the default value should be used instead of asking the question to the user
[17:26:40]
<Aleks (he/him/il/lui)> (in particular this helps with the app CI)
[17:27:25]
<Aleks (he/him/il/lui)> (and it also helps when writing non-interactive scripts that auto-install apps, e.g. in the internecube / clic projects)
[17:27:54]
<kayou> I think you are completely right, I was just surprised when I saw that the result was not the same
[17:28:35]
<kayou> but yes, the ci has no stdin and it works as it should
[17:29:35]
<kayou> at least now I understand why some tests were not passed on my pc
[17:33:11]
<Yunohost Git/Infra notifications> [yunohost] @kay0u pushed 1 commit to dev: add missing args in tests ([f046c291](https://github.com/YunoHost/yunohost/commit/f046c291e52ee536d5c8830d1bf8226f3151746e))
[17:39:00]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#875002594](https://gitlab.com/yunohost/yunohost/-/pipelines/875002594) failed on branch dev
[17:45:22]
<Yunohost Git/Infra notifications> 🏗️ Starting build for yunohost/11.1.20+202305221745 for bullseye/unstable/all ...
[17:46:15]
<Yunohost Git/Infra notifications> ✔️ Completed build for yunohost/11.1.20+202305221745 for bullseye/unstable/all.
[18:16:27]
<Yunohost Git/Infra notifications> Failed to run the source auto-update for : dokuwiki, zwave-js-ui. Please run manually the autoupdate_app_sources.py script on these apps to debug what is happening!
[18:58:42]
<Yunohost Git/Infra notifications> [yunohost] @alexAubin pushed 10 commits to bookworm ([85b08e44c9ee...c31930361257](https://github.com/YunoHost/yunohost/compare/85b08e44c9ee...c31930361257))
[18:58:43]
<Yunohost Git/Infra notifications> [yunohost/bookworm] Update changelog for 11.1.20 - Alexandre Aubin
[18:58:47]
<Yunohost Git/Infra notifications> [yunohost/bookworm] add missing args in tests - Kay0u
[18:58:47]
<Yunohost Git/Infra notifications> [yunohost/bookworm] Merge remote-tracking branch origin/dev into bookworm - Alexandre Aubin
[19:00:25]
<Yunohost Git/Infra notifications> 🏗️ Starting build for yunohost/12.0.0+202305221900 for bookworm/unstable/all ...
[19:01:37]
<Yunohost Git/Infra notifications> ✔️ Completed build for yunohost/12.0.0+202305221900 for bookworm/unstable/all.
[19:03:18]
<Aleks (he/him/il/lui)> with that merge we should be down to only 2 failing tests in bookworm, the ones about `app_propagation_on_ssowat` in here : https://gitlab.com/yunohost/yunohost/-/jobs/4326101161
[19:03:23]
<Aleks (he/him/il/lui)> probably something funky in ssowat
[20:59:07]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#875002594](https://gitlab.com/yunohost/yunohost/-/pipelines/875002594) failed on branch dev, bookworm
[21:10:31]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#875086899](https://gitlab.com/yunohost/yunohost/-/pipelines/875086899) failed on branch bookworm