[01:26:37]
<Émy - OniriCorpe> wtf .__.
sorry that my PR causes weird random bugs .__.
[01:26:45]
<Émy - OniriCorpe> wtf ._.
sorry that my PR causes weird random bugs ._.
[01:26:56]
<Émy - OniriCorpe> wtf .\_.
sorry that my PR causes weird random bugs .\_.
[02:01:50]
<Bram> > <@Alekswag:matrix.org> ```
> set -eu
>
> function foo()
> {
> local bar
> echo $bar
> }
>
> foo
> ```
>
> ```
> line 6: bar: unbound variable
> ```
that makes sens no? you declare bar but you don't bound it
[02:04:56]
<Bram> btw I hate the helpers code is fucking magic implicit land T_T
[02:14:06]
<Bram> also: I hate bash, I hope we'll move to xonsh or the new packaging format soon
[02:26:57]
<Yunohost Git/Infra notifications> [yunohost] @OniriCorpe opened [pull request #1743](https://github.com/YunoHost/yunohost/pull/1743): fix the helper when using using --use_template arg
[02:27:00]
<Émy - OniriCorpe> with the help of Bram : https://github.com/YunoHost/yunohost/pull/1743
[02:32:50]
<Yunohost Git/Infra notifications> [yunohost] @OniriCorpe [commented](https://github.com/YunoHost/yunohost/pull/1743#issuecomment-1826470903) on [issue #1743](https://github.com/YunoHost/yunohost/pull/1743) fix the helper when using using --use_template arg: poke @alexAubin
[02:36:24]
<Yunohost Git/Infra notifications> [yunohost] @OniriCorpe edited [pull request #1743](https://github.com/YunoHost/yunohost/pull/1743): fix the helper when using using --use_template arg
[02:36:35]
<Yunohost Git/Infra notifications> [yunohost] @OniriCorpe edited [pull request #1743](https://github.com/YunoHost/yunohost/pull/1743): fix the fail2ban helper when using using --use_template arg
[02:36:58]
<Yunohost Git/Infra notifications> [yunohost] @OniriCorpe edited [pull request #1743](https://github.com/YunoHost/yunohost/pull/1743): fix the fail2ban helper when using using --use_template arg
[13:18:03]
<Yunohost Git/Infra notifications> [yunohost] @alexAubin [commented](https://github.com/YunoHost/yunohost/pull/1743#discussion_r1405398289) on pull request #1743 fix the fail2ban helper when using using --use_template arg: So hmpf turns out there are only 3 apps using an explicit f2b_jail.conf file, and all use a different variable each time...
[15:14:14]
<Yunohost Git/Infra notifications> [yunohost] @OniriCorpe edited a [comment](https://github.com/YunoHost/yunohost/pull/1743#discussion_r1405418111) on pull request #1743 fix the fail2ban helper when using using --use_template arg: uh 😔 what do we do so? :<
[15:14:14]
<Yunohost Git/Infra notifications> [yunohost] @OniriCorpe [commented](https://github.com/YunoHost/yunohost/pull/1743#discussion_r1405418111) on pull request #1743 fix the fail2ban helper when using using --use_template arg: uh 😔 what do we do so? :<
[15:18:45]
<Yunohost Git/Infra notifications> [yunohost] @alexAubin [commented](https://github.com/YunoHost/yunohost/pull/1743#discussion_r1405418772) on pull request #1743 fix the fail2ban helper when using using --use_template arg: maybe we could instead check that logpath is defined (i mean in the if later), with eg if [ -n "{logpath:-}"] && ...
[15:30:14]
<Yunohost Git/Infra notifications> [yunohost] @OniriCorpe [commented](https://github.com/YunoHost/yunohost/pull/1743#discussion_r1405420668) on pull request #1743 fix the fail2ban helper when using using --use_template arg: yes, but that would make two different behaviors: when using --use_template, the log file would not be created if need...
[15:34:50]
<Yunohost Git/Infra notifications> [yunohost] @OniriCorpe [commented](https://github.com/YunoHost/yunohost/pull/1743#discussion_r1405421444) on pull request #1743 fix the fail2ban helper when using using --use_template arg: maybe we could use something like [ynh_replace_vars](https://github.com/YunoHost/yunohost/blob/5746b94dff4db4fc7acb12586...
[16:02:26]
<Yunohost Git/Infra notifications> [yunohost] @Axolotle pushed 1 commit to bookworm: configpanel: raise when unknown filter key ([d28b6e96](https://github.com/YunoHost/yunohost/commit/d28b6e96c89de081ec2a2bffc0a79054e5c99804))
[16:15:24]
<Yunohost Git/Infra notifications> 🏗️ Starting build for yunohost/12.0.0+202311261615 for bookworm/unstable/all ...
[16:16:30]
<Yunohost Git/Infra notifications> ✔️ Completed build for yunohost/12.0.0+202311261615 for bookworm/unstable/all.
[16:37:51]
<Yunohost Git/Infra notifications> [yunohost] @OniriCorpe [commented](https://github.com/YunoHost/yunohost/pull/1743#discussion_r1405431209) on pull request #1743 fix the fail2ban helper when using using --use_template arg: I tried something in https://github.com/YunoHost/yunohost/pull/1743/commits/5f7a207f112bae91cf61192cbeae3c9e631db6b0
[16:52:33]
<Yunohost Git/Infra notifications> [yunohost] @OniriCorpe edited [pull request #1743](https://github.com/YunoHost/yunohost/pull/1743): fix the fail2ban helper when using using --use_template arg
[16:52:41]
<Yunohost Git/Infra notifications> [yunohost] @OniriCorpe edited [pull request #1743](https://github.com/YunoHost/yunohost/pull/1743): fix the fail2ban helper when using using --use_template arg
[17:45:06]
<Yunohost Git/Infra notifications> [yunohost/bookworm] domain: reset portal_logo value even if file has already been removed - axolotle
[17:45:07]
<Yunohost Git/Infra notifications> [yunohost] @Axolotle pushed 3 commits to bookworm ([d28b6e96c89d...650c0136f2c3](https://github.com/YunoHost/yunohost/compare/d28b6e96c89d...650c0136f2c3))
[17:45:08]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#1085419662](https://gitlab.com/yunohost/yunohost/-/pipelines/1085419662) failed on branch bookworm
[17:45:26]
<Yunohost Git/Infra notifications> 🏗️ Starting build for yunohost/12.0.0+202311261745 for bookworm/unstable/all ...
[17:46:19]
<Yunohost Git/Infra notifications> ✔️ Completed build for yunohost/12.0.0+202311261745 for bookworm/unstable/all.
[18:22:45]
<Yunohost Git/Infra notifications> [yunohost] @alexAubin [commented](https://github.com/YunoHost/yunohost/pull/1743#discussion_r1405455683) on pull request #1743 fix the fail2ban helper when using using --use_template arg: In fact I realize that we can probably grep directly the destination file, which is rendered right before with the var...
[18:57:38]
<Yunohost Git/Infra notifications> [yunohost] @OniriCorpe [commented](https://github.com/YunoHost/yunohost/pull/1743#discussion_r1405460105) on pull request #1743 fix the fail2ban helper when using using --use_template arg: hm yes but we should use ynh_replace_vars (or any equivalent) to get a proper logpath, otherwise the path used to touch...
[19:00:00]
<Yunohost Git/Infra notifications> [yunohost] @OniriCorpe [commented](https://github.com/YunoHost/yunohost/pull/1743#discussion_r1405460391) on pull request #1743 fix the fail2ban helper when using using --use_template arg: maybe something like this? bash tempdir="(mktemp -d)" grep logpath "YNH_APP_BASEDIR/conf/f2b_jail.conf" | sed "s/ ...
[19:03:07]
<Yunohost Git/Infra notifications> [yunohost] @alexAubin [commented](https://github.com/YunoHost/yunohost/pull/1743#discussion_r1405460801) on pull request #1743 fix the fail2ban helper when using using --use_template arg: Eeeh but the point is that /etc/fail2ban/jail.d/app.conf is generated with ynh_add_config which already does "hydra...
[19:40:56]
<Yunohost Git/Infra notifications> [yunohost] 🔴 Pipeline [#1085445946](https://gitlab.com/yunohost/yunohost/-/pipelines/1085445946) failed on branch bookworm
[19:42:23]
<Yunohost Git/Infra notifications> [yunohost] @OniriCorpe [commented](https://github.com/YunoHost/yunohost/pull/1743#discussion_r1405466208) on pull request #1743 fix the fail2ban helper when using using --use_template arg: ah yes
[22:21:41]
<Yunohost Git/Infra notifications> [issues] @scottdky labeled :space_invader: bug on [issue #2290](https://github.com/YunoHost/issues/issues/2290): Lets Encrypt button is disabled for subdomains
[22:21:44]
<Yunohost Git/Infra notifications> [issues] @scottdky opened [issue #2290](https://github.com/YunoHost/issues/issues/2290): Lets Encrypt button is disabled for subdomains