[06:17:13]
<Yunohost Git/Infra notifications> [synapse_python_build] Josue-T created new t𝚊g v1.155.0
[07:09:37]
<Yunohost Git/Infra notifications> [issues] samsam-rolon [commented](https://github.com/YunoHost/issues/issues/2089#issuecomment-4727052846) on [issue #2089](https://github.com/YunoHost/issues/issues/2089) Support Lets Encrypt wildcard certificate: > Yes, that would be a major improvement for the security of YunoHost instances. A malicious hacker could easily scan th...
[12:05:20]
<Yunohost Git/Infra notifications> [yunohost] alexAubin merged [pull request #2302](https://github.com/YunoHost/yunohost/pull/2302): Translations update from Weblate
[12:15:49]
<Yunohost Git/Infra notifications> 🏗️ Starting build for yunohost/12.1.40.1+202606171415 for bookworm/unstable/all...
[12:25:28]
<Yunohost Git/Infra notifications> ✔️ Completed build for yunohost/12.1.40.1+202606171415 for bookworm/unstable/all.
[12:25:40]
<Yunohost Git/Infra notifications> ✔️ Completed distribution for yunohost/12.1.40.1+202606171415 for bookworm/unstable.
[13:07:14]
<Yunohost Git/Infra notifications> [yunohost] alexAubin edited [pull request #2309](https://github.com/YunoHost/yunohost/pull/2309): User invitations and self-registration
[13:11:15]
<Yunohost Git/Infra notifications> [yunohost] alexAubin pushed to user-self-registration: Fix misc typo, i18n, other stuff reported by flake ([6847b16e](https://github.com/YunoHost/yunohost/commit/6847b16e9c88a6507886d47b731c2bf1735af996))
[15:51:04]
<Yunohost Git/Infra notifications> [issues] A-Sverdrup [commented](https://github.com/YunoHost/issues/issues/2680#issuecomment-4732480713) on [issue #2680](https://github.com/YunoHost/issues/issues/2680) At least some offline capability: Caching installed apps: For packages installed directly from source (wget/curl+dpkg) (like Jellyfin):
keep the downloaded gz and refer to it [d...
[15:51:52]
<Yunohost Git/Infra notifications> [issues] A-Sverdrup [commented](https://github.com/YunoHost/issues/issues/2680#issuecomment-4732480713) on [issue #2680](https://github.com/YunoHost/issues/issues/2680) At least some offline capability: Caching installed apps: Solution for packages installed directly [wget/curl+dpkg] from non-apt deb / tar.gz distributions (like Jellyfin):
keep...
[16:16:54]
<Yunohost Git/Infra notifications> [moulinette] alexAubin pushed to dev: API: when no locale header is passed, try to derive the best locale to use from the Accept-Language header ... using a... ([962aa952](https://github.com/YunoHost/moulinette/commit/962aa95212fc2b8d5aa0cdd8b564aa773d84c43a))
[16:16:55]
<Yunohost Git/Infra notifications> [moulinette] alexAubin pushed to dev: lock: when aquiring the lock times out, trigger a specific exception to ease catching specifically this case (useful for... ([85e1d0a8](https://github.com/YunoHost/moulinette/commit/85e1d0a8c39b248f7122d82aa48740fc6980df04))
[16:20:30]
<Yunohost Git/Infra notifications> [yunohost] alexAubin pushed to user-self-registration: socketapi: pass the locale info through so we can get localized errors for user registration/invitation ([e011df4d](https://github.com/YunoHost/yunohost/commit/e011df4d27bf3b698a04959aeb5ab333c1045061))
[16:20:30]
<Yunohost Git/Infra notifications> [yunohost] alexAubin pushed to user-self-registration: socketapi: better handling of moulinette lock aquire timeout ([3d111cbe](https://github.com/YunoHost/yunohost/commit/3d111cbe5b8bac5b83d5fb19a17d23fcf67d3272))
[16:21:08]
<Yunohost Git/Infra notifications> [yunohost] alexAubin edited [pull request #2309](https://github.com/YunoHost/yunohost/pull/2309): User invitations and self-registration
[16:30:11]
<Yunohost Git/Infra notifications> 🏗️ Starting build for moulinette/12.1.3+202606171830 for bookworm/unstable/all...
[16:41:22]
<Yunohost Git/Infra notifications> ✔️ Completed build for moulinette/12.1.3+202606171830 for bookworm/unstable/all.
[16:41:23]
<Yunohost Git/Infra notifications> ✔️ Completed distribution for moulinette/12.1.3+202606171830 for bookworm/unstable.
[19:41:03]
<Yunohost Git/Infra notifications> [yunohost] tituspijean [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3430726878) on pull request #2309 User invitations and self-registration: suggestion
"antibot_challenge_doesnt_exist_or_expired": "This prove you are human challenge does not exist or h...
[19:41:50]
<Yunohost Git/Infra notifications> [yunohost] tituspijean [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3430688037) on pull request #2309 User invitations and self-registration: suggestion
# (garbage-)CollectMode is recommended when using Accept=yes on the socket, in
[19:42:50]
<Yunohost Git/Infra notifications> [yunohost] tituspijean [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3430723115) on pull request #2309 User invitations and self-registration: suggestion
"another_yunohost_operation_is_already_running": "Another YunoHost operation is already running on the...
[19:43:27]
<Yunohost Git/Infra notifications> [yunohost] tituspijean [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3430764095) on pull request #2309 User invitations and self-registration: suggestion
"domain_config_registration_tos_help": "This will add a mandatory checkbox during the account creation...
[19:44:36]
<Yunohost Git/Infra notifications> [yunohost] tituspijean [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3430753385) on pull request #2309 User invitations and self-registration: suggestion
"domain_config_registration_invite_mail_template_help": "This is used when choosing to send the invita...
[19:44:48]
<Yunohost Git/Infra notifications> [yunohost] tituspijean [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3430757917) on pull request #2309 User invitations and self-registration: suggestion
"domain_config_registration_tos": "Terms of Services",
[19:44:54]
<Yunohost Git/Infra notifications> [yunohost] tituspijean [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3430737080) on pull request #2309 User invitations and self-registration: suggestion
"domain_config_registration_invite_mail_template": "Custom email template for invitations",
Merel...
[19:44:56]
<Yunohost Git/Infra notifications> [yunohost] tituspijean [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3430770741) on pull request #2309 User invitations and self-registration: suggestion
"user_invitation_consumed_mail_body": "An invitation link was used to create an account with username ...
[19:44:58]
<Yunohost Git/Infra notifications> [yunohost] tituspijean [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3430773513) on pull request #2309 User invitations and self-registration: suggestion
"user_invitation_expired_or_doesnt_exist": "This invitation doesnt exist, has expired, or has already...
[19:45:04]
<Yunohost Git/Infra notifications> [yunohost] tituspijean [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3430835427) on pull request #2309 User invitations and self-registration: suggestion
"user_registration_to_review_mail_subject": "Dear {domain} admins,\n\nSomeone has just requested an ac...
[19:45:04]
<Yunohost Git/Infra notifications> [yunohost] tituspijean [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3430765284) on pull request #2309 User invitations and self-registration: suggestion
"fullname": "Full name",
[19:45:04]
<Yunohost Git/Infra notifications> [yunohost] tituspijean [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3430825814) on pull request #2309 User invitations and self-registration: suggestion
"user_registration_review_accept_or_reject": "Accept this request and create the account (a/A), or rej...
[19:45:04]
<Yunohost Git/Infra notifications> [yunohost] tituspijean [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3430778855) on pull request #2309 User invitations and self-registration: suggestion
"user_invitation_mail_template": "Hi\n\nYou’ve been invited to create an account on {domain} by the a...
[19:45:05]
<Yunohost Git/Infra notifications> [yunohost] tituspijean [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3430783818) on pull request #2309 User invitations and self-registration: suggestion
"user_registration_confirm_email_mail_body": "Hi,\n\nSomeone, hopefully you, requested an account on {...
[19:45:05]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3430918618) on pull request #2309 User invitations and self-registration: Maybe we should check a bit more, cause dev could make assumption that calling _hash_user_password avoid injection int...
[20:17:55]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3431055616) on pull request #2309 User invitations and self-registration: I am wondering if storing data in /etc/yunohost/ is a good idea (currently we only store config). In a perfect world, ...
[21:32:02]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3431135210) on pull request #2309 User invitations and self-registration: suggestion
api: GET /invitation/<token>
authentication:
api: null
arguments:
...
[21:32:04]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3431140411) on pull request #2309 User invitations and self-registration: suggestion
api: POST /invitation/<token>
authentication:
api: null
arguments:...
[21:32:06]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3431147494) on pull request #2309 User invitations and self-registration: Maybe its abad idea, maybe you dont want to see token in logs ?
[21:32:07]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3431148062) on pull request #2309 User invitations and self-registration: Maybe its abad idea, maybe you dont want to see token in logs ?
[21:32:09]
<Yunohost Git/Infra notifications> [yunohost] Josue-T [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3430940949) on pull request #2309 User invitations and self-registration: Why 710 and not not 700 ?
[21:32:19]
<Yunohost Git/Infra notifications> [yunohost] Josue-T [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3430988058) on pull request #2309 User invitations and self-registration: Seem a duplicate of line 115 ?
[21:32:21]
<Yunohost Git/Infra notifications> [yunohost] Josue-T [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3431121930) on pull request #2309 User invitations and self-registration: suggestion
for mail_user in ["root", "admin", "admins", "no-reply", "registrations", "certmanager", "diag...
[21:32:24]
<Yunohost Git/Infra notifications> [yunohost] Josue-T [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3431032741) on pull request #2309 User invitations and self-registration: Would be curious to understand why we are using root for this ? Maybe could we use an other user with less right ?
[21:32:26]
<Yunohost Git/Infra notifications> [yunohost] Josue-T [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3431061601) on pull request #2309 User invitations and self-registration: Should we raise an exception, as I feel its quite a fatal error if we return here ?
[21:32:27]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3431157212) on pull request #2309 User invitations and self-registration: suggestion
- str ^[a-z0-9][-a-z0-9_\.]*
This is the pattern in other part of our c...
[21:32:28]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3431174880) on pull request #2309 User invitations and self-registration: Seems registration_challenge is in double.
suggestion
[21:37:46]
<Yunohost Git/Infra notifications> [yunohost] tituspijean [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3431063105) on pull request #2309 User invitations and self-registration: suggestion
# However we should also display a similar message on the webadmin form
[21:37:51]
<Yunohost Git/Infra notifications> [yunohost] tituspijean [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3430850930) on pull request #2309 User invitations and self-registration: suggestion
action_help: Allow anybody to list public apps and other information regarding the public port...
[21:37:53]
<Yunohost Git/Infra notifications> [yunohost] tituspijean [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3431002789) on pull request #2309 User invitations and self-registration: suggestion
action_help: Obtain information about a pending invitation
[21:37:57]
<Yunohost Git/Infra notifications> [yunohost] tituspijean [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3431175821) on pull request #2309 User invitations and self-registration: suggestion
raise YunohostValidationError("This invitation token is invalid. Invitation tokens are expected to...
[21:38:01]
<Yunohost Git/Infra notifications> [yunohost] tituspijean [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3431141945) on pull request #2309 User invitations and self-registration: suggestion
return False, "As reported by the diagnosis, outgoing port 25 seems to be blocked, and sending...
[21:38:04]
<Yunohost Git/Infra notifications> [yunohost] tituspijean [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3431131625) on pull request #2309 User invitations and self-registration: The postfix@- one seems weird to me. It looks like it will run systemctl is-active --quiet postfix@-.service, which ...
[21:38:06]
<Yunohost Git/Infra notifications> [yunohost] tituspijean [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3431145703) on pull request #2309 User invitations and self-registration: suggestion
return "warning", "Issues related to emails were found in the diagnosis, such as reverse DNS o...
[21:38:09]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3431328901) on pull request #2309 User invitations and self-registration: How should it work on subdomain (if a topest domain exists) ?
Currently it seems portal options are displayed only on t...
[21:38:11]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3431365077) on pull request #2309 User invitations and self-registration: Indeed, this user "root" may have no specific right, but it could be called yunohost to be less confusing.
[21:38:33]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3431478894) on pull request #2309 User invitations and self-registration: Dont know if relevant what if raw_domain_settings.get("enable_self_registration", False) return "0", it is transfor...
[21:39:11]
<Yunohost Git/Infra notifications> [yunohost] Josue-T [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3431317424) on pull request #2309 User invitations and self-registration: seems a bit fragile in my opinion. But it would be interesting to have some other point of view about this ?
[21:39:13]
<Yunohost Git/Infra notifications> [yunohost] Josue-T [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3431539442) on pull request #2309 User invitations and self-registration: Im not sure to understand when we could end in this case. From my understanding if we can end here it means that the us...
[21:41:01]
<Yunohost Git/Infra notifications> [yunohost] Josue-T [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3431634576) on pull request #2309 User invitations and self-registration: Now we have the [QUERY](https://www.rfc-editor.org/info/rfc10008/) method which is like GET but you can pass some conten...
[21:47:16]
<Yunohost Git/Infra notifications> [yunohost] alexAubin pushed to user-self-registration: Apply suggestions from code review Co-authored-by: tituspijean <tituspijean@yunohost.org> Co-authored-by: Josue-T <7387... ([8869fa36](https://github.com/YunoHost/yunohost/commit/8869fa36f2fe1c25351153cb386b9094d870e8cc))
[21:52:02]
<Yunohost Git/Infra notifications> [yunohost] alexAubin [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3431684443) on pull request #2309 User invitations and self-registration: I dont see what you could really inject like ... its supposed to be a salt and a hash ? What can you really inject x_X
[21:52:38]
<Yunohost Git/Infra notifications> [yunohost] alexAubin edited a [comment](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3431684443) on pull request #2309 User invitations and self-registration: I dont see what you could really inject like ... its supposed to be a salt and a hash ? What can you really inject x_X...
[22:02:41]
<Yunohost Git/Infra notifications> [yunohost] alexAubin [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3431728233) on pull request #2309 User invitations and self-registration: I tried storing it /var/cache/yunohost initially, but ended up with the issue that /var/cache/yunohost has perms 70...
[22:10:26]
<Yunohost Git/Infra notifications> [yunohost] alexAubin [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3431762399) on pull request #2309 User invitations and self-registration: because ynh-portal needs x to be able to read the registration info (in the GET /invitation/<token> route) while *no...
[22:13:21]
<Yunohost Git/Infra notifications> [yunohost] alexAubin [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3431773545) on pull request #2309 User invitations and self-registration: I dont know, to me root is the natural choice because the code runs as root ... yunohost is confusing because its a...
[22:15:38]
<Yunohost Git/Infra notifications> [yunohost] alexAubin [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3431785264) on pull request #2309 User invitations and self-registration: I dont remember all the logic path ... In the context of user self-registration, if the external email is mandatory, it...
[22:17:50]
<Yunohost Git/Infra notifications> [yunohost] alexAubin [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3431797388) on pull request #2309 User invitations and self-registration: Thats because the real postfix service is only a wrapper around postfix@- as also expressed here https://github.com/Y...
[22:22:23]
<Yunohost Git/Infra notifications> [yunohost] alexAubin [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3431814070) on pull request #2309 User invitations and self-registration: I dont understand the question ... I tweaked the thing such as the registration-related settings are only available on ...
[22:24:32]
<Yunohost Git/Infra notifications> [yunohost] alexAubin [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3431823405) on pull request #2309 User invitations and self-registration: ... Then that sounds like an issue that should be handled at the serialization level of the settings, aka a bool should ...
[22:25:29]
<Yunohost Git/Infra notifications> [yunohost] alexAubin [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3431827283) on pull request #2309 User invitations and self-registration: Fragile in which fashion ? It drops the warnings / info or other message that could be happening, but I dont know what ...
[22:28:33]
<Yunohost Git/Infra notifications> [yunohost] alexAubin [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3431838268) on pull request #2309 User invitations and self-registration: Dont know what you mean, this is to handle the fact that the admin may either a) choose the username for the invitee or...
[22:29:20]
<Aleks (he/him/il/lui)> (done counter-reviewing)