[13:29:09]
<Guillaume Bouzige> 🤩
[13:29:10]
<Aleks (he/him/il/lui)> https://aria.im/_matrix/media/v1/download/matrix.org/pwKhCvoxKuQjQEXZBNTbgTkG
[13:29:10]
<Guillaume Bouzige> > <Krakinou> I don't know if it's only that, but I'm sure it happens each time 🙂
I have been battling around with CI those days and what I learned is that you must not be in a hurry. the lock get released like much much later on if only the whole thing is not stuck...i will be willing in a nearby future to run some more tests inVM/VPS to see a bit more in details what is going on...globally it works great when you don't look at it too much and you don't expect any result soon. In fact testing shall be done outside of CI in a reproducible env instead so we don't "look for" or "discover" errors in CI.
[13:29:11]
<Aleks (he/him/il/lui)> (the full set of 200ish icons i spent my entire sunday on :D)
[13:29:11]
<@rosbeefandino:3cmr.fr> 206 😱👏
[13:29:13]
<Pierre (plabuse)> Aleks (he/him/il/lui): nice, beau boulot, nous allons pouvoir mettre des icônes sur le dashboard de Yunohost maintenant, ;-)
[13:40:51]
<Pierre (plabuse)> ok, c'est quoi la taille de tes icônes (140x140), j'aimerais bien faire un sprite css, genre https://w3bits.com/css-sprites/ pour utiliser ensuite dans le code.
[13:40:52]
<Aleks (he/him/il/lui)> Hmyeah if i dont procrastinate and start yet another thing instead of finishing what i already started :D
[13:50:52]
<Aleks (he/him/il/lui)> ébenheu j'ai pas de taille vraiment fixée, mais c'est des carrés, la taille m'importe peu (sauf pour la taille du fichier) car en CSS je resize tout en 200x200
[13:55:42]
<Aleks (he/him/il/lui)> discussing with axolotle i think i'll end up making a PR to host the icons in the apps repo at some point ... the biggest question is wat do with the apps that have no icon/logo, we need some sort of placeholder system, maybe with the icon of the category or tags
[14:05:51]
<axolotle> yep a generated sprite can be a good idea, a single file to fetch from apps
[14:08:24]
<axolotle> that would require to store icon position in sprite in the apps json, with maybe a fallback to a forkawesome icon name indeed
[14:23:54]
<Aleks (he/him/il/lui)> hmmm not sure to understand the benefit of a sprite file, that sounds overly complex for just having a single file to fetch 🤔
[14:24:12]
<Aleks (he/him/il/lui)> like if you modify a single logo you gotta refetch the entire huge file 🤔
[14:24:28]
<axolotle> yup
[14:52:15]
<Pierre (plabuse)> Aleks (he/him/il/lui): ce n'est pas faux, dans notre cas le sprite n'est pas judicieux.
[15:41:03]
<Aleks (he/him/il/lui)> speaking of finishing what I started: before we start packaging too many apps in v2 format, I'm wondering if we shouldnt simplify the notification architecture, ie instead of having:
```
doc/
- DESCRIPTION.md
- ADMIN.md
- notifications/
- pre_install.md
- post_install.md
- etc...
```
I think we should simply have:
```
doc/
- DESCRIPTION.md
- ADMIN.md
- PRE_INSTALL.md
- POST_INSTALL.md
- ...
```
whatcha think folks ?
[15:41:48]
<Aleks (he/him/il/lui)> the idea being to avoid having yet another subfolders, and keeping all filename in caps lock, and this makes it a bit more intuitive that all files support the `__FOOBAR__` syntax for variables/settings
[15:50:56]
<@rosbeefandino:3cmr.fr> > <@Alekswag:matrix.org> hmmm not sure to understand the benefit of a sprite file, that sounds overly complex for just having a single file to fetch 🤔
👍 more i have only 5 apps on m'y ynh why to load all logos. And and who administrate the logo position in the sprite.
[15:53:04]
<@rosbeefandino:3cmr.fr> > <@Alekswag:matrix.org> discussing with axolotle i think i'll end up making a PR to host the icons in the apps repo at some point ... the biggest question is wat do with the apps that have no icon/logo, we need some sort of placeholder system, maybe with the icon of the category or tags
Why not to put the logo in background of the tile letting the capital letter over the logo?
[15:53:54]
<@rosbeefandino:3cmr.fr> If no logo at least it keeps the colored background and the capital letter
[15:54:11]
<Aleks (he/him/il/lui)> ah yeah i was more thinking about integrating this in the webadmin first, not in user portal (for now)
[15:54:51]
<Aleks (he/him/il/lui)> but indeed we could create a placeholder (or alternative logo) using the good old "periodic table" look
[15:55:02]
<@rosbeefandino:3cmr.fr> > <@Alekswag:matrix.org> ah yeah i was more thinking about integrating this in the webadmin first, not in user portal (for now)
😆one more task ;)
[15:55:22]
<Aleks (he/him/il/lui)> yeah YunoHost is infinite
[15:56:27]
<Aleks (he/him/il/lui)> Countable infinites < Uncountable infinites < Yunohost infinites
[15:57:03]
<@rosbeefandino:3cmr.fr> Just for my information what is the v2 app?
[15:57:22]
<Aleks (he/him/il/lui)> a major evolution of the packaging format coming in yunohost 11.1
[15:57:30]
<Aleks (he/him/il/lui)> (though 11.1 stays compatible with the old packaging format of course)
[15:58:20]
<Aleks (he/him/il/lui)> the corresponding doc is in a pull request for now, but you can have a look at https://github.com/YunoHost/doc/blob/8beb56a749efec6dd2a3cf9a7b847fac8d8d1930/pages/06.contribute/10.packaging_apps/14.advanced/03.packaging_v2/packaging_v2.md
[15:59:18]
<Aleks (he/him/il/lui)> there is a also a bunch of PR porting some apps to v2, for example https://github.com/YunoHost-Apps/castopod_ynh/tree/v2
[16:13:24]
<@rosbeefandino:3cmr.fr> Why changing from json to toml?
[16:15:08]
<@rosbeefandino:3cmr.fr> Readability?
[16:20:16]
<@rosbeefandino:3cmr.fr> Hooo, i'm so disconected, i'm packaging only what i need when it's broken. I will throw an eye 👁️🗨️
[16:25:48]
<gredin67> would you prefer JWT secret disabled or a nextcloud_ynh action to write the token in nextcloud config from onlyoffice installer ? https://github.com/YunoHost-Apps/nextcloud_ynh/issues/537
[16:25:48]
<Aleks (he/him/il/lui)> > <@rosbeefandino:3cmr.fr> Why changing from json to toml?
json aint meant to be written by humans, its syntax is annoying, toml is just more lightweight
[16:26:15]
<Aleks (he/him/il/lui)> and also to be consistent with `config_panel.toml` being written in toml
[16:26:39]
<Aleks (he/him/il/lui)> (and the future `tests.toml` replacing that horendous `check_process`)
[16:53:28]
<Guillaume Bouzige> toml is great ! yes
[18:19:56]
<Aleks (he/him/il/lui)> yalh76: hmmm what's the status of https://github.com/YunoHost/package_check/pull/130, is this something we could merge ? 👀
[19:29:17]
<@oufmilo:mtx.travelpandas.eu> Bonsoir,
[19:33:54]
<@oufmilo:mtx.travelpandas.eu> Mon Yunorunner fonctionne ! 🥳🥳
Est ce que c'est bon si je fais un PR avec le résultat comme ici -> https://github.com/YunoHost-Apps/peertube\_ynh/pull/361
Ou alors je dois quand même passer par le votre -> https://ci-apps-dev.yunohost.org/ci/
[20:42:08]
<Aleks (he/him/il/lui)> 🅞🅤🅕🅜🅘🅛🅞: benheu ouai idéalement c'est bien de faire tourner sur la CI classique à moins que y'ai une raison vraiment précise de pas passer par la CI classique
[20:42:30]
<Aleks (he/him/il/lui)> genre ça évite de devoir faire confiance à des CI hébergées par pleins de gens différent
[20:47:31]
<@oufmilo:mtx.travelpandas.eu> > <@Alekswag:matrix.org> 🅞🅤🅕🅜🅘🅛🅞: benheu ouai idéalement c'est bien de faire tourner sur la CI classique à moins que y'ai une raison vraiment précise de pas passer par la CI classique
Ok pas de soucis, c'est juste que parfois ça permet de désencombrer la CI classique.
Je viens de relancer le test sur la CI classique 👍
[20:48:09]
<@oufmilo:mtx.travelpandas.eu> > <@Alekswag:matrix.org> genre ça évite de devoir faire confiance à des CI hébergées par pleins de gens différent
Oui je comprend