Tuesday, February 14, 2023
apps@conference.yunohost.org
February
Mon Tue Wed Thu Fri Sat Sun
    1 2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
         
             

[15:56:47] <eric_G> also, it says :
```
============================================
[Test 8/9] Upgrade from null
============================================

```
[16:01:05] <eric_G> isn't it picking https://github.com/YunoHost-Apps/element_ynh/blob/6ae5488eff8ca42b78a1dea3cf3c8a9a7107797e/tests.toml#L9
[16:01:07] <Aleks (he/him/il/lui)> > <@ericg:matrix.org> I don't understand why upgrade from script fails for element v2

which test exactly do you mean ?
[16:01:07] <Aleks (he/him/il/lui)> i was checking the old "v2" branch test
[16:01:07] <Aleks (he/him/il/lui)> hmmm
[16:01:07] <Aleks (he/him/il/lui)> yeah there's a bug with the name, gotta check it
[16:01:07] <Aleks (he/him/il/lui)> ah, `is_public=false` in the install arg .. hmmm why is that
[16:01:07] <Aleks (he/him/il/lui)> ah found it yes
[16:01:07] <eric_G> `Test 8/9`
[16:05:18] <Aleks (he/him/il/lui)> ah because is_public was false in the old manifest
[16:05:18] <Aleks (he/him/il/lui)> zbleh
[16:10:00] <Yunohost Git/Infra notifications> [package_check] @alexAubin pushed 1 commit to master: tests.toml: fix upgrade name thingy ([efc9313f](https://github.com/YunoHost/package_check/commit/efc9313f87098179ceeaf67af263ea98f97260c6))
[16:11:58] <Aleks (he/him/il/lui)> > <@ericg:matrix.org> I don't understand why upgrade from script fails for element v2

cf https://github.com/YunoHost-Apps/element_ynh/pull/91/files#r1106040132
[16:12:19] <Aleks (he/him/il/lui)> not 100% sure that's the right way to fix it, we could also always force is_public to true in that context in package check ...
[17:12:08] <Yunohost Git/Infra notifications> [package_check] @alexAubin pushed 1 commit to master: Complain about config file manually modified thing in summary.png and for level 7 ([e0c47661](https://github.com/YunoHost/package_check/commit/e0c4766168292074c1d21d5ed377dd791efe95b4))
[17:23:16] <eric_G> https://ci-apps-dev.yunohost.org/ci/job/5646 this seems related to the removale of `YNH_PHP_VERSION="8.1"` will test with it back on...
[18:54:48] <eric_G> oupsy, I was posting in the wrong channel
[19:51:44] <eric_G> adding this to Invidious script seems to fix the issue: https://github.com/YunoHost-Apps/invidious_ynh/blob/ef082b70d674ca08426ecc6a181bbffdcf31a6fd/scripts/install#L113
[20:05:41] <Yunohost Git/Infra notifications> [apps] @fflorent just made [pull request #1632](https://github.com/YunoHost/apps/pull/1632) ready for review: Flag Paheko as working
[20:09:00] <Yunohost Git/Infra notifications> [apps] @fflorent [commented](https://github.com/YunoHost/apps/pull/1632#issuecomment-1430312338) on [issue #1632](https://github.com/YunoHost/apps/pull/1632) Flag Paheko as working: Also a question: as garradin is now renamed paheko, and the migration process is supported, what should we do regarding ...
[20:32:19] <Yunohost Git/Infra notifications> [apps] @ericgaspar merged [pull request #1632](https://github.com/YunoHost/apps/pull/1632): Flag Paheko as working
[20:32:20] <Yunohost Git/Infra notifications> [apps] @ericgaspar pushed 2 commits to master ([6d4f3615cdb0...5c231ac5e37b](https://github.com/YunoHost/apps/compare/6d4f3615cdb0...5c231ac5e37b))
[20:32:30] <Yunohost Git/Infra notifications> [apps/master] Flag Paheko as working - Florent
[20:32:30] <Yunohost Git/Infra notifications> [apps/master] Merge pull request #1632 from fflorent/patch-7 Flag Paheko as working - Éric Gaspar
[20:36:37] <florent> Thanks for the merge, eric_G :)
Do you have an idea of what to do regarding my question by chance? https://github.com/YunoHost/apps/pull/1632#issuecomment-1430312338
[20:38:36] <eric_G> I guess you can look to the Riot -> Element transition : https://github.com/YunoHost/apps/pull/1521/files
[20:39:37] <eric_G> ah... Riot repo as been deleted
[22:46:16] <Yunohost Git/Infra notifications> [apps] @rodinux [commented](https://github.com/YunoHost/apps/pull/1632#issuecomment-1430491688) on [issue #1632](https://github.com/YunoHost/apps/pull/1632) Flag Paheko as working: Perhaps just flagged as deprecated. I have edit also a PR here https://github.com/YunoHost-Apps/garradin_ynh/pull/98 ad...
[22:52:54] <Yunohost Git/Infra notifications> [apps] @rodinux [commented](https://github.com/YunoHost/apps/pull/1632#issuecomment-1430497515) on [issue #1632](https://github.com/YunoHost/apps/pull/1632) Flag Paheko as working: I am not sure if its very clear... Perhaps we can add a message send to the admins in the upgrade script ?
[23:10:32] <Yunohost Git/Infra notifications> [apps] @rodinux [commented](https://github.com/YunoHost/apps/pull/1632#issuecomment-1430513772) on [issue #1632](https://github.com/YunoHost/apps/pull/1632) Flag Paheko as working: like this? https://github.com/YunoHost-Apps/garradin_ynh/pull/99