Tuesday, April 04, 2023
apps@conference.yunohost.org
April
Mon Tue Wed Thu Fri Sat Sun
          1
2
3
4
5
6
7
8
9
10
11
12 13 14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
             

[02:12:38] <Yunohost Git/Infra notifications> App hedgedoc goes down from level 8 to 6 in job [#14800](https://ci-apps.yunohost.org/ci/job/14800)
[03:24:16] <Yunohost Git/Infra notifications> Job [#14081](https://ci-apps.yunohost.org/ci/job/14081) for libreerp failed miserably :(
[03:28:22] <Yunohost Git/Infra notifications> Job [#14155](https://ci-apps.yunohost.org/ci/job/14155) for huginn failed miserably :(
[08:14:05] <Yunohost Git/Infra notifications> Job [#14413](https://ci-apps.yunohost.org/ci/job/14413) for snweb failed miserably :(
[09:33:16] <Yunohost Git/Infra notifications> @ericgaspar forked nextcloud_ynh to [ericgaspar/nextcloud_ynh](https://github.com/ericgaspar/nextcloud_ynh)
[14:13:44] <Aleks (he/him/il/lui)> 85 apps using packaging v2 :3
[14:15:06] <Aleks (he/him/il/lui)> and 24 with the new autoupdate thingy o.o
[14:15:24] <Aleks (he/him/il/lui)> will try setting up the cron job
[14:18:53] <eric_G> I have not yet experienced an app being updated yet
[14:19:58] <eric_G> is this related to the cron job you are talking about?
[14:25:40] <Yunohost Git/Infra notifications> [apps] @alexAubin pushed 1 commit to master: autoupdate-app-sources: always run in dry-run mode by default, even when running on the entire catalog ([662d9bd0](https://github.com/YunoHost/apps/commit/662d9bd0895ac228fb958078b4df7d2b7050ead9))
[14:26:48] <Aleks (he/him/il/lui)> > <@ericg:matrix.org> is this related to the cron job you are talking about?

yeah I didn't set up the cron job on our infra yet, I was waiting for some apps to actually implement it
[15:12:26] <Aleks (he/him/il/lui)> eric_G: I'm confused about https://github.com/YunoHost-Apps/cypht_ynh/blob/master/manifest.toml ... version is "1.3.0" but the corresponding upstream tag is from 2021 ... and the source actually uses a recent commit and it sounds like the upstream abandonned any proper versioning :|
[15:13:01] <Aleks (he/him/il/lui)> the auto-upgrade mechanism will want to switch to some date-based versioning like `2023.03.20 `
[15:20:37] <eric_G> > <@Alekswag:matrix.org> eric_G: I'm confused about https://github.com/YunoHost-Apps/cypht_ynh/blob/master/manifest.toml ... version is "1.3.0" but the corresponding upstream tag is from 2021 ... and the source actually uses a recent commit and it sounds like the upstream abandonned any proper versioning :|

ah yes, according to the upstream maintainer, the app has add a lot of changes and should use recent commit to be updated. (I don't understand why app updates are not tag incremented...).
[15:21:29] <eric_G> 1.4.0 should be on the way
[15:24:07] <Aleks (he/him/il/lui)> hmfyeah I'm seeing this ... but they could still tag from time to time instead of being like "yeah just use a recent commit" T_T
[15:24:44] <Aleks (he/him/il/lui)> it's been like 2 years T_T
[15:24:56] <Aleks (he/him/il/lui)> dunno wat do with this ...
[15:25:46] <eric_G> manually autoupdate 🫠
[15:28:51] <Aleks (he/him/il/lui)> I'm also confused about https://github.com/Indexhibit/indexhibit ... the manifest says version 2.1.6 but there's not mention anywhere of the version on the upstream ? x_x
[15:29:34] <eric_G> https://www.indexhibit.org/
[15:30:02] <eric_G> the is something about version 2.1.6 in here
[15:30:16] <eric_G> but it's not gonna help updating the app
[15:31:00] <Aleks (he/him/il/lui)> ogod
[15:47:26] <Aleks (he/him/il/lui)> hmf similar story with https://github.com/seejohnrun/haste-server ... they just commit without any proper tag/release ... their package.json contains "0.1.0" since like forever -_-
[15:50:59] <tituspijean[m]> Let's add a toml tag for "Bad versioning scheme" and auto create the version like 0.YYYY-MM-DD :P
[15:51:54] <Aleks (he/him/il/lui)> yup I was thinking about that but didn't think about the tip of prefixing stuff with `0.` thanks for the tip 👍️
[15:52:28] <Aleks (he/him/il/lui)> i have a similar boring situation with ethercalc for whose version is `YYYYMMDD` instead of `YYYY.MM.DD` ...
[15:54:15] <Aleks (he/him/il/lui)> https://github.com/alextselegidis/plainpad/tags latest tag 3 years ago
[15:54:16] <Aleks (he/him/il/lui)> for christ sake
[16:16:19] <Yunohost Git/Infra notifications> [apps] @alexAubin pushed 1 commit to master: autoupdate app source: various script improvements after tests on the battlefield ([7daa6cc6](https://github.com/YunoHost/apps/commit/7daa6cc6949cdbebc536d52784aa6083cb87b1d5))
[16:32:32] <Yunohost Git/Infra notifications> [apps] @alexAubin pushed 1 commit to master: autoupdate app source: add boring force_version parameter for cases where the upstreams dont give a flying fuck about... ([df187ecb](https://github.com/YunoHost/apps/commit/df187ecbc18a9a0b003a8a8b7511aea2b930b0be))
[16:41:45] <Yunohost Git/Infra notifications> [apps] @alexAubin pushed 1 commit to master: Meh ([05061a7a](https://github.com/YunoHost/apps/commit/05061a7ac5732996c2cd0a4b5d587d54abe2c956))
[16:44:58] <Yunohost Git/Infra notifications> [apps] @alexAubin pushed 1 commit to master: autoupdate app sources: some upstream repo have a trailing slash ... ([88d70749](https://github.com/YunoHost/apps/commit/88d70749ac739cf3f485e480a678e88c80054137))
[16:53:46] <eric_G> is this usefull? https://github.com/YunoHost-Apps/jirafeau_ynh/blob/bc6973acedb449fe88d69a8b6e391ca06ed39bcc/scripts/install#L127-L132
[16:55:20] <Yunohost Git/Infra notifications> [apps] @alexAubin pushed 1 commit to master: autoupdate app sources: dont update if main version didnt change, despite previous commits ([c33440d0](https://github.com/YunoHost/apps/commit/c33440d0dedeb144e621069536649f2e924cd2d8))
[17:00:00] <Aleks (he/him/il/lui)> apparently it's used here ... https://github.com/YunoHost-Apps/jirafeau_ynh/blob/master/conf/config.local.php#L30 é_è
[17:00:08] <tituspijean[m]> > <@ericg:matrix.org> is this usefull? https://github.com/YunoHost-Apps/jirafeau_ynh/blob/bc6973acedb449fe88d69a8b6e391ca06ed39bcc/scripts/install#L127-L132

Looks like a hack to comply with a varible in the config file
[17:05:07] <Aleks (he/him/il/lui)> Sooo I actually ran the auto-update source script, it triggered PRs for :

20euros, cypht, gamja, haste, indexhibit, osticket, plainpad, prestashop
[17:05:39] <Aleks (he/him/il/lui)> (most of those because of the lack of upstream versioning system)
[17:06:40] <Aleks (he/him/il/lui)> and also realized that for now it doesn't automatically trigger a `!testme`, do we want this ? I'm confused wether or not the existing github workflow did this
[17:07:02] <Yunohost Git/Infra notifications> Job [#14413](https://ci-apps.yunohost.org/ci/job/14413) for snweb failed miserably :(
[17:07:43] <eric_G> link for 20euros doesn't seem to work: https://github.com/jatekos101/20euros/archive/refs/tags/0.1.tar.gz
[17:08:06] <Aleks (he/him/il/lui)> eeeh
[17:08:36] <Aleks (he/him/il/lui)> 🙀
[17:12:12] <Aleks (he/him/il/lui)> ah it should be `v0.1` instead of `0.1` ... hm, will dig this bug
[17:15:21] <Yunohost Git/Infra notifications> [apps] @alexAubin pushed 1 commit to master: autoupdate app sources: fix asset url for latest tag strategy ([09a24333](https://github.com/YunoHost/apps/commit/09a243330b8ee234c9383da17f18555437faf6da))
[17:15:33] <Aleks (he/him/il/lui)> so hmmm what happens now if I relaunch this thing 🤔
[17:17:35] <Aleks (he/him/il/lui)> hmyeah it can't force-push
[17:17:50] <tituspijean[m]> > <@Alekswag:matrix.org> and also realized that for now it doesn't automatically trigger a `!testme`, do we want this ? I'm confused wether or not the existing github workflow did this

I think there's a piece of code in the webhooks that allow for an automated yunorunner job creation if...
 
the author is the github bot or the base branch starts by ci-auto-update-v or whatever, cant remember
[17:18:05] <tituspijean[m]> But I guess that yes, we do want that :)
[17:20:04] <Aleks (he/him/il/lui)> oooh okay nice
[17:42:15] <eric_G> tituspijean: any problem adding groups in the last Galène version?
[17:44:29] <eric_G> when I add `group.json`, the group does not appear in Galène homepage. (but I can access it with a direct link address)
[17:45:49] <tituspijean[m]> I haven't tried :/
[19:54:34] <tituspijean[m]> (trying now)
[20:03:19] <tituspijean[m]> Works for me™ after a service restart 😕
[20:03:40] <tituspijean[m]> (and making sure the file belongs to galene:galene)
[20:51:28] <eric_G> ah... and you have the last version 0.6.2~ynh4 ?(the one with hash password)
[20:56:36] <tituspijean[m]> yup
[20:58:05] <eric_G> mmmh
[20:59:55] <tituspijean[m]> I merely copied the public.json file, and renamed it.
[21:02:46] <eric_G> ahah
[21:02:55] <eric_G> that worked for me too
[21:04:00] <eric_G> can you try to creat a group without hashed password?
[21:06:09] <tituspijean[m]> with plain text password? or no "password" key in the JSON?
[21:06:38] <eric_G> with plain text password
[21:07:29] <tituspijean[m]> works still!
[21:07:42] <tituspijean[m]> ```
cat private.json
{
"op": [{"username": "titus", "password": "coucou"}],
"presenter": [{}],
"description": "nope",
"public": true,
"allow-anonymous": true,
"allow-recording": true,
"allow-subgroups": true
}
```
[21:09:28] <eric_G> Jesus
[21:10:11] <eric_G> I must have misconfigured the json file 😭
[21:17:38] <tituspijean[m]> I'm afraid so 😕
time to preach TOML to jech 😛
[21:18:40] <eric_G> guess what, I fuck up TOML too
[22:37:20] <m606> Hello, is the autoupdate feature recently merged & documented already in service on YNH infra ?
Is it possible to give it a try on the "testing" branch of an app before merging to "master" (just added the required entries in the manifest.toml, I would like to make sure it works as intended)?
[22:38:28] <Aleks (he/him/il/lui)> m606: it's being slowly implemented yeah, i was working on it this afternoon, will add a proper cronjob running every X days soon
[22:39:07] <Aleks (he/him/il/lui)> in any case you can run the script yourself with `python3 autoupdate_app_sources.py /path/to/your/app` to test what it would do
[23:14:25] <Yunohost Git/Infra notifications> Job [#14733](https://ci-apps.yunohost.org/ci/job/14733) for gitlab failed miserably :(
[23:36:10] <m606> > <@Alekswag:matrix.org> in any case you can run the script yourself with `python3 autoupdate_app_sources.py /path/to/your/app` to test what it would do

Alright, thanks - no rush for me. Successfully tested!
However FYI, I had made a mistake in the regex of `autoupdate.asset`in the manifest and it made the autoupdate python script fail with the following error (related to lines 123 and 408 of the script):
```
python3.10/site-packages/toml/decoder.py", line 866, in load_value
ValueError: Reserved escape sequence used
```
[23:37:37] <m606> the regex used to trigger that error was `autoupdate.asset = "MyApp\_.*\.zip"`
[23:39:15] <m606> I had validated the regex on an online tester, and it worked correctly to match an asset name such as`MyApp_v1.0.0.zip`
[23:40:23] <m606> When correcting the regex to `autoupdate.asset = "MyApp_.*.zip"` (removing escape characters) the script did work as expected
[23:49:35] <m606> [Reading further](https://blog.robertelder.org/regular-expression-character-escaping/), it seems that escaping underscore was overkill, but that dot used literally should in theory actually be escaped. But here the script works correctly if NOT escaped, and fail if escaped.
[23:50:35] <m606> > <@m606:matrix.org> [Reading further](https://blog.robertelder.org/regular-expression-character-escaping/), it seems that escaping underscore was overkill, but that dot used literally should in theory actually be escaped. But here the script works correctly if NOT escaped, and fail if escaped.

@Aleks (he/him/il/lui) would you like me to edit the doc to tell not to escape dot ?