[03:37:54]
<Yunohost Git/Infra notifications> App kodi failed all tests in job [#14853](https://ci-apps.yunohost.org/ci/job/14853) :(
[04:05:43]
<Yunohost Git/Infra notifications> App question2answer stays at level 2 in job [#14854](https://ci-apps.yunohost.org/ci/job/14854)
[05:15:28]
<Yunohost Git/Infra notifications> App radicale failed all tests in job [#14857](https://ci-apps.yunohost.org/ci/job/14857) :(
[06:30:59]
<Yunohost Git/Infra notifications> App cockpit rises from level 7 to 8 in job [#15108](https://ci-apps.yunohost.org/ci/job/15108) !
[07:43:00]
<Yunohost Git/Infra notifications> App digisteps rises from level 7 to 8 in job [#15110](https://ci-apps.yunohost.org/ci/job/15110) !
[08:29:30]
<Yunohost Git/Infra notifications> App librephotos failed all tests in job [#15112](https://ci-apps.yunohost.org/ci/job/15112) :(
[10:12:50]
<Yunohost Git/Infra notifications> App roundcube failed all tests in job [#14865](https://ci-apps.yunohost.org/ci/job/14865) :(
[10:18:36]
<tituspijean[m]> > <@yunohostinfra:matrix.org> App roundcube failed all tests in job [#14865](https://ci-apps.yunohost.org/ci/job/14865) :(
what? an incorrect notification from 11 days ago?
[11:01:19]
<Yunohost Git/Infra notifications> App ztncui rises from level 0 to 7 in job [#14867](https://ci-apps.yunohost.org/ci/job/14867) !
[11:34:45]
<Yunohost Git/Infra notifications> [apps] @rndmh3ro opened [pull request #1663](https://github.com/YunoHost/apps/pull/1663): add libremdb to app catalog
[11:37:08]
<Yunohost Git/Infra notifications> [apps] @tituspijean approved [pull request #1663](https://github.com/YunoHost/apps/pull/1663#pullrequestreview-1391866036) add libremdb to app catalog: Cheers
[11:37:20]
<Yunohost Git/Infra notifications> [apps] @tituspijean merged [pull request #1663](https://github.com/YunoHost/apps/pull/1663): add libremdb to app catalog
[11:37:20]
<Yunohost Git/Infra notifications> [apps] @tituspijean pushed 2 commits to master ([3460712c0f9f...6956595ca7dd](https://github.com/YunoHost/apps/compare/3460712c0f9f...6956595ca7dd))
[11:37:24]
<Yunohost Git/Infra notifications> [apps/master] add libremdb to app catalog - Sebastian Gumprich
[11:37:31]
<Yunohost Git/Infra notifications> [apps/master] Merge pull request #1663 from rndmh3ro/libremdb add libremdb to app catalog - tituspijean
[13:05:15]
<rodinux[m]> in the actual stable repo ```# If final_path doesn't exist, create it
if [ -z "$final_path" ]; then
final_path=/var/www/$app
ynh_app_setting_set --app=$app --key=final_path --value=$final_path
fi
# If secret_key doesn't exist, create it
if [[ -z "$secret_key" ]]; then
secret_key=$(ynh_string_random --length=50)
ynh_app_setting_set --app=$app --key=secret_key --value=$secret_key
fi
# Cleaning legacy permissions
if ynh_legacy_permissions_exists; then
ynh_legacy_permissions_delete_all
ynh_app_setting_delete --app=$app --key=is_public
fi```
[13:23:59]
<rodinux[m]> the v2 remove a lot of lines !
[13:39:03]
<rodinux[m]> in a local install I got this https://paste.yunohost.org/raw/ogeqirebaj
[13:39:10]
<rodinux[m]> `Source path '' does not exist`
[13:41:00]
<rodinux[m]> Is it recommanded downgrade the php version ? the initial projecy use php8.0 but here the v2 remove this dependency...
[13:42:39]
<eric_G> PHP version is now set in manifest like so https://github.com/YunoHost-Apps/paheko_ynh/blob/aeda71695cd4cbc6cba47dd441e29bcd8898f556/manifest.toml#L57
[13:47:44]
<rodinux[m]> ok, I see...
[13:49:08]
<rodinux[m]> well I just want be sure the upgrade script could work before merge this...
[13:51:27]
<rodinux[m]> got something like Info : [++++++++++++........] > Backing up the app before upgrading (may take a while)...
Attention : 717 Source path '' does not exist
Attention : 2249 Impossible de sauvegarder paheko__2
Attention : 2297 Il n'y a rien à sauvegarder
[13:56:00]
<rodinux[m]> pehaps because there is no LOAD SETTINGS ? before
[13:57:45]
<rodinux[m]> or a mistake with before key=$final_path and now $install_dir ?
[14:06:18]
<eric_G> this is odd... https://github.com/YunoHost-Apps/paheko_ynh/blob/534bb03f927c5301e69bc0339a7441142a75b485/scripts/install#L106-L108
[14:06:58]
<eric_G> template path should be `--template="../conf/config.local.php"`
[14:07:32]
<tituspijean[m]> (IIRC it works without the `../conf/` too)
[14:07:44]
<eric_G> ah
[14:09:04]
<rodinux[m]> You think it could be the cause of the error ?
[14:09:10]
<eric_G> no
[14:09:41]
<eric_G> but maybe the migration script
[14:10:18]
<rodinux[m]> Yes, I think there is maybe something difficult with the migration script...
[14:15:50]
<rodinux[m]> but the test is without executing the migration...
[14:17:19]
<rodinux[m]> but perhaps it important keep app=$YNH_APP_INSTANCE_NAME
[14:17:39]
<tituspijean[m]> That's weird... we should have a safeguard for that. My guess for the issue is that v1.2.7 still uses $final_path, so when upgrading to packaging v2 and running the backup script the $install_dir variable is not set
[14:17:59]
<tituspijean[m]> > <@rodinux07:matrix.org> got something like Info : [++++++++++++........] > Backing up the app before upgrading (may take a while)...
> Attention : 717 Source path '' does not exist
> Attention : 2249 Impossible de sauvegarder paheko__2
> Attention : 2297 Il n'y a rien à sauvegarder
(referring to this)
[14:18:35]
<rodinux[m]> yes, I was thinking about something like this...
[14:19:48]
<tituspijean[m]> but we should have seen the issue in every other app, hence why I think there should already be a failsafe somewhere in the code
[14:22:17]
<rodinux[m]> here also https://github.com/YunoHost-Apps/paheko_ynh/blob/master/conf/config.local.php
[14:24:27]
<rodinux[m]> pehaps must be "'_INSTALLDIR_' "?
[14:24:30]
<eric_G> this is in the master branch
[14:24:54]
<eric_G> https://github.com/YunoHost-Apps/paheko_ynh/blob/version-2/conf/config.local.php
[14:24:55]
<rodinux[m]> ok, sorry...
[14:26:14]
<rodinux[m]> also in the v2...
[14:33:26]
<rodinux[m]> perhaps the mistake come from the lines here https://github.com/YunoHost-Apps/paheko_ynh/blob/534bb03f927c5301e69bc0339a7441142a75b485/scripts/experimental_helper.sh#L130-L135
[14:36:21]
<rodinux[m]> if the manifest.json is replaced by manifest.toml... I am not sure the exeperimental_helper is also read if the app is not garradin but yet paheko...
[14:46:37]
<rodinux[m]> It seems to read $migration_process and then if [[ $migration_process -eq 1 ]]; then https://github.com/YunoHost-Apps/paheko_ynh/blob/534bb03f927c5301e69bc0339a7441142a75b485/scripts/upgrade#L95-L99
[14:49:57]
<rodinux[m]> but in the migtaion process, normally there is nothing to do https://github.com/YunoHost-Apps/paheko_ynh/blob/c8b5f4a19af86888891ac9af15200be34d5a240c/scripts/experimental_helper.sh#L82-L88
[14:59:00]
<rodinux[m]> perhaps it just need keep app=$YNH_APP_INSTANCE_NAME at the bottom of the script upgrade ??
[15:00:17]
<rodinux[m]> or is a stupid suggestion ?
[15:17:13]
<rodinux[m]> does the lines here have put a key somewhere with $final_path ? https://github.com/YunoHost-Apps/paheko_ynh/blob/534bb03f927c5301e69bc0339a7441142a75b485/scripts/upgrade#L66-L69
[15:20:52]
<rodinux[m]> > <@rodinux07:matrix.org> or is a stupid suggestion ?
well, yes it is not a solution...
[15:28:00]
<rodinux[m]> or the problem can be from these lines https://github.com/YunoHost-Apps/paheko_ynh/blob/534bb03f927c5301e69bc0339a7441142a75b485/scripts/upgrade#L40-L45
[15:44:20]
<rodinux[m]> strange that the source path is not found
[15:44:23]
<rodinux[m]> 2023-04-19 17:06:05,808: DEBUG - 487 ++ [[ phpversion =~ (unprotected|protected|skipped)_ ]]
2023-04-19 17:06:05,808: DEBUG - 487 ++ ynh_app_setting get paheko__2 phpversion
2023-04-19 17:06:05,866: DEBUG - 544 + phpversion=8.0
2023-04-19 17:06:05,866: DEBUG - 544 + ynh_print_info '--message=Declaring files to be backed up...'
2023-04-19 17:06:05,879: DEBUG - 557 + echo 'Declaring files to be backed up...'
2023-04-19 17:06:05,880: DEBUG - 557 + ynh_backup --src_path=
2023-04-19 17:06:05,881: DEBUG - 559 Declaring files to be backed up...
2023-04-19 17:06:05,914: DEBUG - 592 + dest_path=
2023-04-19 17:06:05,914: DEBUG - 593 + is_big=0
[15:45:21]
<rodinux[m]> 2023-04-19 17:06:05,914: DEBUG - 593 + is_big=0
2023-04-19 17:06:05,914: DEBUG - 593 + not_mandatory=0
2023-04-19 17:06:05,914: DEBUG - 593 + BACKUP_CORE_ONLY=1
2023-04-19 17:06:05,915: DEBUG - 593 + test -n paheko__2
2023-04-19 17:06:05,915: DEBUG - 595 ++ ynh_app_setting_get --app=paheko__2 --key=do_not_backup_data
2023-04-19 17:06:05,916: DEBUG - 596 ++ local _globalapp=paheko__2
2023-04-19 17:06:05,954: DEBUG - 633 ++ app=paheko__2
2023-04-19 17:06:05,954: DEBUG - 633 ++ [[ do_not_backup_data =~ (unprotected|protected|skipped)_ ]]
2023-04-19 17:06:05,954: DEBUG - 633 ++ ynh_app_setting get paheko__2 do_not_backup_data
2023-04-19 17:06:06,012: DEBUG - 690 + do_not_backup_data=
2023-04-19 17:06:06,012: DEBUG - 690 + '[' '!' -e '' ']'
2023-04-19 17:06:06,012: DEBUG - 690 + ynh_print_warn '--message=Source path '\'''\'' does not exist'
2023-04-19 17:06:06,033: WARNING - 708 Source path '' does not exist
2023-04-19 17:06:06,035: DEBUG - 704 + ynh_print_log 'Source path '\'''\'' does not exist'
2023-04-19 17:06:06,035: DEBUG - 704 + echo -e 'Source path '\'''\'' does not exist'
2023-04-19 17:06:06,035: DEBUG - 704 + '[' 0 == 0 ']'
[15:58:04]
<rodinux[m]> eric_G: be carefull here https://github.com/YunoHost-Apps/paheko_ynh/blob/c8b5f4a19af86888891ac9af15200be34d5a240c/scripts/upgrade#L113-L114
[15:58:41]
<rodinux[m]> "../conf/....."
[15:59:35]
<rodinux[m]> nad here ynh_add_config --template="../cong/config.local.user.php" --destination="$install_dir/config.local.user.php"
[16:00:01]
<rodinux[m]> and just before https://github.com/YunoHost-Apps/paheko_ynh/blob/c8b5f4a19af86888891ac9af15200be34d5a240c/scripts/upgrade#L110
[16:01:07]
<rodinux[m]> but I don't think it will resolve this probleme with source path...
[16:16:13]
<rodinux[m]> what I nderstand, this line at the beginning will do a backup before upgrade where the key $final_path is stored rather than $install_dir ynh_backup_before_upgrade
[16:35:12]
<rodinux[m]> I see this on the exeperimental.helper.sh # The app settings.yml will be modified as follows:
# - finalpath will be changed according to the new name (but only if the existing $final_path contains the old app name)
[16:37:13]
<rodinux[m]> Perhaps I need erase all the migrations scripts from garradin to make the v2 compatible...
[16:42:22]
<rodinux[m]> 😢
[18:13:45]
<rodinux[m]> Or perhaps I can keep a branch for the migration from garradin with the actual master code and try if removing the migration scripts works ?
[18:37:31]
<rodinux[m]> Ok v2 works if I remove the migration scripts. So can I keep first an old configuration on a branch to let users migrate from garradin if there is still some users and then push the v2 on the master branch ?
[18:42:27]
<eric_G> there is no obligation to migrate to v2 I guess
[19:12:48]
<rodinux[m]> Ok so I can also keep like this. I just now understand that the scripts for migrations don't work for v2...
[19:54:04]
<Yunohost Git/Infra notifications> reactivate_actions_summary.txt
[19:54:04]
<Yunohost Git/Infra notifications> 0 auto-updater actions have just been re-activated.
Log enclosed (#=n/a, -=failed, +=success)
[19:56:33]
<tituspijean[m]> https://aria.im/_matrix/media/v1/download/pijean.ovh/987be95d07651f0d681a69d41bc21588195da3481133a40fa88bbe732f5c7c36
[22:23:08]
<tituspijean[m]> FYI the dev CI was not updated to v11.1.18, most likely due to its self-upgrade failing due to git complaning: `fatal: detected dubious ownership in repository at '/var/www/yunorunner'`. I've ran `git config --global --add safe.directory /var/www/yunorunner`.
Hopefully it works tonight 🙂