[04:24:58]
<Yunohost Git/Infra notifications> App qr rises from level 2 to 8 in job [#16283](https://ci-apps.yunohost.org/ci/job/16283) !
[09:06:20]
<Yunohost Git/Infra notifications> App getsimple rises from level 7 to 8 in job [#16291](https://ci-apps.yunohost.org/ci/job/16291) !
[09:15:39]
<Yunohost Git/Infra notifications> App internetarchive failed all tests in job [#16292](https://ci-apps.yunohost.org/ci/job/16292) :(
[09:30:13]
<Yunohost Git/Infra notifications> App isso rises from level 7 to 8 in job [#16293](https://ci-apps.yunohost.org/ci/job/16293) !
[09:47:49]
<Yunohost Git/Infra notifications> App jackett stays at level 1 in job [#16294](https://ci-apps.yunohost.org/ci/job/16294)
[09:55:19]
<Yunohost Git/Infra notifications> [apps] @ericgaspar pushed 1 commit to master: qr is 8 ([d7a3cb3c](https://github.com/YunoHost/apps/commit/d7a3cb3c71b00320bd8ef6125b44bdd4fcb1f4e1))
[12:58:42]
<Yunohost Git/Infra notifications> App radicale failed all tests in job [#16299](https://ci-apps.yunohost.org/ci/job/16299) :(
[16:24:12]
<Salamandar> Hello, looks like the apps dashboard doesn't provide maintainer information anymore ? :(
[16:24:36]
<Salamandar> I liked to use https://dash.yunohost.org/app_maintainer_dash/salamandar to check my apps but it doesn't work anymore :(
[16:38:07]
<Aleks (he/him/il/lui)> ah yes
[16:38:12]
<Aleks (he/him/il/lui)> we were discussing this the other day
[16:38:33]
<Aleks (he/him/il/lui)> i was not aware people actually used it haha and i kinda stopped evolving tartiflette
[16:38:37]
<Aleks (he/him/il/lui)> but i can dig it and fixit
[16:44:06]
<tituspijean[m]> I too had a look once in a while 😅
[16:45:32]
<Salamandar> Ah :D
[16:45:47]
<Salamandar> I mean if there's another way to do that it's Ok
[16:53:43]
<eric_G> #MeToo
[17:29:52]
<Yunohost Git/Infra notifications> [apps] @Salamandar opened [pull request #1685](https://github.com/YunoHost/apps/pull/1685): Add requires-its-own-domain antifeature.
[19:08:49]
<Yunohost Git/Infra notifications> App pixelfed rises from level 4 to 8 in job [#16305](https://ci-apps.yunohost.org/ci/job/16305) !
[19:19:05]
<Yunohost Git/Infra notifications> App akkoma failed all tests in job [#16306](https://ci-apps.yunohost.org/ci/job/16306) :(
[19:45:03]
<Salamandar> Hey, could I please get push permissions to ihatemoney_ynh please ? I wanted to migrate to v2
[19:49:15]
<tituspijean[m]> Salamandar what's your github username again?
[19:49:31]
<Salamandar> Salamandar :D
[19:53:59]
<tituspijean[m]> 🤦 I couldn't find you
[19:54:31]
<tituspijean[m]> done!
[20:03:26]
<Yunohost Git/Infra notifications> [apps] @tituspijean [commented](https://github.com/YunoHost/apps/pull/1685#issuecomment-1585792588) on [issue #1685](https://github.com/YunoHost/apps/pull/1685) Add requires-its-own-domain antifeature.: Mmmmh why not :D
[20:03:27]
<Yunohost Git/Infra notifications> [apps] @tituspijean approved [pull request #1685](https://github.com/YunoHost/apps/pull/1685#pullrequestreview-1473488258) Add requires-its-own-domain antifeature.
[20:07:26]
<Salamandar> thanks :D
[20:14:30]
<Yunohost Git/Infra notifications> [apps] @Tagadda [commented](https://github.com/YunoHost/apps/pull/1685#issuecomment-1585797013) on [issue #1685](https://github.com/YunoHost/apps/pull/1685) Add requires-its-own-domain antifeature.: Im not sure that an anti-feature is the best fit for this situation. This information is already given by full_domain...
[20:16:40]
<Yunohost Git/Infra notifications> [apps] @tituspijean [commented](https://github.com/YunoHost/apps/pull/1685#issuecomment-1585797741) on [issue #1685](https://github.com/YunoHost/apps/pull/1685) Add requires-its-own-domain antifeature.: > I think a better way to address this issue could be allowing to add a new domain during an app install. Oh yesssss
[20:17:51]
<Yunohost Git/Infra notifications> [apps] @tituspijean [commented](https://github.com/YunoHost/apps/pull/1685#issuecomment-1585797741) on [issue #1685](https://github.com/YunoHost/apps/pull/1685) Add requires-its-own-domain antifeature.: > This information is already given by full_domain Damn I forgot about that. > I think a better way to address this is...
[20:23:45]
<Yunohost Git/Infra notifications> [apps] @alexAubin [commented](https://github.com/YunoHost/apps/pull/1685#issuecomment-1585805063) on [issue #1685](https://github.com/YunoHost/apps/pull/1685) Add requires-its-own-domain antifeature.: > This information is already given by full_domain in manifest.toml (example https://github.com/YunoHost-Apps/owncast_yn...
[20:24:37]
<Yunohost Git/Infra notifications> [apps] @alexAubin [commented](https://github.com/YunoHost/apps/pull/1685#issuecomment-1585805063) on [issue #1685](https://github.com/YunoHost/apps/pull/1685) Add requires-its-own-domain antifeature.: > This information is already given by full_domain in manifest.toml (example https://github.com/YunoHost-Apps/owncast_yn...
[20:25:43]
<Yunohost Git/Infra notifications> [apps] @Salamandar [commented](https://github.com/YunoHost/apps/pull/1685#issuecomment-1585805529) on [issue #1685](https://github.com/YunoHost/apps/pull/1685) Add requires-its-own-domain antifeature.: > This information is already given by full_domain in manifest.toml Oh well thats missing in the doc :(
[20:26:58]
<Yunohost Git/Infra notifications> [apps] @Salamandar [commented](https://github.com/YunoHost/apps/pull/1685#issuecomment-1585805757) on [issue #1685](https://github.com/YunoHost/apps/pull/1685) Add requires-its-own-domain antifeature.: > But maybe the current UX is not great in the webadmin ? Like its only checked after clicking the "install" button ? ...
[20:30:32]
<Yunohost Git/Infra notifications> App getsimple rises from level 7 to 8 in job [#16308](https://ci-apps.yunohost.org/ci/job/16308) !
[20:38:53]
<Yunohost Git/Infra notifications> [my_webapp_ynh] @Tagadda pushed 1 commit to enh-postgresql: Update manifest.toml ([1d83be3e](https://github.com/YunoHost-Apps/my_webapp_ynh/commit/1d83be3e56aba29087fe04de391183f7be7c6b8b))
[20:39:03]
<Yunohost Git/Infra notifications> [my_webapp_ynh] @Tagadda [commented](https://github.com/YunoHost-Apps/my_webapp_ynh/pull/118#issuecomment-1585811653) on [issue #118](https://github.com/YunoHost-Apps/my_webapp_ynh/pull/118) Implement postgresql database choice: testme
[20:39:03]
<Yunohost Git/Infra notifications> [my_webapp_ynh] @yunohost-bot [commented](https://github.com/YunoHost-Apps/my_webapp_ynh/pull/118#issuecomment-1585811657) on [issue #118](https://github.com/YunoHost-Apps/my_webapp_ynh/pull/118) Implement postgresql database choice: :rocket:
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-dev.yunohost.org/ci/api/job/7688/badge)](htt...
[20:53:49]
<Yunohost Git/Infra notifications> [apps] @Tagadda [commented](https://github.com/YunoHost/apps/pull/1685#issuecomment-1585813927) on [issue #1685](https://github.com/YunoHost/apps/pull/1685) Add requires-its-own-domain antifeature.: > > But maybe the current UX is not great in the webadmin ? Like its only checked after clicking the "install" button ?...
[21:14:55]
<Yunohost Git/Infra notifications> [apps] @Salamandar [commented](https://github.com/YunoHost/apps/pull/1685#issuecomment-1585817502) on [issue #1685](https://github.com/YunoHost/apps/pull/1685) Add requires-its-own-domain antifeature.: Yes, agreed.
[21:15:39]
<Tag> zblerg, somehow 3 tests are running on the same lxc container :o
the first one looks okay but the other two don't ^^
https://ci-apps-dev.yunohost.org/ci/job/7687
https://ci-apps-dev.yunohost.org/ci/job/7663
https://ci-apps-dev.yunohost.org/ci/job/7662
[21:18:27]
<Aleks (he/him/il/lui)> uuuh wtf
[21:18:29]
<Aleks (he/him/il/lui)> were they stuck or something ? the start date is yesterday o_O
[21:20:14]
<Tag> ah you're right
[21:20:14]
<Tag> and the logs says that they are completed but yunorunner don't think so...
[21:20:15]
<Aleks (he/him/il/lui)> hmm i think that's because it miserably crashed so it didn't produce any proper result.json or something
[21:25:57]
<Tag> okay looks like the manifest.toml was missing some vars in integration (ldap. disk...) and the linter miserably crashed
[21:34:50]
<Salamandar> > <@tag:lostpod.me> okay looks like the manifest.toml was missing some vars in integration (ldap. disk...) and the linter miserably crashed
yeah that's my fault
[21:34:50]
<Salamandar> didn't think those variables were mandatory
[21:35:52]
<Tag> Well I guess the linter should throw an error (not miserably crash) when these fields are missing, so that's not totally your fault :p
[21:41:40]
<Tag> I don't understand this crash... there's already a check in package_linter.py
[21:41:46]
<Tag> line 1701
[21:43:50]
<Aleks (he/him/il/lui)> what app / test are we talking about ?
[21:43:50]
<Aleks (he/him/il/lui)> ah
[21:46:39]
<Aleks (he/him/il/lui)> hmyeah the code checks if the value is acceptable, but it doesn't quite handle well the case where the key is not there at all
[21:47:06]
<Aleks (he/him/il/lui)> let's replace the `[key]` with `.get(key)`
[21:48:05]
<Aleks (he/him/il/lui)> though i think the logic was also "if some of these key don't exist it's better to miserably crash than only report an Error"
[21:48:06]
<Aleks (he/him/il/lui)> because e.g. if the `yunohost` minimum requirement is missing then the core will explode anyway
[21:48:53]
<Aleks (he/him/il/lui)> ah in fact there's already
```python
if key not in self.manifest.get("integration", {}):
yield Error(f"Missing key in the integration section: {key}")
```
[21:49:04]
<Aleks (he/him/il/lui)> but no `continue`
[21:50:59]
<Yunohost Git/Infra notifications> [package_linter] @alexAubin pushed 1 commit to alexAubin-patch-1: manifest validation: missing continue when some key doesnt exist to try to prevent miserably crashing ([85dd7d4d](https://github.com/YunoHost/package_linter/commit/85dd7d4d2440ce4f7c86473c994216ebfacd277c))
[21:51:06]
<Yunohost Git/Infra notifications> [package_linter] @alexAubin opened [pull request #113](https://github.com/YunoHost/package_linter/pull/113): manifest validation: missing continue when some key doesnt exist to…
[21:51:09]
<Yunohost Git/Infra notifications> [package_linter] @alexAubin created new branch alexAubin-patch-1
[21:51:09]
<Tag> aaaah ok, it needs to continue!!
[21:51:11]
<Yunohost Git/Infra notifications> [package_linter] @alexAubin pushed 1 commit to master: manifest validation: missing continue when some key doesnt exist to try to prevent miserably crashing (#113) ([a640c914](https://github.com/YunoHost/package_linter/commit/a640c914dfa747675fd90902501b2a3f8076d51b))
[21:51:11]
<Yunohost Git/Infra notifications> [package_linter] @alexAubin deleted branch alexAubin-patch-1
[21:51:11]
<Yunohost Git/Infra notifications> [package_linter] @alexAubin merged [pull request #113](https://github.com/YunoHost/package_linter/pull/113): manifest validation: missing continue when some key doesnt exist to…
[22:01:39]
<Tag> that works! thanks Aleks (he/him/il/lui) :)