[06:23:50]
<Yunohost Git/Infra notifications> [package_check] @alexAubin pushed 1 commit to master: Dont check witness file for php anymore because its a mess for bookworm, and anyway those witness tests are kind of no... ([a40df5d7](https://github.com/YunoHost/package_check/commit/a40df5d73233c509edc8a0ebe08158080466540b))
[06:51:14]
<Yunohost Git/Infra notifications> Job [#16407](https://ci-apps.yunohost.org/ci/job/16407) for prosody failed miserably :(
[07:31:01]
<Yunohost Git/Infra notifications> [nextcloud_ynh] @Limezy [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/581#issuecomment-1590632819) on [issue #581](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/581) Packaging version 2 PostgreSQL: Will it cover the case when the database is already PostgreSQL ?
I had some issues in the past where I had to deactivate...
[07:33:12]
<Yunohost Git/Infra notifications> [nextcloud_ynh] @ericgaspar [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/581#issuecomment-1590636299) on [issue #581](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/581) Packaging version 2 PostgreSQL: I successfully upgraded to 27.0.0 from PostgreSQL version
[08:09:46]
<Yunohost Git/Infra notifications> [nextcloud_ynh] @lapineige [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/586#issuecomment-1590691669) on [issue #586](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/586) 27.0.0: Tested on an ARM server, works like a charm 🙂, and super quickly (as well as app updates).
[08:23:24]
<Yunohost Git/Infra notifications> [package_check] @alexAubin pushed 1 commit to master: And also ignore witness DB >_> ([7831c5fa](https://github.com/YunoHost/package_check/commit/7831c5fa1c0e92ea2174845f15989fcc6625bea8))
[08:36:31]
<Aleks (he/him/il/lui)> omg T_T
[08:36:32]
<Aleks (he/him/il/lui)> https://github.com/YunoHost-Apps/agendav_ynh/blob/master/scripts/_common.sh
[08:36:42]
<Aleks (he/him/il/lui)> this script uses `$YNH_DEFAULT_PHP_VERSION`
[08:36:52]
<Aleks (he/him/il/lui)> but because it's sourced before the official helpers
[08:37:00]
<Aleks (he/him/il/lui)> `set -eu` is not set and `$YNH_DEFAULT_PHP_VERSION` is not define
[08:37:04]
<Aleks (he/him/il/lui)> resulting in empty string
[08:37:19]
<Aleks (he/him/il/lui)> resulting in `php_dependencies='php-ctype php-curl php-mbstring php-mcrypt php-tokenizer php-xml php-xmlreader php-xmlwriter php-mysql'`
[08:37:46]
<Aleks (he/him/il/lui)> which may result in epic php mess because the version-agnostic packages may trigger a whole bunch of issues
[08:37:46]
<Aleks (he/him/il/lui)> :|
[08:38:19]
<Aleks (he/him/il/lui)> i don't understand how we missed this, it feels like many app do use such a syntax to declare php dependencies x_x
[08:38:24]
<Aleks (he/him/il/lui)> https://botsin.space/@scream
[08:46:07]
<Yunohost Git/Infra notifications> [nextcloud_ynh] @lapineige [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/586#issuecomment-1590752846) on [issue #586](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/586) 27.0.0: Same on x86 :)
[09:04:30]
<Yunohost Git/Infra notifications> Job [#16411](https://ci-apps.yunohost.org/ci/job/16411) for grr failed miserably :(
[09:26:26]
<Yunohost Git/Infra notifications> [nextcloud_ynh] @lapineige [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/586#issuecomment-1590832564) on [issue #586](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/586) 27.0.0: Same on a Raspberry Pi :) Sounds good :D
[10:27:20]
<lapineige> should it be something checked by package linter ?
[11:09:41]
<Aleks (he/him/il/lui)> yeah maybe :/ didnt have time to think more about this
[12:23:07]
<tituspijean[m]> > <@Alekswag:matrix.org> this script uses `$YNH_DEFAULT_PHP_VERSION`
We should never rely on that :/
[12:23:07]
<eric_G> For Bookstack, I'd like the user to choose between two standard/ldap authentication methods. Only the ldap method requires a password. Can I set conditions in the manifest (if standard chosen, ask for password else don't ask)?
[12:23:33]
<eric_G> * Only the standard method requires a password
[12:33:01]
<Yunohost Git/Infra notifications> [nextcloud_ynh] @orhtej2 [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/581#issuecomment-1591105415) on [issue #581](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/581) Packaging version 2 PostgreSQL: Funny story, restore after failed update to this branch fails to restore automatically: https://paste.yunohost.org/raw/u...
[12:37:59]
<Yunohost Git/Infra notifications> [nextcloud_ynh] @orhtej2 [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/581#issuecomment-1591112446) on [issue #581](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/581) Packaging version 2 PostgreSQL: Also, did I mention installing this version over master failed? :P https://paste.yunohost.org/raw/bukarohele
[12:42:03]
<Aleks (he/him/il/lui)> > <@ericg:matrix.org> For Bookstack, I'd like the user to choose between two standard/ldap authentication methods. Only the ldap method requires a password. Can I set conditions in the manifest (if standard chosen, ask for password else don't ask)?
eeh i think maybe yes
[12:42:03]
<eric_G> ready for testing 🫡
[12:42:03]
<Aleks (he/him/il/lui)> but i don't know if that was really tested
[12:42:03]
<Aleks (he/him/il/lui)> 😬
[12:42:03]
<Aleks (he/him/il/lui)> hmmm
[12:42:03]
<Aleks (he/him/il/lui)> @_@
[12:42:03]
<Aleks (he/him/il/lui)> > <@titus:pijean.ovh> We should never rely on that :/
https://paste.yunohost.org/raw/edeyoxesoy
[12:42:14]
<Aleks (he/him/il/lui)> meh there's no example of actual "visible" syntax in example_ynh ..
[12:42:59]
<Aleks (he/him/il/lui)> should be something like this https://github.com/YunoHost-Apps/vpnclient_ynh/blob/master/config_panel.toml#L96 (but for a manifest question)
[12:43:57]
<Aleks (he/him/il/lui)> dunno how your question is named exactly, but that could be something like `visible = "auth_method == 'ldap'"`
[12:53:28]
<eric_G> I am using this code: https://github.com/YunoHost-Apps/bookstack_ynh/blob/cb611a9f9ac92cd041a5e2462ec29734ba0229e5/manifest.toml#L48-L52
[12:54:08]
<eric_G> when I install with ldap, I get this error:
```
Info: Installing bookstack...
Info: Provisionning sources...
Info: Provisionning system_user...
Info: Provisionning install_dir...
Info: Provisionning permissions...
Info: Provisionning apt...
Info: Provisionning database...
Info: The operation 'Install the 'bookstack' app' could not be completed. Please share the full log of this operation using the command 'yunohost log share 20230614-125208-app_install-bookstack' to get help
Traceback (most recent call last):
File "/usr/bin/yunohost", line 77, in <module>
yunohost.cli(
File "/usr/lib/python3/dist-packages/yunohost/__init__.py", line 41, in cli
ret = moulinette.cli(
File "/usr/lib/python3/dist-packages/moulinette/__init__.py", line 111, in cli
Cli(
File "/usr/lib/python3/dist-packages/moulinette/interfaces/cli.py", line 507, in run
ret = self.actionsmap.process(args, timeout=timeout)
File "/usr/lib/python3/dist-packages/moulinette/actionsmap.py", line 584, in process
return func(**arguments)
File "/usr/lib/python3/dist-packages/yunohost/log.py", line 410, in func_wrapper
result = func(*args, **kwargs)
File "/usr/lib/python3/dist-packages/yunohost/app.py", line 1212, in app_install
del env_dict_for_logging[f"YNH_APP_ARG_{question.name.upper()}"]
KeyError: 'YNH_APP_ARG_PASSWORD'
```
[12:54:23]
<eric_G> https://paste.yunohost.org/raw/wuxubilosa
[12:55:38]
<eric_G> When using standard as auth, the installation is successful
[13:18:33]
<Yunohost Git/Infra notifications> App librephotos failed all tests in job [#16419](https://ci-apps.yunohost.org/ci/job/16419) :(
[13:42:10]
<Aleks (he/him/il/lui)> > <@ericg:matrix.org> when I install with ldap, I get this error:
> ```
> Info: Installing bookstack...
> Info: Provisionning sources...
> Info: Provisionning system_user...
> Info: Provisionning install_dir...
> Info: Provisionning permissions...
> Info: Provisionning apt...
> Info: Provisionning database...
> Info: The operation 'Install the 'bookstack' app' could not be completed. Please share the full log of this operation using the command 'yunohost log share 20230614-125208-app_install-bookstack' to get help
> Traceback (most recent call last):
> File "/usr/bin/yunohost", line 77, in <module>
> yunohost.cli(
> File "/usr/lib/python3/dist-packages/yunohost/__init__.py", line 41, in cli
> ret = moulinette.cli(
> File "/usr/lib/python3/dist-packages/moulinette/__init__.py", line 111, in cli
> Cli(
> File "/usr/lib/python3/dist-packages/moulinette/interfaces/cli.py", line 507, in run
> ret = self.actionsmap.process(args, timeout=timeout)
> File "/usr/lib/python3/dist-packages/moulinette/actionsmap.py", line 584, in process
> return func(**arguments)
> File "/usr/lib/python3/dist-packages/yunohost/log.py", line 410, in func_wrapper
> result = func(*args, **kwargs)
> File "/usr/lib/python3/dist-packages/yunohost/app.py", line 1212, in app_install
> del env_dict_for_logging[f"YNH_APP_ARG_{question.name.upper()}"]
> KeyError: 'YNH_APP_ARG_PASSWORD'
>
> ```
ah 🤔
[13:42:22]
<Aleks (he/him/il/lui)> hmm that sounds like an easy bug to fix if that's the only issue
[13:42:36]
<Aleks (he/him/il/lui)> are you running this on your local machine ?
[13:42:57]
<eric_G> > <@Alekswag:matrix.org> are you running this on your local machine ?
no
[13:43:01]
<Aleks (he/him/il/lui)> 😬
[13:43:24]
<eric_G> 🫠
[13:43:46]
<Aleks (he/him/il/lui)> hmkay let me try to fix the bug and rebuild the image
[13:44:27]
<Aleks (he/him/il/lui)> though to have it included in the CI it has to be pushed on stabl
[13:44:28]
<Aleks (he/him/il/lui)> meh
[13:45:26]
<eric_G> 11.1.21.3.1
[15:11:53]
<Aleks (he/him/il/lui)> eric_G: it should be fixed on the CI now
[17:03:25]
<tituspijean[m]> > <@Alekswag:matrix.org> https://paste.yunohost.org/raw/edeyoxesoy
I know! 😅 One packager got in a "Apply example_ynh" frenzy at some point and we let that default php version variable enter plenty of apps. It may kill plenty of them when upgrading to new major Debian.
[17:04:08]
<Aleks (he/him/il/lui)> well at least right now they basically won't pass the bookworm test unless we apply some magic T_T
[17:04:30]
<Aleks (he/him/il/lui)> but the real issue is, the more time passes, the more fuzzy the notion of "default debian version for php" becomes, because nowadays we include Sury
[17:04:52]
<Aleks (he/him/il/lui)> and Sury does provide php packages which corresponds to even lower version of debian's default
[17:05:24]
<Aleks (he/him/il/lui)> and even if you pick the "debian's php version" it will still install the packages from sury anyway
[18:16:39]
<Yunohost Git/Infra notifications> [nextcloud_ynh] @JoshuaPettus [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/582#issuecomment-1591768247) on [issue #582](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/582) Impossible to delete files and folders after the latest update: For those that see this, its actually a regression in NC Server 26+, not Music. There is a pull request being worked o...
[18:16:56]
<Yunohost Git/Infra notifications> [nextcloud_ynh] @JoshuaPettus [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/582#issuecomment-1591768247) on [issue #582](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/582) Impossible to delete files and folders after the latest update: For those that see this, its actually a regression in NC Server 25+, not Music. There is a pull request being worked o...
[19:07:53]
<Yunohost Git/Infra notifications> [nextcloud_ynh] @tio-trom [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/582#issuecomment-1591832075) on [issue #582](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/582) Impossible to delete files and folders after the latest update: In the meantime if any maintainer here wants they can fix it for the YNH package https://github.com/owncloud/music/issue...
[19:07:57]
<Yunohost Git/Infra notifications> [nextcloud_ynh] @tio-trom reopened [issue #582](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/582): Impossible to delete files and folders after the latest update
[19:18:27]
<Yunohost Git/Infra notifications> [nextcloud_ynh] @tio-trom [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/582#issuecomment-1591832075) on [issue #582](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/582) Impossible to delete files and folders after the latest update: In the meantime if any maintainer here wants they can fix it for the YNH package https://github.com/owncloud/music/issue...