[00:22:05]
<Yunohost Git/Infra notifications> App castopod goes down from level 8 to 2 in job [#21665](https://ci-apps.yunohost.org/ci/job/21665)
[00:25:36]
<Mateusz Szymański> > <@yunohostinfra:matrix.org> App castopod goes down from level 8 to 2 in job [#21665](https://ci-apps.yunohost.org/ci/job/21665)
this is what you get for assuming this one more fix won't hurt x_x
fixed: https://github.com/YunoHost-Apps/castopod_ynh/pull/129
[01:15:23]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot pushed 1 commit to add-to-wishlist-opensign: Add OpenSign to wishlist ([f04e0550](https://github.com/YunoHost/apps/commit/f04e05500ba6041d26790732a1e8931b2cfe0fef))
[01:15:24]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot opened [pull request #1933](https://github.com/YunoHost/apps/pull/1933): Add OpenSign to wishlist
[01:15:24]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot created new branch add-to-wishlist-opensign
[03:49:14]
<Yunohost Git/Infra notifications> App retroarch goes down from level 8 to 2 in job [#21674](https://ci-apps.yunohost.org/ci/job/21674)
[05:50:16]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot pushed 1 commit to add-to-wishlist-stirling-pdf: Add Stirling PDF to wishlist ([eeefbd17](https://github.com/YunoHost/apps/commit/eeefbd17b830b613f13486bbe291b0f458aa3779))
[05:50:16]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot created new branch add-to-wishlist-stirling-pdf
[05:50:17]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot opened [pull request #1934](https://github.com/YunoHost/apps/pull/1934): Add Stirling PDF to wishlist
[12:16:54]
<lapineige> If someone is willing to, I need some help to debug and fix Peertube installs… I don't get it
https://github.com/YunoHost-Apps/peertube_ynh/pull/397
[12:37:30]
<Aleks (he/him/il/lui)> `"message": "relation \"plugin\" does not exist",`
[12:37:40]
<Aleks (he/him/il/lui)> meh peertube seems to fail a lot these days x_x
[12:41:42]
<Mateusz Szymański> > <@Alekswag:matrix.org> meh peertube seems to fail a lot these days x_x
it's LDAP plugin breaking all over again, I was trying to figure out if the old plugin is compatible with 6.x and came empty handed
[12:41:46]
<Mateusz Szymański> ¯\_(ツ)_/¯
[12:42:17]
<Mateusz Szymański> it was written by original author so one would assume it works but here's practice :P
[12:43:54]
<Mateusz Szymański> also that string never appears in plugin code so it's as if the installer itself breaks BUT while reading through install docs we should not use CLI (there are install issues reported due to CLI interacting with DB that's being modified by live instance) and switch to using REST API for plugin management, but that brings the problem of awaiting for the service to become responsive so...
[12:50:19]
<lapineige> > <@orhtej2:matrix.org> it's LDAP plugin breaking all over again, I was trying to figure out if the old plugin is compatible with 6.x and came empty handed
It's not working with current version eithier
[12:51:00]
<lapineige> Should I try to report this upstream ?
[12:51:53]
<Mateusz Szymański> > Should I try to report this upstream ?
sure, why not, I remember Chocobozzz occasionally stopping by peertube_ynh to help
[12:55:47]
<lapineige> Do you think it would be easier to debug it by installing the package without the plugin, and installing it afterwards ?
[12:57:39]
<Mateusz Szymański> I think YNH install process is inherently broken now due to aftermentioned usage of CLI - it depends on service to initialize DB well enough for CLI to work and that's a problem
[12:57:50]
<Mateusz Szymański> I think we need a deeper rewrite to use REST API
[13:01:47]
<lapineige> Done here : https://github.com/Chocobozzz/PeerTube/issues/6139
[13:03:17]
<Mateusz Szymański> wonder if this should go here: https://framagit.org/framasoft/peertube/official-plugins/-/tree/master/peertube-plugin-auth-ldap
but gitverse fragmentation is getting out of hand
[13:32:41]
<Yunohost Git/Infra notifications> App lemmy rises from level 1 to 8 in job [#21684](https://ci-apps.yunohost.org/ci/job/21684) !
[13:52:16]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot opened [pull request #1935](https://github.com/YunoHost/apps/pull/1935): Add GotHub to wishlist
[13:52:16]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot created new branch add-to-wishlist-gothub
[13:52:16]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot pushed 1 commit to add-to-wishlist-gothub: Add GotHub to wishlist ([1c0dc1c7](https://github.com/YunoHost/apps/commit/1c0dc1c72d8e5da140cf07d5f92fcff1fc6ce4a9))
[13:59:08]
<Aleks (he/him/il/lui)> :|
[13:59:18]
<Aleks (he/him/il/lui)> #MakeAMoreAccessibleWishlistTheySaid
[13:59:22]
<Aleks (he/him/il/lui)> #ItWillBeGreat
[14:21:53]
<Yunohost Git/Infra notifications> [apps] @tituspijean edited [pull request #1934](https://github.com/YunoHost/apps/pull/1934): Add Stirling PDF to wishlist
[14:21:53]
<Yunohost Git/Infra notifications> [apps] @tituspijean edited [pull request #1934](https://github.com/YunoHost/apps/pull/1934): Add Stirling PDF to wishlist
[14:22:30]
<Yunohost Git/Infra notifications> [apps] @alexAubin pushed 28 commits to graveyard_and_drafts ([06605a2d050a...1a8a5d2186f6](https://github.com/YunoHost/apps/compare/06605a2d050a...1a8a5d2186f6))
[14:22:35]
<Yunohost Git/Infra notifications> [apps/graveyard_and_drafts] Merge pull request #1928 from YunoHost/update_app_levels Update app levels according to CI results - Alexandre Aubin
[14:22:41]
<Yunohost Git/Infra notifications> [apps/graveyard_and_drafts] Flag pagure as notworking, level 0 since april - Alexandre Aubin
[14:22:41]
<Yunohost Git/Infra notifications> [apps] @alexAubin pushed 7 commits to master ([a177b2f2c3db...ec6f8f44bbcc](https://github.com/YunoHost/apps/compare/a177b2f2c3db...ec6f8f44bbcc))
[14:22:41]
<Yunohost Git/Infra notifications> [apps] @alexAubin merged [pull request #1920](https://github.com/YunoHost/apps/pull/1920): Graveyard and drafts
[14:22:45]
<Yunohost Git/Infra notifications> [apps/master] Add description for graveyard.toml in README.md - Alexandre Aubin
[14:22:48]
<Yunohost Git/Infra notifications> [apps] @alexAubin deleted branch graveyard_and_drafts
[14:22:49]
<Yunohost Git/Infra notifications> [apps/master] Merge branch master into graveyard_and_drafts - Alexandre Aubin
[14:24:10]
<Yunohost Git/Infra notifications> [apps] @alexAubin pushed 208 commits to add-to-wishlist-digishare ([675188f6d31d...de4e6edecb21](https://github.com/YunoHost/apps/compare/675188f6d31d...de4e6edecb21))
[14:24:16]
<Yunohost Git/Infra notifications> [apps] @alexAubin pushed 3 commits to master ([ec6f8f44bbcc...22af026aeaff](https://github.com/YunoHost/apps/compare/ec6f8f44bbcc...22af026aeaff))
[14:24:17]
<Yunohost Git/Infra notifications> [apps] @alexAubin merged [pull request #1844](https://github.com/YunoHost/apps/pull/1844): Add DIGISHARE to wishlist
[14:24:18]
<Yunohost Git/Infra notifications> [apps] @alexAubin deleted branch add-to-wishlist-digishare
[14:24:37]
<Yunohost Git/Infra notifications> [apps] @alexAubin pushed 2 commits to master ([22af026aeaff...9434fb1ee523](https://github.com/YunoHost/apps/compare/22af026aeaff...9434fb1ee523))
[14:24:37]
<Yunohost Git/Infra notifications> [apps] @alexAubin merged [pull request #1906](https://github.com/YunoHost/apps/pull/1906): Add Zotero to wishlist
[14:24:41]
<Yunohost Git/Infra notifications> [apps/master] Add Zotero to wishlist - yunohost-bot
[14:24:46]
<Yunohost Git/Infra notifications> [apps/master] Merge pull request #1906 from YunoHost/add-to-wishlist-zotero Add Zotero to wishlist - Alexandre Aubin
[14:24:49]
<Yunohost Git/Infra notifications> [apps] @alexAubin deleted branch add-to-wishlist-zotero
[14:24:50]
<Yunohost Git/Infra notifications> [apps] @tituspijean [commented](https://github.com/YunoHost/apps/pull/1934#discussion_r1436481400) on pull request #1934 Add Stirling PDF to wishlist: suggestion description = "Edit, compress, sign, OCR and other various operations on PDF files"
[14:25:14]
<Yunohost Git/Infra notifications> [apps] @tituspijean pushed 1 commit to add-to-wishlist-stirling-pdf: Enhance stirling-pdf description ([9914328f](https://github.com/YunoHost/apps/commit/9914328f9071b06523c69530fbd1c2a5909f38d7))
[14:25:27]
<Yunohost Git/Infra notifications> [apps] @tituspijean approved [pull request #1934](https://github.com/YunoHost/apps/pull/1934#pullrequestreview-1796399799) Add Stirling PDF to wishlist
[14:26:02]
<Yunohost Git/Infra notifications> [apps] @alexAubin closed [pull request #1875](https://github.com/YunoHost/apps/pull/1875): Add Affine to wishlist
[14:26:02]
<Yunohost Git/Infra notifications> [apps] @alexAubin [commented](https://github.com/YunoHost/apps/pull/1875#issuecomment-1869580443) on [issue #1875](https://github.com/YunoHost/apps/pull/1875) Add Affine to wishlist: Closing because the license aint clear and that sounds like a big huge framework thing that does everything and may be ...
[14:26:04]
<Yunohost Git/Infra notifications> [apps] @tituspijean pushed 3 commits to master ([9434fb1ee523...c13ff20df164](https://github.com/YunoHost/apps/compare/9434fb1ee523...c13ff20df164))
[14:26:04]
<Yunohost Git/Infra notifications> [apps] @tituspijean merged [pull request #1934](https://github.com/YunoHost/apps/pull/1934): Add Stirling PDF to wishlist
[14:26:08]
<Yunohost Git/Infra notifications> [apps] @alexAubin deleted branch add-to-wishlist-affine
[14:26:08]
<Yunohost Git/Infra notifications> [apps] @tituspijean deleted branch add-to-wishlist-stirling-pdf
[14:26:10]
<Yunohost Git/Infra notifications> [apps/master] Add Stirling PDF to wishlist - yunohost-bot
[14:26:40]
<Aleks (he/him/il/lui)> https://github.com/YunoHost/apps/pull/1913 "Open-source phishing framework", srsly, ~_~
[14:27:40]
<Yunohost Git/Infra notifications> [apps] @tituspijean [commented](https://github.com/YunoHost/apps/pull/1933#discussion_r1436482718) on pull request #1933 Add OpenSign to wishlist: suggestion description = "DocuSign alternative, for signing and annotating PDF files"
[14:27:54]
<Yunohost Git/Infra notifications> [apps] @tituspijean pushed 1 commit to add-to-wishlist-opensign: Enhance OpenSign description ([4dbe2fbe](https://github.com/YunoHost/apps/commit/4dbe2fbeeb7ba5e9d7adc59dbbf3c4818e9b2a40))
[14:28:43]
<Yunohost Git/Infra notifications> [apps] @alexAubin [commented](https://github.com/YunoHost/apps/pull/1931#discussion_r1436483156) on pull request #1931 Add opencast to wishlist: suggestion [opencast] draft = "https://github.com/YunoHost-Apps/opencast_ynh" name = "opencast"
[14:28:50]
<Yunohost Git/Infra notifications> [apps] @alexAubin pushed 1 commit to add-to-wishlist-opencast: Update wishlist.toml ([c0c2183d](https://github.com/YunoHost/apps/commit/c0c2183dfd6a76dd6a7b5836cd530105e925e768))
[14:29:15]
<Yunohost Git/Infra notifications> [apps] @alexAubin merged [pull request #1931](https://github.com/YunoHost/apps/pull/1931): Add opencast to wishlist
[14:29:16]
<Yunohost Git/Infra notifications> [apps] @alexAubin pushed 3 commits to master ([c13ff20df164...47380d6dc215](https://github.com/YunoHost/apps/compare/c13ff20df164...47380d6dc215))
[14:29:20]
<Yunohost Git/Infra notifications> [apps] @alexAubin deleted branch add-to-wishlist-opencast
[14:29:20]
<Yunohost Git/Infra notifications> [apps/master] Add opencast to wishlist - yunohost-bot
[14:29:24]
<Yunohost Git/Infra notifications> [apps/master] Update wishlist.toml - Alexandre Aubin
[14:30:17]
<Yunohost Git/Infra notifications> [apps] @tituspijean commented [pull request #1933](https://github.com/YunoHost/apps/pull/1933#pullrequestreview-1796402507) Add OpenSign to wishlist: I am unsure about packaging easiness on this one... https://github.com/OpenSignLabs/OpenSign/blob/staging/INSTALLATION.m...
[14:35:15]
<Yunohost Git/Infra notifications> [apps] @alexAubin merged [pull request #1932](https://github.com/YunoHost/apps/pull/1932): Add Frigate to wishlist
[14:35:17]
<Yunohost Git/Infra notifications> [apps] @alexAubin pushed 2 commits to master ([47380d6dc215...9dac790e4013](https://github.com/YunoHost/apps/compare/47380d6dc215...9dac790e4013))
[14:35:20]
<Yunohost Git/Infra notifications> [apps/master] Add Frigate to wishlist - yunohost-bot
[14:35:55]
<Yunohost Git/Infra notifications> [apps] @tituspijean [commented](https://github.com/YunoHost/apps/pull/1932#issuecomment-1869585865) on [issue #1932](https://github.com/YunoHost/apps/pull/1932) Add Frigate to wishlist: Docker only :/ https://docs.frigate.video/frigate/installation and https://github.com/blakeblackshear/frigate/blob/dev/M...
[14:37:02]
<Yunohost Git/Infra notifications> [apps] @alexAubin [commented](https://github.com/YunoHost/apps/pull/1929#issuecomment-1869586502) on [issue #1929](https://github.com/YunoHost/apps/pull/1929) Add Shinobi to wishlist: Not a free software .. https://gitlab.com/Shinobi-Systems/Shinobi/-/blob/master/COPYING.md
[14:37:05]
<Yunohost Git/Infra notifications> [apps] @alexAubin closed [pull request #1929](https://github.com/YunoHost/apps/pull/1929): Add Shinobi to wishlist
[14:38:03]
<Aleks (he/him/il/lui)> tituspijean: well yeah idk i'm dont know if we really want to look at "is it easy to install it" beyond "does it look plausible" x_x
[14:38:46]
<Yunohost Git/Infra notifications> [apps] @alexAubin deleted branch add-to-wishlist-shinobi
[14:39:23]
<Aleks (he/him/il/lui)> `docker buildx build` wtf is that
[14:39:38]
<tituspijean> > <@Alekswag:matrix.org> tituspijean: well yeah idk i'm dont know if we really want to look at "is it easy to install it" beyond "does it look plausible" x_x
yup hence my comment, I read the installation steps for the PDF one, and thought "I sure do not want to package that monstruosity"
[14:43:02]
<Yunohost Git/Infra notifications> [apps] @tituspijean [commented](https://github.com/YunoHost/apps/pull/1913#discussion_r1436488804) on pull request #1913 Add Gophish to wishlist: suggestion description = "Phishing toolkit for security awareness training and penetration testers."
[14:43:17]
<Yunohost Git/Infra notifications> [apps] @tituspijean edited a [comment](https://github.com/YunoHost/apps/pull/1913#discussion_r1436488804) on pull request #1913 Add Gophish to wishlist: suggestion description = "Phishing toolkit for security awareness training and penetration testers"
[14:43:49]
<Yunohost Git/Infra notifications> [apps] @tituspijean pushed 1 commit to add-to-wishlist-gophish: Enhance Gophish description ([5102b01a](https://github.com/YunoHost/apps/commit/5102b01a59dbfe27d7a9423a29b1cfffd7edaf22))
[14:54:43]
<lapineige> > <@orhtej2:matrix.org> wonder if this should go here: https://framagit.org/framasoft/peertube/official-plugins/-/tree/master/peertube-plugin-auth-ldap
> but gitverse fragmentation is getting out of hand
Yeah and the main gitlab repo seems to be a mirror of the github one
[15:35:04]
<Yunohost Git/Infra notifications> [apps] @ericgaspar deleted branch add-to-wishlist-frigate
[15:45:08]
<Tag> grmpf i guess i have to patch the nodejs helper to use yarn 4 :(
[15:49:06]
<orhtej2> > <@tag:lostpod.me> grmpf i guess i have to patch the nodejs helper to use yarn 4 :(
Wait something actually builds with yarn newer than 1.x?
[15:49:41]
<Tag> glitchsoc and probably next mastodon release
[15:50:58]
<Tag> ohno i'm dumb, yarn is not handle by the nodejs helper
[15:51:04]
<Tag> so everything is fine :)
[19:33:09]
<Yunohost Git/Infra notifications> App osada failed all tests in job [#21694](https://ci-apps.yunohost.org/ci/job/21694) :(
[19:45:51]
<Émy - OniriCorpe> I'm facing a weird bug, where the $port (the 'main' port) is set to 443, so AGH tries to bind 443 at boot and fails
[19:45:52]
<Émy - OniriCorpe>
https://github.com/YunoHost-Apps/adguardhome_ynh/pull/154
[19:49:35]
<Yunohost Git/Infra notifications> App osada failed all tests in job [#21695](https://ci-apps.yunohost.org/ci/job/21695) :(
[19:49:50]
<Aleks (he/him/il/lui)> uuuh
[19:50:49]
<Aleks (he/him/il/lui)> is it really $port ? Or isn't it just that it wants to run DNS-over-HTTPS which indeed requires port 443 ?
[19:51:42]
<Émy - OniriCorpe> AdGuardHome[6139]: 2023/12/26 17:32:39.360985 [fatal] web: https: listen tcp 0.0.0.0:443: bind: address already in use
[19:51:49]
<Émy - OniriCorpe> AGH tries to listen on 443 to serve web
[19:51:54]
<Émy - OniriCorpe> instead of an internal port
[19:52:52]
<Aleks (he/him/il/lui)> isnt it because 443 is hardcoded here ? 😬 https://github.com/YunoHost-Apps/adguardhome_ynh/blob/6f551cf865d5cb57e085791ddf7ac2f80bf68519/conf/AdGuardHome.yaml#L78
[19:53:38]
<Émy - OniriCorpe> uuuh sigh
[19:55:16]
<Émy - OniriCorpe> and I don't know what to put here, that's unclear
[19:56:09]
<Émy - OniriCorpe> it was already there btw, I dont modified it https://github.com/YunoHost-Apps/adguardhome_ynh/blob/master/conf/AdGuardHome.yaml#L78
[19:58:14]
<Tag> that would be PORT\_DNS\_OVER\_HTTP
[19:58:26]
<Émy - OniriCorpe> https://aria.im/_matrix/media/v1/download/im.emelyne.eu/TIhpZDYqSlAregKIYqwadTrt
[19:58:34]
<Émy - OniriCorpe> I think just removing it should do the job
[19:58:50]
<Tag> 🤔
[19:59:34]
<Émy - OniriCorpe> > <@tag:lostpod.me> that would be __PORT_DNS_OVER_HTTP__
are you sure?
[19:59:38]
<Tag> Yep
[20:00:30]
<Émy - OniriCorpe> okay i'll try this
[20:00:31]
<Émy - OniriCorpe> ah
[20:00:36]
<Tag> huh I mean PORT
[20:00:36]
<Tag> euh non
[20:00:37]
<Émy - OniriCorpe> j p p
[20:00:37]
<Tag> le premier truc que j'ai dit
[20:00:42]
<Tag> mais après il faut bien l'utiliser quelque part dans le nginx.conf
[20:01:00]
<Tag> ici je pense https://github.com/YunoHost-Apps/adguardhome_ynh/blob/6f551cf865d5cb57e085791ddf7ac2f80bf68519/conf/nginx.conf#L30C50-L30C50
[20:01:37]
<Émy - OniriCorpe> yup
[20:04:20]
<Émy - OniriCorpe> also, each time I use '!testme' I delete my comment to avoid unnecessarily overloading the PR thread, maybe automating the deletion of these comments (if they only contain a '!testme' or equivalent) by the bot would be great
[20:06:28]
<Émy - OniriCorpe> > <@tag:lostpod.me> le premier truc que j'ai dit
too bad :'3 https://ci-apps-dev.yunohost.org/ci/job/12148
[20:07:15]
<Tag> faudrait essayer de l'installer et bricoler les ports à la main pour voir dans quel situation ça fonctionne
[20:07:25]
<Tag> (je rajoute ça sur ma never-ending todo list)
[20:08:13]
<Tag> and this would take place here https://github.com/YunoHost/yunorunner/blob/master/run.py#L1612
[20:08:52]
<Émy - OniriCorpe> > <@oniricorpe:im.emelyne.eu> also, each time I use '!testme' I delete my comment to avoid unnecessarily overloading the PR thread, maybe automating the deletion of these comments (if they only contain a '!testme' or equivalent) by the bot would be great
also AltText for bot images would be really appreciated
[20:08:55]
<Aleks (he/him/il/lui)> personally i just cancel/restart the older job
[20:09:06]
<Aleks (he/him/il/lui)> it will automatically pick the newest commit of the branch anyway
[20:09:22]
<Tag> sometimes we want to keep an old result :p
[20:09:38]
<Émy - OniriCorpe> > <@Alekswag:matrix.org> it will automatically pick the newest commit of the branch anyway
I know but this time I didn't :")
[20:09:46]
<Aleks (he/him/il/lui)> yeaah but i mean, when iterating quickly 😬
[20:10:03]
<Aleks (he/him/il/lui)> but yeah doesnt fix all the use case i guess
[20:10:52]
<Tag> yes! I agree. But deleting the !testme comment (if it only contains !testme and nothing else) would be a nice idea
[20:11:24]
<Aleks (he/him/il/lui)> > <@oniricorpe:im.emelyne.eu> also AltText for bot images would be really appreciated
yeaah i used the image trick because it allowed to create the reply and link to an image that would be created later, hence no need to have a callback that edits the comment ... but if we kept the comment ID and edited it later, we could just put the results in proper markdown instead
[20:25:46]
<Émy - OniriCorpe> AdGuardHome[6081]: 2023/12/26 20:13:11.135836 [error] parsing configuration file: validating tcp ports: duplicated values: [13120]
[20:25:47]
<Émy - OniriCorpe> awawawawa
[20:26:23]
<Émy - OniriCorpe> > <@Alekswag:matrix.org> yeaah i used the image trick because it allowed to create the reply and link to an image that would be created later, hence no need to have a callback that edits the comment ... but if we kept the comment ID and edited it later, we could just put the results in proper markdown instead
it would be really nice, alt texts are important
[20:27:14]
<Tag> > <@oniricorpe:im.emelyne.eu> AdGuardHome[6081]: 2023/12/26 20:13:11.135836 [error] parsing configuration file: validating tcp ports: duplicated values: [13120]
🤔 can you share the actual config file ?
[20:27:38]
<Émy - OniriCorpe> > <@tag:lostpod.me> 🤔 can you share the actual config file ?
no because it's generated by the script running on the CI
[20:27:45]
<Tag> :/
[20:27:45]
<Émy - OniriCorpe> I can't extract it
[20:28:18]
<Tag> well, running your own package_check will allow you to.... 🤐
[20:29:26]
<Émy - OniriCorpe> yes but on my proxmox it's reallyyyyyy slooowwwww to run
[20:29:50]
<Émy - OniriCorpe> and I'm running windows on my main PC
[20:30:41]
<Tag> > <@oniricorpe:im.emelyne.eu> and I'm running windows on my main PC
oh, you don't run LXD inside WSL yet ? 🙃
[20:30:45]
<Émy - OniriCorpe> but anyway, AGH certainly cries because 'bind_port:' and 'tls: port_https:' are the same
[20:31:14]
<Émy - OniriCorpe> > <@tag:lostpod.me> oh, you don't run LXD inside WSL yet ? 🙃
some times ago, at was buggy, maybe it's fixed now
[20:32:51]
<Tag> I was joking about it but it might be a solution ^^
[20:35:53]
<Émy - OniriCorpe> I'll try to put a totally deferent port value (so not the internal port for AGH, nor dns_over_http, dns_over_quic
[20:35:59]
<Émy - OniriCorpe> different*
[20:38:22]
<Émy - OniriCorpe> this PR is really hazardous :"3
[20:40:10]
<Émy - OniriCorpe> O M G it worked ahahah I didn't believe it at all :"3
[20:50:03]
<Émy - OniriCorpe> thanks @tag
[20:50:08]
<Émy - OniriCorpe> and @alek
[20:50:31]
<Émy - OniriCorpe> @[Aleks (he/him/il/lui)] @Tag (siggh enter does not autocomplete on fluffychat)
[21:18:44]
<Émy - OniriCorpe> is this correct? first time writing a 'config' script https://github.com/YunoHost-Apps/adguardhome_ynh/blob/c9c017af09178bd46f3da14fa77ac54b063d3ce5/scripts/config
[22:04:17]
<Émy - OniriCorpe> ERROR Config panel question 'dns_over_https' should be initialized with a value during install or upgrade.
[22:04:19]
<Émy - OniriCorpe>
but it is awawawa
[22:08:37]
<Aleks (he/him/il/lui)> i think i've seen the other day that settings are not auto-loaded during config script, you got to ynh_setting_get them é_è (but that doesnt seem to be the issue yet)
[22:10:45]
<Aleks (he/him/il/lui)> hmmm i'm confused
[22:15:22]
<Émy - OniriCorpe> https://aria.im/_matrix/media/v1/download/im.emelyne.eu/sXiFdmOsKrmuQXpeQDzMbcsz
[22:15:41]
<Émy - OniriCorpe> It was supposed to be a simple PR lmao
[22:17:03]
<Émy - OniriCorpe> > <@Alekswag:matrix.org> i think i've seen the other day that settings are not auto-loaded during config script, you got to ynh_setting_get them é_è (but that doesnt seem to be the issue yet)
i can try that anyway, right?
[22:18:01]
<Aleks (he/him/il/lui)> > <@oniricorpe:im.emelyne.eu> It was supposed to be a simple PR lmao
i was supposed to add letsencrypt support to YunoHost and then get back to regular life, hmmmm 7~8ish years ago
[22:18:20]
<Émy - OniriCorpe> but if i do a ynh_setting_get, does it get the var before the potential user modified choice in the panel or after?
[22:20:10]
<Aleks (he/him/il/lui)> it gets the var in the last state that it was saved, ie probably the install script, but yeah, there's some ambiguity about what is the real source of truth ... yet for complicated reason, you have to save it as a setting ... that's why the current status quo with config panel is a mess and there is https://github.com/YunoHost/issues/issues/1973 and https://github.com/YunoHost/yunohost/pull/1675 and i don't remember the status x_x
[22:20:42]
<Aleks (he/him/il/lui)> but yeah if you want to fetch the value from the file (which *is* the real truth) you could use ynh_read_var_from_file
[22:21:13]
<Aleks (he/him/il/lui)> ynh_read_var_in_file* : https://yunohost.org/fr/packaging_apps_helpers#ynh-read-var-in-file
[22:22:45]
<Émy - OniriCorpe> no, i would get the value the user wants (so the modified one in the config panel
[22:23:06]
<Émy - OniriCorpe> not the value already saved before the user modif
[22:24:02]
<Émy - OniriCorpe> so, my config script is for openning or closing ports if the user changes $dns_over_https from true to false (or false to true), so the user wants to activate or deactivate DoH/DoQ
[22:24:08]
<Aleks (he/him/il/lui)> ah yes
[22:25:10]
<Émy - OniriCorpe> if a user changes $dns_over_https from true to false, $dns_over_https does have to be false and the script closes the ports
[22:25:34]
<Émy - OniriCorpe> what a mess ahahahah
[22:26:03]
<Aleks (he/him/il/lui)> https://github.com/YunoHost/example_ynh/blob/master/scripts/config#L79
[22:26:18]
<Aleks (he/him/il/lui)> nevermind, $dns_over_https should exist and should correspond to the new value
[22:26:34]
<Aleks (he/him/il/lui)> i'm looking for the full log of the error you mentionned
[22:26:48]
<Émy - OniriCorpe> thanks a lot for your help
[22:27:49]
<Aleks (he/him/il/lui)> actually i think you should define a custom setter rather than `ynh_app_config_apply` though I don't really know the pro/cons ... but it using a custom setter is closer to what was the intended design
[22:27:58]
<Aleks (he/him/il/lui)> i.e. defining `set__dns_over_https()`
[22:28:12]
<Émy - OniriCorpe> hum yes
[22:30:39]
<Émy - OniriCorpe> does i need to remove the bind in the config_panel.toml?
[22:32:10]
<Émy - OniriCorpe> and i put my if condition in the set__dns_over_https() instead of the ynh_app_config_apply(), do I understand correctly?
[22:33:09]
<Aleks (he/him/il/lui)> yes but you keep the "bind" thing in config_panel.toml ... though maybe since you're defining a custom setter you may need to explicitly update the ynh setting value and/or the value in the file using ynh_write_var_in_file, i'm not sure
[22:33:36]
<Aleks (he/him/il/lui)> will try to install the app because i don't get why yunohost is throwing the error regarding the undefined setting
[22:34:02]
<Émy - OniriCorpe> yes it's really weird
[22:34:37]
<Aleks (he/him/il/lui)> i'm anticipating something really stupid like "it wants quote but there's no quote" or vice-versa
[22:34:58]
<Aleks (he/him/il/lui)> #computerz
[22:41:49]
<Émy - OniriCorpe> same 'dns_over_https' should be initialized with a value during install or upgrade with set__dns_over_https()
[22:41:54]
<Émy - OniriCorpe> https://ci-apps-dev.yunohost.org/ci/job/12151
[22:42:57]
<Aleks (he/him/il/lui)> i'm able to run `config get` when installing on my machine 😬
[22:43:08]
<Aleks (he/him/il/lui)> (but i'm on a bookworm dev env)
[22:44:11]
<Aleks (he/him/il/lui)> buut it shows false/no but the value inside the file is true 😬
[22:44:16]
<Aleks (he/him/il/lui)> (╯°□°）╯︵ ┻━┻
[22:44:41]
<Émy - OniriCorpe> computers were a mistake
[22:45:09]
<Aleks (he/him/il/lui)> ah but the bind statement was removed
[22:48:55]
<Émy - OniriCorpe> restored
[22:56:01]
<Aleks (he/him/il/lui)> confusion intensifies
[22:57:05]
<Aleks (he/him/il/lui)> ah i see
[22:59:26]
<Aleks (he/him/il/lui)> you need that line at the end : https://github.com/YunoHost/example_ynh/blob/master/scripts/config#L102C1-L102C22
[22:59:56]
<Aleks (he/him/il/lui)> also small typo in your config script (prices -> dns_over_https)
[23:01:34]
<Aleks (he/him/il/lui)> (added PR suggestions)
[23:07:36]
<Émy - OniriCorpe> yes
[23:27:10]
<Émy - OniriCorpe> okay, CI testing
[23:33:58]
<Émy - OniriCorpe> it works
[23:34:13]
<Aleks (he/him/il/lui)> :o
[23:36:51]
<Émy - OniriCorpe> I also adressed this https://github.com/YunoHost-Apps/adguardhome_ynh/issues/135
[23:45:15]
<Émy - OniriCorpe> https://aria.im/_matrix/media/v1/download/im.emelyne.eu/RrdKyxRYRAALlnMTxcPUTLiN
[23:48:10]
<Émy - OniriCorpe> also the firewal is reloaded 3 times when provisionning ports, maybe once (after the 3 ports opening) would be enough
[23:48:22]
<Émy - OniriCorpe> https://aria.im/_matrix/media/v1/download/im.emelyne.eu/IfHIyaOIGqRGQQHkICenihRW
[23:48:27]
<Émy - OniriCorpe> it's a core thing
[23:51:49]
<Aleks (he/him/il/lui)> yeah :|
[23:53:29]
<Aleks (he/him/il/lui)> `firewall_allow()` doesnt support multiple ports...
[23:55:40]
<Émy - OniriCorpe> hum, can't we do firewall_allow() 3 times THEN reload the firewall?
[23:56:03]
<Émy - OniriCorpe> n times then reload
[23:57:14]
<Émy - OniriCorpe> by looking in [resources.ports] for the number of ports requested + the main port