[04:29:23]
<Yunohost Git/Infra notifications> Job [#21772](https://ci-apps.yunohost.org/ci/job/21772) for qr failed miserably :(
[11:21:48]
<Yunohost Git/Infra notifications> App archivist failed all tests in job [#21776](https://ci-apps.yunohost.org/ci/job/21776) :(
[11:58:03]
<lapineige> Any idea how to change such a loop to use ynh\_add\_config instead ? 😅
https://github.com/YunoHost-Apps/archivist\_ynh/blob/update-to-new-packaging-standards/scripts/install#L126
[12:04:30]
<lapineige> `chown: invalid spec: ‘archivist:’`
https://ci-apps-dev.yunohost.org/ci/job/12307
In packaging v1, the $app user is not created ? 🤔
[12:33:46]
<lapineige> Does anyone here master config panel stuff ? I really don't get how to adjust it for CI testing… https://ci-apps-dev.yunohost.org/ci/job/12311
[12:38:45]
<tituspijean> mmmh somhow you have an uninitialized `$app` somewhere: AssertionError: Setting file /etc/yunohost/apps//settings.yml does not exists ?
[12:39:35]
<tituspijean> `AssertionError: Setting file /etc/yunohost/apps/overwrite_cron/settings.yml`
wat 🙂
[12:43:31]
<orhtej2> > <@titus:pijean.ovh> mmmh somhow you have an uninitialized `$app` somewhere: AssertionError: Setting file /etc/yunohost/apps//settings.yml does not exists ?
Saw the same in unattended_upgrades, it is due to broken `config` script iirc
[12:48:45]
<tituspijean> ah yeah. lapineige try removing this line: https://github.com/YunoHost-Apps/archivist_ynh/blob/46eb5ac3c9f3e688c8663a7200d5a979ad52e6c6/scripts/config#L16
[13:24:43]
<lapineige> > Saw the same in unattended_upgrades, it is due to broken `config` script iirc
I'm trying to fix it but don't know nor understand anything about config script...
[13:48:48]
<lapineige> No luck ☹️ (https://ci-apps-dev.yunohost.org/ci/job/12312)
[13:52:49]
<lapineige> > Saw the same in unattended_upgrades, it is due to broken `config` script iirc
Do you know if I can "disable" that script temporarily ? Appart from commenting everything ?
[13:53:12]
<lapineige> No luck ☹️ (https://ci-apps-dev.yunohost.org/ci/job/12312)
https://ci-apps-dev.yunohost.org/ci/job/12313 users still not present
[13:53:44]
<orhtej2> > Do you know if I can "disable" that script temporarily ? Appart from commenting everything ?
Rename it
[14:51:56]
<thatoo> > <@thatoo:defis.info> Here is the issue I opened : https://github.com/frappe/frappe/issues/24016
<a data-mention-type="user" href="https://matrix.to/#/@Alekswag:matrix.org" contenteditable="false">Aleks (he/him/il/lui)</a> I dig the issue and discovered that the next version of ERPnext and thus Dokos have a new parameter for the command, just the one we need, `` --no-setup-db `` and I tried and it works!
The following command works without the need of mysql root password and does the job as expected :
`` bench new-site $site_name --db-name $db_name --db-password $db_pwd --no-setup-db --admin-password $admin_pwd ``
So I can move forward on my script and who knows maybe some day a Yunohost package.
[15:54:22]
<lapineige> I did it, now I have: `Config panel question 'encryption_pwd' should be initialized with a value during install or upgrade.` (https://ci-apps-dev.yunohost.org/ci/job/12316)
Yet : `yunohost app install --no-remove-on-failure --force /app_folder -a "encrypt=true&encryption_pwd=password&…`
_internally screams_
(and config panel script has been removed, only the `config.toml` still exists)
[15:54:27]
<lapineige> Wtf is happening…
[15:57:20]
<Aleks (he/him/il/lui)> ogod, archivist
[15:58:18]
<Aleks (he/him/il/lui)> `$encryption_pwd` is not saved as a setting during the install script
[15:59:04]
<lapineige> Oh 😆
[16:00:02]
<lapineige> Is it safe to do it ? It's saved in a file, maybe the script could retrieve it from there ?
[16:00:35]
<Aleks (he/him/il/lui)> yes, that's dpne using the `bind` option of the config panel thingy
[16:00:55]
<lapineige> Great, I'll look into it, it might be safer than saving it twice.
[16:01:01]
<Aleks (he/him/il/lui)> https://github.com/YunoHost-Apps/nextcloud_ynh/pull/638/files
[16:01:09]
<Aleks (he/him/il/lui)> you can have a look at the nextcloud config panel here
[16:02:03]
<Aleks (he/him/il/lui)> typically something like:
```
[main.mode.has_internet_connection]
bind = ":__INSTALL_DIR__/config/config.php"
```
this mean it fetches / write the info in the config.php file, assuming this variable is exactly named "has_internet_connection" in this file
[16:02:19]
<Aleks (he/him/il/lui)> otherwile you'd need to write `bind = "the_actual_name:__INSTALL_DIR__/config/config.php"`
[16:04:45]
<lapineige> Ok, the thing is the file only contains the password, no key:value. Is it possible to handle that situation, or should it always be in a key:value format ?
[16:05:44]
<lapineige> Oh yes, it seems so : https://github.com/YunoHost/example_ynh/blob/master/config_panel.toml.example#L185
[16:05:49]
<Aleks (he/him/il/lui)> in that case omitting the `:` should do the trick
[16:06:01]
<lapineige> That's great ! 🎉
[16:06:03]
<lapineige> Thanks you 🙂
[16:08:48]
<lapineige> Ah wait, it can't work ? Config panel settings are supposed to be changed, not just read from a file ?
If I bind it, users would be able to change it ? 🤔
[16:09:42]
<Aleks (he/him/il/lui)> hmm i'm guessing there's probably some way to make it readonyl
[16:10:30]
<Aleks (he/him/il/lui)> guessing `readonly = true`
[16:10:33]
<lapineige> no I would seek for the contrary, it's supposed to be changed by users !
[16:10:38]
<Aleks (he/him/il/lui)> ah
[16:10:42]
<Aleks (he/him/il/lui)> 🤔
[16:11:02]
<Aleks (he/him/il/lui)> well yes users will be able to edit it ?
[16:11:47]
<lapineige> I was worried the bind would prevent this. If it doesn't, it's great !
[16:12:06]
<Aleks (he/him/il/lui)> nah it just means "read/write this value into this file instead of the yunohost settings"
[16:12:14]
<Aleks (he/him/il/lui)> which is actually the most common case
[16:12:33]
<lapineige> https://ci-apps-dev.yunohost.org/ci/job/12319
CI complains that this settings, that has a default value, is not initialized : https://github.com/YunoHost-Apps/archivist_ynh/blob/update-to-new-packaging-standards/config_panel.toml#L24
It that because the check_process doesn't give a value ? Or because it's not stored either ?
[16:12:50]
<lapineige> > <@Alekswag:matrix.org> nah it just means "read/write this value into this file instead of the yunohost settings"
thanks for the explaination 🙂
[16:13:18]
<Aleks (he/him/il/lui)> heuarg
[16:13:58]
<Aleks (he/him/il/lui)> it's difficult to explain but i'm surprised this "default" value thing is accepted by the core though i think i have some idea
[16:14:06]
<Aleks (he/him/il/lui)> but basically config panel do not "auto initialize settings"
[16:14:29]
<Aleks (he/him/il/lui)> cf packaging v3 wishlist, clarifying the situation between install question, settings, config panel etc ...
[16:14:55]
<Aleks (he/him/il/lui)> unfortunately you have to create that setting in the install script
[16:15:30]
<Aleks (he/him/il/lui)> (or even better if you're feeling like it : writing a small bash helper that reads the config panel, find every key with a `default` value, and create the corresponding setting 😬)
[16:18:59]
<Aleks (he/him/il/lui)> hmmyes but this is still packaging v1 apparently so install questions are not automatically saved as settings
[16:19:02]
<Aleks (he/him/il/lui)> gotta move to packaging v2
[16:19:17]
<lapineige> yeah, but that's a whole other amount of work 😅
[16:19:26]
<lapineige> I'm trying to fix the basics first 😂
[16:19:36]
<lapineige> once done packaging v3 will be ready 😄
[16:19:50]
<Aleks (he/him/il/lui)> well there's a script to help you ;P
[16:20:09]
<Aleks (he/him/il/lui)> https://github.com/YunoHost/apps/tree/master/tools/packaging_v2 -> convert_app_to_packaging_v2.py
[16:20:24]
<Aleks (he/him/il/lui)> (be careful though, that will overwrite uncommited changes)
[16:20:44]
<lapineige> ~~no it's in the manifest.json~~ no it's in config panel; sry
[16:20:49]
<lapineige> ~no it's in the manifest.json~ no it's in config panel; sry
[16:21:09]
<lapineige> I'm very unsure archivist is that easy to convert 😂
[16:21:33]
<lapineige> I'm cleaning a lot of stuff right now, it will be easier in the future (I'm also learning how it works at the same time)
[16:25:25]
<lapineige> (It's a mess of bash stuff because… yeah, bash, but it's really complete and handling a lot of edge case, as far as I can see…)
[17:08:50]
<Yunohost Git/Infra notifications> [package_check] @alexAubin pushed 1 commit to master: Fix a stupid issue in which a custom arg ending with _path would get its value replaced instead of the actual path é_è ([b8606ecc](https://github.com/YunoHost/package_check/commit/b8606ecc5e31ac32324f0d72e0b42561bf5a09f2))
[17:59:47]
<Yunohost Git/Infra notifications> [wordpress_ynh] @lapineige created new branch allow_email
[18:01:02]
<Yunohost Git/Infra notifications> [wordpress_ynh] @lapineige pushed 1 commit to allow_email: add allow_email parameter ([b07ebde5](https://github.com/YunoHost-Apps/wordpress_ynh/commit/b07ebde5b853c6ff946762186a9d200a970d5ff2))
[18:02:04]
<Yunohost Git/Infra notifications> [wordpress_ynh] @lapineige labeled enhancement on [pull request #233](https://github.com/YunoHost-Apps/wordpress_ynh/pull/233): add allow_email parameter
[18:02:04]
<Yunohost Git/Infra notifications> [wordpress_ynh] @yunohost-bot [commented](https://github.com/YunoHost-Apps/wordpress_ynh/pull/233#issuecomment-1873007029) on [issue #233](https://github.com/YunoHost-Apps/wordpress_ynh/pull/233) add allow_email parameter: Fingers crossed
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-dev.yunohost.org/ci/api/job/12330/ba...
[18:02:04]
<Yunohost Git/Infra notifications> [wordpress_ynh] @lapineige opened [pull request #233](https://github.com/YunoHost-Apps/wordpress_ynh/pull/233): add allow_email parameter
[18:02:04]
<Yunohost Git/Infra notifications> [wordpress_ynh] @lapineige [commented](https://github.com/YunoHost-Apps/wordpress_ynh/pull/233#issuecomment-1873007024) on [issue #233](https://github.com/YunoHost-Apps/wordpress_ynh/pull/233) add allow_email parameter: testme
[18:03:28]
<Yunohost Git/Infra notifications> [wordpress_ynh] @alexAubin [commented](https://github.com/YunoHost-Apps/wordpress_ynh/pull/233#issuecomment-1873007491) on [issue #233](https://github.com/YunoHost-Apps/wordpress_ynh/pull/233) add allow_email parameter: cf https://github.com/YunoHost-Apps/wordpress_ynh/pull/230#discussion_r1412851429
[18:03:36]
<lapineige> Damned… I restarted the wrong CI job…
Sorry 😅
[18:08:37]
<Yunohost Git/Infra notifications> [apps] @ericgaspar created new branch joplin
[18:09:16]
<Yunohost Git/Infra notifications> [apps] @ericgaspar pushed 97 commits to joplin ([38aa6ffff8d2...694a3d26c5eb](https://github.com/YunoHost/apps/compare/38aa6ffff8d2...694a3d26c5eb))
[18:09:21]
<Yunohost Git/Infra notifications> [apps/joplin] Merge pull request #1939 from YunoHost/add-to-wishlist-faircamp Add Faircamp to wishlist - Alexandre Aubin
[18:10:24]
<Yunohost Git/Infra notifications> [apps] @ericgaspar pushed 1 commit to joplin: Update apps.toml ([f193244d](https://github.com/YunoHost/apps/commit/f193244dc2b8aafd0e7680dc7a5b0d354b36e600))
[18:10:47]
<Yunohost Git/Infra notifications> [apps] @ericgaspar opened [pull request #1946](https://github.com/YunoHost/apps/pull/1946): Add joplin to catalog
[18:12:11]
<Yunohost Git/Infra notifications> [apps] @ericgaspar pushed 1 commit to joplin: Update wishlist.toml ([a25722d3](https://github.com/YunoHost/apps/commit/a25722d367a770da5303fceb18ffa1b662cacb5f))
[18:16:06]
<lapineige> > <@Alekswag:matrix.org> typically something like:
>
> ```
> [main.mode.has_internet_connection]
> bind = ":__INSTALL_DIR__/config/config.php"
> ```
>
> this mean it fetches / write the info in the config.php file, assuming this variable is exactly named "has_internet_connection" in this file
Hum… let me guess, if in my file (a basic txt) I have line like this `key=value`, it won't work, right ?
[18:16:40]
<Aleks (he/him/il/lui)> why wouldnt it work ?
[18:17:13]
<lapineige> The syntax doesn't seem to be included in any example, and has it doesn't list such a file type… well, launching CI then 🙂
[18:17:55]
<Aleks (he/him/il/lui)> there's some dirty magic trying to find anything that look like "<key> <delimiter> <value>"
[18:19:56]
<Yunohost Git/Infra notifications> [wordpress_ynh] @lapineige [commented](https://github.com/YunoHost-Apps/wordpress_ynh/pull/233#issuecomment-1873010988) on [issue #233](https://github.com/YunoHost-Apps/wordpress_ynh/pull/233) add allow_email parameter: Its needed for some extensions that send email, so lets keep it ?
[18:20:02]
<lapineige> Oh yeah, Yunohost dark magic
[18:20:23]
<Yunohost Git/Infra notifications> [apps] @alexAubin closed [pull request #1926](https://github.com/YunoHost/apps/pull/1926): Add JItsi BRoadcasting Infrastruct to wishlist
[18:20:46]
<eric_G> I keep adding apps half working to the repo and forgetting about them... 🙄
[18:21:22]
<lapineige> It's already worth it 😄
[18:21:34]
<eric_G> > It's already worth it 😄
is it?
[18:21:39]
<lapineige> half of the work done for the next person 🙂
[18:22:16]
<Yunohost Git/Infra notifications> [wordpress_ynh] @alexAubin [commented](https://github.com/YunoHost-Apps/wordpress_ynh/pull/233#issuecomment-1873011469) on [issue #233](https://github.com/YunoHost-Apps/wordpress_ynh/pull/233) add allow_email parameter: To me that just gives the false impression that the app integrates properly with email, which it doesnt if this aint ac...
[18:22:46]
<eric_G> > half of the work done for the next person 🙂
meu... that is not how it works I am afraid
[18:23:04]
<Yunohost Git/Infra notifications> [apps] @alexAubin deleted branch add-to-wishlist-jitsi-broadcasting-infrastruct
[18:23:28]
<lapineige> sometimes 🙂
I did help fixing apps that were halfway done, that I would never have started myself
[18:24:41]
<eric_G> here is your homework:
https://github.com/YunoHost-Apps/mailbag_ynh
[18:24:55]
<eric_G> https://github.com/YunoHost-Apps/rss_ynh
[18:25:41]
<lapineige> I still can't figure out how to feed the config panel with a value for "encrypt" option… https://ci-apps-dev.yunohost.org/ci/job/12331
Help 😆
[18:26:46]
<Yunohost Git/Infra notifications> [wordpress_ynh] @lapineige [commented](https://github.com/YunoHost-Apps/wordpress_ynh/pull/233#issuecomment-1873012291) on [issue #233](https://github.com/YunoHost-Apps/wordpress_ynh/pull/233) add allow_email parameter: > Or if we cant configure it automatically, we should at least properly document it how to manually configure it in ADM...
[18:27:02]
<Yunohost Git/Infra notifications> [wordpress_ynh] @lapineige labeled pending on [pull request #233](https://github.com/YunoHost-Apps/wordpress_ynh/pull/233): add allow_email parameter
[18:27:02]
<Yunohost Git/Infra notifications> [wordpress_ynh] @lapineige labeled help wanted on [pull request #233](https://github.com/YunoHost-Apps/wordpress_ynh/pull/233): add allow_email parameter
[18:27:48]
<Aleks (he/him/il/lui)> `if [ $encrypt ]; then`
[18:27:53]
<Aleks (he/him/il/lui)> darkvadornoooo.gif
[18:28:36]
<Aleks (he/him/il/lui)> bash is (s)hell but this is not how it works :(
[18:29:02]
<Aleks (he/him/il/lui)> either write `if [ some_condition ]` or `if some command` but not `if [ $variable ]` é_è
[18:30:02]
<lapineige> it was 0 and 1 before, I tried to streamline it to only booleans
[18:30:10]
<lapineige> with 0 bash skill 😂
[18:30:37]
<lapineige> I see that `if some command` is dangerous https://stackoverflow.com/questions/3810709/how-to-evaluate-a-boolean-variable-in-an-if-block-in-bash/3810777#3810777
[18:30:55]
<Aleks (he/him/il/lui)> that's `if $variable`
[18:31:21]
<Aleks (he/him/il/lui)> and yes it's dangerous because if `$variable` is something provided by the user, you are executing arbitrary code, etc, classic injection
[18:33:10]
<Aleks (he/him/il/lui)> anyway, regarding `if [ $variable ]` syntax :
```
foo="false"
if [ $foo ]; then echo "coucou"; fi
# Displays coucou ...
```
[18:33:22]
<Aleks (he/him/il/lui)> also works with `foo=0`
[18:33:48]
<lapineige> yeah I changed it, thanks for the tip
[18:33:57]
<Aleks (he/him/il/lui)> in fact the only case where it's interpreted as "not passing the condition" is if `$foo` is empty
[18:35:05]
<Aleks (he/him/il/lui)> a day may come when somebody actually invents "modern bash"
[18:35:05]
<Aleks (he/him/il/lui)> but it is not this day
[18:45:35]
<lapineige> regarding the config panel issue, I don't think it's related 😅 (install script doesn't fail)
[18:46:00]
<Aleks (he/him/il/lui)> ah yes i got carried away
[18:47:22]
<Aleks (he/him/il/lui)> to me it sounds like the `config` script may be interfering, it's using super old syntax, honestly i would just trash it and start over
[18:49:24]
<Aleks (he/him/il/lui)> ah also using `bind = "encrypt:$final_path/Backup_list.conf"` ain't gonna work, it's not going to replace the `$var` stuff in that context
[18:49:34]
<Aleks (he/him/il/lui)> maybe `__FINAL_PATH__` works
[19:09:17]
<lapineige> Ah damned the bind argument only work if the file exists 😅
[19:13:24]
<lapineige> Well anyway happy end of the year everyone 😃
[21:27:55]
<Yunohost Git/Infra notifications> [example_ynh] @OniriCorpe opened [pull request #222](https://github.com/YunoHost/example_ynh/pull/222): add the missing --app to ynh_app_setting_set
[21:49:43]
<Yunohost Git/Infra notifications> [example_ynh] @alexAubin edited review [pull request #222](https://github.com/YunoHost/example_ynh/pull/222#pullrequestreview-1799693498): add the missing --app to ynh_app_setting_set
[21:49:44]
<Yunohost Git/Infra notifications> [example_ynh] @alexAubin [commented](https://github.com/YunoHost/example_ynh/pull/222#discussion_r1438932763) on pull request #222 add the missing --app to ynh_app_setting_set: suggestion ynh_app_setting_set --app=app --key=prices --value="prices"
[21:50:35]
<Yunohost Git/Infra notifications> [example_ynh] @alexAubin pushed 3 commits to master ([5a7f9f5c61e8...3efd02c447b7](https://github.com/YunoHost/example_ynh/compare/5a7f9f5c61e8...3efd02c447b7))
[21:50:38]
<Yunohost Git/Infra notifications> [example_ynh] @alexAubin merged [pull request #222](https://github.com/YunoHost/example_ynh/pull/222): add the missing --app to ynh_app_setting_set
[21:50:39]
<Yunohost Git/Infra notifications> [example_ynh] @OniriCorpe [commented](https://github.com/YunoHost/example_ynh/pull/222#discussion_r1438932803) on pull request #222 add the missing --app to ynh_app_setting_set: ah yes lmao
[21:50:39]
<Yunohost Git/Infra notifications> [example_ynh/master] add the missing --app to ynh_app_setting_set - OniriCorpe
[22:55:41]
<Émy - OniriCorpe> `2023-12-31 23:38:46,846: DEBUG - + ynh_write_var_in_file --file=/var/www/adguardhome/AdGuardHome.yaml '--key=tls>enabled' --value=true
2023-12-31 23:38:47,092: DEBUG - + after=
2023-12-31 23:38:47,092: DEBUG - + [[ -f /var/www/adguardhome/AdGuardHome.yaml ]]
2023-12-31 23:38:47,109: DEBUG - + return 1
2023-12-31 23:38:47,110: DEBUG - + ynh_exit_properly`
What is the error? 😐
[22:57:37]
<Aleks (he/him/il/lui)> can't magically guess without the full log 😐️
[22:58:35]
<Émy - OniriCorpe> https://paste.yunohost.org/raw/bepujoxomu
[23:01:34]
<Aleks (he/him/il/lui)> maybe `/var/www/adguardhome/AdGuardHome.yaml` doesnt exists but would be a bit surprising maybe
[23:04:37]
<Aleks (he/him/il/lui)> ah i think it's because it doesnt like \`--key="tls>enabled"`
[23:04:41]
<Aleks (he/him/il/lui)> ah i think it's because it doesnt like `--key="tls>enabled"`
[23:04:59]
<Aleks (he/him/il/lui)> maybe you want `--key="enabled" --after="tls"`
[23:06:51]
<Émy - OniriCorpe> Hum no, there’s multiples “enabled” in the config file
[23:07:22]
<Émy - OniriCorpe> I want to modify explicitly the “tls enabled” one
[23:08:23]
<Émy - OniriCorpe> I saw somewhere that we can use > for that
[23:09:56]
<Aleks (he/him/il/lui)> yes, that's the syntax inside the toml
[23:10:04]
<Aleks (he/him/il/lui)> but not the helper "manual" call
[23:10:10]
<Aleks (he/him/il/lui)> the equivalent is to use `--after="tls"`
[23:10:18]
<Aleks (he/him/il/lui)> that's just what it does under the hood
[23:12:02]
<Émy - OniriCorpe> So --key=“enabled” --after=“tls” ?
[23:12:24]
<Aleks (he/him/il/lui)> yup
[23:12:32]
<Émy - OniriCorpe> Oh thanks ❤️
[23:21:42]
<Émy - OniriCorpe> Maybe add the —after in the helper docs page?
[23:30:00]
<Aleks (he/him/il/lui)> anybody can do it in https://github.com/YunoHost/yunohost/blob/dev/helpers/utils#L711-L717 , and similar stuff for read_var_in_file
[23:45:43]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot created new branch add-to-wishlist-fluffy-chat
[23:45:44]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot pushed 1 commit to add-to-wishlist-fluffy-chat: Add Fluffy Chat to wishlist ([9c3fdec2](https://github.com/YunoHost/apps/commit/9c3fdec2836066318649b4e734531d61acdd690e))
[23:45:49]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot opened [pull request #1947](https://github.com/YunoHost/apps/pull/1947): Add Fluffy Chat to wishlist