[09:50:27]
<Yunohost Git/Infra notifications> [cloud-init-images] Salamandar pushed to pretty: Call xz with --force --keep ([64a8b220](https://github.com/YunoHost/cloud-init-images/commit/64a8b220a484a0243be6ffaa56cfa4446657f7b9))
[09:51:19]
<Yunohost Git/Infra notifications> [cloud-init-images] Salamandar pushed to pretty: Download origin image only if necessary ([17a6ba58](https://github.com/YunoHost/cloud-init-images/commit/17a6ba589d9b7ae3e5b514bb801aa1bf32dd10dd))
[09:51:19]
<Yunohost Git/Infra notifications> [cloud-init-images] Salamandar pushed to pretty: virt-customize: dont update, the install script will do it too ([61417e70](https://github.com/YunoHost/cloud-init-images/commit/61417e70da212f59db8e6ba98ecaa9526b6d3724))
[10:16:06]
<Yunohost Git/Infra notifications> [cloud-init-images] Salamandar pushed to pretty: double-quotes paths ([ca0d8cd4](https://github.com/YunoHost/cloud-init-images/commit/ca0d8cd4ea1109732a461608cec751b9e559ddf2))
[10:18:43]
<Yunohost Git/Infra notifications> [cloud-init-images] Salamandar pushed to main: Prettyfy the script, add a gitignore ([7031f69a](https://github.com/YunoHost/cloud-init-images/commit/7031f69ab96f1a4ef45c3110a83ab4923f7f37eb))
[10:19:57]
<Yunohost Git/Infra notifications> [cloud-init-images] Salamandar pushed to main: Call xz with --force --keep ([64a8b220](https://github.com/YunoHost/cloud-init-images/commit/64a8b220a484a0243be6ffaa56cfa4446657f7b9))
[10:20:02]
<Yunohost Git/Infra notifications> [cloud-init-images] Salamandar pushed to main: Download origin image only if necessary ([17a6ba58](https://github.com/YunoHost/cloud-init-images/commit/17a6ba589d9b7ae3e5b514bb801aa1bf32dd10dd))
[10:20:06]
<Yunohost Git/Infra notifications> [cloud-init-images] Salamandar pushed to main: virt-customize: dont update, the install script will do it too ([61417e70](https://github.com/YunoHost/cloud-init-images/commit/61417e70da212f59db8e6ba98ecaa9526b6d3724))
[10:20:12]
<Yunohost Git/Infra notifications> [cloud-init-images] Salamandar pushed to main: double-quotes paths ([ca0d8cd4](https://github.com/YunoHost/cloud-init-images/commit/ca0d8cd4ea1109732a461608cec751b9e559ddf2))
[10:20:14]
<Yunohost Git/Infra notifications> [cloud-init-images] Salamandar deleted branch pretty
[10:20:25]
<Yunohost Git/Infra notifications> [cloud-init-images] Salamandar pushed to main: Fix quoting ([5d439f99](https://github.com/YunoHost/cloud-init-images/commit/5d439f9930d7b8fcc0efbdec2e2cf1a074091f8d))
[10:20:40]
<Yunohost Git/Infra notifications> [cloud-init-images] Salamandar pushed to fpu-refacto: Refactorize, ensure set ([8c5afc33](https://github.com/YunoHost/cloud-init-images/commit/8c5afc33bf78c724d76c8f211a264217df27e14a))
[10:23:38]
<Yunohost Git/Infra notifications> [cloud-init-images] Salamandar pushed to main: readme: Add info about command to follow logs ([115b7a6f](https://github.com/YunoHost/cloud-init-images/commit/115b7a6febcecde927358261ec3f22d0b14f77fe))
[10:26:10]
<Yunohost Git/Infra notifications> [yunohost] zamentur pushed to fix-api-doc: [fix] API doc generation ([1e75e2a9](https://github.com/YunoHost/yunohost/commit/1e75e2a9e9885717b3bd5d334a19b593f451f7d6))
[10:27:23]
<Yunohost Git/Infra notifications> [yunohost] zamentur opened [pull request #2334](https://github.com/YunoHost/yunohost/pull/2334) : [fix] API doc generation
[10:29:00]
<Yunohost Git/Infra notifications> [yunohost] zamentur pushed to fix-api-doc: [enh] Generate random ascii between a-zA-Z0-9 instead of a-f0-9 ([eb13ae74](https://github.com/YunoHost/yunohost/commit/eb13ae741e250d3671eee2fe4983afd9c6adeb92))
[10:30:19]
<Yunohost Git/Infra notifications> [yunohost] zamentur pushed to fix-api-doc: Linter ([5ea4ffbd](https://github.com/YunoHost/yunohost/commit/5ea4ffbdb0186a7d24e36212e48243d18dc67652))
[10:31:11]
<Yunohost Git/Infra notifications> [yunohost] zamentur pushed to fix-api-doc: :art: Format Python code with Ruff, and Bash code with Shfmt ([4bb4192e](https://github.com/YunoHost/yunohost/commit/4bb4192e3adc4904a26b4d29449d03b117ae1ff3))
[10:31:25]
<Yunohost Git/Infra notifications> [yunohost] zamentur pushed to fix-api-doc: enh(dnsbl): Hostkarma yellowlist is not blocklist (#2333) Co-authored-by: ljf (zamentur) <zamentur@users.noreply.github... ([02b15466](https://github.com/YunoHost/yunohost/commit/02b1546648544fcfc02af9fdb17f3e88b61408b9))
[10:31:43]
<Yunohost Git/Infra notifications> [yunohost] zamentur pushed to dev: [fix] API doc generation (#2334) ([a39d2cda](https://github.com/YunoHost/yunohost/commit/a39d2cdaabf5c12422e1b7c4423980d0e47f2d30))
[10:31:43]
<Yunohost Git/Infra notifications> [yunohost] zamentur pushed to fix-api-doc: Merge branch dev into fix-api-doc ([dc590253](https://github.com/YunoHost/yunohost/commit/dc590253695beb70ebf885f66a347f8552def99d))
[10:31:44]
<Yunohost Git/Infra notifications> [yunohost] zamentur deleted branch fix-api-doc
[10:31:44]
<Yunohost Git/Infra notifications> [yunohost] zamentur merged [pull request #2334](https://github.com/YunoHost/yunohost/pull/2334) : [fix] API doc generation
[10:31:46]
<Yunohost Git/Infra notifications> 🏗️ Starting build for yunohost/12.1.40.1+202608021230 for bookworm/unstable/all...
[10:36:17]
<Yunohost Git/Infra notifications> ✔️ Completed build for yunohost/12.1.40.1+202608021230 for bookworm/unstable/all.
[10:36:19]
<Yunohost Git/Infra notifications> ✔️ Completed distribution for yunohost/12.1.40.1+202608021230 for bookworm/unstable.
[11:22:30]
<Yunohost Git/Infra notifications> [yunohost] zamentur pushed to enh-add-portal-api-doc: [enh] Add portal API doc ([20185a93](https://github.com/YunoHost/yunohost/commit/20185a93313a9d1a04cc42cbec83908437342f3c))
[11:22:35]
<Yunohost Git/Infra notifications> [yunohost] zamentur opened [pull request #2335](https://github.com/YunoHost/yunohost/pull/2335) : [enh] Add portal API doc
[11:34:53]
<Yunohost Git/Infra notifications> [yunohost] zamentur pushed to fix-import-users: [fix] Linter ([41d8ab52](https://github.com/YunoHost/yunohost/commit/41d8ab526b073cf9b48de24ea6339d924c636e5c))
[11:34:57]
<Yunohost Git/Infra notifications> [yunohost] zamentur pushed 7 commits to fix-import-users ([41d8ab526b07...5d28bfebdfa0](https://github.com/YunoHost/yunohost/compare/41d8ab526b07...5d28bfebdfa0))
[11:35:04]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2330#discussion_r3698849957) on pull request #2330 [enh] Antibot with proof of work: suggestion
# Force bots to compute about 500 000 hashes (bruteforce)
[11:48:30]
<Yunohost Git/Infra notifications> [install_script] Salamandar pushed to main: trixie: Do not accept sid as target ([edd82a0b](https://github.com/YunoHost/install_script/commit/edd82a0b562d62c524ea1de05727d2feabd2800a))
[11:48:40]
<Yunohost Git/Infra notifications> [install_script] Salamandar pushed to main: bookworm, trixie: check_assertions: Reorder distros checks For better error messages, check for non-debian before check... ([dbb95ab2](https://github.com/YunoHost/install_script/commit/dbb95ab2b64344bc7c183dfb0b2a55519c28e2a2))
[11:48:43]
<Yunohost Git/Infra notifications> [install_script] Salamandar pushed to main: trixie: check_assertions: Use /etc/os-release instead of /etc/debian_version This is more standard and contains more in... ([cfe6b528](https://github.com/YunoHost/install_script/commit/cfe6b5280ff52cc7b51a76fe7c2d60356a09bbdd))
[12:13:32]
<Yunohost Git/Infra notifications> [install_script] Salamandar pushed to main: trixie: Ensure gpg overwrites the trixie apt key ([d0bc3093](https://github.com/YunoHost/install_script/commit/d0bc3093b779f4418572f018a3b51f84eec9b210))
[12:15:08]
<Yunohost Git/Infra notifications> [install_script] Salamandar pushed to main: trixie: Remove additional echo ([3b6ba209](https://github.com/YunoHost/install_script/commit/3b6ba209c7baed55d4289499aea0dc5d96d72a25))
[12:15:08]
<Yunohost Git/Infra notifications> [install_script] Salamandar pushed to main: trixie: Prettyfying the script output ([6e479db9](https://github.com/YunoHost/install_script/commit/6e479db9eedc129215949cc6a35d972f7ee7957e))
[12:21:12]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3698981332) on pull request #2309 User invitations and self-registration: Dont know what i had in mind (maybe specific use case where mail parent domain are managed but website are hosted elsew...
[12:44:39]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699048117) on pull request #2309 User invitations and self-registration: suggestion
type = "url"
placeholder = "https://example.com/terms"
pattern.regexp = "^https?:/...
[12:44:45]
<Yunohost Git/Infra notifications> [yunohost] zamentur edited a [comment](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699048117) on pull request #2309 User invitations and self-registration: suggestion
type = "url"
placeholder = "https://example.com/terms"
pattern.regexp = "^https?:/...
[12:59:32]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699090767) on pull request #2309 User invitations and self-registration: suggestion
dovecot = only in [None, "dovecot"]
postfix = only in [None, "postfix"]
[13:20:51]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699152729) on pull request #2309 User invitations and self-registration: I think those 2 environment vars are not available when the function is run by resources.py. SO it means all those email...
[13:32:21]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699185691) on pull request #2309 User invitations and self-registration: suggestion
assert isinstance(file_path, (str, Path)), f"Error: file_path {file_path} should be a string but is ...
[13:34:43]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699191847) on pull request #2309 User invitations and self-registration: suggestion
assert isinstance(data, (str, bytes, list)), f"Error: data should be either a string or a list but is ...
[13:35:38]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699194483) on pull request #2309 User invitations and self-registration: suggestion
assert isinstance(file_path, (str, Path)), f"Error: file_path {file_path} should be a string or path...
[13:36:03]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699195343) on pull request #2309 User invitations and self-registration: suggestion
assert isinstance(data, (dict, list)), f"Error: data should be a dict or a list but is of type {type(...
[13:36:51]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699197815) on pull request #2309 User invitations and self-registration: suggestion
assert isinstance(file_path, (str, Path))
[13:37:12]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699198742) on pull request #2309 User invitations and self-registration: suggestion
assert isinstance(data, (dict, list))
[15:38:35]
<Yunohost Git/Infra notifications> [yunohost] zamentur pushed to user-self-registration: [enh] Just in case a user starts a password with {CRYPT}... ([3b130ea9](https://github.com/YunoHost/yunohost/commit/3b130ea9e908e24646a3ee76637c76339cded77d))
[15:38:38]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699285680) on pull request #2309 User invitations and self-registration: suggestion
[15:38:55]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699313176) on pull request #2309 User invitations and self-registration: Should probably translated cause instance admin could test if the link work and get this message
[15:39:05]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699332021) on pull request #2309 User invitations and self-registration: In a normal usecase, it happens when link are badly copied or concatenate with another string. I suggest to give a less ...
[15:39:06]
<Yunohost Git/Infra notifications> [yunohost] zamentur edited a [comment](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699332021) on pull request #2309 User invitations and self-registration: In a normal usecase, it happens when link are badly copied or concatenate with another string. I suggest to give a less ...
[15:39:07]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699336877) on pull request #2309 User invitations and self-registration: I dont understand how "/" could be in HTTP_HOST.
HTTP_HOST could be a domain example.com or a domain followed by a...
[15:39:18]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699346175) on pull request #2309 User invitations and self-registration: Remove port (should only happens on development context)
suggestion
domain = request.get_header("host").split(":"...
[15:39:31]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699353582) on pull request #2309 User invitations and self-registration: Path is supported in read_json version of this PR
suggestion
portal_settings = read_json(portal_settings_pa...
[15:39:43]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699467799) on pull request #2309 User invitations and self-registration: I dont succeed to make this work.
I have this Error display on the screen
Failed to user_invitation_consume: None...
[15:39:47]
<Yunohost Git/Infra notifications> [yunohost] zamentur edited a [comment](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699467799) on pull request #2309 User invitations and self-registration: I dont succeed to make this work.
I have this Error display on the screen
Failed to user_invitation_consume: None...
[15:39:53]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699476253) on pull request #2309 User invitations and self-registration: Not sure its a good idea to send in production mode the error to the end user.
And for admin, the stack trace could be...
[15:39:54]
<Yunohost Git/Infra notifications> [yunohost] zamentur pushed to user-self-registration: [fix] Avoid flooding lock thropugh call socket api and invitation consume entry ([c9c4d9fd](https://github.com/YunoHost/yunohost/commit/c9c4d9fdd73768825a34bce12337a94819e21d21))
[15:40:14]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699526607) on pull request #2309 User invitations and self-registration: suggestion
for _ in range(10000):
CHALLENGES.popitem()
[15:40:20]
<Yunohost Git/Infra notifications> [yunohost] zamentur deleted a [comment](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699526607) on pull request #2309 User invitations and self-registration: suggestion
for _ in range(10000):
CHALLENGES.popitem()
[15:43:09]
<Yunohost Git/Infra notifications> [yunohost] zamentur edited [pull request #2330](https://github.com/YunoHost/yunohost/pull/2330) : [enh] Antibot with proof of work
[15:52:00]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699590941) on pull request #2309 User invitations and self-registration: suggestion
def portal_registration_queue(username: str, fullname: str, password: str, external_email: str | None =Non...
[15:52:47]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699593517) on pull request #2309 User invitations and self-registration: suggestion
def portal_invitation_consume(token: str, username: str, fullname: str, password: str, external_email: str...
[15:57:07]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699607361) on pull request #2309 User invitations and self-registration: suggestion
def portal_invitation_get(token: str) -> dict[str, str | bool | None]:
[15:59:38]
<Yunohost Git/Infra notifications> [yunohost] zamentur edited a [comment](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699593517) on pull request #2309 User invitations and self-registration: suggestion
def portal_invitation_consume(token: str, username: str, fullname: str, password: str, external_email: str...
[16:00:10]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699618037) on pull request #2309 User invitations and self-registration: suggestion
def portal_registration_confirm(request_id: str) -> None:
[16:19:41]
<Yunohost Git/Infra notifications> [yunohost] zamentur pushed to fix-import-users: [fix][unitest] Import/export users ([27956f0f](https://github.com/YunoHost/yunohost/commit/27956f0fccb7b2edbb6fc6bf12842a69532514ce))
[16:20:51]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699685964) on pull request #2309 User invitations and self-registration:
Done https://github.com/YunoHost/yunohost/pull/2332
suggestion
[16:21:21]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699687331) on pull request #2309 User invitations and self-registration: Fixed in https://github.com/YunoHost/yunohost/pull/2332
suggestion
[16:21:45]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699688793) on pull request #2309 User invitations and self-registration: Fixed in https://github.com/YunoHost/yunohost/pull/2332
[16:26:30]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699706022) on pull request #2309 User invitations and self-registration: suggestion
def user_registration_reject(request_id: str) -> None:
[16:28:04]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699711921) on pull request #2309 User invitations and self-registration: suggestion
def user_registration_accept(request_id: str) -> None:
[16:33:41]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699730132) on pull request #2309 User invitations and self-registration: It miss an email to alert external_email (if exists) that the account has been accepted and provisioned.
[17:27:00]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699866145) on pull request #2309 User invitations and self-registration: Display or not display the ip , that is the question ?
[17:31:37]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699874892) on pull request #2309 User invitations and self-registration: suggestion
def user_registration_queue(username: str, fullname: str, password: str, external_email: str | None, accep...
[17:35:32]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699882010) on pull request #2309 User invitations and self-registration: suggestion
require_and_validate_external_email=require_and_validate_external_email
I guess it was here to...
[18:21:38]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699973350) on pull request #2309 User invitations and self-registration: Note that its possible that the username has been registered in user_list between the moment of the registration reques...
[18:32:51]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3699994112) on pull request #2309 User invitations and self-registration: suggestion
try:
user_registration_accept(request["id"])
except YunohostValida...
[18:41:40]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3700012968) on pull request #2309 User invitations and self-registration: Missing translation
[18:51:08]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3700031957) on pull request #2309 User invitations and self-registration: Maybe define a constant for this 100 ?
And add a diagnosis alert on that or directly a mail to admins ?
[18:55:51]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3700040985) on pull request #2309 User invitations and self-registration: suggestion
def _validate_user_inputs_for_registration(username: str, fullname: str, password: str, external_email: st...
[18:57:45]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3700044864) on pull request #2309 User invitations and self-registration: suggestion
logger.warning(f"Group {group} doesnt exist (anymore?)")
continue
[19:04:55]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3700057532) on pull request #2309 User invitations and self-registration: suggestion
def user_invitation_generate(domain: str, username: str | None = None, groups: list[str] = [], external_em...
[19:08:56]
<Yunohost Git/Infra notifications> [yunohost] zamentur [commented](https://github.com/YunoHost/yunohost/pull/2309#discussion_r3700065399) on pull request #2309 User invitations and self-registration: TODO i suggest to factorize this part with the same part in user_create + add yunohost app id from catalog to avoid futu...
[19:25:20]
<Yunohost Git/Infra notifications> [yunohost] zamentur changes_requested [pull request #2309](https://github.com/YunoHost/yunohost/pull/2309#pullrequestreview-4839531022) User invitations and self-registration: Sooooo, i finally finish the code review of the python part...
I tried to pay attention in the same way we do for smal...
[19:29:22]
<Yunohost Git/Infra notifications> [yunohost] zamentur edited [pull request #2309](https://github.com/YunoHost/yunohost/pull/2309) : User invitations and self-registration
[19:30:32]
<Yunohost Git/Infra notifications> [yunohost] zamentur edited review [pull request #2309](https://github.com/YunoHost/yunohost/pull/2309#pullrequestreview-4839531022) : User invitations and self-registration
[20:21:43]
<Yunohost Git/Infra notifications> [yunohost-portal] zamentur [commented](https://github.com/YunoHost/yunohost-portal/pull/40#discussion_r3700213652) on pull request #40 User self registration: I am not sure, but disabled dont get focus on TAB, so screen reader users jump the info...
Bu if we put readonly, the f...
[20:29:38]
<Yunohost Git/Infra notifications> [yunohost-portal] zamentur [commented](https://github.com/YunoHost/yunohost-portal/pull/40#discussion_r3700227129) on pull request #40 User self registration: Sniff what have you done to 404 page
[20:48:59]
<Yunohost Git/Infra notifications> [yunohost-admin] zamentur [commented](https://github.com/YunoHost/yunohost-admin/pull/681#discussion_r3700267321) on pull request #681 User self registration: This dependencies has a lot subdependencies.
We probably should check the weight of the js.
[21:03:07]
<Yunohost Git/Infra notifications> [yunohost-admin] zamentur [commented](https://github.com/YunoHost/yunohost-admin/pull/681#discussion_r3700293249) on pull request #681 User self registration: [a11y]
Currently browsing in that is quite difficult.
May be we should implement:
- a title with <hX> or with role att...
[21:03:22]
<Yunohost Git/Infra notifications> [yunohost-admin] zamentur edited a [comment](https://github.com/YunoHost/yunohost-admin/pull/681#discussion_r3700293249) on pull request #681 User self registration: [a11y]
Currently browsing in that is quite difficult.
May be we should implement:
- a title with <hX> or with role att...
[21:06:30]
<Yunohost Git/Infra notifications> [yunohost-admin] zamentur [commented](https://github.com/YunoHost/yunohost-admin/pull/681#discussion_r3700299431) on pull request #681 User self registration: [a11y]
We should indicate the username to know which qr code is displayed
suggestion
:aria-label="t(...
[21:07:57]
<Yunohost Git/Infra notifications> [yunohost-admin] zamentur edited a [comment](https://github.com/YunoHost/yunohost-admin/pull/681#discussion_r3700299431) on pull request #681 User self registration: [a11y]
We should indicate the username to know which qr code is displayed
suggestion
:aria-label="t(...
[21:08:19]
<Yunohost Git/Infra notifications> [yunohost-admin] zamentur [commented](https://github.com/YunoHost/yunohost-admin/pull/681#discussion_r3700302407) on pull request #681 User self registration: [a11y]
suggestion
:aria-label="t(users_invitation_copy_link_aria, {username: invitation.username})...
[21:10:09]
<Yunohost Git/Infra notifications> [yunohost-admin] zamentur [commented](https://github.com/YunoHost/yunohost-admin/pull/681#discussion_r3700305613) on pull request #681 User self registration: suggestion
<span class="fw-bold" :id="invitation.token">{{ invitation.username || t(users_invitatio...
[21:11:02]
<Yunohost Git/Infra notifications> [yunohost-admin] zamentur edited a [comment](https://github.com/YunoHost/yunohost-admin/pull/681#discussion_r3700299431) on pull request #681 User self registration: [a11y]
We should indicate the username to know which qr code is displayed
suggestion
:aria-desribedBy...
[21:11:22]
<Yunohost Git/Infra notifications> [yunohost-admin] zamentur edited a [comment](https://github.com/YunoHost/yunohost-admin/pull/681#discussion_r3700302407) on pull request #681 User self registration: [a11y]
suggestion
:aria-desribedBy="invitation.token"
[21:11:33]
<Yunohost Git/Infra notifications> [yunohost-admin] zamentur edited a [comment](https://github.com/YunoHost/yunohost-admin/pull/681#discussion_r3700302407) on pull request #681 User self registration: [a11y]
suggestion
:aria-describedby="invitation.token"
[21:11:44]
<Yunohost Git/Infra notifications> [yunohost-admin] zamentur edited a [comment](https://github.com/YunoHost/yunohost-admin/pull/681#discussion_r3700299431) on pull request #681 User self registration: [a11y]
We should indicate the username to know which qr code is displayed
suggestion
:aria-describedb...
[21:17:20]
<Yunohost Git/Infra notifications> [yunohost-admin] zamentur [commented](https://github.com/YunoHost/yunohost-admin/pull/681#discussion_r3700309120) on pull request #681 User self registration: suggestion
:aria-describedby="invitation.token"
[21:23:30]
<Yunohost Git/Infra notifications> [yunohost-admin] zamentur edited a [comment](https://github.com/YunoHost/yunohost-admin/pull/681#discussion_r3700309120) on pull request #681 User self registration: [a11y]
suggestion
:aria-describedby="invitation.token"
Like that we heard
> Cancel BUTTON bob
[21:23:31]
<Yunohost Git/Infra notifications> [yunohost-admin] zamentur edited a [comment](https://github.com/YunoHost/yunohost-admin/pull/681#discussion_r3700302407) on pull request #681 User self registration: [a11y]
suggestion
:aria-describedby="invitation.token"
Like that we heard
> Copy invite link BUT...
[21:23:32]
<Yunohost Git/Infra notifications> [yunohost-admin] zamentur edited a [comment](https://github.com/YunoHost/yunohost-admin/pull/681#discussion_r3700299431) on pull request #681 User self registration: [a11y]
We should indicate the username to know which qr code is displayed
suggestion
:aria-describedb...
[21:23:33]
<Yunohost Git/Infra notifications> [yunohost-admin] zamentur changes_requested [pull request #681](https://github.com/YunoHost/yunohost-admin/pull/681#pullrequestreview-4839726475) User self registration: SO i finish the review, (i have not took a long time on data.ts...).
Change needed are about a11y and i18n.
[21:31:02]
<Yunohost Git/Infra notifications> [yunohost-portal] zamentur pushed to enh-antibot-with-proof-of-work: [enh] Proof of work challenge as optional ([1f6d2aea](https://github.com/YunoHost/yunohost-portal/commit/1f6d2aeaf9225c548946fb9c18985f4760e81332))