[09:30:08]
<Yunohost Git/Infra notifications> [issues] fflorent [commented](https://github.com/YunoHost/issues/issues/2737#issuecomment-5461557719) on [issue #2737](https://github.com/YunoHost/issues/issues/2737) Postgresql migration on debian major upgrade: @Josue-T I wonder if the command could not be simplified by just invoking aptitude why postgresql | grep -E "^i\s+\S+-y...
[09:45:32]
<Yunohost Git/Infra notifications> [yunohost] fflorent edited review [pull request #2358](https://github.com/YunoHost/yunohost/pull/2358#pullrequestreview-5057426394) : Add one more check to ensure that no app is declaring postgresql in t…
[09:45:33]
<Yunohost Git/Infra notifications> [yunohost] fflorent commented [pull request #2358](https://github.com/YunoHost/yunohost/pull/2358#pullrequestreview-5057426394) Add one more check to ensure that no app is declaring postgresql in t…: Thank you
The code looks OK to me (except few remarks, not sure how important they are).
If I understand correctly [y...
[09:45:33]
<Yunohost Git/Infra notifications> [yunohost] fflorent [commented](https://github.com/YunoHost/yunohost/pull/2358#discussion_r3886083411) on pull request #2358 Add one more check to ensure that no app is declaring postgresql in t…: - either rename app_id to app_info which gives a more accurate idea of what it contains
suggestion
for a...
[09:45:33]
<Yunohost Git/Infra notifications> [yunohost] fflorent [commented](https://github.com/YunoHost/yunohost/pull/2358#discussion_r3886071986) on pull request #2358 Add one more check to ensure that no app is declaring postgresql in t…: I see below we import utils running from ..utils.my_module import whatever, why not doing the same?
suggestion
fr...
[09:58:58]
<Yunohost Git/Infra notifications> [yunohost] Thovi98 [commented](https://github.com/YunoHost/yunohost/pull/2358#issuecomment-5461674467) on [issue #2358](https://github.com/YunoHost/yunohost/pull/2358) Add one more check to ensure that no app is declaring postgresql in t…: > I wonder if this is not due to the fact that discourse adds the apt.postgresql.org extra repository For the record, t...
[18:34:03]
<Yunohost Git/Infra notifications> [issues] Josue-T [commented](https://github.com/YunoHost/issues/issues/2737#issuecomment-5464145702) on [issue #2737](https://github.com/YunoHost/issues/issues/2737) Postgresql migration on debian major upgrade: > [@Josue-T](https://github.com/Josue-T) I wonder if the command could not be simplified by just invoking aptitude why ...
[18:37:16]
<Yunohost Git/Infra notifications> [yunohost] Josue-T pushed to trixie_psql_app_check: Update src/migrations/postgresql.py Co-authored-by: Florent <florent.git@zeteo.me> ([5f3e346d](https://github.com/YunoHost/yunohost/commit/5f3e346db8310fa51b7f0793e847e62546c028f7))
[18:41:24]
<Yunohost Git/Infra notifications> [yunohost] Josue-T [commented](https://github.com/YunoHost/yunohost/pull/2358#issuecomment-5464179523) on [issue #2358](https://github.com/YunoHost/yunohost/pull/2358) Add one more check to ensure that no app is declaring postgresql in t…: > Thank you > > The code looks OK to me (except few remarks, not sure how important they are). > > If I understand co...
[18:51:53]
<Yunohost Git/Infra notifications> [yunohost] Josue-T [commented](https://github.com/YunoHost/yunohost/pull/2341#discussion_r3887381901) on pull request #2341 Mail trixie: > Maybe this line could raise an error, if someone as already fill the same mail in the maildrop ? Im not sure that th...
[19:10:25]
<Yunohost Git/Infra notifications> [yunohost] Josue-T [commented](https://github.com/YunoHost/yunohost/pull/2341#discussion_r3887419318) on pull request #2341 Mail trixie: > It might conflict with nextcloud config panel option mail_forward https://github.com/YunoHost-Apps/nextcloud_ynh/blo...
[19:11:23]
<Yunohost Git/Infra notifications> [yunohost] Josue-T edited a [comment](https://github.com/YunoHost/yunohost/pull/2341#discussion_r3887419318) on pull request #2341 Mail trixie: > It might conflict with nextcloud config panel option mail_forward https://github.com/YunoHost-Apps/nextcloud_ynh/blo...
[19:17:06]
<Yunohost Git/Infra notifications> [yunohost] Josue-T [commented](https://github.com/YunoHost/yunohost/pull/2341#issuecomment-5464344906) on [issue #2341](https://github.com/YunoHost/yunohost/pull/2341) Mail trixie: > > There is some security implication because of [this](https://matrix.to/#/GgYiGWJbdhBZSAOnDq:matrix.org/jKjw9RFgzej...
[20:37:22]
<Yunohost Git/Infra notifications> [yunohost] yalh76 closed [pull request #2023](https://github.com/YunoHost/yunohost/pull/2023) : Improving go helper
[20:38:19]
<Yunohost Git/Infra notifications> [yunohost] yalh76 deleted branch go_helper
[20:46:33]
<Yunohost Git/Infra notifications> [yunohost] tituspijean approved [pull request #2342](https://github.com/YunoHost/yunohost/pull/2342#pullrequestreview-5059087413) dns: push: Join TXT chunks split by registrars before comparing: Tested in production, I confirm this works. :+1:
[20:46:58]
<Yunohost Git/Infra notifications> [yunohost] tituspijean merged [pull request #2342](https://github.com/YunoHost/yunohost/pull/2342) : dns: push: Join TXT chunks split by registrars before comparing
[20:47:08]
<Yunohost Git/Infra notifications> [yunohost] tituspijean pushed to trixie: dns: push: Join TXT chunks split by registrars before comparing (#2342) ([327718c2](https://github.com/YunoHost/yunohost/commit/327718c2ea1bf1c7ed2dcaae4756a5865a6b0c6a))
[20:47:08]
<Yunohost Git/Infra notifications> [yunohost] tituspijean deleted branch fix-dns-push-split-txt