[17:01:33]
<Yunohost Git/Infra notifications> [gitlab_ynh] @kay0u pushed 1 commit to testing: Upgrade to 15.9.1 ([30506455](https://github.com/YunoHost-Apps/gitlab_ynh/commit/30506455059c4141d5f86537cfdc2415553a44f4))
[17:01:33]
<Yunohost Git/Infra notifications> [gitlab_ynh] @yunohost-bot pushed 1 commit to testing: Auto-update README ([b6c1b9f0](https://github.com/YunoHost-Apps/gitlab_ynh/commit/b6c1b9f06597dac82fc6b171f70b40afb960cc8d))
[17:08:12]
<Yunohost Git/Infra notifications> [gitlab_ynh] @kay0u opened [pull request #212](https://github.com/YunoHost-Apps/gitlab_ynh/pull/212): Testing
[17:08:31]
<Yunohost Git/Infra notifications> [gitlab_ynh] @kay0u [commented](https://github.com/YunoHost-Apps/gitlab_ynh/pull/212#issuecomment-1452219978) on [issue #212](https://github.com/YunoHost-Apps/gitlab_ynh/pull/212) Testing: testme
[17:08:34]
<Yunohost Git/Infra notifications> [gitlab_ynh] @yunohost-bot [commented](https://github.com/YunoHost-Apps/gitlab_ynh/pull/212#issuecomment-1452220041) on [issue #212](https://github.com/YunoHost-Apps/gitlab_ynh/pull/212) Testing: :rocket:
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-dev.yunohost.org/ci/api/job/5949/badge)](htt...
[17:38:27]
<Aleks (he/him/il/lui)> which are supposed to be `group` question and only ask for "actual" group, not primary group
[17:38:33]
<Aleks (he/him/il/lui)> but we could have an option like "allow_primary_group" for those question
[17:49:32]
<Aleks (he/him/il/lui)> ah i misunderstood the question ? xD
[17:49:37]
<kayou> in short, i want to grant access to qBittorrent_ynh to the "admin" of the app, and only the admin, how can i do that? :)
[17:49:52]
<Aleks (he/him/il/lui)> eeeeeh i don't think there's a way right now ... but how do you define the "admin of the app" other than ... the person(s) able to access the admin perm of the app ? 😅
[17:50:48]
<kayou> yeah, it's not really an admin, maybe there is a logic issue in my mind. This app is "only for the people you really trust"
[17:52:25]
<kayou> and we can't access this app without having access to the admin config
[17:53:03]
<Aleks (he/him/il/lui)> hmmmyeah
[17:53:12]
<Aleks (he/him/il/lui)> so that's more about UI/UX to properly warn 😬
[17:58:29]
<kayou> really nice work with packaging v2 btw! i still have a lot of things to learn about it, but it's way more easy to write a new package
[18:10:22]
<tituspijean> > <@kayou:matrix.org> aaaaaaaannd i've set `main.protected = true` but i still can grant `visitors` access :/
I think `protected` means that admins cannot tune this permission
[18:11:10]
*tituspijean thinks his literacy is very bad
[18:13:54]
<kayou> aaaaaaaannd i've set `main.protected = true` but i still can grant `visitors` access during the install :/
[18:56:26]
<kayou> I think I found a bug with the protected permissions.
so if I summarize:
if I add an `init_main_permission`, then during the installation, I can allow the group "visitors", if I don't put `init_main_permission` but a `main.allowed = "admins"` in my resources, then, the permission doesn't allow the group `admins`, and I have to add it manually to have access to the app
[19:00:33]
<Yunohost Git/Infra notifications> [apps] @kay0u created new branch qbittorrent
[19:01:06]
<Yunohost Git/Infra notifications> [apps] @kay0u pushed 1 commit to qbittorrent: Add qBittorrent ([b9228260](https://github.com/YunoHost/apps/commit/b9228260aedb1df13831a8ff621eb8f42d5ce623))
[19:01:09]
<Yunohost Git/Infra notifications> [apps] @kay0u opened [pull request #1640](https://github.com/YunoHost/apps/pull/1640): Add qBittorrent
[19:32:41]
<tituspijean> @room, meeting o'clock! https://pad.lqdn.fr/p/yunohost-2023-03-02
[19:33:07]
<tituspijean> (reminder, chromium-based browsers seem more compatible with Galène 🙂 )
[19:35:04]
<florent> Does Galène require an account?
[19:35:16]
<tituspijean> Nope, cf. the header of the pad 🙂
[19:35:30]
<florent> Ooops!
[19:35:54]
<yalh76> Sorry guys, won’t be there today, currently going back home from Lyon. tituspijean will do the usual Yalh stuff ;)
[19:44:15]
<Aleks (he/him/il/lui)> > <@kayou:matrix.org> I think I found a bug with the protected permissions.
> so if I summarize:
> if I add an `init_main_permission`, then during the installation, I can allow the group "visitors", if I don't put `init_main_permission` but a `main.allowed = "admins"` in my resources, then, the permission doesn't allow the group `admins`, and I have to add it manually to have access to the app
eeeh for the second part maybe this gotta be a list, ie `main.allowed = ['admins']` ? (This should be reported by the core)
[19:45:27]
<Yunohost Git/Infra notifications> [apps] @ericgaspar approved [pull request #1640](https://github.com/YunoHost/apps/pull/1640#pullrequestreview-1322506285) Add qBittorrent
[19:45:41]
<Yunohost Git/Infra notifications> [apps] @ericgaspar merged [pull request #1640](https://github.com/YunoHost/apps/pull/1640): Add qBittorrent
[19:45:43]
<Yunohost Git/Infra notifications> [apps] @ericgaspar pushed 2 commits to master ([6c7c91f58998...d5dc97624f07](https://github.com/YunoHost/apps/compare/6c7c91f58998...d5dc97624f07))
[19:45:44]
<Yunohost Git/Infra notifications> [apps] @ericgaspar deleted branch qbittorrent
[19:45:47]
<Yunohost Git/Infra notifications> [apps/master] Add qBittorrent - Kay0u
[19:46:00]
<Yunohost Git/Infra notifications> [apps/master] Merge pull request #1640 from YunoHost/qbittorrent Add qBittorrent - Éric Gaspar
[19:46:05]
<Yunohost Git/Infra notifications> [apps] @ericgaspar approved [pull request #1639](https://github.com/YunoHost/apps/pull/1639#pullrequestreview-1322506912) WireGuard Client is working
[19:46:10]
<Yunohost Git/Infra notifications> [apps] @ericgaspar merged [pull request #1639](https://github.com/YunoHost/apps/pull/1639): WireGuard Client is working
[19:46:10]
<Yunohost Git/Infra notifications> [apps] @ericgaspar pushed 2 commits to master ([d5dc97624f07...76135ff265a4](https://github.com/YunoHost/apps/compare/d5dc97624f07...76135ff265a4))
[19:46:11]
<Yunohost Git/Infra notifications> [apps/master] WireGuard Client is working - tituspijean
[19:46:15]
<Yunohost Git/Infra notifications> [apps/master] Merge pull request #1639 from YunoHost/tituspijean-patch-1 WireGuard Client is working - Éric Gaspar
[19:46:36]
<Yunohost Git/Infra notifications> [apps] @ericgaspar approved [pull request #1638](https://github.com/YunoHost/apps/pull/1638#pullrequestreview-1322507842) Update app levels according to CI results
[19:46:41]
<Yunohost Git/Infra notifications> [apps] @ericgaspar merged [pull request #1638](https://github.com/YunoHost/apps/pull/1638): Update app levels according to CI results
[19:46:42]
<Yunohost Git/Infra notifications> [apps] @ericgaspar pushed 5 commits to master ([76135ff265a4...575bedda16b4](https://github.com/YunoHost/apps/compare/76135ff265a4...575bedda16b4))
[19:46:45]
<Yunohost Git/Infra notifications> [apps/master] Revert level changes due to CI issue, not to the app themselves - Alexandre Aubin
[19:47:06]
<Yunohost Git/Infra notifications> [apps/master] https://ci-apps-dev.yunohost.org/ci/job/5840 - Éric Gaspar
[20:12:39]
<Yunohost Git/Infra notifications> [apps] @tituspijean deleted branch tituspijean-patch-1
[20:58:54]
<Yunohost Git/Infra notifications> @johanbove forked apps to [johanbove/yunohost-apps](https://github.com/johanbove/yunohost-apps)
[21:13:10]
<Yunohost Git/Infra notifications> [my_webapp_ynh] @fflorent [commented](https://github.com/YunoHost-Apps/my_webapp_ynh/pull/101#issuecomment-1452553865) on [issue #101](https://github.com/YunoHost-Apps/my_webapp_ynh/pull/101) Allow to configure extra nginx conf in app.d/ directory: testme
[21:13:12]
<Yunohost Git/Infra notifications> [my_webapp_ynh] @yunohost-bot [commented](https://github.com/YunoHost-Apps/my_webapp_ynh/pull/101#issuecomment-1452553909) on [issue #101](https://github.com/YunoHost-Apps/my_webapp_ynh/pull/101) Allow to configure extra nginx conf in app.d/ directory: Fingers crossed
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-dev.yunohost.org/ci/api/job/5954/bad...
[21:45:24]
<kayou> > <@Alekswag:matrix.org> eeeh for the second part maybe this gotta be a list, ie `main.allowed = ['admins']` ? (This should be reported by the core)
https://github.com/YunoHost/package_check/blob/06a1f367a722168d68856d11ffdd80351ebe2672/lib/tests.sh#L198
`[install.init_main_permission]` was commented in my manifest
[21:46:23]
<kayou> we could use tomlq to avoid this issue where we need to read/get value of things in toml
[21:46:23]
<kayou> https://unix.stackexchange.com/questions/614943/how-to-use-a-toml-lens-on-a-single-file-on-ubuntu-20-04
[21:46:53]
<kayou> ^ `pip install yq` then use tomlq
[21:47:28]
<kayou> or use python to read the file and get the field
[21:48:11]
<kayou> anyway, that's not a big issue
[22:04:21]
<Aleks (he/him/il/lui)> > <@kayou:matrix.org> https://github.com/YunoHost/package_check/blob/06a1f367a722168d68856d11ffdd80351ebe2672/lib/tests.sh#L198
> `[install.init_main_permission]` was commented in my manifest
/o\
[22:06:16]
<Aleks (he/him/il/lui)> ooooor toml_to_json and then jq ;P https://github.com/YunoHost/yunohost/blob/sources_toml/helpers/utils#L1064
[22:19:09]
<Yunohost Git/Infra notifications> [apps] @ericgaspar pushed 1 commit to master: Create qbittorrent.png ([4b2f40fb](https://github.com/YunoHost/apps/commit/4b2f40fb51750314ffc0eea2849d409eb16f7ebf))
[23:03:32]
<kayou> hogod
[23:03:41]
<kayou> yeah
[23:03:47]
<kayou> why not i guess
[23:06:04]
<kayou> https://github.com/YunoHost/package_check/blob/06a1f367a722168d68856d11ffdd80351ebe2672/lib/tests.sh#L205
[23:06:53]
<kayou> when the main permission is protected, there is an error with this line, and package_check fail
[23:09:59]
<Aleks (he/him/il/lui)> aaaaaa
[23:10:09]
<Aleks (he/him/il/lui)> skipped_uris ogod
[23:10:12]
<Aleks (he/him/il/lui)> what year is it
[23:10:19]
<kayou> i know
[23:10:23]
<kayou> --'
[23:10:31]
<Aleks (he/him/il/lui)> 😬
[23:10:36]
<kayou> ```
_RUN_YUNOHOST_CMD "tools shell -c \"from yunohost.permission import user_permission_update; user_permission_update(\"$app_id_to_check.main\", add=\"visitors\", force=True)\""
```
[23:10:40]
<kayou> ```bash
_RUN_YUNOHOST_CMD "tools shell -c \"from yunohost.permission import user_permission_update; user_permission_update(\"$app_id_to_check.main\", add=\"visitors\", force=True)\""
```
[23:11:03]
<Aleks (he/him/il/lui)> ah yes you have to force it so cant simply use the `yunohost user permission whatever` command
[23:11:19]
<kayou> i can't get the right syntax
[23:11:23]
<kayou> yup
[23:11:56]
<Aleks (he/him/il/lui)> LGTM but why not use simple quote instead of escaping double quotes ?
[23:12:27]
<Aleks (he/him/il/lui)> (but maybe the issue aint about quotes)
[23:18:35]
<kayou> because there is the variable $app_id_to_check
[23:19:30]
<Aleks (he/him/il/lui)> hmmyeah but `"foo('$app')"` should work
[23:20:04]
<Aleks (he/him/il/lui)> (but `'foo("$bar")'` doesnt)
[23:20:07]
<kayou> haha wtf bash
[23:20:34]
<Aleks (he/him/il/lui)> yeah because in `"foo('$app')"` what matters are the outside quotes
[23:20:43]
<Aleks (he/him/il/lui)> the inside quotes are just regular chars
[23:21:04]
<Aleks (he/him/il/lui)> so doesnt matter that the inside chars are simple quotes or whatever
[23:22:25]
<kayou> i understand
[23:27:51]
<kayou> that's help a lot! thanks for the tips!
[23:28:18]
<Aleks (he/him/il/lui)> \o/
[23:36:02]
<Yunohost Git/Infra notifications> [package_check] @kay0u pushed 1 commit to master: stop using skipped_uris to force access of an app ([9af40915](https://github.com/YunoHost/package_check/commit/9af4091505b35168903b67f5b1795e2186cc941b))
[23:36:18]
<kayou> ¯\_(ツ)_/¯