[05:49:38]
<Yunohost Git/Infra notifications> [apps] @tituspijean edited review [pull request #1656](https://github.com/YunoHost/apps/pull/1656#pullrequestreview-1347824035): Update app levels according to CI results
[05:49:39]
<Yunohost Git/Infra notifications> [apps] @tituspijean [commented](https://github.com/YunoHost/apps/pull/1656#discussion_r1141647096) on pull request #1656 Update app levels according to CI results: suggestion
level = 8
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps.yunohost.org/ci/api/job/...
[05:49:39]
<Yunohost Git/Infra notifications> [apps] @tituspijean changes_requested [pull request #1656](https://github.com/YunoHost/apps/pull/1656#pullrequestreview-1347824035) Update app levels according to CI results
[05:50:14]
<Yunohost Git/Infra notifications> [apps] @tituspijean edited [pull request #1656](https://github.com/YunoHost/apps/pull/1656): Update app levels according to CI results
[06:59:01]
<Yunohost Git/Infra notifications> App veloren failed all tests in job [#14457](https://ci-apps.yunohost.org/ci/job/14457) :(
[07:26:46]
<Yunohost Git/Infra notifications> App wondercms rises from level 7 to 8 in job [#14458](https://ci-apps.yunohost.org/ci/job/14458) !
[08:13:21]
<Yunohost Git/Infra notifications> @marcoil forked apps to [marcoil/yunohost-apps](https://github.com/marcoil/yunohost-apps)
[08:17:46]
<Yunohost Git/Infra notifications> [apps] @marcoil opened [pull request #1657](https://github.com/YunoHost/apps/pull/1657): Add the Firefly-III Data Importer
[09:08:06]
<Yunohost Git/Infra notifications> [apps] @ericgaspar approved [pull request #1657](https://github.com/YunoHost/apps/pull/1657#pullrequestreview-1348072715) Add the Firefly-III Data Importer
[09:08:19]
<Yunohost Git/Infra notifications> [apps] @ericgaspar pushed 2 commits to master ([4c329c1d2599...02c8748dbc3f](https://github.com/YunoHost/apps/compare/4c329c1d2599...02c8748dbc3f))
[09:08:19]
<Yunohost Git/Infra notifications> [apps] @ericgaspar merged [pull request #1657](https://github.com/YunoHost/apps/pull/1657): Add the Firefly-III Data Importer
[09:08:19]
<Yunohost Git/Infra notifications> [apps/master] Add the Firefly-III Data Importer - Marc Ordinas i Llopis
[09:08:23]
<Yunohost Git/Infra notifications> [apps/master] Merge pull request #1657 from marcoil/add-firefly-iii-di Add the Firefly-III Data Importer - Éric Gaspar
[09:09:22]
<Yunohost Git/Infra notifications> [apps] @ericgaspar edited [pull request #1656](https://github.com/YunoHost/apps/pull/1656): Update app levels according to CI results
[11:05:18]
<Yunohost Git/Infra notifications> [apps] @tituspijean pushed 1 commit to update_app_levels: Flarum back at level 8 ([c9089d44](https://github.com/YunoHost/apps/commit/c9089d44f1bce6dd7ce29d0870ae956459930402))
[11:53:52]
<Yunohost Git/Infra notifications> App funkwhale rises from level 6 to 8 in job [#14464](https://ci-apps.yunohost.org/ci/job/14464) !
[13:00:37]
<Yunohost Git/Infra notifications> Job [#13944](https://ci-apps.yunohost.org/ci/job/13944) for nodered failed miserably :(
[13:18:59]
<eric_G> some app repos use more than one screenshot. As this is also used for the webadmin pages, I think it is worth having an alert on CI tests about limiting the number of screenshot to only one.
[14:16:42]
<Aleks (he/him/il/lui)> ah ? the webadmin pages show also only one screenshot ?
[14:16:45]
<eric_G> no but it should 😬
[14:16:48]
<Aleks (he/him/il/lui)> zblerg idk it was designed to have several screenshots (hence having a screenshot folder), I would more wonder about showing them on the README somehow 🤔
[14:16:48]
<Aleks (he/him/il/lui)> can you cite apps that do have several screenshots ?
[14:16:48]
<eric_G> what i noticed is that sometimes the README description is quite long (copy/pasta) and this is used in the webadmin app page... same with multiple screenshots. It makes the webadmin cluttered with not so useful information.
[14:16:49]
<eric_G> but I have been removing multiple screenshots regularly in other repo...
[14:16:49]
<Aleks (he/him/il/lui)> ooh okay
[14:16:49]
<eric_G> https://github.com/YunoHost-Apps/searxng_ynh
[14:16:49]
<Yunohost Git/Infra notifications> [apps] @alexAubin pushed 1 commit to master: firefly-iii-di uses branch main ([999d8e99](https://github.com/YunoHost/apps/commit/999d8e994b223fea746eac8e068e4404aaa83b6d))
[15:06:43]
<tituspijean> Maybe we can make the Screenshots section collapsed by default?
[15:18:13]
<Yunohost Git/Infra notifications> [apps] @alexAubin [commented](https://github.com/YunoHost/apps/pull/1656#discussion_r1142281987) on pull request #1656 Update app levels according to CI results: suggestion level = 7 (apparently photoprism is back to level 7 in latest job :tada: )
[15:18:38]
<Yunohost Git/Infra notifications> [apps] @alexAubin edited [pull request #1656](https://github.com/YunoHost/apps/pull/1656): Update app levels according to CI results
[15:19:30]
<Yunohost Git/Infra notifications> [apps] @alexAubin pushed 1 commit to update_app_levels: photoprism back to level 7 ([43fefcf7](https://github.com/YunoHost/apps/commit/43fefcf7acb96d41797ea1f446c02fb5d9200dc1))
[15:33:37]
<Yunohost Git/Infra notifications> App nodered rises from level 6 to 8 in job [#13944](https://ci-apps.yunohost.org/ci/job/13944) !
[15:34:45]
<Yunohost Git/Infra notifications> [apps] @ericgaspar edited [pull request #1656](https://github.com/YunoHost/apps/pull/1656): Update app levels according to CI results
[15:34:45]
<Yunohost Git/Infra notifications> [apps] @ericgaspar edited [pull request #1656](https://github.com/YunoHost/apps/pull/1656): Update app levels according to CI results
[15:34:47]
<Yunohost Git/Infra notifications> [apps] @ericgaspar pushed 1 commit to update_app_levels: Update apps.toml ([b358cba2](https://github.com/YunoHost/apps/commit/b358cba2b77fec70b8183d6666df665b82f003a5))
[15:49:40]
<m606> Hello, when using Github Actions related udpater.sh to auto-update a package, would having a working but kind of scrambled manifest.toml be regarded as a significant issue by YNH project admins?
Since `jq` cannot manage toml manifest sections (in particular the `[ressources.source]` section), i can use `tomlq`. However, tomlq has two problems: in-place parameter apparently doesn't work with toml output and capturing modified toml output scrambles the formatting (remove indentation, comments and delete header keys without properties even though there are subkeys). Github issues for both topics are already opened at `yq`'s repo.
[15:49:41]
<Aleks (he/him/il/lui)> m606: yes honestly I would just go for a brutal `sed` to be sure to not mess indent ...
[15:49:42]
<Aleks (he/him/il/lui)> at least that's what I plan to go for in https://github.com/YunoHost/apps/pull/1655
[15:49:42]
<Aleks (he/him/il/lui)> it's kind of "dirty" but that should solve the issue
[15:49:42]
<Aleks (he/him/il/lui)> (or maybe not a sed but a python `replace()`)
[15:58:06]
<tituspijean> I have just fixed the autoupdater for flarum btw
[15:59:10]
<tituspijean> https://github.com/YunoHost-Apps/flarum_ynh/pull/213/files
[15:59:20]
<tituspijean> (in the interim of aleks' PR)
[16:00:04]
<tituspijean> it does depend on a additional `pip install yq` in the .yml file to use the `tomlq` command
[16:01:30]
<tituspijean> (it concede it basically does what you were describing both ^^ at least there's an example out there 🙂 )
[16:02:25]
<m606> > <@Alekswag:matrix.org> m606: yes honestly I would just go for a brutal `sed` to be sure to not mess indent ...
and if for now I use the bash script, would I be _allowed_ to just match the property name (I've got `url` and `sha256` to change in my current case) instead of the section (that wouldn't work if there were several sources, but that is not the case here) ?
[16:13:51]
<m606> Yes actually I did check in the Apps repo to see whether somebody already had implemented toml lookup and I saw several apps using the method you point out (which I thus thought to be using as well) to fetch data.
Now i needed also something to replace data, and thought about using the folllowing:
```bash
# Update manifest' source information in manifest
# This will loose manifest original's format (especially indentation) as yq currently does not apply automatic styling for toml, cf. https://github.com/kislyuk/yq/issues/164
cat manifest.toml | tomlq -t --arg url "$asset_url" --arg sha256 "$checksum" '.resources.sources.main.url |= $url | .resources.sources.main.sha256 |= $sha256' > $tempdir/manifest.toml
mv $tempdir/manifest.toml manifest.toml
```
But that scrambles the formatting due to `yq` limitations: [scrambling](https://github.com/kislyuk/yq/issues/164) and [no in-place editing apparently working](https://github.com/kislyuk/yq/issues/130) (for this last point I trusted the issue and did not check myself).
I could easily replace that by 2 sed commands shaped in this way `sed -i "s/^\s*url\s\=\s\"`
[16:18:57]
<m606> but that would work only if there is a unique `sources` subsection
[16:20:36]
<m606> Yes actually I did check in the Apps repo to see whether somebody already had implemented toml lookup and I saw several apps using the method you point out (which I thus thought to be using as well) to fetch data.
Now i needed also something to replace data, and thought about using the folllowing:
`
# Update manifest' source information in manifest
# This will loose manifest original's format (especially indentation) as yq currently does not apply automatic styling for toml, cf. https://github.com/kislyuk/yq/issues/164
cat manifest.toml | tomlq -t --arg url "$asset_url" --arg sha256 "$checksum" '.resources.sources.main.url |= $url | .resources.sources.main.sha256 |= $sha256' > $tempdir/manifest.toml
mv $tempdir/manifest.toml manifest.toml
`
But that scrambles the formatting due to `yq` limitations: [scrambling](https://github.com/kislyuk/yq/issues/164) and [no in-place editing apparently working](https://github.com/kislyuk/yq/issues/130) (for this last point I trusted the issue and did not check myself).
I could easily replace that by 2 sed commands shaped in this way `sed -i "s/^\s*url\s\=\s\"`
[16:20:52]
<m606> Yes actually I did check in the Apps repo to see whether somebody already had implemented toml lookup and I saw several apps using the method you point out (which I thus thought to be using as well) to fetch data.
Now i needed also something to replace data, and thought about using the folllowing:
```
# Update manifest' source information in manifest
# This will loose manifest original's format (especially indentation) as yq currently does not apply automatic styling for toml, cf. https://github.com/kislyuk/yq/issues/164
cat manifest.toml | tomlq -t --arg url "$asset_url" --arg sha256 "$checksum" '.resources.sources.main.url |= $url | .resources.sources.main.sha256 |= $sha256' > $tempdir/manifest.toml
mv $tempdir/manifest.toml manifest.toml
```
But that scrambles the formatting due to `yq` limitations: [scrambling](https://github.com/kislyuk/yq/issues/164) and [no in-place editing apparently working](https://github.com/kislyuk/yq/issues/130) (for this last point I trusted the issue and did not check myself).
I could easily replace that by 2 sed commands shaped in this way `sed -i "s/^\s*url\s\=\s\"`
[16:24:46]
<m606> Yes actually I did check in the Apps repo to see whether somebody already had implemented toml lookup and I saw several apps using the method you point out (which I thus thought to be using as well) to fetch data.
Now i needed also something to replace data, and thought about using the folllowing:
```
# Update manifest' source information in manifest
# This will loose manifest original's format (especially indentation) as yq currently does not apply automatic styling for toml, cf. https://github.com/kislyuk/yq/issues/164
cat manifest.toml | tomlq -t --arg url "$asset_url" --arg sha256 "$checksum" '.resources.sources.main.url |= $url | .resources.sources.main.sha256 |= $sha256' > $tempdir/manifest.toml
mv $tempdir/manifest.toml manifest.toml
```
But that scrambles the formatting due to `yq` limitations: [scrambling](https://github.com/kislyuk/yq/issues/164) and [no in-place editing apparently working](https://github.com/kislyuk/yq/issues/130) (for this last point I trusted the issue and did not check myself).
I could easily replace that by 2 sed commands shaped in this way `sed -i "s/^\s*url\s\=\s\"/replacement_line/"`
[16:44:44]
<m606> Or actually, if we say that it is ok to fetch data using `yq`, for a less app-specific approach, I could also only fetch the value using `tomlq` and then using the latter in the `sed` regex part to have it replaced.
[16:48:15]
<Aleks (he/him/il/lui)> (my god etherpad_mypads's install has like 18 minutes of npm install ... srsly ...)
[17:15:44]
<Yunohost Git/Infra notifications> App pgadmin failed all tests in job [#14471](https://ci-apps.yunohost.org/ci/job/14471) :(
[17:49:51]
<m606> Here is what it could be as well:
```
old_src_main_url=$(cat manifest.toml | tomlq -j '.resources.sources.main.url')
old_src_main_sha256=$(cat manifest.toml | tomlq -j '.resources.sources.main.sha256')
sed -i "s^$old_src_main_url^$asset_url^" # use alternate sed delimiter to avoid url escaping
sed -i "s/$old_src_main_sha256/$checksum/"
```
[19:26:30]
<tituspijean> Gitea now supports Actions: https://blog.gitea.io/2023/03/gitea-1.19.0-is-released/#-gitea-actions-21937httpsgithubcomgo-giteagiteaissues21937
[23:58:57]
<Yunohost Git/Infra notifications> App endi failed all tests in job [#14478](https://ci-apps.yunohost.org/ci/job/14478) :(
[23:59:25]
<Yunohost Git/Infra notifications> [apps] @alexAubin pushed 1 commit to autoupdate_app_sources: New source autoupdate: add logic to compute sha256 + update infos in manifest.toml ([6d9c0c7c](https://github.com/YunoHost/apps/commit/6d9c0c7c07e115408d2010d1d209c38d103b7ad3))