[08:23:19]
<florent> When you have some time for that, can anyone review this PR? (Github does not allow me to request a review)
https://github.com/YunoHost-Apps/my_webapp_ynh/pull/101
[08:41:36]
<Yunohost Git/Infra notifications> [my_webapp_ynh] @ericgaspar pushed 1 commit to v2: Cleaning ([dafc95ba](https://github.com/YunoHost-Apps/my_webapp_ynh/commit/dafc95ba31fdb8edd0104e4dfa4f3cf420a1f93d))
[08:41:54]
<Yunohost Git/Infra notifications> [my_webapp_ynh] @ericgaspar [commented](https://github.com/YunoHost-Apps/my_webapp_ynh/pull/107#issuecomment-1453169790) on [issue #107](https://github.com/YunoHost-Apps/my_webapp_ynh/pull/107) V2: testme
[08:41:56]
<Yunohost Git/Infra notifications> [my_webapp_ynh] @yunohost-bot [commented](https://github.com/YunoHost-Apps/my_webapp_ynh/pull/107#issuecomment-1453169833) on [issue #107](https://github.com/YunoHost-Apps/my_webapp_ynh/pull/107) V2: :stuck_out_tongue_winking_eye:
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-dev.yunohost.org/ci/ap...
[08:50:00]
<florent> Hmm, that being said, it may be a better fit to focus first on the conversion to the V2 manifest made by eric_G. I'll rebase after his work is merged.
[08:50:53]
<Yunohost Git/Infra notifications> [my_webapp_ynh] @fflorent [commented](https://github.com/YunoHost-Apps/my_webapp_ynh/pull/101#issuecomment-1453179973) on [issue #101](https://github.com/YunoHost-Apps/my_webapp_ynh/pull/101) Allow to configure extra nginx conf in app.d/ directory: Propose to first focus on #107 and then review this.
[09:30:42]
<Guillaume Bouzige> hello
I am trying to solve some linter issue with adguardhome and running some CI test with PR https://github.com/YunoHost-Apps/adguardhome_ynh/pull/97 but I have those weird errors
```
Error: In use
Warning: Failed to restore snapshot? Retrying in 20 sec ...
Error: If this keeps happening, restarting the LXD daemon might help :| ...
```
is it normal or is it the app script that does those errors ?
[09:36:02]
<Aleks (he/him/il/lui)> yeah sorry it's a mess, the worker 7 (I think) always gets those ...
[09:36:17]
<Aleks (he/him/il/lui)> we should cleanup stuff to get rid of this
[09:36:30]
<Aleks (he/him/il/lui)> but in the meantime just restart the job and hope it runs on another worker :/
[09:36:38]
<Guillaume Bouzige> no worry, where can I get infos to build my own CI, it is yunorunner stuf right ?
[09:38:05]
<Aleks (he/him/il/lui)> yeah, yunorunner is sort of a web ui / job manager for package_check
[09:38:21]
<Aleks (he/him/il/lui)> the hard part is having a machine on which you can safely deploy LXD
[09:38:40]
<Guillaume Bouzige> VM wont do it ?
[09:38:51]
<Aleks (he/him/il/lui)> or rather even a *YunoHost*, on which you'll install LXD and Yunorunner
[09:38:51]
<Guillaume Bouzige> qemu/libvirt based
[09:39:06]
<Aleks (he/him/il/lui)> VM, qemu, libvirt, VPS, whatever
[09:39:12]
<Aleks (he/him/il/lui)> just a "non-production" machine ;P
[09:39:49]
<Guillaume Bouzige> yup. so yunohost + LXD + yunorunner right ?
[09:46:25]
<Aleks (he/him/il/lui)> yup
[09:46:46]
<Aleks (he/him/il/lui)> ooor actually
[09:47:12]
<Aleks (he/him/il/lui)> - well first of all the install process still needs to be a bit smoothen for the context of "people deploying their own yunorunner stack" :P
[09:47:19]
<Aleks (he/him/il/lui)> - install YunoHost
[09:47:33]
<Aleks (he/him/il/lui)> - Install yunorunner_ynh (yeah 👀) https://github.com/YunoHost-Apps/yunorunner_ynh
[09:48:37]
<Aleks (he/him/il/lui)> - `cd /var/www/yunorunner/` and run `bash maintenance/finish_install.sh` which will install LXD and do a bunch of other things such as disabling "unecessary" services in the context of a CI server (such as yunohost-api, php-fpm, ...)
[09:48:48]
<Aleks (he/him/il/lui)> (cf https://github.com/YunoHost/yunorunner/blob/master/maintenance/finish_install.sh )
[09:49:33]
<Aleks (he/him/il/lui)> ah it will also add the LXD remote to be able to fetch the "dev base img" (= LXC images with yunohost preinstalled, used by package_check)
[10:00:27]
<Guillaume Bouzige> ok great. I will follow those guidelines. thanks
[10:07:51]
<Guillaume Bouzige> another question not related. how can I install a previous version of a yunohost app ?
[10:13:07]
<Aleks (he/him/il/lui)> hmmm you can probably jump to the corresponding commit and for example `yunohost app install https://github.com/YunoHost-Apps/wordpress_ynh/tree/c7b8716cb052c99d0abb2c2cb1f587a29d59fba6`
[10:13:32]
<Guillaume Bouzige> ok thanks
[10:13:32]
<Aleks (he/him/il/lui)> or if this doesnt work, git clone the repo locally, checkout the previous commit, and then `yunohost app install /path/to/the/app/folder`
[10:24:36]
<Yunohost Git/Infra notifications> [gitlab_ynh] @kay0u created new branch packagingV2
[10:24:37]
<Yunohost Git/Infra notifications> [gitlab_ynh] @kay0u pushed 1 commit to packagingV2: convert packaging v1 to v2 [untested] ([0406947a](https://github.com/YunoHost-Apps/gitlab_ynh/commit/0406947a698cd7b1380c3a91616aa4fcd957370e))
[10:25:20]
<Yunohost Git/Infra notifications> [package_check] @kay0u edited [pull request #141](https://github.com/YunoHost/package_check/pull/141): Check ssowat conf instead of turbo parsing manifest.json or manifest.toml
[10:27:19]
<Yunohost Git/Infra notifications> [package_check] @kay0u edited [pull request #141](https://github.com/YunoHost/package_check/pull/141): Check ssowat conf instead of turbo parsing manifest.json or manifest.toml
[10:28:27]
<Yunohost Git/Infra notifications> [package_check] @alexAubin merged [pull request #141](https://github.com/YunoHost/package_check/pull/141): Check ssowat conf instead of turbo parsing manifest.json or manifest.toml
[10:28:27]
<Yunohost Git/Infra notifications> [package_check] @alexAubin pushed 2 commits to master ([9af4091505b3...d00a1ce9eae0](https://github.com/YunoHost/package_check/compare/9af4091505b3...d00a1ce9eae0))
[10:28:28]
<Yunohost Git/Infra notifications> [gitlab_ynh] @kay0u opened [pull request #213](https://github.com/YunoHost-Apps/gitlab_ynh/pull/213): convert packaging v1 to v2 [untested]
[10:28:29]
<Yunohost Git/Infra notifications> [package_check] @alexAubin deleted branch check-the-ssowat-conf
[10:28:32]
<Yunohost Git/Infra notifications> [gitlab_ynh] @kay0u [commented](https://github.com/YunoHost-Apps/gitlab_ynh/pull/213#issuecomment-1453306787) on [issue #213](https://github.com/YunoHost-Apps/gitlab_ynh/pull/213) convert packaging v1 to v2 [untested]: testme
[10:28:33]
<Yunohost Git/Infra notifications> [package_check/master] Check ssowat conf instead of turbo parsing manifest.json or manifest.toml - Kay0u
[10:28:34]
<Yunohost Git/Infra notifications> [gitlab_ynh] @yunohost-bot [commented](https://github.com/YunoHost-Apps/gitlab_ynh/pull/213#issuecomment-1453306854) on [issue #213](https://github.com/YunoHost-Apps/gitlab_ynh/pull/213) convert packaging v1 to v2 [untested]: :rocket:
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-dev.yunohost.org/ci/api/job/5969/badge)](htt...
[10:28:36]
<Yunohost Git/Infra notifications> [package_check/master] Merge pull request #141 from YunoHost/check-the-ssowat-conf Check ssowat conf instead of turbo parsing manifest.json or... - Alexandre Aubin
[10:30:17]
<Aleks (he/him/il/lui)> >yunohost service add "gitlab-runsvdir" --log [34532 different files]
ogod /o\
[10:31:26]
<kayou> haha
[10:31:28]
<kayou> yeah
[10:32:22]
<kayou> ¯\_(ツ)_/¯ at least we have logs
[10:34:00]
<kayou> 🤔 why qBittorrent is not tested by ci-apps?
[10:34:43]
<kayou> it's tagged as "working" in the app catalog
[10:35:47]
<Aleks (he/him/il/lui)> 🤔
[10:53:26]
<kayou> i don't think i have ssh access to ci-apps to investigate
[10:55:23]
<Guillaume Bouzige> I have a funny error with helper ynh_add_config https://github.com/YunoHost/yunohost/blob/74180ded2279293cecb18cdedd6df8a0c0c90508/helpers/utils#L369 when I do it in cryptpad here https://github.com/YunoHost-Apps/cryptpad_ynh/blob/2ddffd382bdfb203644c99149cc7e2b4d6cdb124/scripts/upgrade#L195 I have this error `touch: cannot touch '/etc/nginx/conf.d/sandbox-office.domain2.tld.d/cryptpad.conf': No such file or directory`
[10:55:38]
<Guillaume Bouzige> I am trying to figure it ouy
[10:55:53]
<Guillaume Bouzige> *out
[10:57:28]
<kayou> ```
ynh_add_config --template="/etc/nginx/conf.d/$domain.d/cryptpad.conf" --destination="/etc/nginx/conf.d/$sandboxdomain.d/cryptpad.conf"
```
i'm a bit out of the loop, but how the nginx conf could be a template for another nginx conf?
[10:57:50]
<Guillaume Bouzige> I yeah I could just use the template from conf directory
[10:57:57]
<kayou> why not using `ynh_add_nginx_config`
[10:58:50]
<Guillaume Bouzige> because I need to surcharge the domain to the sandbox one
[10:58:51]
<Guillaume Bouzige> otherwise it takes the 'normal' domain of app
[10:59:19]
<kayou> or, cp and string replace then?
[10:59:53]
<kayou> because `ynh_add_config` wont replace the old domain to the new one
[11:00:11]
<kayou> https://yunohost.org/fr/packaging_apps_helpers#ynh-replace-string
[11:00:47]
<Guillaume Bouzige> `ynh_add_config --template="nginx.conf" --destination="/etc/nginx/conf.d/$sandboxdomain.d/$app.conf"` instead of this `ynh_add_config --template="/etc/nginx/conf.d/$domain.d/cryptpad.conf" --destination="/etc/nginx/conf.d/$sandboxdomain.d/cryptpad.conf"`
[11:01:19]
<Guillaume Bouzige> I wanna add config so using this helper seems like a great fit to me
[11:01:35]
<kayou> yes, but `__DOMAIN__` will be replaced by $domain, not $sandboxdomain
[11:02:13]
<Guillaume Bouzige> what where ?
[11:02:16]
<kayou> you could also temporary replace `domain=$sandboxdomain`
[11:02:32]
<kayou> ho no sorry, there is no __DOMAIN__ in nginx conf
[11:02:43]
<Guillaume Bouzige> I am fine with those already
[11:03:11]
<Guillaume Bouzige> I mean I got both domain and sandbox domain sets in nginx nicely
[11:04:03]
<Guillaume Bouzige> I am about to run another test to solve this `touch error`, either I try to change the first arg of ynh_add_config or I try to mkdir before calling the helper
[11:04:21]
<Guillaume Bouzige> what would be best solution i your opinion ?
[11:05:39]
<kayou> 🤔 `yunohost domain add $sandboxdomain` should create the nginx folder
[11:06:13]
<Guillaume Bouzige> hum hum hum
[11:07:59]
<Guillaume Bouzige> now I am confused
[11:08:08]
<kayou> i'm too
[11:08:53]
<Guillaume Bouzige> I think in general it is better not to use `--template=nginx.conf` instead of `--template=/etc/nginx/...`
[11:09:04]
<Guillaume Bouzige> I mean the opposite
[11:09:57]
<Guillaume Bouzige> I can start from that if there is no better idea
[11:11:01]
<kayou> i think the best you could do is something like that (but it won't solve the touch error)
```
bck_domain=$domain
domain=$sandboxdomain
ynh_add_nginx_config
domain=$bck_domain
```
[11:11:04]
<kayou> because it will handle the `sub_path_only` stuff
[11:13:55]
<Guillaume Bouzige> hhhmmm but if it wont solve the touch error why would i need that ?
[11:16:24]
<kayou> because you are talking about using `--template=nginx.conf`
[11:16:53]
<kayou> but indeed it is out of the subject
[11:17:09]
<Guillaume Bouzige> yeah well your solution could be potentially better
[11:17:22]
<Guillaume Bouzige> so I don't even need to use that helper no more
[11:17:39]
<kayou> i don't understand why the folder `/etc/nginx/conf.d/sandbox-office.domain2.tld.d/` doesn't exist
[11:18:43]
<Guillaume Bouzige> I won't be surprised somehow somewhere something check that the domain of the app has already an existing folder and since this is another domain than the main one of the app....
[11:19:07]
<Guillaume Bouzige> I am on really edgy usecase here
[11:19:20]
<kayou> do you have a modified nginx conf so the regen conf don't modify the current config, and then dont create the new folder?
[11:19:35]
<Guillaume Bouzige> i test in fresh yunohost VPS only
[11:19:41]
<kayou> meh
[11:19:43]
<Guillaume Bouzige> so no modif at all
[11:20:15]
<Guillaume Bouzige> let me try your solution of tricking domain and using helper nginx config
[11:21:02]
<kayou> because if you create this folder, it wont have the correct rights, an the `/etc/nginx/conf.d/$sandboxdomain.tld.conf` wont be present
[11:26:57]
<Guillaume Bouzige> [test is running with this https://github.com/Ddataa/cryptpad_ynh/blob/4643a6b70242fa5f8ac198de606f00e3c52150dd/scripts/upgrade#L195]
[11:30:27]
<Guillaume Bouzige> same error
[11:30:54]
<Guillaume Bouzige> `cannot touch no such file or directory`
[12:24:37]
<Guillaume Bouzige> shit
[12:49:39]
<Guillaume Bouzige> I am trying the other solution now with different `--template` option on ynh add config helper
[12:50:00]
<Guillaume Bouzige> but same error same stoy
[12:50:05]
<Guillaume Bouzige> *story
[12:50:33]
<kayou> you can: put `read` right before the the ynh_add_config line to be able to check the presence of the folder
[12:51:06]
<kayou> or try to run yunohost add $sandboxdomain manually to check if the folder exists too
[12:52:07]
<Guillaume Bouzige> I think I am gonna just mkdir and all
[12:52:46]
<kayou> wait
[12:52:54]
<Guillaume Bouzige> yes
[12:53:11]
<kayou> https://github.com/Ddataa/cryptpad_ynh/blob/4643a6b70242fa5f8ac198de606f00e3c52150dd/scripts/upgrade#L126-L129
[12:53:32]
<kayou> are you sure the script execute this command `yunohost domain add ...`
[12:54:06]
<Guillaume Bouzige> aaahhh nnooo
[12:54:09]
<kayou> ` if [ -z "$sandboxdomain" ]; then`
if the sandboxdomain var doesn't exist you can the command bellow
[12:54:18]
<Guillaume Bouzige> you must be right
[12:54:19]
<kayou> you mean -n i think
[12:54:27]
<Guillaume Bouzige> yeah I do
[12:55:00]
<Guillaume Bouzige> `if [ -n "$sandboxdomain" ]; then` like this ?
[12:55:41]
<kayou> if I understand what you are trying to do, yes
[12:56:32]
<kayou> "if the var exists, then you add the domain to yunohost"
[12:56:33]
<Guillaume Bouzige> I do this test in order to avoid creating the sandbox domain if it already exist
[12:57:35]
<Guillaume Bouzige> yes
[12:57:38]
<Guillaume Bouzige> thanks
[12:57:54]
<kayou> then you want to list domains with `yunohost domain list`
[12:57:56]
<kayou> and grep it
[12:58:22]
<Guillaume Bouzige> yeah like how ?
[12:58:57]
<Guillaume Bouzige> hum maybe I don't really need to do that...
[13:06:16]
<kayou> `yunohost domain list --output-as json | jq .domains[] | tr -d '"' | grep -qw "^domain.tld$"` should do it, if you are not afraid of complicated command for a simple check :p
[13:06:54]
<Guillaume Bouzige> how do you set a port open only on UDP and not on TCP when `ynh_app_setting_set --app=$app --key=port --value=$port` ?
[13:08:04]
<kayou> ```bash
if yunohost domain list --output-as json | jq .domains[] | tr -d '"' | grep -qw "^$sandboxdomain$";
then
...
fi
```
[13:08:27]
<kayou> ynh_app_setting_set doesn't open a port
[13:08:59]
<kayou> ```
yunohost firewall allow UDP $port
```
[13:10:00]
<Guillaume Bouzige> i see
[13:11:52]
<Guillaume Bouzige> > <@kayou:matrix.org> are you sure the script execute this command `yunohost domain add ...`
you did it, it was the issue. I have push the PR to solve upgrade of cryptpad app, I don't know if you can review so I can merge https://github.com/YunoHost-Apps/cryptpad_ynh/pull/178
[13:15:34]
<kayou> done :)
[13:16:14]
<kayou> why not testing this code with package_check btw?
[13:16:26]
<Guillaume Bouzige> how ?
[13:17:03]
<Guillaume Bouzige> ohohoh because too many troubles with the sandbox domain
[13:17:13]
<kayou> why did you put
```
# We don't test that in CI
if ! [ ${PACKAGE_CHECK_EXEC:-0} -eq 1 ]; then
```
[13:17:16]
<Guillaume Bouzige> there is nothing sets to have multiple domain on one app
[13:17:23]
<kayou> hmm ok
[13:17:29]
<Guillaume Bouzige> so many many issues it was
[13:18:49]
<kayou> at least if package check can ensure that the code runs without problems, even if the sandbox domain is not tested, it is not so bad.
[13:19:02]
<kayou> idk
[13:27:18]
<Guillaume Bouzige> I agree but it was blocking tests
[13:27:29]
<Guillaume Bouzige> ca nyou review again pls ?
[13:27:30]
<kayou> okok
[13:28:08]
<Guillaume Bouzige> I mean we could actually do it and then modif package_check to understand that it could be a normal behavior for an app
[13:28:26]
<Guillaume Bouzige> what does LGTM stands for ?
[13:28:54]
<kayou> Looks Good To Me
[13:35:47]
<Guillaume Bouzige> thanks
[14:04:14]
<kayou> why did you decreased the package version?
[14:04:51]
<Guillaume Bouzige> dunno I thought it needs the value to be changed
[14:04:57]
<Guillaume Bouzige> does it matter >
[14:04:59]
<Guillaume Bouzige> ?
[14:06:12]
<kayou> changed probably but increase. Otherwise Yunohost will not propose the update
[14:06:12]
<Guillaume Bouzige> I remembered that if you dont change the version value in manifest the upgrade wont be catch
[14:06:13]
<Guillaume Bouzige> ah ok
[14:07:12]
<kayou> if the software version is not increased, then increase the package version. If he software version is increase, put the package version to 1
[14:08:34]
<Guillaume Bouzige> i see
[14:08:49]
<Guillaume Bouzige> since the readme is auto generated, where do I modify it ?
[14:09:13]
<kayou> in the manifest
[14:09:13]
<Guillaume Bouzige> in disclaimer.md in doc folder
[14:09:24]
<kayou> only the manifest
[14:09:51]
<kayou> https://github.com/YunoHost-Apps/cryptpad_ynh/blob/4a9981f6e77750604db0e78fd8b0d76ace0bbec7/manifest.json#L9
[14:09:57]
<Guillaume Bouzige> hum there is no content from README in manifest
[14:10:35]
<Guillaume Bouzige> I want to update the disclaimer
[14:10:43]
<Guillaume Bouzige> to tell about the necessity for admin to configure DNS and certificates of sandbox domain after install/upgrade
[14:11:46]
<kayou> you can use PRE/POST_INSTALL for that: https://github.com/YunoHost/example_ynh/tree/master/doc
[14:12:24]
<Guillaume Bouzige> why I can't just edit the DISCLAIMER.md ?
[14:12:24]
<kayou> and a reminder in PRE/POST_UPGRADE i guess
[14:12:43]
<Guillaume Bouzige> aahhh voila
[14:12:43]
<kayou> you can
[14:13:01]
<kayou> but i'm not sure people read the readme before installing an app
[14:13:19]
<Guillaume Bouzige> yeah I just need the info to be there visible
[14:13:19]
<kayou> personall=é before installing an app
[14:13:33]
<kayou> personally before installing an app, i read the scripts :P
[14:13:51]
<kayou> i don't think it's a problem to duplicate this information
[14:14:46]
<Guillaume Bouzige> can you review me https://github.com/YunoHost-Apps/cryptpad_ynh/pull/179 ?
[14:16:31]
<kayou> btw, what is this sandboxdomain?
[14:18:36]
<Guillaume Bouzige> so cryptpad has always been working with both main domain and sandbox domain, it is a core aspect of their special architecture...it was never forced as mandatory by the cryptpad team until after an external security audit and version 4.12.0, they decided to make it mandatory since they were tired of repeating how important it is
[14:19:13]
<Guillaume Bouzige> I have been selfhosting cryptpad since a few years before I came upon yunohost
[14:19:53]
<Guillaume Bouzige> so I decided to dirty my hand and implement the sandbox domain into yunohost app in order to have access to last version
[14:20:43]
<Guillaume Bouzige> we got fairly blocked for months because of a bug in ssowat regarding an extra trailing slash but aleks successfully found a way to solve it then we could process to release
[14:22:07]
<Guillaume Bouzige> I saw that you did some stuff on adguardhome, do you selfhost it on some servers of yours too ?
[14:23:17]
<kayou> i use it at home
[14:24:29]
<Guillaume Bouzige> do you use DNS over HTTPS ?
[14:25:14]
<kayou> nop, but it tested it without any problem, as explained in the issue
[14:26:06]
<kayou> but I'm not sure I understand it, and maybe there are specific cases, especially with mac
[14:27:16]
<Guillaume Bouzige> yes it is
[14:28:32]
<Guillaume Bouzige> I used it for upstream DNS, like I have one adguardhome at home, one at works, one at family etc... and one upstream for all those in a VPS where I can use dns over https for those downstream ones to it...
[14:29:08]
<Guillaume Bouzige> I believe it is kind of broken now but I have to run more tests to find out...
[14:30:12]
<kayou> it's hard to test DOH --'
[14:30:45]
<kayou> i found one project on github to test it, but that's it.
[14:31:01]
<Guillaume Bouzige> well yes
[14:31:16]
<Guillaume Bouzige> I am off for now but thanks a lot for your help kayou
[14:32:19]
<kayou> np!
[17:01:49]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot pushed 10 commits to update_app_levels ([ffbcc60886fe...dae14c81a932](https://github.com/YunoHost/apps/compare/ffbcc60886fe...dae14c81a932))
[17:01:50]
<Yunohost Git/Infra notifications> [apps/update_app_levels] Update app levels according to CI results - root
[17:01:50]
<Yunohost Git/Infra notifications> [apps/update_app_levels] Create qbittorrent.png - Éric Gaspar
[17:01:50]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot opened [pull request #1641](https://github.com/YunoHost/apps/pull/1641): Update app levels according to CI results
[17:01:50]
<Yunohost Git/Infra notifications> [apps/update_app_levels] Merge pull request #1638 from YunoHost/update_app_levels Update app levels according to CI results - Éric Gaspar
[17:57:08]
<eric_G> Do we need to creat the log directory like in Mattermost:
```
# Create log directory
mkdir -p /var/log/$app
chown $app -R "/var/log/$app"
```
[17:57:51]
<kayou> i have no idea
[17:58:37]
<eric_G> I see lots of apps that add app service like so `yunohost service add $app --description="Collaboration platform built for developers" --log="/var/log/$app/$app.log"` but without creating a log dir...
[18:02:05]
<kayou> in my server there is `/var/log/mattermost/mattermost.log` and `/var/log/mattermost/notifications.log`
[18:02:25]
<kayou> accessible by everyone LUL
[18:02:38]
<kayou> ```
drwxrwxrwx 2 mattermost mattermost 4096 Dec 2 2021 .
drwxr-xr-x 25 root root 12288 Mar 1 00:00 ..
-rw-r--r-- 1 mattermost mattermost 3360447 Mar 3 17:19 mattermost.log
-rw-r--r-- 1 mattermost mattermost 5353847 Mar 2 18:23 notifications.log
```
[18:13:58]
<Aleks (he/him/il/lui)> > <@yunohostinfra:matrix.org> [apps] @yunohost-bot opened [pull request #1641](https://github.com/YunoHost/apps/pull/1641): Update app levels according to CI results
Uuuuh wut
[18:17:04]
<kayou> I think there is a problem here
[18:18:13]
<kayou> There is a lot of 404
[19:15:46]
<eric_G> I am trying to grab a fingerprint like so: `fingerprint="$(cat /etc/opt/simplex/fingerprint )"` but `__FINGERPRINT__` is not replaced in the `POST_INSTALL.md` file...
[19:15:49]
<eric_G> https://github.com/YunoHost-Apps/simplex_ynh/blob/version-2/doc/POST_INSTALLATION.md
[19:16:44]
<eric_G> https://github.com/YunoHost-Apps/simplex_ynh/blob/version-2/doc/POST_INSTALL.md
[20:00:18]
<Aleks (he/him/il/lui)> > <@ericg:matrix.org> I am trying to grab a fingerprint like so: `fingerprint="$(cat /etc/opt/simplex/fingerprint )"` but `__FINGERPRINT__` is not replaced in the `POST_INSTALL.md` file...
Hmmm do you define it as a setting though ?
[20:23:18]
<Yunohost Git/Infra notifications> [my_webapp_ynh] @narFnarF opened [issue #112](https://github.com/YunoHost-Apps/my_webapp_ynh/issues/112): Documentation doesnt explain what is the username for SFTP
[20:23:57]
<Yunohost Git/Infra notifications> [my_webapp_ynh] @narFnarF edited [issue #112](https://github.com/YunoHost-Apps/my_webapp_ynh/issues/112): Documentation doesnt explain what is the username for SFTP
[20:36:26]
<Yunohost Git/Infra notifications> [my_webapp_ynh] @narFnarF edited [issue #112](https://github.com/YunoHost-Apps/my_webapp_ynh/issues/112): Documentation doesnt explain what is the SFTP username
[20:38:14]
<Yunohost Git/Infra notifications> [my_webapp_ynh] @narFnarF [commented](https://github.com/YunoHost-Apps/my_webapp_ynh/issues/112#issuecomment-1454098419) on [issue #112](https://github.com/YunoHost-Apps/my_webapp_ynh/issues/112) Documentation doesnt explain what is the SFTP username: Update: I found that the default username is my_webapp but I have multiple instances of this app. I tried my_webapp2...
[21:28:26]
<Yunohost Git/Infra notifications> [apps] @alexAubin pushed 1 commit to master: update_app_level script: use new result endpoint ([4cab9ecc](https://github.com/YunoHost/apps/commit/4cab9ecc4565f559091fde2dc26b1e149995379d))
[21:29:41]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot pushed 1 commit to update_app_levels: Update app levels according to CI results ([03d90102](https://github.com/YunoHost/apps/commit/03d901023670921295b78bbc1b30a508469c1179))
[21:30:06]
<Yunohost Git/Infra notifications> [apps] @alexAubin closed [pull request #1641](https://github.com/YunoHost/apps/pull/1641): Update app levels according to CI results
[21:30:13]
<Yunohost Git/Infra notifications> [apps] @alexAubin deleted branch update_app_levels
[21:30:23]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot pushed 1 commit to update_app_levels: Update app levels according to CI results ([b124745c](https://github.com/YunoHost/apps/commit/b124745c98d2711e5addfadd8be8bbb388b404e0))
[21:30:24]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot created new branch update_app_levels
[21:30:24]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot opened [pull request #1642](https://github.com/YunoHost/apps/pull/1642): Update app levels according to CI results
[21:31:26]
<Yunohost Git/Infra notifications> Job [#14011](https://ci-apps.yunohost.org/ci/job/14011) for hubzilla failed miserably :(
[21:33:45]
<Yunohost Git/Infra notifications> Job [#14012](https://ci-apps.yunohost.org/ci/job/14012) for metabase failed miserably :(
[21:34:48]
<Aleks (he/him/il/lui)> eh suddently the CI starts talking ?
[21:37:35]
<Aleks (he/him/il/lui)> > <@yunohostinfra:matrix.org> [apps] @yunohost-bot opened [pull request #1642](https://github.com/YunoHost/apps/pull/1642): Update app levels according to CI results
eh a shitload of missing result ... top kek the main CI was not testing appsv2 because it's only in catalog v3
[21:40:44]
<Yunohost Git/Infra notifications> [apps] @alexAubin closed [pull request #1642](https://github.com/YunoHost/apps/pull/1642): Update app levels according to CI results
[21:40:56]
<Yunohost Git/Infra notifications> [apps] @alexAubin deleted branch update_app_levels
[21:41:03]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot pushed 1 commit to update_app_levels: Update app levels according to CI results ([f4a81657](https://github.com/YunoHost/apps/commit/f4a816570cab7c0998dc55065272171ad09383e8))
[21:41:03]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot opened [pull request #1643](https://github.com/YunoHost/apps/pull/1643): Update app levels according to CI results
[21:41:04]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot created new branch update_app_levels
[21:50:14]
<Aleks (he/him/il/lui)> https://aria.im/_matrix/media/v1/download/matrix.org/tsKPbuEqJmJCVqAcWqBIFCtR
[21:50:59]
<eric_G> > <@Alekswag:matrix.org> Hmmm do you define it as a setting though ?
am I doing this right?: https://github.com/YunoHost-Apps/simplex_ynh/blob/a9e34fc0275e1437eabe4626ef8ec3e9f3729726/scripts/install#L33-L34
[21:51:21]
<Aleks (he/him/il/lui)> yup that should work
[21:51:37]
<eric_G> ```
Success! Installation completed
Info: The operation 'Install the 'simplex' app' could not be completed. Please share the full log of this operation using the command 'yunohost log share 20230303-214655-app_install-simplex' to get help
Traceback (most recent call last):
File "/usr/bin/yunohost", line 77, in <module>
yunohost.cli(
File "/usr/lib/python3/dist-packages/yunohost/__init__.py", line 41, in cli
ret = moulinette.cli(
File "/usr/lib/python3/dist-packages/moulinette/__init__.py", line 111, in cli
Cli(
File "/usr/lib/python3/dist-packages/moulinette/interfaces/cli.py", line 507, in run
ret = self.actionsmap.process(args, timeout=timeout)
File "/usr/lib/python3/dist-packages/moulinette/actionsmap.py", line 584, in process
return func(**arguments)
File "/usr/lib/python3/dist-packages/yunohost/log.py", line 410, in func_wrapper
result = func(*args, **kwargs)
File "/usr/lib/python3/dist-packages/yunohost/app.py", line 1349, in app_install
notifications = _filter_and_hydrate_notifications(
File "/usr/lib/python3/dist-packages/yunohost/app.py", line 3135, in _filter_and_hydrate_notifications
return {
File "/usr/lib/python3/dist-packages/yunohost/app.py", line 3137, in <dictcomp>
name: _hydrate_app_template(_value_for_locale(content_per_lang), data)
File "/usr/lib/python3/dist-packages/yunohost/app.py", line 2236, in _hydrate_app_template
template = template.replace(stuff, data[varname])
TypeError: replace() argument 2 must be str, not int
```
[21:51:49]
<Aleks (he/him/il/lui)> 🤔
[21:53:23]
<Aleks (he/him/il/lui)> ah the issue is about the port i'm guessing
[21:53:44]
<Aleks (he/him/il/lui)> anyway that's indeed a bug, didnt thought about that case
[22:11:09]
<eric_G> cool that works now!
[22:15:22]
<Aleks (he/him/il/lui)> 👍️
[22:15:38]
<Aleks (he/him/il/lui)> still gotta upgrade the ci apps base img but i'm battling with the app level update and it's a huge mess @_@
[22:15:59]
<Aleks (he/him/il/lui)> and i'm in the train with unstable 4G haha
[22:16:11]
<p4p4j0hn> Hi all :)
[22:19:08]
<p4p4j0hn> Would someone please check my PR to trilium? We need to change the architecture to "all" I think. Someone reported on the forum that they were using it on armhf but they can't upgrade now.
[22:22:28]
<Aleks (he/him/il/lui)> hmmm sure but then why did you set `architectures = ['amd64']` in the first place then 😝
[22:25:05]
<p4p4j0hn> Because looking at the upstream, all the prebuilt stuff is for amd64, so as I was writing the app manifest for v2 I put it in there.
[22:26:33]
<p4p4j0hn> I don't have merge rights so it would seem that Eric is to blame as well ;-)
[22:26:41]
<eric_G> so it may not work for armhf... 😜
[22:27:46]
<p4p4j0hn> According flatrongraad it has been
[22:28:14]
<p4p4j0hn> in the forum. https://forum.yunohost.org/t/trilium-notes-hierachical-note-taking-app/15199/4
[22:29:45]
<p4p4j0hn> I would say it has been tested out there in userland so it must. The v1 package didn't seem to have any architecture limits defined.
[22:31:37]
<eric_G> I can see any binary for armhf, only a `.deb` for amd64 and I don't think the app is installing it... https://github.com/zadam/trilium/releases/tag/v0.59.1
[22:31:50]
<eric_G> *can't
[22:32:34]
<p4p4j0hn> The app is using source and npm build, no prebuilt binaries
[22:33:45]
<eric_G> ah ok
[22:34:58]
<p4p4j0hn> It was my mistake, I was looking at the prebuilt stuff when I wrote the manifest.
[22:56:09]
<Yunohost Git/Infra notifications> [apps] @alexAubin deleted branch update_app_levels
[22:56:09]
<Yunohost Git/Infra notifications> [apps] @alexAubin closed [pull request #1643](https://github.com/YunoHost/apps/pull/1643): Update app levels according to CI results
[22:57:11]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot pushed 1 commit to update_app_levels: Update app levels according to CI results ([6df3ef95](https://github.com/YunoHost/apps/commit/6df3ef956b506cca7d7e17eadddb6f368ecd54f1))
[22:57:16]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot created new branch update_app_levels
[22:57:16]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot opened [pull request #1644](https://github.com/YunoHost/apps/pull/1644): Update app levels according to CI results
[22:57:38]
<Aleks (he/him/il/lui)> :|
[22:57:50]
<p4p4j0hn> Eric, the CI image still has yunohost 11.1.12.2 and you put >=11.1.13, will that affect the testing? also, the CI seems to be failing, can't restore a snapshot https://ci-apps-dev.yunohost.org/ci/job/5982
[22:59:01]
<eric_G> not being in a hurry, we are going to be patient 😬
[22:59:26]
<p4p4j0hn> ok :-)
[23:00:58]
<p4p4j0hn> I'm supposed to be working on my income tax filing anyway :P
[23:01:30]
<Guillaume Bouzige> > <@kayou:matrix.org> ```bash
> if yunohost domain list --output-as json | jq .domains[] | tr -d '"' | grep -qw "^$sandboxdomain$";
> then
> ...
> fi
> ```
I had to use this and adapt at the end, the upgrade was failing. but it gives me a warning tho "Warning: grep: !=: No such file or directory"
[23:02:05]
<Guillaume Bouzige> https://github.com/YunoHost-Apps/cryptpad_ynh/blob/4c63efd4bd82f90f895dcc3793aa500d293f89f5/scripts/upgrade#L126
[23:04:18]
<Aleks (he/him/il/lui)> https://aria.im/_matrix/media/v1/download/matrix.org/DkJIYicBvJkQBglBAxsHPONB
[23:04:18]
<Yunohost Git/Infra notifications> [apps] @alexAubin [commented](https://github.com/YunoHost/apps/pull/1644#issuecomment-1454241478) on [issue #1644](https://github.com/YunoHost/apps/pull/1644) Update app levels according to CI results: nope nope nope nope
[23:04:19]
<Yunohost Git/Infra notifications> [apps] @alexAubin closed [pull request #1644](https://github.com/YunoHost/apps/pull/1644): Update app levels according to CI results
[23:04:24]
<Yunohost Git/Infra notifications> [apps] @alexAubin deleted branch update_app_levels
[23:04:54]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot created new branch update_app_levels
[23:04:54]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot pushed 1 commit to update_app_levels: Update app levels according to CI results ([043732ca](https://github.com/YunoHost/apps/commit/043732ca0755ac33d8b00f249a3f437411a796d8))
[23:04:55]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot opened [pull request #1645](https://github.com/YunoHost/apps/pull/1645): Update app levels according to CI results
[23:06:17]
<Guillaume Bouzige> can someone review me here https://github.com/YunoHost-Apps/cryptpad_ynh/pull/180
[23:06:53]
<Guillaume Bouzige> pls
[23:10:59]
<Yunohost Git/Infra notifications> [apps] @alexAubin edited [pull request #1645](https://github.com/YunoHost/apps/pull/1645): Update app levels according to CI results
[23:12:44]
<Yunohost Git/Infra notifications> [apps] @alexAubin pushed 1 commit to update_app_levels: Revert level changes for coin, isso, pytition ([3f4e20b0](https://github.com/YunoHost/apps/commit/3f4e20b08447749e9e3ba60006ecfa39b7908ebc))
[23:12:52]
<Aleks (he/him/il/lui)> (sooo PR 1645 should be somewhat ok)
[23:31:49]
<p4p4j0hn> @eric_G I was preparing a PR for v0.59.1 I wanted to add a warning to do a full app backup prior to upgrading because this release has a database upgrade and if the upgrade fails after the app starts up again, the backup included in the upgrade script will not be restorable
[23:32:07]
<p4p4j0hn> for trilium
[23:33:15]
<Aleks (he/him/il/lui)> if trillium is using packaging v2, a safety backup before upgrade is automatically performed by the core
[23:33:21]
<Aleks (he/him/il/lui)> (and restored if upgrade fails)
[23:40:16]
<Yunohost Git/Infra notifications> [my_webapp_ynh] @kay0u [commented](https://github.com/YunoHost-Apps/my_webapp_ynh/issues/112#issuecomment-1454268760) on [issue #112](https://github.com/YunoHost-Apps/my_webapp_ynh/issues/112) Documentation doesnt explain what is the SFTP username: It should be my_webapp__2 with two _ before the 2 . It should be explain in the mail you received after the instal...
[23:52:07]
<p4p4j0hn> The data directory isn't backed up during the trilium upgrade. If anything happened late in the upgrade process and the note database was already upgraded, the pre-upgrade backup is useless.
[23:53:01]
<p4p4j0hn> 0.59.1 includes one of these database upgrades. Which is why the user should be warned to make a full backup.