Tuesday, July 04, 2023
apps@conference.yunohost.org
July
Mon Tue Wed Thu Fri Sat Sun
          1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
           

[03:12:01] <Yunohost Git/Infra notifications> App duniter goes down from level 8 to 6 in job [#16813](https://ci-apps.yunohost.org/ci/job/16813)
[05:46:52] <Yunohost Git/Infra notifications> App jeedom goes down from level 8 to 6 in job [#16816](https://ci-apps.yunohost.org/ci/job/16816)
[06:24:01] <Yunohost Git/Infra notifications> [gitlab_ynh] @kay0u pushed 5 commits to packagingV2 ([42cbd4e2bdab...847528368e25](https://github.com/YunoHost-Apps/gitlab_ynh/compare/42cbd4e2bdab...847528368e25))
[06:24:05] <Yunohost Git/Infra notifications> [gitlab_ynh/packagingV2] 16.1.1, add bookworm support - Kay0u
[06:24:05] <Yunohost Git/Infra notifications> [gitlab_ynh] @yunohost-bot pushed 1 commit to packagingV2: Auto-update README ([c0839409](https://github.com/YunoHost-Apps/gitlab_ynh/commit/c0839409ad730e4dd7996bb515be2f26ecbb02dd))
[06:24:09] <Yunohost Git/Infra notifications> [gitlab_ynh/packagingV2] Auto-update README - yunohost-bot
[06:24:10] <Yunohost Git/Infra notifications> [gitlab_ynh/packagingV2] Merge branch testing into packagingV2 - Kay0u
[06:27:13] <Yunohost Git/Infra notifications> [gitlab_ynh] @kay0u pushed 1 commit to packagingV2: 16.1.1 in manifest.toml ([2e64b4c5](https://github.com/YunoHost-Apps/gitlab_ynh/commit/2e64b4c5eeea009a155bbe097405cefd7810bc8a))
[06:27:17] <Yunohost Git/Infra notifications> [gitlab_ynh] @yunohost-bot pushed 1 commit to packagingV2: Auto-update README ([8da448e8](https://github.com/YunoHost-Apps/gitlab_ynh/commit/8da448e80cc77b2a7e6e0537fae0369ee1079ce6))
[08:22:12] <Yunohost Git/Infra notifications> App seafile failed all tests in job [#16821](https://ci-apps.yunohost.org/ci/job/16821) :(
[09:47:33] <@rosbeefandino:3cmr.fr> Hi ! In conf panel are getter/setter called even if hidden?
[09:58:40] <Yunohost Git/Infra notifications> App technitium-dns rises from level 7 to 8 in job [#16825](https://ci-apps.yunohost.org/ci/job/16825) !
[10:17:56] <Yunohost Git/Infra notifications> App libreto rises from level 2 to 7 in job [#16826](https://ci-apps.yunohost.org/ci/job/16826) !
[10:39:39] <@rosbeefandino:3cmr.fr> And are alternative fields data values accessible thrue other getter/setter ? (Are all fields values global )

And is a field require, "mandatory", a setter ? Do I need to create it and if yes could it be blank ?
[11:04:08] <Yunohost Git/Infra notifications> App humhub rises from level 6 to 8 in job [#16827](https://ci-apps.yunohost.org/ci/job/16827) !
[11:30:26] <Yunohost Git/Infra notifications> [gitlab_ynh] @kay0u pushed 1 commit to packagingV2: fix upgrade ([0b343c20](https://github.com/YunoHost-Apps/gitlab_ynh/commit/0b343c207420f721cd835af377bf43f67e79a6eb))
[11:32:29] <Aleks (he/him/il/lui)> > <@yunohostinfra:matrix.org> [gitlab_ynh] @kay0u pushed 1 commit to packagingV2: fix upgrade ([0b343c20](https://github.com/YunoHost-Apps/gitlab_ynh/commit/0b343c207420f721cd835af377bf43f67e79a6eb))

hmmm are you sure it's necessary ? 🤔 https://github.com/YunoHost/yunohost/blob/dev/src/utils/resources.py#L1177
[11:33:02] <kayou> i have an issue with packaging v2, especially with the upgrade part:

gitlab uses several ports

https://github.com/YunoHost-Apps/gitlab_ynh/blob/8da448e80cc77b2a7e6e0537fae0369ee1079ce6/manifest.toml#L77-L80
the "upgrade from an older version" test fails because the new ports conflicts each other: `sidekiq_port` and `puma_port` are both at `8084`
Is there anything i can do in my side to fix it?
[11:33:03] <kayou> haha
[11:33:13] <kayou> i was writing something about that
[11:33:35] <Aleks (he/him/il/lui)> :D
[11:34:40] <kayou> i have an issue for the automigration then
[11:35:26] <kayou> because the new ports are not defined with the old values
[11:37:34] <Aleks (he/him/il/lui)> eeeh
[11:38:05] <Aleks (he/him/il/lui)> do you have a log or something
[11:38:37] <kayou> about that piece of code? no because there is no log for ressources (?)
[11:38:48] <kayou> but i'll put some debug in that part and run the migration again
[11:39:33] <kayou> pointing out this part of the code is a good start and a great help
[11:42:03] <Aleks (he/him/il/lui)> or some log showing the v1->v2 crashing because of this even though there's no full debug info available or idk
[11:42:35] <kayou> https://ci-apps-dev.yunohost.org/ci/job/7592
[11:44:18] <kayou> it's hard to tell that the issue is that ports, but i did the migration manually on ynh-dev
[11:44:36] <Aleks (he/him/il/lui)> oh okay
[11:44:53] <kayou> and I found out that the ports are the same
[11:45:33] <Aleks (he/him/il/lui)> ah `web_port` becomes just `port` ? that might be related ?
[11:45:45] <Aleks (he/him/il/lui)> ooor maybe not 😅
[11:45:50] <kayou> hmm
[11:46:05] <kayou> could be
[11:59:42] <kayou> ```
INFO Provisionning ports...
WARNING port_main: None
WARNING port_puma: None
WARNING puma_port: None
WARNING port_sidekiq: None
WARNING sidekiq_port: None
```

[11:59:58] <Aleks (he/him/il/lui)> uuuh
[12:00:17] <kayou> ```
for name, infos in self.ports.items():
setting_name = f"port_{name}" if name != "main" else "port"
port_value = self.get_setting(setting_name)
logger.warning(f"port_{name}: {port_value}")
if not port_value and name != "main":
# Automigrate from legacy setting foobar_port (instead of port_foobar)
legacy_setting_name = "{name}_port"
port_value = self.get_setting(legacy_setting_name)
logger.warning(f"{name}_port: {port_value}")
if port_value:
self.set_setting(setting_name, port_value)
self.delete_setting(legacy_setting_name)
continue
```
[12:00:37] <kayou> i just added some `logger.warning`
[12:01:11] <Aleks (he/him/il/lui)> yeah
[12:01:26] <Aleks (he/him/il/lui)> but then im confused as to how all of these can be None x_x
[12:16:08] <kayou> ^https://github.com/YunoHost/yunohost/commit/36a17dfdbd611c0072b4dad71b4c4f07506713b5
[12:40:22] <Aleks (he/him/il/lui)> oh
[12:40:23] <Aleks (he/him/il/lui)> lord
[12:40:23] <Aleks (he/him/il/lui)> my
[12:40:40] <kayou> https://github.com/YunoHost/yunohost/blob/36a17dfdbd611c0072b4dad71b4c4f07506713b5/src/app.py#L1896-L1897
[12:40:59] <Aleks (he/him/il/lui)> uuuh
[12:41:03] <Aleks (he/him/il/lui)> wut
[12:41:04] <Aleks (he/him/il/lui)> nope
[12:41:04] <kayou> I'm looking for another string in the code
[12:41:07] <kayou> and i don't understand these lines
[12:41:20] <Aleks (he/him/il/lui)> i think that one is hydrated later
[12:41:30] <kayou> what is {entity] here?
[12:41:35] <kayou> hmm ok
[12:41:56] <kayou> ha yes, because it's a template^^
[12:41:56] <Aleks (he/him/il/lui)> `entity` is a generic word because there are now config panels for apps, domains, global settings
[12:42:42] <kayou> ok then
[12:43:21] <kayou> I haven't found any other errors of this type
[12:43:38] <Aleks (he/him/il/lui)> cool 😅
[12:45:19] <kayou> well, my `web_port` which becomes `port` I don't really know what to do with it, maybe I'll keep
```
if [ -n $(ynh_app_setting_get --app=$app --key=web_port) ]
then
ynh_app_setting_set --app=$app --key=port --value=$(ynh_app_setting_get --app=$app --key=web_port)
ynh_app_setting_delete --app=$app --key=web_port
fi
```
[12:45:58] <Aleks (he/him/il/lui)> yeah i guess that's okay
[12:46:11] <Aleks (he/him/il/lui)> though ultimately i don't think it matters that much if you change the port anyway
[12:46:22] <Aleks (he/him/il/lui)> like it should only matter if there's some hardcoded value somewhere
[12:46:33] <Aleks (he/him/il/lui)> but eg the nginx conf is supposed to be regenerated with the new value anyway
[12:46:37] <kayou> yeah, it's just to keep the settings.yml small and without any old unused value
[12:46:44] <Aleks (he/him/il/lui)> 👍️
[12:55:16] <Yunohost Git/Infra notifications> [gitlab_ynh] @kay0u pushed 1 commit to packagingV2: fix the migration from packaging v1 to v2 ([d1cfb251](https://github.com/YunoHost-Apps/gitlab_ynh/commit/d1cfb2510c2eeae4dad672fcbc0de3bcb7f5cf87))
[13:00:49] <Yunohost Git/Infra notifications> App ampache goes down from level 8 to 6 in job [#16829](https://ci-apps.yunohost.org/ci/job/16829)
[13:14:50] <Yunohost Git/Infra notifications> [nextcloud_ynh] @kay0u pushed 6 commits to 27.0.0 ([860a01830b0f...52a302e2c6a5](https://github.com/YunoHost-Apps/nextcloud_ynh/compare/860a01830b0f...52a302e2c6a5))
[13:14:57] <Yunohost Git/Infra notifications> [nextcloud_ynh/27.0.0] Auto-update README - yunohost-bot
[13:14:57] <Yunohost Git/Infra notifications> [nextcloud_ynh] @yunohost-bot pushed 1 commit to 27.0.0: Auto-update README ([2cb9a21d](https://github.com/YunoHost-Apps/nextcloud_ynh/commit/2cb9a21dfa5e9a85d0651eb759bf922e71ac5444))
[13:14:59] <Yunohost Git/Infra notifications> [nextcloud_ynh/27.0.0] Merge pull request #585 from YunoHost-Apps/testing Testing - Éric Gaspar
[13:15:04] <Yunohost Git/Infra notifications> [nextcloud_ynh/27.0.0] Merge branch testing into 27.0.0 - Kayou
[13:15:09] <Yunohost Git/Infra notifications> [nextcloud_ynh] @kay0u approved [pull request #586](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/586#pullrequestreview-1512871435) 27.0.0: Tested on my side too
[13:15:17] <Aleks (he/him/il/lui)> 27.0 already ? 🙀
[13:25:27] <Yunohost Git/Infra notifications> [wordpress_ynh] @kay0u approved [pull request #219](https://github.com/YunoHost-Apps/wordpress_ynh/pull/219#pullrequestreview-1512890551) Packaging v2 and v6.2.2: LGMT
[13:33:20] <Yunohost Git/Infra notifications> [package_linter] @alexAubin pushed 2 commits to master ([809c45601d9d...6a5c346ecd2a](https://github.com/YunoHost/package_linter/compare/809c45601d9d...6a5c346ecd2a))
[13:33:30] <Yunohost Git/Infra notifications> [package_linter/master] Report http->https redirection as warning instead of info for app packaging v2 - Alexandre Aubin
[13:33:30] <Yunohost Git/Infra notifications> [package_linter/master] nginx: complain about using http_host rather than host - Alexandre Aubin
[13:37:02] <Yunohost Git/Infra notifications> [package_linter] @tituspijean [commented](https://github.com/YunoHost/package_linter/pull/103#issuecomment-1620267785) on [issue #103](https://github.com/YunoHost/package_linter/pull/103) Change web applications location policy: We will rather move to a global /apps directory, as per https://github.com/YunoHost/issues/issues/1936.
[13:37:05] <Yunohost Git/Infra notifications> [package_linter] @tituspijean closed [pull request #103](https://github.com/YunoHost/package_linter/pull/103): Change web applications location policy
[13:37:07] <Yunohost Git/Infra notifications> [package_linter] @tituspijean deleted branch webapp-location
[13:39:22] <kayou> should it be `$upgrade` instead of `$http_upgrade`
https://github.com/YunoHost-Apps/gitlab_ynh/blob/d1cfb2510c2eeae4dad672fcbc0de3bcb7f5cf87/conf/nginx.conf#L22
[13:39:24] <kayou> ?
[13:41:09] <kayou> hmm $upgrade doesn't exist
[13:42:47] <Aleks (he/him/il/lui)> 😬
[13:43:40] <Yunohost Git/Infra notifications> [gitlab_ynh] @kay0u pushed 1 commit to packagingV2: http_host -> host ([59a6543a](https://github.com/YunoHost-Apps/gitlab_ynh/commit/59a6543a7778040cb42e3317d185eb5ba86bcf77))
[14:44:48] <tituspijean[m]> (hmmm nope: https://developer.mozilla.org/fr/docs/Web/HTTP/Headers/Connection, only "keep-alive" or "close" xD)
[14:44:48] <tituspijean[m]> seems ok according to https://stackoverflow.com/questions/61516838/what-happens-if-i-include-upgrade-and-connection-headers-on-http-requests-th
[14:44:48] <Yunohost Git/Infra notifications> App jeedom goes down from level 8 to 6 in job [#16830](https://ci-apps.yunohost.org/ci/job/16830)
[14:44:48] <tituspijean[m]> (basically it's up to the client to allow the upgrade with that header, and I'm guessing the server allows it with `Connection $connection_upgrade`, but I'm trying to find a source confirming that)
[15:25:34] <Aleks (he/him/il/lui)> Is it okay if we drop the `--dedicated_service` of ynh_add_fpm_config in bookworm ? The only app using it is pihole x_x ...
[15:54:55] <tituspijean[m]> I see no problem with that app 🙃 Joke aside, that's actually something I wondered. Wouldn't it be cleaner to enforce that to all apps?
Like, if Nextcloud or Wordpress is too resource-consuming, then its service would be killed, not all the other services.
And logs management would be cleaner too. We could directly integrate the PHP logs with the apps logs with no filtering or whatever.
[15:54:55] <Aleks (he/him/il/lui)> yes, that was the argument a while ago when it was created
[15:55:08] <Aleks (he/him/il/lui)> and at the time we sort of acted that this should be the de-facto standard
[15:55:15] <Aleks (he/him/il/lui)> but in the end only pihole implemented it
[15:55:24] <Aleks (he/him/il/lui)> so hmpf i'd say we just drop it ...
[15:55:45] <tituspijean[m]> could we implement it through... *packaging v2*? 😇
[15:55:46] <Aleks (he/him/il/lui)> things are working okay-ish regarding resources etc
[15:55:46] <Aleks (he/him/il/lui)> eeeh
[15:56:03] <Aleks (he/him/il/lui)> ¯\_(ツ)_/¯ packaging v3
[15:57:00] <tituspijean[m]> fair enough 😛
[15:57:00] <Aleks (he/him/il/lui)> i'm mainly trying to cleanup the mess in `ynh_add_fpm_config` especially the unecessary complexity about `usage` / `footprint` settings ...
[15:57:44] <Aleks (he/him/il/lui)> and ended up in this huge mess with the old deprecated `--package` option, `--use_template` which nobody uses, and `--dedicated_service` and hmpf
[15:58:03] <tituspijean[m]> for the logs that would be great. Right now we ask users "to look into PHP-FPM logs", maybe not knowing which version we are talking about, or the relevant errors might be hidden the bulk of other errors or infos.
[15:58:03] <Aleks (he/him/il/lui)> even `--phpversion` has no real sense since it just grabs `$phpversion` automatically anyway
[15:58:19] <Aleks (he/him/il/lui)> so tl;dr we could just always type `ynh_add_fpm_config` with no option, end of the story
[15:58:31] <Aleks (he/him/il/lui)> > <@titus:pijean.ovh> for the logs that would be great. Right now we ask users "to look into PHP-FPM logs", maybe not knowing which version we are talking about, or the relevant errors might be hidden the bulk of other errors or infos.

yeah ...
[15:59:03] <tituspijean[m]> > <@Alekswag:matrix.org> i'm mainly trying to cleanup the mess in `ynh_add_fpm_config` especially the unecessary complexity about `usage` / `footprint` settings ...

what do you think about it? Allowing direct figures to be implemented?
[15:59:03] <Aleks (he/him/il/lui)> it should just default to `low` by default, and then we let the user customize this through a config panel
[15:59:24] <Aleks (he/him/il/lui)> but packagers shouldn't have to deal with the mess of initializing settings, and then checking if they exist during upgrade etc...
[16:00:00] <tituspijean[m]> > <@Alekswag:matrix.org> but packagers shouldn't have to deal with the mess of initializing settings, and then checking if they exist during upgrade etc...

oh yeah...
[16:00:00] <Aleks (he/him/il/lui)> and if you really want to have it to medium / high by default, just initialize `fpm_usage` / `fpm_footprint` setting with the corresponding value
[16:00:30] <Aleks (he/him/il/lui)> anyway, PR incoming
[16:16:19] <Aleks (he/him/il/lui)> https://github.com/YunoHost/yunohost/pull/1684
[16:16:20] <tituspijean[m]> fine for me 🙂
[16:49:23] <Yunohost Git/Infra notifications> [wordpress_ynh] @ericgaspar pushed 1 commit to testing: Update scripts/install Co-authored-by: Alexandre Aubin <alex.aubin@mailoo.org> ([ff1a645b](https://github.com/YunoHost-Apps/wordpress_ynh/commit/ff1a645b4864c9d036ac4c5a746aced37df3c48a))
[16:49:24] <Yunohost Git/Infra notifications> [wordpress_ynh] @ericgaspar dismissed review [pull request #219](https://github.com/YunoHost-Apps/wordpress_ynh/pull/219#pullrequestreview-1512890551): Packaging v2 and v6.2.2
[16:49:33] <Yunohost Git/Infra notifications> [wordpress_ynh] @ericgaspar [commented](https://github.com/YunoHost-Apps/wordpress_ynh/pull/219#issuecomment-1620531225) on [issue #219](https://github.com/YunoHost-Apps/wordpress_ynh/pull/219) Packaging v2 and v6.2.2: testme
[16:49:34] <Yunohost Git/Infra notifications> [wordpress_ynh] @yunohost-bot [commented](https://github.com/YunoHost-Apps/wordpress_ynh/pull/219#issuecomment-1620531257) on [issue #219](https://github.com/YunoHost-Apps/wordpress_ynh/pull/219) Packaging v2 and v6.2.2: :sunflower:
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-dev.yunohost.org/ci/api/job/8061/badge)](...
[16:50:08] <Yunohost Git/Infra notifications> [nextcloud_ynh] @ericgaspar pushed 5 commits to testing ([5dcd677159a9...c60ba00136b7](https://github.com/YunoHost-Apps/nextcloud_ynh/compare/5dcd677159a9...c60ba00136b7))
[16:50:09] <Yunohost Git/Infra notifications> [nextcloud_ynh] @ericgaspar merged [pull request #586](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/586): 27.0.0
[16:50:13] <Yunohost Git/Infra notifications> [nextcloud_ynh] @ericgaspar deleted branch 27.0.0
[16:50:15] <Yunohost Git/Infra notifications> [nextcloud_ynh/testing] Merge branch testing into 27.0.0 - Kayou
[16:50:17] <Yunohost Git/Infra notifications> [nextcloud_ynh/testing] Auto-update README - yunohost-bot
[16:50:21] <Yunohost Git/Infra notifications> [nextcloud_ynh/testing] Merge pull request #586 from YunoHost-Apps/27.0.0 27.0.0 - Éric Gaspar
[16:51:38] <Yunohost Git/Infra notifications> [nextcloud_ynh] @ericgaspar opened [pull request #589](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/589): Testing
[16:52:31] <Yunohost Git/Infra notifications> [nextcloud_ynh] @ericgaspar edited [pull request #589](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/589): Testing
[16:52:32] <Yunohost Git/Infra notifications> [nextcloud_ynh] @ericgaspar [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/589#issuecomment-1620534328) on [issue #589](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/589) Testing: testme
[16:52:32] <Yunohost Git/Infra notifications> [nextcloud_ynh] @yunohost-bot [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/589#issuecomment-1620534351) on [issue #589](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/589) Testing: :rocket:
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-dev.yunohost.org/ci/api/job/8062/badge)](htt...
[18:42:58] <Yunohost Git/Infra notifications> [nextcloud_ynh] @ericgaspar pushed 6 commits to v2 ([fd0bd8b95598...cef10a7d5f3a](https://github.com/YunoHost-Apps/nextcloud_ynh/compare/fd0bd8b95598...cef10a7d5f3a))
[18:42:59] <Yunohost Git/Infra notifications> [nextcloud_ynh/v2] Auto-update README - yunohost-bot
[18:42:59] <Yunohost Git/Infra notifications> [nextcloud_ynh/v2] Merge pull request #586 from YunoHost-Apps/27.0.0 27.0.0 - Éric Gaspar
[18:43:00] <Yunohost Git/Infra notifications> [nextcloud_ynh/v2] Merge branch testing into v2 - Éric Gaspar
[19:06:06] <Yunohost Git/Infra notifications> App grav rises from level 6 to 8 in job [#16835](https://ci-apps.yunohost.org/ci/job/16835) !
[22:23:42] <Yunohost Git/Infra notifications> [gitlab_ynh] @yunohost-bot pushed 1 commit to autopatch-http_host: [autopatch] Fix Host and X-Forwarded-For header spoofing ([cd9f3bed](https://github.com/YunoHost-Apps/gitlab_ynh/commit/cd9f3bed76f7f58ba693fafec731aad5d550695b))
[22:23:42] <Yunohost Git/Infra notifications> [gitlab_ynh] @yunohost-bot created new branch autopatch-http_host
[22:23:42] <Yunohost Git/Infra notifications> [gitlab_ynh] @yunohost-bot opened [pull request #224](https://github.com/YunoHost-Apps/gitlab_ynh/pull/224): [autopatch] Fix Host and X-Forwarded-For header spoofing
[22:55:42] <Yunohost Git/Infra notifications> processed_http_host_summary.txt
[22:55:42] <Yunohost Git/Infra notifications> [autopatch] Fix Host and X-Forwarded-For header spoofing
has been run. Log enclosed (#=n/a, -=failed, +=success)
[23:14:33] <Aleks (he/him/il/lui)> 🤔
[23:53:40] <Yunohost Git/Infra notifications> App ztncui rises from level 7 to 8 in job [#16839](https://ci-apps.yunohost.org/ci/job/16839) !