[08:11:34]
<Yunohost Git/Infra notifications> [apps] @Salamandar [commented](https://github.com/YunoHost/apps/pull/1627#issuecomment-1646964006) on [issue #1627](https://github.com/YunoHost/apps/pull/1627) Add initial json schemas for validation of TOML app files (manifest.toml, tests.toml): This is now complete.
[08:13:53]
<Yunohost Git/Infra notifications> [gitlab_ynh] @kay0u [commented](https://github.com/YunoHost-Apps/gitlab_ynh/pull/213#issuecomment-1647402748) on [issue #213](https://github.com/YunoHost-Apps/gitlab_ynh/pull/213) convert packaging v1 to v2 [untested]: bookwormtestme
[08:14:36]
<Yunohost Git/Infra notifications> [gitlab_ynh] @yunohost-bot [commented](https://github.com/YunoHost-Apps/gitlab_ynh/pull/213#issuecomment-1647402806) on [issue #213](https://github.com/YunoHost-Apps/gitlab_ynh/pull/213) convert packaging v1 to v2 [untested]: :worm:
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-bookworm-dev.yunohost.org/ci/api/job/5/badge)]...
[08:14:46]
<lapineige> It does work https://ci-apps-bookworm-dev.yunohost.org/ci/job/6 but the bot does not anwser : https://github.com/YunoHost-Apps/wallabag2_ynh/pull/171/#issuecomment-1647425499
[08:15:57]
<tituspijean> Temporary bug I guess. You can click the badge on the test page and paste into a comment on the PR to get the same result as the bot ;)
[08:17:59]
<lapineige> It worked here : https://github.com/YunoHost-Apps/synapse-admin_ynh/pull/36#issuecomment-1647432561
[08:20:19]
<lapineige> > The app seems to require TLS anyway. Any drawback in using sendmail instead ?
🆙, any insight ?
[08:25:53]
<tituspijean> Just try it? 😅
[10:13:35]
<Salamandar> Hmmmm
[10:13:51]
<Salamandar> Question about manifest.toml
[10:14:04]
<Salamandar> When I read the doc and the code, it seems the install question type "select" requires `choices` to be a dict
[10:14:06]
<Salamandar> BUT
[10:14:41]
<Salamandar> in https://github.com/YunoHost/example_ynh/blob/master/manifest.toml it's a list 😲
[10:58:07]
<Yunohost Git/Infra notifications> App fider goes down from level 7 to 3 in job [#17315](https://ci-apps.yunohost.org/ci/job/17315)
[10:58:18]
<Yunohost Git/Infra notifications> [nextcloud_ynh] @tomdereub [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/417#issuecomment-1647672447) on [issue #417](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/417) Add notify push option: Hi, whats the status of this PR ? It seems that its quite ready to merge, does it mean that you finally decided to int...
[11:09:04]
<orhtej2> > <@Salamandar:matrix.org> in https://github.com/YunoHost/example_ynh/blob/master/manifest.toml it's a list 😲
seems like both lists and dicts are gracefully handled, i.e. here: https://github.com/YunoHost/yunohost/blob/465f6da5cd4d716bbcb802dfd742114083034235/src/utils/form.py#L787
[11:10:02]
<Salamandar> Oh i misread this part ! Thanks
[11:10:16]
<Salamandar> Although list is not handled line 797
[11:10:16]
<Salamandar> Alright i edit the schema file
[11:10:16]
<Salamandar> 779†
[11:10:16]
<Salamandar> But it should be OK
[11:43:52]
<Yunohost Git/Infra notifications> App mediawiki failed all tests in job [#17317](https://ci-apps.yunohost.org/ci/job/17317) :(
[13:12:26]
<Aleks (he/him/il/lui)> > <@Salamandar:matrix.org> Alright i edit the schema file
cheers for that o/
[13:12:51]
<Aleks (he/him/il/lui)> i'm testing it with the hope to run it on all currently existing .toml manifests to see if we can spot boring corner cases
[13:13:14]
<Aleks (he/him/il/lui)> i see that apparently the new version doesn't like the choices-as-list anymore and wants a dict all the time ?
[13:13:21]
<Aleks (he/him/il/lui)> not sure how to create an "or" thingy 😬
[13:39:22]
<Aleks (he/him/il/lui)> https://github.com/YunoHost-Apps/uptime-kuma_ynh/blob/master/manifest.toml#L32 hmmmm i'm confused if `full_domain` is an actual thing or not in the end ...
[13:40:50]
<Aleks (he/him/il/lui)> yeah nope it's detected automagically ... https://github.com/YunoHost/yunohost/blob/dev/src/app.py#L2825
[13:49:37]
<Yunohost Git/Infra notifications> [apps] @alexAubin approved [pull request #1627](https://github.com/YunoHost/apps/pull/1627#pullrequestreview-1543510881) Add initial json schemas for validation of TOML app files (manifest.toml, tests.toml): Feedback after running on all the current manifest.toml in the wild, excited to integrate this in example_ynh and linter...
[13:49:37]
<Yunohost Git/Infra notifications> [apps] @alexAubin [commented](https://github.com/YunoHost/apps/pull/1627#discussion_r1272276632) on pull request #1627 Add initial json schemas for validation of TOML app files (manifest.toml, tests.toml): suggestion "required": ["license"], Unfortunately we cant make those mandatory because some small p...
[13:49:38]
<Yunohost Git/Infra notifications> [apps] @alexAubin [commented](https://github.com/YunoHost/apps/pull/1627#discussion_r1272287286) on pull request #1627 Add initial json schemas for validation of TOML app files (manifest.toml, tests.toml): Unfortunately this can be a boolean or "TCP" / "UDP"
[13:49:39]
<Yunohost Git/Infra notifications> [apps] @alexAubin [commented](https://github.com/YunoHost/apps/pull/1627#discussion_r1272277759) on pull request #1627 Add initial json schemas for validation of TOML app files (manifest.toml, tests.toml): Unfortunately we should also allow regular list of strings i think ? :grimacing: Dunno how complex it is to allow both ...
[13:49:39]
<Yunohost Git/Infra notifications> [apps] @alexAubin [commented](https://github.com/YunoHost/apps/pull/1627#discussion_r1272278551) on pull request #1627 Add initial json schemas for validation of TOML app files (manifest.toml, tests.toml): suggestion "show_tile": {
[13:49:40]
<Yunohost Git/Infra notifications> [apps] @alexAubin [commented](https://github.com/YunoHost/apps/pull/1627#discussion_r1272284344) on pull request #1627 Add initial json schemas for validation of TOML app files (manifest.toml, tests.toml): So eeeh we should also have example in here I think, which is often use (though less than before because its not rele...
[13:49:40]
<Yunohost Git/Infra notifications> [apps] @alexAubin [commented](https://github.com/YunoHost/apps/pull/1627#discussion_r1272285021) on pull request #1627 Add initial json schemas for validation of TOML app files (manifest.toml, tests.toml): Aaaand possibly an optional = True or False key ?
[13:49:40]
<Yunohost Git/Infra notifications> [apps] @alexAubin [commented](https://github.com/YunoHost/apps/pull/1627#discussion_r1272291911) on pull request #1627 Add initial json schemas for validation of TOML app files (manifest.toml, tests.toml): suggestion "^[a-z][a-z0-9_-]*": { Some sources have - in their names
[14:12:05]
<Yunohost Git/Infra notifications> [example_ynh] @alexAubin pushed 3 commits to simplified-add-fpm-config ([66481a81e0b8^...2d7a1239f0d0](https://github.com/YunoHost/example_ynh/compare/66481a81e0b8^...2d7a1239f0d0))
[14:12:08]
<Yunohost Git/Infra notifications> [example_ynh] @alexAubin created new branch simplified-add-fpm-config
[14:12:08]
<Yunohost Git/Infra notifications> [example_ynh/simplified-add-fpm-config] extra_php - Éric Gaspar
[14:12:12]
<Yunohost Git/Infra notifications> [example_ynh/simplified-add-fpm-config] fix - Éric Gaspar
[14:12:12]
<Yunohost Git/Infra notifications> [example_ynh/simplified-add-fpm-config] fpm config: cf YunoHost 11.2, remove the necessity to handle fpm_usage / footprint manually - Alexandre Aubin
[14:13:15]
<Yunohost Git/Infra notifications> [example_ynh] @alexAubin opened [pull request #210](https://github.com/YunoHost/example_ynh/pull/210): Simplified add fpm config
[14:42:58]
<Yunohost Git/Infra notifications> [nextcloud_ynh] @oleole39 opened [issue #590](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/590): Specific incompatibility of a NC app (e.g. Mail) blocks overall NC upgrade without explicit warning
[16:15:09]
<Yunohost Git/Infra notifications> [apps] @Salamandar [commented](https://github.com/YunoHost/apps/pull/1627#discussion_r1272424111) on pull request #1627 Add initial json schemas for validation of TOML app files (manifest.toml, tests.toml): Ooooops :)
[16:15:09]
<Yunohost Git/Infra notifications> [apps] @Salamandar [commented](https://github.com/YunoHost/apps/pull/1627#discussion_r1272423745) on pull request #1627 Add initial json schemas for validation of TOML app files (manifest.toml, tests.toml): Ah I already fixed it but not pushed yet ^^
[16:15:09]
<Yunohost Git/Infra notifications> [apps] @Salamandar [commented](https://github.com/YunoHost/apps/pull/1627#discussion_r1272425672) on pull request #1627 Add initial json schemas for validation of TOML app files (manifest.toml, tests.toml): OK, no problem
[16:15:09]
<Yunohost Git/Infra notifications> [apps] @Salamandar [commented](https://github.com/YunoHost/apps/pull/1627#discussion_r1272421660) on pull request #1627 Add initial json schemas for validation of TOML app files (manifest.toml, tests.toml): Alright :)
[16:15:09]
<Yunohost Git/Infra notifications> [apps] @Salamandar [commented](https://github.com/YunoHost/apps/pull/1627#discussion_r1272427510) on pull request #1627 Add initial json schemas for validation of TOML app files (manifest.toml, tests.toml): Well thats missing from the doc O:)
[16:15:09]
<Yunohost Git/Infra notifications> [apps] @Salamandar [commented](https://github.com/YunoHost/apps/pull/1627#discussion_r1272422192) on pull request #1627 Add initial json schemas for validation of TOML app files (manifest.toml, tests.toml): Its not complex at all, actually I support both string and list of strings for the apt packages already :)
[16:15:15]
<Yunohost Git/Infra notifications> [apps] @Salamandar [commented](https://github.com/YunoHost/apps/pull/1627#discussion_r1272433125) on pull request #1627 Add initial json schemas for validation of TOML app files (manifest.toml, tests.toml): Fixed : "example": {"type": ["string", "number", "boolean"]}, "opti...
[16:17:12]
<Yunohost Git/Infra notifications> [apps] @Salamandar [commented](https://github.com/YunoHost/apps/pull/1627#discussion_r1272433865) on pull request #1627 Add initial json schemas for validation of TOML app files (manifest.toml, tests.toml): *gasp* Alright, I have put a lot of "^[a-z][a-z0-9_]*" in the file. Should i change all of them ? Or only this one ?
[16:17:13]
<Yunohost Git/Infra notifications> [apps] @Salamandar [commented](https://github.com/YunoHost/apps/pull/1627#issuecomment-1648154793) on [issue #1627](https://github.com/YunoHost/apps/pull/1627) Add initial json schemas for validation of TOML app files (manifest.toml, tests.toml): FYI there are other linters out there I think, with tother stdout formats. Also the TOML files could be converted to jso...
[16:17:13]
<Salamandar> > <@Alekswag:matrix.org> i see that apparently the new version doesn't like the choices-as-list anymore and wants a dict all the time ?
yeah i fixed that
[16:17:46]
<Salamandar> > <@Alekswag:matrix.org> https://github.com/YunoHost-Apps/uptime-kuma_ynh/blob/master/manifest.toml#L32 hmmmm i'm confused if `full_domain` is an actual thing or not in the end ...
i asked myself the same thing :D
[16:17:46]
<Salamandar> > <@Alekswag:matrix.org> not sure how to create an "or" thingy 😬
it's done using "anyOf": [ {first possibility}, { second possibily } ]
[16:23:15]
<Aleks (he/him/il/lui)> yeaaaah i've spent so much time thinking about what to do with this ... on one hand, it would be nice to have such an explicit an clear flag, but on the other hand, it can be deduced from other infos in the manifest, so it's either "deduce it implicitly from the other infos" or "you have to check for the consistency between this info and the other stuff in the manifest" so meh i went for the first thing
[16:24:07]
<Yunohost Git/Infra notifications> [nextcloud_ynh] @oleole39 edited [issue #590](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/590): Specific incompatibility of a NC app (e.g. Mail) blocks overall NC upgrade without explicit warning
[16:27:45]
<Yunohost Git/Infra notifications> [apps] @alexAubin [commented](https://github.com/YunoHost/apps/pull/1627#discussion_r1272492289) on pull request #1627 Add initial json schemas for validation of TOML app files (manifest.toml, tests.toml): Zblerg turns out url is not required because sometimes they are only internal / pure-LDAP ... though could also be sym...
[16:27:46]
<Yunohost Git/Infra notifications> [apps] @alexAubin approved [pull request #1627](https://github.com/YunoHost/apps/pull/1627#pullrequestreview-1543822782) Add initial json schemas for validation of TOML app files (manifest.toml, tests.toml): A bunch of other minor comments, I think we can go into production after these even though therell still be a couple of...
[16:27:46]
<Yunohost Git/Infra notifications> [apps] @alexAubin [commented](https://github.com/YunoHost/apps/pull/1627#discussion_r1272475100) on pull request #1627 Add initial json schemas for validation of TOML app files (manifest.toml, tests.toml): suggestion "pattern": "^>= ?[0-9]*\\.[0-9]*\\.[0-9]*" Ideally we should allow for >= 11.x ...
[16:27:46]
<Yunohost Git/Infra notifications> [apps] @alexAubin [commented](https://github.com/YunoHost/apps/pull/1627#discussion_r1272482324) on pull request #1627 Add initial json schemas for validation of TOML app files (manifest.toml, tests.toml): Ogod theres a few ones not passing this because they have letters and dashes and stuff ... such as gamja, forgejo I w...
[16:27:47]
<Yunohost Git/Infra notifications> [apps] @alexAubin [commented](https://github.com/YunoHost/apps/pull/1627#discussion_r1272479256) on pull request #1627 Add initial json schemas for validation of TOML app files (manifest.toml, tests.toml): In addition to strategy, upstream and asset, we can have a force_version arg of type string, cf for example http...
[16:28:01]
<Yunohost Git/Infra notifications> [apps] @alexAubin [commented](https://github.com/YunoHost/apps/pull/1627#discussion_r1272475899) on pull request #1627 Add initial json schemas for validation of TOML app files (manifest.toml, tests.toml): Apparently this can also be a list of allowed groups ... not sure if thats a bug or a feature
[16:28:51]
<Yunohost Git/Infra notifications> [apps] @alexAubin [commented](https://github.com/YunoHost/apps/pull/1627#discussion_r1272494503) on pull request #1627 Add initial json schemas for validation of TOML app files (manifest.toml, tests.toml): Hmmmm idk, not hard opinion on this, Im mainly trying to check whats causing issues in existing TOML :grimacing:
[17:50:50]
<Tag> https://ci-apps-dev.yunohost.org/ci/job/8380 but it's in the install script /o\
`1455 ERROR Config panel question 'create_account' should be initialized with a value during install or upgrade.`
[17:54:06]
<Aleks (he/him/il/lui)> yeah :|
[17:55:02]
<Aleks (he/him/il/lui)> hmpf
[17:56:01]
<Aleks (he/him/il/lui)> the message is confusing, it *sounds* like it's talking about a setting, but more accurately it's talking about trying to get the value for the `create_account` stuff in the config panel
[17:56:05]
<Aleks (he/him/il/lui)> which is `bind:`-ed to the file
[17:56:21]
<Aleks (he/him/il/lui)> so my guess is that it ain't succesful in finding the value in the php conf
[17:56:37]
<Aleks (he/him/il/lui)> probably because it's not just something looking like `key=value`
[17:59:02]
<Aleks (he/him/il/lui)> anyway that's the good old confusion about "Config panel options are not meant to be stored as a setting because the truth-source is supposed to be the actual configuration file itself, but because you have to initialize/upgrade that conf file, it also needs to be a template hydrated with variables, so there's a confusion between the setting and the value inside the file itself"
[17:59:29]
<Aleks (he/him/il/lui)> I guess maybe removing the `bind` statement would be one way to solve this, which just means the truth-source is the app's setting and not the conf file
[17:59:34]
<Aleks (he/him/il/lui)> but hmpf ~_~
[18:00:51]
<Aleks (he/him/il/lui)> that actually doesn't create any issue, the whole thing about using the actual conf file as truth source versus the app setting is driven by the fact that "people may manually edit the app's conf file", to which we can also answer "fuck power users"
[18:02:58]
<Tag> Mmh we could add a `default` key in the config_panel.toml, and exports the config_panel.toml to settings at provisioning step
[18:04:39]
<Tag> So at install, we get defaults from the config_panel, and at upgrade it gets the binds
[18:05:59]
<Aleks (he/him/il/lui)> yeah, could do that ... but my jusqu'auboutiste-me also want to think about the settings which must be initialized manually but are not part of the config panel
[18:06:07]
<Aleks (he/him/il/lui)> but there are several issues overlapping
[18:06:24]
<Aleks (he/him/il/lui)> - initializing the settings (or at least variables needed to hydrate the configs)
[18:06:46]
<Aleks (he/him/il/lui)> - (upgrading the config file during upgrade, which are also handled by the config panel)
[18:07:07]
<Aleks (he/him/il/lui)> - the confusing error messages
[18:08:46]
<Aleks (he/him/il/lui)> - the fact that, in your specific case (but in others too), the `bind` magic doesn't work because the conf doesn't look like a simple `key=value` syntax, so not caught by ljf's magic regex, and the anwser to this is that you probably need to create a custom `getter` / `setter` that read/write the conf file
[18:09:47]
<Aleks (he/him/il/lui)> ooooor what could also work would be to tweak the PHP conf such that it looks something like:
```php
$creataccount = __CREATE_ACCOUNT__;
$wgGroupPermissions['*']['createaccount'] = $createaccount;
```
[18:09:54]
<Aleks (he/him/il/lui)> ooooor what could also work would be to tweak the PHP conf such that it looks something like:
```php
$createaccount = __CREATE_ACCOUNT__;
$wgGroupPermissions['*']['createaccount'] = $createaccount;
```
[18:44:16]
<Yunohost Git/Infra notifications> [apps] @alexAubin pushed 1 commit to master: autoupdate_app_sources: add debug info in matrix message ([8c7798d0](https://github.com/YunoHost/apps/commit/8c7798d0a1cad453eb15504b9c3d29f9c29be9c7))
[19:13:00]
<Yunohost Git/Infra notifications> [apps] @alexAubin pushed 1 commit to master: autoupdate_app_sources: more human-friendly messages when data type mismatch between old and new infos ([906eb7b1](https://github.com/YunoHost/apps/commit/906eb7b1bc2d6af7d0cc7acf796f22acac6d1611))