[00:30:21]
<Aleks (he/him/il/lui)> Mokay folks, as discussed in previous meeting, our teams setup in https://github.com/orgs/YunoHost-Apps/teams is a mess ... I'm proposing to simply delete every team except the few ones that seem to make sense :
- `Apps Group` : ... though I'm not even sure it's really meaningful ... there's also the concept of each individual member being Owner (vs Member) of the org ...
- `Internet Cube` : even though the project is mostly inactive but who knows
- `Matrix Bridges` : that one seems to make some sense
[08:02:16]
<Yunohost Git/Infra notifications> Job [#17327](https://ci-apps.yunohost.org/ci/job/17327) for icecoder failed miserably :(
[09:17:15]
<gredin67> is this PR going to change the way the config panel must be implemented in apps packaging ? Or will it be backward compatible ?
https://github.com/YunoHost/yunohost/pull/1677
[10:27:17]
<Aleks (he/him/il/lui)> It's supposed to be backward compatible
[11:23:10]
<Yunohost Git/Infra notifications> [apps] @tituspijean [commented](https://github.com/YunoHost/apps/pull/1627#discussion_r1273387989) on pull request #1627 Add initial json schemas for validation of TOML app files (manifest.toml, tests.toml): suggestion "pattern": "^>= ?[0-9]*(?:\\.[0-9]*)*" (untested)
[11:55:17]
<Aleks (he/him/il/lui)> > <@Alekswag:matrix.org> Mokay folks, as discussed in previous meeting, our teams setup in https://github.com/orgs/YunoHost-Apps/teams is a mess ... I'm proposing to simply delete every team except the few ones that seem to make sense :
> - `Apps Group` : ... though I'm not even sure it's really meaningful ... there's also the concept of each individual member being Owner (vs Member) of the org ...
> - `Internet Cube` : even though the project is mostly inactive but who knows
> - `Matrix Bridges` : that one seems to make some sense
(let's go then)
[11:56:44]
<orhtej2> following up on conversation on support room: does setting up `logrotate` require creating dirs prior?
compare (reported) https://github.com/YunoHost-Apps/miniflux_ynh/blob/381e2ba05c7e6386d02741341cce65d1d7ab0892/scripts/install#L69
```
drwxrw-r-- 2 root root 4096 Jan 13 2023 miniflux
```
And https://github.com/YunoHost-Apps/dendrite_ynh/blob/e510ca75af00a31fe34b69da0f221c850065dfb0/scripts/install#L132
```
drwxr-xr-x 2 dendrite root 12288 Jul 25 00:51 dendrite
```
Is any of these 'better'?
[11:57:22]
<orhtej2> original issue is:
```
Jul 25 09:44:22 logrotate[398718]: error: skipping "/var/log/miniflux/*.log" because parent directory has insecure permissions (It's world writable or writable by group which is not "root") Set "su" directive in config file to >
```
[11:58:21]
<Aleks (he/him/il/lui)> i think what you're describing is unrelated, the user issue is about the fact that it has `w` for `others`, ie it's world writable, which is not the case for what you describe for miniflux or dendrite
[11:59:00]
<orhtej2> my working setup:
```
orhtej2@circledsquareroot:~$ ls -ld /var/log/
drwxr-xr-x 19 root root 4096 Jul 23 00:00 /var/log/
```
[11:59:03]
<Aleks (he/him/il/lui)> but anyway i'd say ideally, those folders shouldnt have any "others" permission" at all, like, least priviledge principle etc
[11:59:46]
<orhtej2> > my working setup:
>
> ```
> orhtej2@circledsquareroot:~$ ls -ld /var/log/
> drwxr-xr-x 19 root root 4096 Jul 23 00:00 /var/log/
> ```
same as reported by user btw
[12:00:32]
<orhtej2> > <@Alekswag:matrix.org> i think what you're describing is unrelated, the user issue is about the fact that it has `w` for `others`, ie it's world writable, which is not the case for what you describe for miniflux or dendrite
facepalm, I see what you mean, I was sure its 755 in both cases
[12:00:46]
<Aleks (he/him/il/lui)> > my working setup:
>
> ```
> orhtej2@circledsquareroot:~$ ls -ld /var/log/
> drwxr-xr-x 19 root root 4096 Jul 23 00:00 /var/log/
> ```
that's something else, you are showing `/var/log` now
[13:51:25]
<Yunohost Git/Infra notifications> [wordpress_ynh] @alexAubin approved [pull request #219](https://github.com/YunoHost-Apps/wordpress_ynh/pull/219#pullrequestreview-1545540411) Packaging v2 and v6.2.2
[13:57:08]
<Aleks (he/him/il/lui)> > <@Alekswag:matrix.org> Mokay folks, as discussed in previous meeting, our teams setup in https://github.com/orgs/YunoHost-Apps/teams is a mess ... I'm proposing to simply delete every team except the few ones that seem to make sense :
> - `Apps Group` : ... though I'm not even sure it's really meaningful ... there's also the concept of each individual member being Owner (vs Member) of the org ...
> - `Internet Cube` : even though the project is mostly inactive but who knows
> - `Matrix Bridges` : that one seems to make some sense
Sooo done, and I also got rid of the 'Apps group' teams because it's just unecessarily confusing and redundant with the "owner" status of the organization
[14:00:37]
<Yunohost Git/Infra notifications> [apps] @Salamandar [commented](https://github.com/YunoHost/apps/pull/1627#discussion_r1273594893) on pull request #1627 Add initial json schemas for validation of TOML app files (manifest.toml, tests.toml): Fixed.
[14:04:11]
<Yunohost Git/Infra notifications> [apps] @Salamandar [commented](https://github.com/YunoHost/apps/pull/1627#discussion_r1273599920) on pull request #1627 Add initial json schemas for validation of TOML app files (manifest.toml, tests.toml): I found even better : ^>= ?[0-9]{1,2}(\.[0-9]{1,2}){0,2}
[14:06:47]
<Yunohost Git/Infra notifications> [apps] @Salamandar [commented](https://github.com/YunoHost/apps/pull/1627#discussion_r1273604877) on pull request #1627 Add initial json schemas for validation of TOML app files (manifest.toml, tests.toml): fixed
[14:07:30]
<Yunohost Git/Infra notifications> [apps] @Salamandar [commented](https://github.com/YunoHost/apps/pull/1627#discussion_r1273605817) on pull request #1627 Add initial json schemas for validation of TOML app files (manifest.toml, tests.toml): wow :D
[14:16:12]
<Yunohost Git/Infra notifications> [apps] @Salamandar [commented](https://github.com/YunoHost/apps/pull/1627#discussion_r1273618131) on pull request #1627 Add initial json schemas for validation of TOML app files (manifest.toml, tests.toml): Lets go with a simpler regex: ^[0-9]{1-3}([.-][0-9a-z]*~ynh[0-9]*
[14:19:58]
<Yunohost Git/Infra notifications> [apps] @Salamandar [commented](https://github.com/YunoHost/apps/pull/1627#issuecomment-1649937597) on [issue #1627](https://github.com/YunoHost/apps/pull/1627) Add initial json schemas for validation of TOML app files (manifest.toml, tests.toml): All issues should be fixed now.
[14:21:45]
<Aleks (he/him/il/lui)> Salamandar: \o/
[14:22:13]
<Aleks (he/him/il/lui)> last thing : is it okay if we rename the file to something like `manifest.v2.schema.json` to anticipate future formats ?
[14:22:23]
<Aleks (he/him/il/lui)> (same for `tests.v1.schema.json`)
[14:22:37]
<Yunohost Git/Infra notifications> @computablefacts forked apps to [computablefacts/ynh-apps](https://github.com/computablefacts/ynh-apps)
[14:33:01]
<Salamandar> Aleks (he/him/il/lui): please git pull again, i fixed regexes
[14:33:15]
<Salamandar> > <@Alekswag:matrix.org> last thing : is it okay if we rename the file to something like `manifest.v2.schema.json` to anticipate future formats ?
yeah, I was actually wondering about that o/
[14:35:06]
<Salamandar> done
[14:43:49]
<Aleks (he/him/il/lui)> Salamandar: hmmm the `$id` thing at the top, shouldnt it point to the raw version ?
[14:44:24]
<Aleks (he/him/il/lui)> i'm getting stacktraces in the `jsonschema` python lib, mostly because the url doesnt exists yet, but it tries to interpret the result as json anyway
[14:48:04]
<Salamandar> https://json-schema.org/understanding-json-schema/basics.html#declaring-a-unique-identifier
[14:49:21]
<Salamandar> not sure what's the best though
[14:50:03]
<Aleks (he/him/il/lui)> 🤔
[14:50:40]
<Aleks (he/him/il/lui)> ah well actually it's trying to fetch `https://github.com/YunoHost/apps/blob/master/schemas/string_or_array_of`
[14:50:43]
<Aleks (he/him/il/lui)> hmm i'm confused
[14:51:14]
<Aleks (he/him/il/lui)> sounds related to the `"$ref": "#/$defs/string_or_array_of"` thingies
[14:51:44]
<Aleks (he/him/il/lui)> ah i think that's line 279 ?
[14:51:51]
<Aleks (he/him/il/lui)> ` "$ref": "string_or_array_of"`
[14:52:04]
<Aleks (he/him/il/lui)> probably was meant to be `#/$defs/string_or_array_of` ?
[14:52:13]
<Aleks (he/him/il/lui)> the schema doesn't comform to the schema /o\
[14:56:02]
<Salamandar> ooops
[14:56:02]
<Salamandar> yeah indeed 😄
[14:56:52]
<Salamandar> fixed
[15:00:20]
<Yunohost Git/Infra notifications> [apps] @tituspijean edited a [comment](https://github.com/YunoHost/apps/pull/1627#discussion_r1273683177) on pull request #1627 Add initial json schemas for validation of TOML app files (manifest.toml, tests.toml): Buuuuut what about YunoHost v100.1.2.3.4 ? 🙃
[15:00:20]
<Yunohost Git/Infra notifications> [apps] @tituspijean [commented](https://github.com/YunoHost/apps/pull/1627#discussion_r1273683177) on pull request #1627 Add initial json schemas for validation of TOML app files (manifest.toml, tests.toml): Buuuuut what about YunoHost v100.1.2.3.4 ? 🙃
[15:35:43]
<Yunohost Git/Infra notifications> [wordpress_ynh] @ericgaspar merged [pull request #219](https://github.com/YunoHost-Apps/wordpress_ynh/pull/219): Packaging v2 and v6.2.2
[15:35:43]
<Yunohost Git/Infra notifications> [wordpress_ynh] @ericgaspar pushed 24 commits to master ([8ae328a28773...bdb20044af59](https://github.com/YunoHost-Apps/wordpress_ynh/compare/8ae328a28773...bdb20044af59))
[15:35:49]
<Yunohost Git/Infra notifications> [wordpress_ynh/master] Update scripts/install Co-authored-by: Alexandre Aubin <alex.aubin@mailoo.org> - Éric Gaspar
[15:35:51]
<Yunohost Git/Infra notifications> [wordpress_ynh/master] Update scripts/install Co-authored-by: Alexandre Aubin <alex.aubin@mailoo.org> - Éric Gaspar
[15:35:54]
<Yunohost Git/Infra notifications> [wordpress_ynh/master] Merge pull request #219 from YunoHost-Apps/testing - Éric Gaspar
[15:46:18]
<Yunohost Git/Infra notifications> [apps] @alexAubin pushed 2 commits to master ([ed9b3256bee7...117e600130b1](https://github.com/YunoHost/apps/compare/ed9b3256bee7...117e600130b1))
[15:46:22]
<Yunohost Git/Infra notifications> [apps] @alexAubin merged [pull request #1627](https://github.com/YunoHost/apps/pull/1627): Add initial json schemas for validation of TOML app files (manifest.toml, tests.toml)
[15:46:23]
<Yunohost Git/Infra notifications> [apps/master] Add initial json schemas for validation of TOML app files (manifest.toml, tests.toml) - Félix Piédallu
[15:46:26]
<Yunohost Git/Infra notifications> [apps/master] Merge pull request #1627 from Salamandar/schemas Add initial json schemas for validation of TOML app files (manifest.to... - Alexandre Aubin
[15:56:59]
<Salamandar> o/
[16:01:13]
<Yunohost Git/Infra notifications> [package_linter] @alexAubin pushed 1 commit to master: Add new schema validation for manifest v2 (only reports stuff as info for now) ([ea1f11b2](https://github.com/YunoHost/package_linter/commit/ea1f11b26be1f428568132873607d0be40c2def9))
[16:51:24]
<Salamandar> as usual, i made a mistake
[16:51:29]
<Salamandar> the $id should be https://raw.githubusercontent.com/YunoHost/apps/master/schemas/manifest.v2.schema.json
[16:51:46]
<Salamandar> \><'
[17:46:26]
<oufmilo[m]> hello you have modify something with yunorunner ?
[17:46:35]
<oufmilo[m]> i've got an error in package linter
[18:12:55]
<Tag> any logs to share with us all? 👀
[18:13:31]
<oufmilo[m]> > <@tag:lostpod.me> any logs to share with us all? 👀
https://paste.yunohost.org/ebuxolupoz.sql
[18:14:19]
<oufmilo[m]> https://paste.yunohost.org/yedimowoba.sql
[18:14:54]
<oufmilo[m]> > <@yunohostinfra:matrix.org> [package_linter] @alexAubin pushed 1 commit to master: Add new schema validation for manifest v2 (only reports stuff as info for now) ([ea1f11b2](https://github.com/YunoHost/package_linter/commit/ea1f11b26be1f428568132873607d0be40c2def9))
this commit i think
[18:15:20]
<tituspijean> Erf yes, we deployed a JSON/TOML verification earlier, without installing the proper dependencies in the CI
[18:15:32]
<Tag> > https://paste.yunohost.org/ebuxolupoz.sql
this one, I'm unsure what's the issue
[18:16:23]
<Tag> Ah
[18:16:28]
<Tag> Missing a " here https://github.com/oufmilo/calckey_ynh/blob/master/manifest.toml#L44
[18:19:13]
<tituspijean> oufmilo: you're using your own yunorunner instance, right?
[18:20:32]
<Tag> > <@titus:pijean.ovh> Erf yes, we deployed a JSON/TOML verification earlier, without installing the proper dependencies in the CI
Mmmh this should install the dependencies, right ? https://github.com/YunoHost/package_linter/commit/ea1f11b26be1f428568132873607d0be40c2def9#diff-661c3b5fe67e77caea903b5fdb903b5fb6e8277c912d4a4af94e179ade2910baR22-R26
[18:23:37]
<tituspijean> line 25 installs toml, not jsonschema, or... it's included?
[18:23:37]
<tituspijean> fixing
[18:23:37]
<tituspijean> eh looks like a bad copy and paste 😛
[18:23:53]
<Yunohost Git/Infra notifications> [package_linter] @tituspijean pushed 1 commit to fix-jsonschema: Fix jsonschema dependency installation ([e52035c5](https://github.com/YunoHost/package_linter/commit/e52035c519f845bb5f73a8288a40647db5a3676a))
[18:23:54]
<Yunohost Git/Infra notifications> [package_linter] @tituspijean created new branch fix-jsonschema
[18:24:18]
<Yunohost Git/Infra notifications> [package_linter] @tituspijean opened [pull request #114](https://github.com/YunoHost/package_linter/pull/114): Fix jsonschema dependency installation
[18:25:36]
<tituspijean> ^I can haz review Tag ?
[18:30:44]
<Yunohost Git/Infra notifications> [package_linter] @Tagadda approved [pull request #114](https://github.com/YunoHost/package_linter/pull/114#pullrequestreview-1546097773) Fix jsonschema dependency installation: Haz read, looks goude
[18:32:28]
<Yunohost Git/Infra notifications> [package_linter] @tituspijean pushed 1 commit to master: Fix jsonschema dependency installation ([0dd375db](https://github.com/YunoHost/package_linter/commit/0dd375db34ce558ee22bcf23a3b8f706f9e1f670))
[18:32:29]
<Yunohost Git/Infra notifications> [package_linter] @tituspijean merged [pull request #114](https://github.com/YunoHost/package_linter/pull/114): Fix jsonschema dependency installation
[18:32:31]
<Yunohost Git/Infra notifications> [package_linter] @tituspijean deleted branch fix-jsonschema
[19:11:24]
<oufmilo[m]> > <@titus:pijean.ovh> oufmilo: you're using your own yunorunner instance, right?
yes !
[19:19:45]
<oufmilo[m]> it's working again
[21:23:13]
<Aleks (he/him/il/lui)> > <@yunohostinfra:matrix.org> [package_linter] @tituspijean pushed 1 commit to fix-jsonschema: Fix jsonschema dependency installation ([e52035c5](https://github.com/YunoHost/package_linter/commit/e52035c519f845bb5f73a8288a40647db5a3676a))
ogod who wrote this 👀
[22:17:50]
<Yunohost Git/Infra notifications> Job [#17342](https://ci-apps.yunohost.org/ci/job/17342) for peertube_remote_runner failed miserably :(
[22:49:12]
<Krakotte> Hi, it seems that escaping characters in the regex for autoupdate in resources.sources break package_check
[22:49:39]
<Krakotte> for example, with autoupdate.asset = ".*.zip" everything runs fine
[22:49:54]
<Krakotte> with autoupdate.asset = ".*\.zip"
[22:50:12]
<Krakotte> Testing package /media/git/calibreweb_ynh/
Traceback (most recent call last):
File "/home/nicolas/package_check/./lib/parse_tests_toml.py", line 151, in <module>
test_list = build_test_list(sys.argv[1])
File "/home/nicolas/package_check/./lib/parse_tests_toml.py", line 136, in build_test_list
manifest = toml.load(open(basedir + "/manifest.toml", "r"))
File "/home/nicolas/.local/lib/python3.9/site-packages/toml/decoder.py", line 156, in load
return loads(f.read(), _dict, decoder)
File "/home/nicolas/.local/lib/python3.9/site-packages/toml/decoder.py", line 340, in loads
raise TomlDecodeError("Unbalanced quotes", original, i)
toml.decoder.TomlDecodeError: Unbalanced quotes (line 83 column 89 char 3187)
cat: '/tmp/package_check.iUjcrg/tests/*.json': Aucun fichier ou dossier de ce type
Launching new LXC ynh-appci-bullseye-amd64-stable-test-0 ...
Creating initial snapshot ynh-appci-bullseye-amd64-stable-test-0 ...
[22:51:30]
<Krakotte> (don't know if it breaks also the updater though)
[23:00:40]
<Krakotte> oups, wrong copy/paste
[23:00:45]
<Krakotte> autoupdate.asset = "calibre-web-.*\.zip"
[23:00:56]
<Krakotte> Testing package /media/git/calibreweb_ynh/
Traceback (most recent call last):
File "/home/nicolas/.local/lib/python3.9/site-packages/toml/decoder.py", line 511, in loads
ret = decoder.load_line(line, currentlevel, multikey,
File "/home/nicolas/.local/lib/python3.9/site-packages/toml/decoder.py", line 778, in load_line
value, vtype = self.load_value(pair[1], strictly_valid)
File "/home/nicolas/.local/lib/python3.9/site-packages/toml/decoder.py", line 866, in load_value
raise ValueError("Reserved escape sequence used")
ValueError: Reserved escape sequence used
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/nicolas/package_check/./lib/parse_tests_toml.py", line 151, in <module>
test_list = build_test_list(sys.argv[1])
File "/home/nicolas/package_check/./lib/parse_tests_toml.py", line 136, in build_test_list
manifest = toml.load(open(basedir + "/manifest.toml", "r"))
File "/home/nicolas/.local/lib/python3.9/site-packages/toml/decoder.py", line 156, in load
return loads(f.read(), _dict, decoder)
File "/home/nicolas/.local/lib/python3.9/site-packages/toml/decoder.py", line 514, in loads
raise TomlDecodeError(str(err), original, pos)
toml.decoder.TomlDecodeError: Reserved escape sequence used (line 73 column 1 char 2346)
cat: '/tmp/package_check.ZD57XW/tests/*.json': Aucun fichier ou dossier de ce type
Launching new LXC ynh-appci-bullseye-amd64-stable-test-0 ...
Creating initial snapshot ynh-appci-bullseye-amd64-stable-test-0 ...
[23:30:49]
<Tag> IIRC, you'll need to write `calibre-web-.*\\\.zip`
[23:32:48]
<Aleks (he/him/il/lui)> Yeah that's probably because \ is already an escape char in toml
[23:33:43]
<Tag> ooor `'''calibre-web-.*\.zip'''` but i'm not sure that's better 😁