[00:06:50]
<thatoo> Finally I have a complete bash script to install Dokos : https://github.com/Thatoo/Dokos_ynh/blob/Thatoo-bash-script-install/bash-script-install/dokos_install.sh
[00:08:51]
<thatoo> No more
```
```
```
```
```
```
```
```
```
sudo bash -c 'cat << EOF >> /etc/mysql/my.cnf
[mysqld]
character-set-client-handshake = FALSE
character-set-server = utf8mb4
collation-server = utf8mb4_unicode_ci
[mysql]
default-character-set = utf8mb4
EOF'
sudo service mysql restart
```
```
```
```
```
```
```
```
```
```
```
```
```
I tricked the command bench new-site this way :
```
```
```
```
```
```
```
#to trick the command bench new-site which check value of character_set_server and collation_server even though we created a database setting character and collation for the database itself
character_set_server=$(sudo mysql -u root -ss -N -e "SELECT VARIABLE_VALUE FROM information_schema.GLOBAL_VARIABLES WHERE variable_name ='character_set_server';")
collation_server=$(sudo mysql -u root -ss -N -e "SELECT VARIABLE_VALUE FROM information_schema.GLOBAL_VARIABLES WHERE variable_name ='collation_server';")
sudo mysql -u root -e "SET GLOBAL character_set_server = 'utf8mb4'";
sudo mysql -u root -e "SET GLOBAL collation_server = 'utf8mb4_unicode_ci'";
bench new-site $site_name --db-name $db_name --db-password $db_pwd --no-setup-db --admin-password $admin_pwd
# putting back the original value of character_set_server and collation_server
sudo mysql -u root -e "SET GLOBAL character_set_server = '$character_set_server'";
sudo mysql -u root -e "SET GLOBAL collation_server = '$collation_server'";
```
It's not very nice but it works. I hope it will work also for a Yunohost package.
If you want to talk about it, here is the discussion : https://github.com/Thatoo/Dokos_ynh/discussions/2
[00:16:32]
<Yunohost Git/Infra notifications> [apps] @alexAubin pushed 1 commit to alexAubin-patch-1: Update apps.toml: working or notworking ? .. lets say working ([53729def](https://github.com/YunoHost/apps/commit/53729defda42533fe1bfe067606ad305715260b3))
[00:16:32]
<Yunohost Git/Infra notifications> [apps] @alexAubin created new branch alexAubin-patch-1
[00:18:02]
<Yunohost Git/Infra notifications> [apps] @alexAubin pushed 1 commit to master: Update apps.toml: working or notworking ? lets say working ... ([7ac999c8](https://github.com/YunoHost/apps/commit/7ac999c81d04e32c8949673e7e1327876ccb4b35))
[00:18:14]
<Yunohost Git/Infra notifications> [apps] @alexAubin deleted branch alexAubin-patch-1
[00:18:21]
<Yunohost Git/Infra notifications> [apps] @alexAubin deleted branch add-to-wishlist-vod2podrss
[00:18:26]
<Yunohost Git/Infra notifications> [apps] @alexAubin deleted branch add-to-wishlist-reaction
[00:18:26]
<Yunohost Git/Infra notifications> [apps] @alexAubin deleted branch add-to-wishlist-immich
[00:18:27]
<Yunohost Git/Infra notifications> [apps] @alexAubin deleted branch add-to-wishlist-lago
[00:18:35]
<Yunohost Git/Infra notifications> [apps] @alexAubin deleted branch add-to-wishlist-dynamic-qr-code
[00:18:38]
<Yunohost Git/Infra notifications> [apps] @alexAubin deleted branch add-to-wishlist-maloja
[00:18:41]
<Yunohost Git/Infra notifications> [apps] @alexAubin deleted branch add-to-wishlist-bearblog
[00:18:42]
<Yunohost Git/Infra notifications> [apps] @alexAubin deleted branch add-to-wishlist-wishthis
[00:18:43]
<Yunohost Git/Infra notifications> [apps] @alexAubin deleted branch add-to-wishlist-octoprint
[00:18:45]
<Yunohost Git/Infra notifications> [apps] @alexAubin deleted branch add-to-wishlist-windmill
[00:18:46]
<Yunohost Git/Infra notifications> [apps] @alexAubin deleted branch add-to-wishlist-opentalk
[00:18:47]
<Yunohost Git/Infra notifications> [apps] @alexAubin deleted branch add-to-wishlist-voyantserver
[09:56:07]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot opened [pull request #1951](https://github.com/YunoHost/apps/pull/1951): Add Blaze to wishlist
[09:56:09]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot created new branch add-to-wishlist-blaze
[09:56:15]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot pushed 1 commit to add-to-wishlist-blaze: Add Blaze to wishlist ([58d8331a](https://github.com/YunoHost/apps/commit/58d8331a836952c1aa8b23d638abe80cb2d7754f))
[10:31:50]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot created new branch add-to-wishlist-linkace
[10:31:50]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot opened [pull request #1952](https://github.com/YunoHost/apps/pull/1952): Add LinkAce to wishlist
[10:31:52]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot pushed 1 commit to add-to-wishlist-linkace: Add LinkAce to wishlist ([e8c04b20](https://github.com/YunoHost/apps/commit/e8c04b20af34b677bb241b7286e0619c230995c7))
[10:44:11]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot created new branch add-to-wishlist-serpbear
[10:44:16]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot pushed 1 commit to add-to-wishlist-serpbear: Add SerpBear to wishlist ([a4079226](https://github.com/YunoHost/apps/commit/a407922643f8e214c41c4b806da3f74777d133f6))
[10:44:18]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot opened [pull request #1953](https://github.com/YunoHost/apps/pull/1953): Add SerpBear to wishlist
[10:50:32]
<Aleks (he/him/il/lui)> More fucking wishlist
[10:50:33]
<Aleks (he/him/il/lui)> Djeezus christ
[11:00:48]
<kayou> Why this job is stopped, but still running
https://ci-apps-dev.yunohost.org/ci/job/12382
[11:02:10]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot created new branch add-to-wishlist-password-pusher
[11:02:10]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot opened [pull request #1954](https://github.com/YunoHost/apps/pull/1954): Add Password Pusher to wishlist
[11:09:09]
<Yunohost Git/Infra notifications> [apps] @alexAubin [commented](https://github.com/YunoHost/apps/pull/1951#issuecomment-1875195623) on [issue #1951](https://github.com/YunoHost/apps/pull/1951) Add Blaze to wishlist: 4th app proposal from the same user, im tired of this shit
[11:09:09]
<Yunohost Git/Infra notifications> [apps] @alexAubin closed [pull request #1951](https://github.com/YunoHost/apps/pull/1951): Add Blaze to wishlist
[11:09:09]
<Yunohost Git/Infra notifications> [apps] @alexAubin deleted branch add-to-wishlist-password-pusher
[11:09:09]
<Yunohost Git/Infra notifications> [apps] @alexAubin deleted branch add-to-wishlist-blaze
[11:09:37]
<Yunohost Git/Infra notifications> [apps] @alexAubin [commented](https://github.com/YunoHost/apps/pull/1952#issuecomment-1875195522) on [issue #1952](https://github.com/YunoHost/apps/pull/1952) Add LinkAce to wishlist: 4th app proposal from the same user, im tired of this shit
[11:09:38]
<Yunohost Git/Infra notifications> [apps] @alexAubin deleted branch add-to-wishlist-serpbear
[11:09:38]
<Yunohost Git/Infra notifications> [apps] @alexAubin [commented](https://github.com/YunoHost/apps/pull/1953#issuecomment-1875195208) on [issue #1953](https://github.com/YunoHost/apps/pull/1953) Add SerpBear to wishlist: 4th app proposal from the same user, im tired of this shit
[11:09:38]
<Yunohost Git/Infra notifications> [apps] @alexAubin closed [pull request #1953](https://github.com/YunoHost/apps/pull/1953): Add SerpBear to wishlist
[11:09:39]
<Yunohost Git/Infra notifications> [apps] @alexAubin [commented](https://github.com/YunoHost/apps/pull/1954#issuecomment-1875194869) on [issue #1954](https://github.com/YunoHost/apps/pull/1954) Add Password Pusher to wishlist: 4th app proposal from the same user, im tired of this shit
[11:09:39]
<Yunohost Git/Infra notifications> [apps] @alexAubin deleted branch add-to-wishlist-linkace
[11:09:40]
<Yunohost Git/Infra notifications> [apps] @alexAubin closed [pull request #1952](https://github.com/YunoHost/apps/pull/1952): Add LinkAce to wishlist
[11:13:37]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot created new branch add-to-wishlist-it-tools
[11:13:37]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot opened [pull request #1955](https://github.com/YunoHost/apps/pull/1955): Add IT Tools to wishlist
[11:13:37]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot pushed 1 commit to add-to-wishlist-it-tools: Add IT Tools to wishlist ([b5aefad4](https://github.com/YunoHost/apps/commit/b5aefad4369af8e4d4374acb95396bd717a166d5))
[11:14:49]
<Yunohost Git/Infra notifications> [apps] @alexAubin closed [pull request #1955](https://github.com/YunoHost/apps/pull/1955): Add IT Tools to wishlist
[11:15:43]
<Yunohost Git/Infra notifications> [apps] @alexAubin deleted branch add-to-wishlist-it-tools
[11:15:43]
<Yunohost Git/Infra notifications> [apps] @alexAubin [commented](https://github.com/YunoHost/apps/pull/1955#issuecomment-1875204045) on [issue #1955](https://github.com/YunoHost/apps/pull/1955) Add IT Tools to wishlist: 5th app in a row from the same user...
[11:58:09]
<kayou> Add the internet to the wishlist
[12:21:46]
<tituspijean> > <@yunohostinfra:matrix.org> [apps] @alexAubin [commented](https://github.com/YunoHost/apps/pull/1955#issuecomment-1875204045) on [issue #1955](https://github.com/YunoHost/apps/pull/1955) Add IT Tools to wishlist: 5th app in a row from the same user...
Being the devil's advocate for a minute: we do not specify anywhere that we expect users to be reasonable 😕
[12:31:13]
<lapineige> Yeah, it's a whishlist, not a todo list, people might just list what they would like to see implemented, to give it some attention (hopefully), while not asking us to do it in particular or with any priority
[12:32:30]
<lapineige> (And if people think it's a todo-list, well let's just ignore them, we have a life :)
[12:37:13]
<Aleks (he/him/il/lui)> it's more than in the current process (which is inherited from the wishlist-in-the-doc era) this creates a pull request, which we are supposed to review before merging, which takes time and energy
[12:37:40]
<Aleks (he/him/il/lui)> we could also decide to go for "just committing to master without a PR", so have no curation and just moderation a posteriori
[12:38:14]
<Charles P.> on my way to create a python script to add the whole awesome-selfhosted list to wishlist
[12:56:43]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot opened [pull request #1956](https://github.com/YunoHost/apps/pull/1956): Add Llamafile to wishlist
[12:56:43]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot created new branch add-to-wishlist-llamafile
[12:56:43]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot pushed 1 commit to add-to-wishlist-llamafile: Add Llamafile to wishlist ([af6c5240](https://github.com/YunoHost/apps/commit/af6c5240513a18a115121dee8940ae105c32570b))
[13:01:56]
<eric_G> > <@Alekswag:matrix.org> we could also decide to go for "just committing to master without a PR", so have no curation and just moderation a posteriori
Well, I am in favor of merging straight to master. the curation is made by how many votes an app gets
[13:01:57]
<eric_G> and from time to time the apps with 0 votes get (automatically) removed from the list
[13:01:58]
<kayou> > <@ericg:matrix.org> Well, I am in favor of merging straight to master. the curation is made by how many votes an app gets
Until you get a crazy guy like you know who 😕
[13:08:51]
<eric_G> in the whishlist there is 120ish apps with 0 stars.
[13:13:18]
<Mateusz Szymański> > <@kayou:matrix.org> Until you get a crazy guy like you know who 😕
add `avada kedavra` to wishlist?
[13:16:12]
<Yunohost Git/Infra notifications> App cjdns failed all tests in job [#21838](https://ci-apps.yunohost.org/ci/job/21838) :(
[14:07:57]
<thatoo> > <@thatoo:defis.info> No more
> ```
>
>
> ```
>
> ```
>
>
> ```
>
> ```
>
>
> ```
>
> ```
>
>
> ```
>
> ```
> sudo bash -c 'cat << EOF >> /etc/mysql/my.cnf
> [mysqld]
> character-set-client-handshake = FALSE
> character-set-server = utf8mb4
> collation-server = utf8mb4_unicode_ci
>
> [mysql]
> default-character-set = utf8mb4
> EOF'
>
> sudo service mysql restart
> ```
>
> ```
>
>
> ```
>
> ```
>
>
> ```
>
> ```
>
>
> ```
>
> ```
>
>
> ```
>
> ```
>
>
> ```
>
> ```
>
>
> ```
>
> I tricked the command bench new-site this way :
> ```
>
>
> ```
>
> ```
>
>
> ```
>
> ```
>
>
> ```
>
> ```
> #to trick the command bench new-site which check value of character_set_server and collation_server even though we created a database setting character and collation for the database itself
> character_set_server=$(sudo mysql -u root -ss -N -e "SELECT VARIABLE_VALUE FROM information_schema.GLOBAL_VARIABLES WHERE variable_name ='character_set_server';")
> collation_server=$(sudo mysql -u root -ss -N -e "SELECT VARIABLE_VALUE FROM information_schema.GLOBAL_VARIABLES WHERE variable_name ='collation_server';")
> sudo mysql -u root -e "SET GLOBAL character_set_server = 'utf8mb4'";
> sudo mysql -u root -e "SET GLOBAL collation_server = 'utf8mb4_unicode_ci'";
>
> bench new-site $site_name --db-name $db_name --db-password $db_pwd --no-setup-db --admin-password $admin_pwd
>
> # putting back the original value of character_set_server and collation_server
> sudo mysql -u root -e "SET GLOBAL character_set_server = '$character_set_server'";
> sudo mysql -u root -e "SET GLOBAL collation_server = '$collation_server'";
> ```
>
> It's not very nice but it works. I hope it will work also for a Yunohost package.
>
> If you want to talk about it, here is the discussion : https://github.com/Thatoo/Dokos_ynh/discussions/2
[Update] Instead of tricking bench new-site modifying mysql GLOBAL VARIABLES which could impact other part of Yunohost (so it wasn't a satisfying solution), let's modify Dokos python file and let it check character_set_database and collation_database instead of character_set_server and collation_server
```
```
```
```
So the script becomes
```
```
```
#Let's make the command bench new-site check value of character_set_database and collation_database instead of character_set_server and collation_server
sed -i 's/"character_set_server": "utf8mb4",/"character_set_database": "utf8mb4",/g' $benchdir/apps/frappe/frappe/database/mariadb/setup_db.py
sed -i 's/"collation_server": "utf8mb4_unicode_ci",/"collation_database": "utf8mb4_unicode_ci",/g' $benchdir/apps/frappe/frappe/database/mariadb/setup_db.py
bench new-site $site_name --db-name $db_name --db-password $db_pwd --no-setup-db --admin-password $admin_pwd
```
which is much better, and it works, and make me more confident to start on a Yunohost package.
I hope I didn't bother with my updates. Now I'll work on trying to make a package here : https://github.com/Thatoo/Dokos_ynh
[15:31:53]
<lapineige> > <@ericg:matrix.org> Well, I am in favor of merging straight to master. the curation is made by how many votes an app gets
the only issue with this is spam, but until we get there…
[15:37:22]
<lapineige> thatoo: that channel is made for that 😉
[15:46:33]
<Charles P.> > the only issue with this is spam, but until we get there…
could also commit directly only once a day with all added apps of the day, except if there are more than n apps waiting to be committed then it would trigger a PR (that way if there's spam, just close that PR)
[15:47:09]
<lapineige> that would slow down things, it's already something
[15:47:34]
<lapineige> but it won't fix the moderation issue with spam
[15:47:34]
<lapineige> (i.e. false apps for ads...)
[15:49:32]
<Charles P.> it would at most allow people to spam with either adding n-1 apps per day (quite limiting) or open a pr per day (better than the system in place which allows to spam prs)
[15:51:13]
<Charles P.> just set n at a small number such as 3 or 5 (there's rarely more than 5 additions to the wishlist a day, I think that's a good middle-point)
[16:24:38]
<Aleks (he/him/il/lui)> not really concerned with spam, right now it's needed to be trust_level_1 on the forum to add something to the wishlist
[16:56:27]
<lapineige> then it's more an individual thing, that could get banned
[16:56:27]
<lapineige> oh yeah that's right
[17:33:16]
<eric_G> ```
if [[ the user has contributed at least one PR to the project ]]
then
You are welcome to suggest apps to the wishlist
else
You need to contribute to the project to be able to propose apps to the wishlist
fi
```
[18:05:14]
<Charles P.> How do you count contributions then?
Is a contributor someone who did open an issue/commented on an issue/did open a pr/did a commit on a repo of Yunohost/Yunohost-Apps org? Is someone who only helps people on Matrix/Forum without ever contributing code a contributor?
[18:07:52]
<Charles P.> Best timing
[18:08:01]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot pushed 1 commit to add-to-wishlist-scenarichainserver: Add SCENARIchainserver to wishlist ([d69b75e0](https://github.com/YunoHost/apps/commit/d69b75e04cb9ab45c0e0f01dba1e63e5a029cf5d))
[18:08:02]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot opened [pull request #1957](https://github.com/YunoHost/apps/pull/1957): Add SCENARIchainserver to wishlist
[18:08:02]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot created new branch add-to-wishlist-scenarichainserver
[18:24:16]
<Aleks (he/him/il/lui)> > <@charlesp:stratus.family> How do you count contributions then?
> Is a contributor someone who did open an issue/commented on an issue/did open a pr/did a commit on a repo of Yunohost/Yunohost-Apps org? Is someone who only helps people on Matrix/Forum without ever contributing code a contributor?
one ~easy thing to implement would be to require trust_level_2 for the wishlist ... cf definition in https://blog.discourse.org/2018/06/understanding-discourse-trust-levels/
[20:22:13]
<Yunohost Git/Infra notifications> App libretranslate goes down from level 7 to 1 in job [#21840](https://ci-apps.yunohost.org/ci/job/21840)
[21:50:13]
<lapineige> Or maybe start with level_1 and wait to close it further if it starts to be painful ?
[21:53:11]
<Aleks (he/him/il/lui)> it's already required to be trust levle 1
[22:15:01]
<lapineige> then the rate limit ?
[22:15:02]
<lapineige> or the direct PR and that's it for now ?
[22:15:26]
<lapineige> and if it get painfull, level 2 or rate limit ?
[22:18:56]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot pushed 1 commit to add-to-wishlist-mirotalk: Add MiroTalk to wishlist ([ce6e30e9](https://github.com/YunoHost/apps/commit/ce6e30e992701e41c9b5bf4b7086cae227d8ee14))
[22:18:56]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot created new branch add-to-wishlist-mirotalk
[22:19:22]
<Yunohost Git/Infra notifications> [apps] @yunohost-bot opened [pull request #1958](https://github.com/YunoHost/apps/pull/1958): Add MiroTalk to wishlist
[23:10:23]
<Aleks (he/him/il/lui)> The instructions: Évitez les formulations marketing type 'le meilleur', ou les propriétés vagues telles que 'facile', 'simple', 'léger'.
The users : Free, Simple, Secure, Fast.
[23:13:41]
<Tag> La facilité de repomper la description github...