Thursday, January 25, 2024
apps@conference.yunohost.org
January
Mon Tue Wed Thu Fri Sat Sun
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
       
             

[04:25:46] <Yunohost Git/Infra notifications> App icecoder rises from level 0 to 7 in job [#22524](https://ci-apps.yunohost.org/ci/job/22524) !
[04:27:34] <Yunohost Git/Infra notifications> [apps] @alexAubin merged [pull request #1968](https://github.com/YunoHost/apps/pull/1968): Update app levels according to CI results
[04:31:08] <Yunohost Git/Infra notifications> [apps] @alexAubin pushed 3 commits to master ([fd5469dd11a4...1a37c0baeaec](https://github.com/YunoHost/apps/compare/fd5469dd11a4...1a37c0baeaec))
[04:35:19] <Yunohost Git/Infra notifications> [apps] @alexAubin deleted branch update_app_levels
[04:39:11] <Yunohost Git/Infra notifications> [apps/master] Update app levels according to CI results - root
[14:05:16] <Yunohost Git/Infra notifications> [apps] @orhtej2 closed [pull request #1975](https://github.com/YunoHost/apps/pull/1975): Just grab a set of numbers from tag name.
[14:05:16] <Yunohost Git/Infra notifications> [nextcloud_ynh] @supermamie closed [issue #654](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/654): Add a link to incompatible apps on big upgrades
[14:05:16] <Émy - OniriCorpe> there's no logs on job timeout :/
https://ci-apps-dev.yunohost.org/ci/job/12966
[14:05:16] <Yunohost Git/Infra notifications> [nextcloud_ynh] @supermamie [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/654#issuecomment-1909726156) on [issue #654](https://github.com/YunoHost-Apps/nextcloud_ynh/issues/654) Add a link to incompatible apps on big upgrades: Then I close my issue, as always : YunoHost’s contributors are the best
[14:05:18] <Émy - OniriCorpe> i tried https://ci-apps-dev.yunohost.org/ci/logs/12966.log
[16:32:12] <Aleks (he/him/il/lui)> depends on what you mean by functional testing, celery is just a tool to manage a bunch of workers and task queues
[16:32:13] <Guillaume Bouzige> yep i see
[16:32:13] <Guillaume Bouzige> i mean by functionnal testing, trying features (tests fonctionnels) vs unitary testing (test unitaires)
[16:32:13] <Aleks (he/him/il/lui)> yes but like, what does it mean for you to do "functional testing of a backup", is the current app CI doing functional testing or unit testing from your point of view ?
[16:32:14] <Aleks (he/him/il/lui)> or do you mean "functional testing of a backup" like you want to test if restoring your real-life backups works
[16:32:14] <Yunohost Git/Infra notifications> [nextcloud_ynh] @alexAubin pushed 1 commit to check-app-compatibility-before-upgrade: Update upgrade: fix boring bug because of apt install piped into jq ([fc131c1b](https://github.com/YunoHost-Apps/nextcloud_ynh/commit/fc131c1b3b8d97981a02397c961dd68bd5cdb390))
[16:32:15] <Yunohost Git/Infra notifications> [nextcloud_ynh] @yunohost-bot [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/647#issuecomment-1910550311) on [issue #647](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/647) Upgrade script: check that installed apps are compatible with the future version before actually starting the upgrade: :sunflower:
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-dev.yunohost.org/ci/api/job/12971/badge)]...
[16:32:15] <Yunohost Git/Infra notifications> [nextcloud_ynh] @alexAubin [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/647#issuecomment-1910550162) on [issue #647](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/647) Upgrade script: check that installed apps are compatible with the future version before actually starting the upgrade: testme
[18:02:35] <Mateusz Szymański> > <@oniricorpe:im.emelyne.eu> there's no logs on job timeout :/
> https://ci-apps-dev.yunohost.org/ci/job/12966

neither on cancel
[18:02:36] <Aleks (he/him/il/lui)> yes, CI should be rewritten using standard technologies like celery and reduce the bash soup :|
[18:02:36] <Aleks (he/him/il/lui)> we could scale the workers much more easily
[18:03:08] <Aleks (he/him/il/lui)> https://i.imgflip.com/8dk6m5.jpg
[18:13:37] <Yunohost Git/Infra notifications> [nextcloud_ynh] @alexAubin pushed 1 commit to check-app-compatibility-before-upgrade: Update upgrade: zgrompf ([12b88c27](https://github.com/YunoHost-Apps/nextcloud_ynh/commit/12b88c27480f2f0cf7501de7491c36e5483b25ed))
[18:22:36] <Yunohost Git/Infra notifications> [nextcloud_ynh] @alexAubin pushed 1 commit to check-app-compatibility-before-upgrade: Update PRE_UPGRADE.md ([2891edce](https://github.com/YunoHost-Apps/nextcloud_ynh/commit/2891edce520075266b9ff401ca3829cac8c18a17))
[18:45:13] <lapineige> Damned… never give me full write rights on all repo… just commited to master…
[18:45:13] <Émy - OniriCorpe> I can't troubleshoot this damn thing https://github.com/YunoHost-Apps/vaultwarden_ynh/pull/244
vaultwarden wants libssl3 but it's not available on debian bullseye
[18:57:26] <lapineige> > If schema is compatible just dump it to sql and run that on pgsql one? Syntax for inserts is ANSI

Just for fun, one could imagine to backup it (it makes a SQL dump), and then import it back as a restore… with the db setting changed 😄
[19:00:02] <Aleks (he/him/il/lui)> > Damned… never give me full write rights on all repo… just commited to master…

shit happens, as we say in france, We do not do le omelette without le casser-des-oeufs
[19:01:12] <Aleks (he/him/il/lui)> > <@oniricorpe:im.emelyne.eu> I can't troubleshoot this damn thing https://github.com/YunoHost-Apps/vaultwarden_ynh/pull/244
> vaultwarden wants libssl3 but it's not available on debian bullseye

hmmm i'm guessing it's for bookworm ? We probably need a conditional dependency x_x
[19:03:08] <tituspijean> If I understand well the upstream comment (https://github.com/dani-garcia/vaultwarden/discussions/3833#discussioncomment-6889874), we would need to build our own libssl3, and declare its location in the cargo file (https://github.com/search?q=repo%3Adani-garcia%2Fvaultwarden%20vendored\_openssl&type=code)?
[19:03:41] <Aleks (he/him/il/lui)> ah like the upstream is incompatible with libssl1.x ?
[19:03:53] <Aleks (he/him/il/lui)> hmpf
[19:04:13] <Aleks (he/him/il/lui)> then honestly it's a no go, building libssl ourselves sounds like a recipe for security disaster
[19:04:16] <Émy - OniriCorpe> idk 🤷‍♀️
[19:04:17] <tituspijean> If so, we would need to git clone openssl v3 repo and build it to extract its `lib` directory (https://github.com/openssl/openssl/blob/openssl-3.1.4/INSTALL.md#install-openssl)
[19:04:27] <Aleks (he/him/il/lui)> yeaaaaaaaaaaaaaa no
[19:04:32] <Émy - OniriCorpe> the only thing i founded is https://github.com/dani-garcia/vaultwarden/discussions/3833
[19:04:46] <Émy - OniriCorpe> "Though, it should just work out-off-box and should detect the OpenSSL version and dev packages on the host you build it on." yes but no
[19:04:48] <Aleks (he/him/il/lui)> #TeamBookworm
[19:08:06] <tituspijean> I don't see any clear mention of libssl3 in vaultwarden's code though... how did you conclude that's the version we need Emy?
[19:09:28] <Émy - OniriCorpe> > <@titus:pijean.ovh> I don't see any clear mention of libssl3 in vaultwarden's code though... how did you conclude that's the version we need Emy?

because vaulwarden crashes with the following error
`var/www/vaultwarden/live/vaultwarden: error while loading shared libraries: libssl.so.3: cannot open shared object file: No such file or directory`
[19:09:34] <Émy - OniriCorpe> 🤷‍♀️
[19:09:54] <Émy - OniriCorpe> i never told it was incompatible with libssl1
[19:10:24] <Émy - OniriCorpe> AFAIK we can compile vaultwarden with libssl1
[19:11:01] <Émy - OniriCorpe> but it seems the docked binaries are compiled with libssl3 and it fucks our package
[19:12:08] <Aleks (he/him/il/lui)> merp
[19:12:10] <Émy - OniriCorpe> yeah sigh
[19:12:25] <Émy - OniriCorpe> i tried some hacky things but without success
[19:12:44] <Émy - OniriCorpe> check the latests commits x)
[19:12:48] <tituspijean> > <@oniricorpe:im.emelyne.eu> but it seems the docked binaries are compiled with libssl3 and it fucks our package

erf we're doomed
[19:13:29] <Aleks (he/him/il/lui)> https://i.imgflip.com/8dl20p.jpg
[19:13:29] <Émy - OniriCorpe> also i just learned that we can't have an OR condition in a fail2ban regex and siiiiiiiiiiiighhhhh
[19:13:51] <tituspijean> I was about to suggest the Cargo.toml modification to point to libssl.so.1, but if the whole thing is compiled with libssl.so.3.... 😕
[19:13:57] <Émy - OniriCorpe> and we can't add multiple fail2ban config using our helper
[19:14:25] <Aleks (he/him/il/lui)> security is overrated anyway, how are we gonna inject our backdoors if we secure everything too much ?
[19:14:27] <tituspijean> *here be dragons*
[19:14:28] <Émy - OniriCorpe> > <@titus:pijean.ovh> I was about to suggest the Cargo.toml modification to point to libssl.so.1, but if the whole thing is compiled with libssl.so.3.... 😕

we extract docker binaries, we don't compile vaultwarden
[19:16:07] <tituspijean> yeah I understand that, but if the binary is built/hardcoded to expect libssl.so.3, there's not much we can do? Or fuck it and let's force-feed with the vendor config as suggested upstream? 😅
[19:16:19] <Émy - OniriCorpe> i guess if we want to make latest vaultwarden versions available to our users, we have to compile again, untill bookworm 😬
[19:16:49] <tituspijean> (I don't see the cargo.toml thingy in your last commits, but maybe I'm too blind/tired/hungry)
[19:17:30] <Émy - OniriCorpe> > <@titus:pijean.ovh> yeah I understand that, but if the binary is built/hardcoded to expect libssl.so.3, there's not much we can do? Or fuck it and let's force-feed with the vendor config as suggested upstream? 😅

i tried this shit but it won't worked https://github.com/YunoHost-Apps/vaultwarden_ynh/pull/244/commits/0ab990f8a35939829158c1e8f86754baf53e9599
[19:18:31] <tituspijean> with same error you mentioned above I guess?
[19:18:31] <Émy - OniriCorpe> yes
[19:18:31] <Émy - OniriCorpe> i tried this too https://github.com/YunoHost-Apps/vaultwarden_ynh/pull/244/commits/f310c89a10039e058c8b92df1abf256394a39a77
[19:18:34] <tituspijean> talking about hungry, the risotto is ready 🤤
[19:18:42] <Émy - OniriCorpe> > <@titus:pijean.ovh> (I don't see the cargo.toml thingy in your last commits, but maybe I'm too blind/tired/hungry)

we extract docker binaries, we don't compile vaultwarden
[19:19:10] <tituspijean> ah damn... I understand now, the cargo thing is for build instructions
[19:19:18] <tituspijean> my bad
[19:21:19] <Yunohost Git/Infra notifications> [nextcloud_ynh] @alexAubin [commented](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/647#issuecomment-1910836150) on [issue #647](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/647) Upgrade script: check that installed apps are compatible with the future version before actually starting the upgrade: Hell yes its working
[19:21:28] <Aleks (he/him/il/lui)> if anybody feels like reviewing https://github.com/YunoHost-Apps/nextcloud_ynh/pull/647 😬
[19:23:34] <tituspijean> Here's my review: [s/nextcloud\_ynh/pull/647/files#diff-57aeb84da86cb7420dfedd8e49bc644fb799d5413d01927a0417bde753e8922fR102-R104 ](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/647/files#diff-57aeb84da86cb7420dfedd8e49bc644fb799d5413d01927a0417bde753e8922fR102-R104 )is pure witchcraft
[19:23:46] <tituspijean> Here's my review: https://github.com/YunoHost-Apps/nextcloud_ynh/pull/647/files#diff-57aeb84da86cb7420dfedd8e49bc644fb799d5413d01927a0417bde753e8922fR102-R104 is pure witchcraft
[19:27:04] <Émy - OniriCorpe> > <@oniricorpe:im.emelyne.eu> because vaulwarden crashes with the following error
> `var/www/vaultwarden/live/vaultwarden: error while loading shared libraries: libssl.so.3: cannot open shared object file: No such file or directory`

as the poet said "nique sa mère le blizzard"
[23:20:44] <Yunohost Git/Infra notifications> [apps] @tituspijean pushed 1 commit to superset: Add Superset to catalog ([cf3fb3a7](https://github.com/YunoHost/apps/commit/cf3fb3a76127f54c6e3a6de5f496a9e97e0b6516))
[23:20:44] <Yunohost Git/Infra notifications> [apps] @tituspijean created new branch superset
[23:20:57] <Yunohost Git/Infra notifications> [apps] @tituspijean opened [pull request #1977](https://github.com/YunoHost/apps/pull/1977): Add Superset to catalog
[23:21:25] <Yunohost Git/Infra notifications> [apps] @tituspijean pushed 1 commit to superset: Superset, he said ([946aff52](https://github.com/YunoHost/apps/commit/946aff5239e974da1da2594164f20a251feba565))
[23:21:54] <Yunohost Git/Infra notifications> [apps] @tituspijean pushed 1 commit to superset: Remove Superset from wishlist ([a35a8171](https://github.com/YunoHost/apps/commit/a35a817165cb538e562a91bdabe19bfb057e1106))
[23:23:33] <Yunohost Git/Infra notifications> [apps] @alexAubin approved [pull request #1977](https://github.com/YunoHost/apps/pull/1977#pullrequestreview-1844866055) Add Superset to catalog